UAT: _DEFAULT_SKELETON_RATIO in project_context.py is 0.2 but spec requires 0.15 #3240

Open
opened 2026-04-05 08:20:10 +00:00 by freemo · 3 comments
Owner

Metadata

  • Branch: fix/acms-default-skeleton-ratio
  • Commit Message: fix(cli): correct _DEFAULT_SKELETON_RATIO from 0.2 to 0.15 per spec
  • Milestone: None (backlog)
  • Parent Epic: #359

Backlog note: This issue was discovered during autonomous operation
on milestone v3.4.0 (M5: ACMS v1 + Context Scaling). It does not block milestone completion and has been
placed in the backlog for human review and future milestone assignment.

Background and Context

The agents project context set command configures ACMS pipeline parameters including skeleton_ratio, which controls the fraction of context budget reserved for inherited plan skeleton. The default value for this parameter is defined in src/cleveragents/cli/commands/project_context.py.

Code-level analysis of src/cleveragents/cli/commands/project_context.py against docs/specification.md revealed a discrepancy between the implemented default and the spec-required default for skeleton_ratio.

Current Behavior

In src/cleveragents/cli/commands/project_context.py line 68:

_DEFAULT_SKELETON_RATIO = 0.2

The implementation uses 0.2 as the default, which is 33% higher than the spec-required 0.15. This default is used in:

  • _default_acms_config() (line 192): "skeleton_ratio": _DEFAULT_SKELETON_RATIO
  • context_show command display (line 905): acms.get('skeleton_ratio', _DEFAULT_SKELETON_RATIO)

Running agents project context show <project> without having previously set skeleton_ratio displays 0.2 instead of the spec-required 0.15.

Expected Behavior

docs/specification.md line 35362 states:

skeleton_ratio: <float>  # Fraction of budget for inherited plan skeleton (optional, default: 0.15)

The spec also states in the --skeleton-ratio flag description (line 3790):

--skeleton-ratio FLOAT: Fraction of context budget reserved for inherited plan skeleton. Range: 0.0–1.0. Default: 0.15.

The default value for skeleton_ratio should be 0.15.

Acceptance Criteria

  • _DEFAULT_SKELETON_RATIO in src/cleveragents/cli/commands/project_context.py is set to 0.15.
  • Running agents project context show <project> without a previously configured skeleton_ratio displays 0.15.
  • All existing tests continue to pass.
  • No other references to the incorrect default value of 0.2 remain for skeleton_ratio.

Supporting Information

Steps to Reproduce:

  1. Run agents project context show <project> without having previously set skeleton_ratio
  2. Observe the displayed skeleton ratio is 0.2 instead of the spec-required 0.15
  3. Or inspect _DEFAULT_SKELETON_RATIO in src/cleveragents/cli/commands/project_context.py

Code Location:
src/cleveragents/cli/commands/project_context.py, line 68:

_DEFAULT_SKELETON_RATIO = 0.2  # Should be 0.15 per spec

Fix:
Change _DEFAULT_SKELETON_RATIO = 0.2 to _DEFAULT_SKELETON_RATIO = 0.15 in src/cleveragents/cli/commands/project_context.py.

Subtasks

  • Change _DEFAULT_SKELETON_RATIO = 0.2 to _DEFAULT_SKELETON_RATIO = 0.15 in src/cleveragents/cli/commands/project_context.py
  • Search codebase for any other references to the incorrect default value 0.2 for skeleton_ratio and correct them
  • Verify agents project context show <project> displays 0.15 when skeleton_ratio has not been explicitly set
  • Update or add tests to assert the correct default value of 0.15
  • Run nox (all default sessions), fix any errors
  • Verify coverage >= 97% via nox -s coverage_report

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • _DEFAULT_SKELETON_RATIO is 0.15 and all usages reflect the corrected default.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
  • All nox stages pass.
  • Coverage >= 97%.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata - **Branch**: `fix/acms-default-skeleton-ratio` - **Commit Message**: `fix(cli): correct _DEFAULT_SKELETON_RATIO from 0.2 to 0.15 per spec` - **Milestone**: None (backlog) - **Parent Epic**: #359 > **Backlog note:** This issue was discovered during autonomous operation > on milestone v3.4.0 (M5: ACMS v1 + Context Scaling). It does not block milestone completion and has been > placed in the backlog for human review and future milestone assignment. ## Background and Context The `agents project context set` command configures ACMS pipeline parameters including `skeleton_ratio`, which controls the fraction of context budget reserved for inherited plan skeleton. The default value for this parameter is defined in `src/cleveragents/cli/commands/project_context.py`. Code-level analysis of `src/cleveragents/cli/commands/project_context.py` against `docs/specification.md` revealed a discrepancy between the implemented default and the spec-required default for `skeleton_ratio`. ## Current Behavior In `src/cleveragents/cli/commands/project_context.py` line 68: ```python _DEFAULT_SKELETON_RATIO = 0.2 ``` The implementation uses **0.2** as the default, which is 33% higher than the spec-required 0.15. This default is used in: - `_default_acms_config()` (line 192): `"skeleton_ratio": _DEFAULT_SKELETON_RATIO` - `context_show` command display (line 905): `acms.get('skeleton_ratio', _DEFAULT_SKELETON_RATIO)` Running `agents project context show <project>` without having previously set `skeleton_ratio` displays 0.2 instead of the spec-required 0.15. ## Expected Behavior `docs/specification.md` line 35362 states: ``` skeleton_ratio: <float> # Fraction of budget for inherited plan skeleton (optional, default: 0.15) ``` The spec also states in the `--skeleton-ratio` flag description (line 3790): > `--skeleton-ratio FLOAT`: Fraction of context budget reserved for inherited plan skeleton. Range: 0.0–1.0. Default: `0.15`. The default value for `skeleton_ratio` should be **0.15**. ## Acceptance Criteria - `_DEFAULT_SKELETON_RATIO` in `src/cleveragents/cli/commands/project_context.py` is set to `0.15`. - Running `agents project context show <project>` without a previously configured `skeleton_ratio` displays `0.15`. - All existing tests continue to pass. - No other references to the incorrect default value of `0.2` remain for `skeleton_ratio`. ## Supporting Information **Steps to Reproduce:** 1. Run `agents project context show <project>` without having previously set `skeleton_ratio` 2. Observe the displayed skeleton ratio is 0.2 instead of the spec-required 0.15 3. Or inspect `_DEFAULT_SKELETON_RATIO` in `src/cleveragents/cli/commands/project_context.py` **Code Location:** `src/cleveragents/cli/commands/project_context.py`, line 68: ```python _DEFAULT_SKELETON_RATIO = 0.2 # Should be 0.15 per spec ``` **Fix:** Change `_DEFAULT_SKELETON_RATIO = 0.2` to `_DEFAULT_SKELETON_RATIO = 0.15` in `src/cleveragents/cli/commands/project_context.py`. ## Subtasks - [ ] Change `_DEFAULT_SKELETON_RATIO = 0.2` to `_DEFAULT_SKELETON_RATIO = 0.15` in `src/cleveragents/cli/commands/project_context.py` - [ ] Search codebase for any other references to the incorrect default value `0.2` for `skeleton_ratio` and correct them - [ ] Verify `agents project context show <project>` displays `0.15` when `skeleton_ratio` has not been explicitly set - [ ] Update or add tests to assert the correct default value of `0.15` - [ ] Run `nox` (all default sessions), fix any errors - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - `_DEFAULT_SKELETON_RATIO` is `0.15` and all usages reflect the corrected default. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. - All nox stages pass. - Coverage >= 97%. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester
freemo added this to the v3.4.0 milestone 2026-04-05 08:41:39 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified — clear spec-vs-implementation mismatch with exact line references in both spec and code
  • Priority: Medium — spec compliance issue. The default value is 33% higher than spec-required, which affects ACMS context budget allocation for all users who haven't explicitly set the ratio.
  • Milestone: v3.4.0 — ACMS v1 + Context Scaling is the M5 scope where skeleton_ratio is defined
  • MoSCoW: Should Have — the spec explicitly states default: 0.15 for skeleton_ratio. This is a straightforward one-line fix with clear spec backing.
  • Parent Epic: #359 (referenced in issue body)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified — clear spec-vs-implementation mismatch with exact line references in both spec and code - **Priority**: Medium — spec compliance issue. The default value is 33% higher than spec-required, which affects ACMS context budget allocation for all users who haven't explicitly set the ratio. - **Milestone**: v3.4.0 — ACMS v1 + Context Scaling is the M5 scope where skeleton_ratio is defined - **MoSCoW**: Should Have — the spec explicitly states `default: 0.15` for skeleton_ratio. This is a straightforward one-line fix with clear spec backing. - **Parent Epic**: #359 (referenced in issue body) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • Priority: Medium
  • Milestone: v3.4.0 (assigned — ACMS context configuration is M5 scope)
  • MoSCoW: Should Have — the spec explicitly states default 0.15 for skeleton_ratio; the implementation uses 0.2 which is 33% higher. This is a simple one-line fix
  • Parent Epic: #396 (ACMS Context Pipeline)

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium - **Milestone**: v3.4.0 (assigned — ACMS context configuration is M5 scope) - **MoSCoW**: Should Have — the spec explicitly states default 0.15 for skeleton_ratio; the implementation uses 0.2 which is 33% higher. This is a simple one-line fix - **Parent Epic**: #396 (ACMS Context Pipeline) --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Author
Owner

Label compliance fix applied:

  • Removed duplicate org-level labels: State/Unverified (org), Priority/Backlog (org), Type/Bug (org)
  • Kept: State/Verified (repo), Priority/Medium (repo), Type/Bug (repo)
  • Reason: Issue had conflicting org-level and repo-level labels. Org-level labels are superseded by repo-level labels.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

Label compliance fix applied: - Removed duplicate org-level labels: `State/Unverified` (org), `Priority/Backlog` (org), `Type/Bug` (org) - Kept: `State/Verified` (repo), `Priority/Medium` (repo), `Type/Bug` (repo) - Reason: Issue had conflicting org-level and repo-level labels. Org-level labels are superseded by repo-level labels. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer
freemo removed this from the v3.4.0 milestone 2026-04-06 21:01:57 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#359 Epic: ACMS v1 + Context Scaling (M5)
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core#3240
No description provided.