cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(cli): add NAME positional argument to agents actor add command per spec #3239

Merged
freemo merged 1 commits from fix/actor-add-name-positional-argument into master 2026-04-05 21:09:18 +00:00
Conversation 2 Commits 1 Files Changed 8
+287 -21
freemo commented 2026-04-05 08:17:23 +00:00
Owner
Copy Link
Copy Source

Summary

The spec (docs/reference/actor_cli.md) defines the synopsis for agents actor add as:

agents actor add <NAME> --config <FILE> [--update] [--unsafe] [--set-default] [--option key=value] [--format FORMAT]

The implementation was missing the required <NAME> positional argument, silently reading the actor name from the config file's name field instead. This deviates from the spec and breaks the expected CLI UX.

Changes

  • src/cleveragents/cli/commands/actor.py: Add name as a required positional typer.Argument to the add command. Update docstring to match spec synopsis exactly. Remove the now-redundant config-file name validation (name comes from CLI arg, not config). The positional NAME takes precedence over any name field in the config file.

  • features/actor_add_name_positional.feature + features/steps/actor_add_name_positional_steps.py: New Behave BDD feature and step definitions for the NAME positional argument (TDD — written before the fix).

  • features/steps/actor_cli_steps.py, features/steps/actor_add_rich_output_steps.py, features/steps/actor_cli_yaml_steps.py: Updated all existing actor add step invocations to pass the NAME positional argument.

  • robot/helper_actor_add_rich_output.py, robot/helper_m2_e2e_verification.py: Updated Robot Framework helpers to pass NAME positional argument.

Before / After

Before (broken):

agents actor add --config ./actors/my-actor.yaml   # NAME read from config file

After (spec-compliant):

agents actor add local/my-actor --config ./actors/my-actor.yaml

Testing

  • New Behave BDD scenarios verify:
    1. NAME positional argument is accepted and passed to the registry
    2. NAME positional argument takes precedence over config file name field
    3. Missing NAME argument causes a CLI error (exit code 2)
  • All existing actor add tests updated to pass NAME positional argument
  • ruff check and ruff format pass on all modified files
  • pyright reports 0 errors on actor.py

Closes #2905

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary The spec (`docs/reference/actor_cli.md`) defines the synopsis for `agents actor add` as: ``` agents actor add <NAME> --config <FILE> [--update] [--unsafe] [--set-default] [--option key=value] [--format FORMAT] ``` The implementation was missing the required `<NAME>` positional argument, silently reading the actor name from the config file's `name` field instead. This deviates from the spec and breaks the expected CLI UX. ## Changes - **`src/cleveragents/cli/commands/actor.py`**: Add `name` as a required positional `typer.Argument` to the `add` command. Update docstring to match spec synopsis exactly. Remove the now-redundant config-file name validation (name comes from CLI arg, not config). The positional `NAME` takes precedence over any `name` field in the config file. - **`features/actor_add_name_positional.feature`** + **`features/steps/actor_add_name_positional_steps.py`**: New Behave BDD feature and step definitions for the `NAME` positional argument (TDD — written before the fix). - **`features/steps/actor_cli_steps.py`**, **`features/steps/actor_add_rich_output_steps.py`**, **`features/steps/actor_cli_yaml_steps.py`**: Updated all existing `actor add` step invocations to pass the `NAME` positional argument. - **`robot/helper_actor_add_rich_output.py`**, **`robot/helper_m2_e2e_verification.py`**: Updated Robot Framework helpers to pass `NAME` positional argument. ## Before / After **Before (broken):** ```bash agents actor add --config ./actors/my-actor.yaml # NAME read from config file ``` **After (spec-compliant):** ```bash agents actor add local/my-actor --config ./actors/my-actor.yaml ``` ## Testing - New Behave BDD scenarios verify: 1. `NAME` positional argument is accepted and passed to the registry 2. `NAME` positional argument takes precedence over config file `name` field 3. Missing `NAME` argument causes a CLI error (exit code 2) - All existing actor add tests updated to pass `NAME` positional argument - `ruff check` and `ruff format` pass on all modified files - `pyright` reports 0 errors on `actor.py` Closes #2905 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker
freemo added 1 commit 2026-04-05 08:17:23 +00:00
fix(cli): add NAME positional argument to agents actor add command per spec
CI / lint (pull_request) Successful in 28s
Details
CI / typecheck (pull_request) Successful in 53s
Details
CI / security (pull_request) Successful in 55s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / build (pull_request) Successful in 17s
Details
CI / helm (pull_request) Successful in 23s
Details
CI / unit_tests (pull_request) Successful in 7m0s
Details
CI / e2e_tests (pull_request) Failing after 16m33s
Details
CI / integration_tests (pull_request) Successful in 23m25s
Details
CI / docker (pull_request) Successful in 1m25s
Details
CI / coverage (pull_request) Successful in 10m40s
Details
CI / status-check (pull_request) Failing after 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 58m9s
Details
2d07cd5ef8 
The spec (docs/reference/actor_cli.md) defines the synopsis for
`agents actor add` as:

  agents actor add <NAME> --config <FILE> [--update] [--unsafe]
  [--set-default] [--option key=value] [--format FORMAT]

The implementation was missing the required <NAME> positional argument,
silently reading the actor name from the config file's `name` field
instead. This deviates from the spec and breaks the expected CLI UX.

Changes:
- Add `name` as a required positional Argument to the `add` command
- Update docstring to match spec synopsis exactly
- The positional NAME takes precedence over any `name` field in config
- Remove the now-redundant config-file name validation (name comes from CLI)
- Add Behave BDD feature + steps for the NAME positional argument (TDD)
- Update all existing Behave step invocations to pass NAME positional arg
- Update Robot Framework helpers to pass NAME positional arg

ISSUES CLOSED: #2905
freemo commented 2026-04-05 08:24:23 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3239-1775372600]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3239-1775372600] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 09:05:49 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Independent Code Review ✅

Summary

This PR correctly fixes a spec deviation where agents actor add was missing the required <NAME> positional argument. The spec (docs/reference/actor_cli.md) clearly defines the synopsis as:

agents actor add <NAME> --config <FILE> [--update] [--unsafe] [--set-default] [--option key=value] [--format FORMAT]

The implementation was silently reading the actor name from the config file's name field instead. This PR brings the CLI into alignment with the spec.

What Was Reviewed

Specification Alignment ✅

  • The name parameter is now a required typer.Argument with metavar="NAME" — matches spec synopsis exactly
  • The docstring and examples are updated to match the spec
  • The YAML config example in the spec does NOT include a name field, confirming name should come from CLI
  • The old validation requiring name in the config file is correctly removed

Code Quality ✅

  • Proper Annotated[str, typer.Argument(...)] typing — no # type: ignore
  • Clean removal of the redundant config-file name validation (6 lines removed)
  • name is correctly passed through to _canonicalize_actor_config(), registry.upsert_actor(), and service.upsert_actor()
  • No unnecessary complexity introduced

Test Quality ✅

  • 3 new Behave BDD scenarios covering: acceptance, precedence over config name, and missing argument error
  • Step definitions properly mock _get_services and verify upsert_actor is called with the correct name
  • All existing test files updated consistently (actor_cli_steps.py, actor_add_rich_output_steps.py, actor_cli_yaml_steps.py)
  • Robot Framework helpers updated (helper_actor_add_rich_output.py, helper_m2_e2e_verification.py)

Commit Format ✅

  • Conventional Changelog: fix(cli): add NAME positional argument to agents actor add command per spec
  • ISSUES CLOSED: #2905 footer present
  • Single commit — clean history

Security ✅

  • No secrets or credentials in code
  • No new input validation concerns (typer handles argument parsing)

Minor Note

The PR is missing a milestone assignment (issue #2905 has milestone v3.7.0). This is a metadata gap but does not block the review.

Verdict

Code is correct, spec-aligned, well-tested, and ready to merge. Scheduling merge for when all CI checks pass.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Code Review ✅ ### Summary This PR correctly fixes a spec deviation where `agents actor add` was missing the required `<NAME>` positional argument. The spec (`docs/reference/actor_cli.md`) clearly defines the synopsis as: ``` agents actor add <NAME> --config <FILE> [--update] [--unsafe] [--set-default] [--option key=value] [--format FORMAT] ``` The implementation was silently reading the actor name from the config file's `name` field instead. This PR brings the CLI into alignment with the spec. ### What Was Reviewed **Specification Alignment** ✅ - The `name` parameter is now a required `typer.Argument` with `metavar="NAME"` — matches spec synopsis exactly - The docstring and examples are updated to match the spec - The YAML config example in the spec does NOT include a `name` field, confirming name should come from CLI - The old validation requiring `name` in the config file is correctly removed **Code Quality** ✅ - Proper `Annotated[str, typer.Argument(...)]` typing — no `# type: ignore` - Clean removal of the redundant config-file name validation (6 lines removed) - `name` is correctly passed through to `_canonicalize_actor_config()`, `registry.upsert_actor()`, and `service.upsert_actor()` - No unnecessary complexity introduced **Test Quality** ✅ - 3 new Behave BDD scenarios covering: acceptance, precedence over config name, and missing argument error - Step definitions properly mock `_get_services` and verify `upsert_actor` is called with the correct name - All existing test files updated consistently (actor_cli_steps.py, actor_add_rich_output_steps.py, actor_cli_yaml_steps.py) - Robot Framework helpers updated (helper_actor_add_rich_output.py, helper_m2_e2e_verification.py) **Commit Format** ✅ - Conventional Changelog: `fix(cli): add NAME positional argument to agents actor add command per spec` - `ISSUES CLOSED: #2905` footer present - Single commit — clean history **Security** ✅ - No secrets or credentials in code - No new input validation concerns (typer handles argument parsing) ### Minor Note The PR is missing a milestone assignment (issue #2905 has milestone v3.7.0). This is a metadata gap but does not block the review. ### Verdict Code is correct, spec-aligned, well-tested, and ready to merge. Scheduling merge for when all CI checks pass. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo scheduled this pull request to auto merge when all checks succeed 2026-04-05 09:08:08 +00:00
freemo merged commit eb4ccc819c into master 2026-04-05 21:09:14 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#2905 UAT: agents actor add - NAME positional argument missing from implementation (spec deviation)
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#3239
Delete Branch "fix/actor-add-name-positional-argument"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?