Refactor: Address outstanding TODOs and FIXMEs in the codebase #3154

Open
opened 2026-04-05 07:00:08 +00:00 by freemo · 3 comments
Owner

During a routine scan, the Architecture Guard identified several TODO and FIXME comments in the codebase that indicate areas of technical debt or incomplete implementation. To maintain code quality and prevent these from becoming stale, they should be addressed.

Action Items:

  • src/cleveragents/a2a/facade.py: Wire to ACMS ContextAssemblyPipeline once available.
  • src/cleveragents/application/services/cleanup_service.py: Wire DB session query when Container is available.
  • src/cleveragents/application/services/cleanup_service.py: Wire DB session deletion when Container is available.
  • src/cleveragents/application/services/correction_service.py: affected_files and artifacts_to_archive use synthetic data.
  • src/cleveragents/application/services/llm_actors.py: Wire actor-configured response_format into provider calls (two occurrences).
  • src/cleveragents/application/services/phase_gating.py: Address TOCTOU race condition when reading and updating plan phase.
  • src/cleveragents/application/services/plan_lifecycle_service.py: Replace EstimationStubActor with real actor dispatch.
  • src/cleveragents/application/services/service_retry_wiring.py: Refactor the class that conflates factory/config, execution, and caching.
  • src/cleveragents/application/services/uko_indexer_internals.py: Integrate a real embedding model instead of the placeholder vector.
  • src/cleveragents/application/services/uko_loader.py: Precompute layer index for performance when scaling demands it.
  • src/cleveragents/cli/commands/plan.py: Migrate to EstimationResult.as_display_dict() to reduce duplication.
  • src/cleveragents/cli/commands/skill.py: When MCP adapter integration is available, call it.
  • src/cleveragents/mcp/adapter.py: resource_slots are stored in source_metadata but should be handled properly.
  • src/cleveragents/tool/runner.py: Pass pref.target_resource to the resolver.

Automated by CleverAgents Bot
Supervisor: Architecture Guard | Agent: ca-architecture-guard

During a routine scan, the Architecture Guard identified several `TODO` and `FIXME` comments in the codebase that indicate areas of technical debt or incomplete implementation. To maintain code quality and prevent these from becoming stale, they should be addressed. **Action Items:** * [ ] `src/cleveragents/a2a/facade.py`: Wire to ACMS ContextAssemblyPipeline once available. * [ ] `src/cleveragents/application/services/cleanup_service.py`: Wire DB session query when Container is available. * [ ] `src/cleveragents/application/services/cleanup_service.py`: Wire DB session deletion when Container is available. * [ ] `src/cleveragents/application/services/correction_service.py`: `affected_files` and `artifacts_to_archive` use synthetic data. * [ ] `src/cleveragents/application/services/llm_actors.py`: Wire actor-configured `response_format` into provider calls (two occurrences). * [ ] `src/cleveragents/application/services/phase_gating.py`: Address TOCTOU race condition when reading and updating plan phase. * [ ] `src/cleveragents/application/services/plan_lifecycle_service.py`: Replace `EstimationStubActor` with real actor dispatch. * [ ] `src/cleveragents/application/services/service_retry_wiring.py`: Refactor the class that conflates factory/config, execution, and caching. * [ ] `src/cleveragents/application/services/uko_indexer_internals.py`: Integrate a real embedding model instead of the placeholder vector. * [ ] `src/cleveragents/application/services/uko_loader.py`: Precompute layer index for performance when scaling demands it. * [ ] `src/cleveragents/cli/commands/plan.py`: Migrate to `EstimationResult.as_display_dict()` to reduce duplication. * [ ] `src/cleveragents/cli/commands/skill.py`: When MCP adapter integration is available, call it. * [ ] `src/cleveragents/mcp/adapter.py`: `resource_slots` are stored in `source_metadata` but should be handled properly. * [ ] `src/cleveragents/tool/runner.py`: Pass `pref.target_resource` to the resolver. --- **Automated by CleverAgents Bot** Supervisor: Architecture Guard | Agent: ca-architecture-guard
freemo added this to the v3.8.0 milestone 2026-04-05 07:43:26 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • Priority: Backlog — technical debt cleanup
  • Milestone: v3.8.0
  • MoSCoW: Could Have — addressing TODO/FIXME comments is desirable for code quality but none of these are blocking any milestone deliverable. This should be done incrementally as developers touch the affected files.

Note: #3141 was closed as a duplicate of this issue.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Backlog — technical debt cleanup - **Milestone**: v3.8.0 - **MoSCoW**: Could Have — addressing TODO/FIXME comments is desirable for code quality but none of these are blocking any milestone deliverable. This should be done incrementally as developers touch the affected files. Note: #3141 was closed as a duplicate of this issue. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Author
Owner

Label compliance fix applied:

  • Removed conflicting label: Type/Refactor
  • Kept: Type/Task
  • Reason: Issue had two conflicting Type/* labels. Per CONTRIBUTING.md, exactly one Type/* label is required. Since this issue is about addressing TODOs/FIXMEs (a task), Type/Task is the correct type.

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

Label compliance fix applied: - Removed conflicting label: `Type/Refactor` - Kept: `Type/Task` - Reason: Issue had two conflicting `Type/*` labels. Per CONTRIBUTING.md, exactly one `Type/*` label is required. Since this issue is about addressing TODOs/FIXMEs (a task), `Type/Task` is the correct type. --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer
Author
Owner

Label compliance fix applied:

  • Removed duplicate Type/Task label (keeping Type/Refactor as primary)
  • Removed duplicate MoSCoW/Could Have (repo-level) label (org-level MoSCoW/Could have is sufficient)
  • Reason: Issue had two Type/* labels and two MoSCoW labels, violating CONTRIBUTING.md single-label-per-category rule

Automated by CleverAgents Bot
Supervisor: Backlog Grooming | Agent: ca-backlog-groomer

Label compliance fix applied: - Removed duplicate `Type/Task` label (keeping `Type/Refactor` as primary) - Removed duplicate `MoSCoW/Could Have` (repo-level) label (org-level `MoSCoW/Could have` is sufficient) - Reason: Issue had two Type/* labels and two MoSCoW labels, violating CONTRIBUTING.md single-label-per-category rule --- **Automated by CleverAgents Bot** Supervisor: Backlog Grooming | Agent: ca-backlog-groomer
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#3154
No description provided.