cleveragents/cleveragents-core

Fork 3

fix(error-handling): handle FileNotFoundError in robot.helper_actor_config #3151

Merged

freemo merged 1 commit from fix/error-handling-helper-actor-config-file-not-found into master

2026-04-05 21:14:53 +00:00

freemo commented

2026-04-05 06:57:33 +00:00

Owner

Summary

Fixes the unhandled FileNotFoundError in robot/helper_actor_config.py that caused the script to crash with a raw Python traceback when the provided config file path did not exist.

Changes

`robot/helper_actor_config.py`

Wrapped ActorConfiguration.from_file(path=config_path) in a try...except FileNotFoundError block
On FileNotFoundError: prints a user-friendly error message to sys.stderr and calls sys.exit(1) to ensure a non-zero exit code
The main function already had a -> None return type annotation

`robot/actor_configuration.robot`

Added test case "Missing Config File Exits With Non-Zero Code And Stderr Message" that:
- Runs helper_actor_config.py with a path that does not exist
- Asserts the return code is non-zero
- Asserts stderr contains the expected error message

Before / After

Before — script crashes with unhandled exception:

Traceback (most recent call last):
  File "robot/helper_actor_config.py", line 15, in main
    config = ActorConfiguration.from_file(path=config_path)
FileNotFoundError: [Errno 2] No such file or directory: '/path/to/missing.yaml'

After — graceful error with non-zero exit:

Error: Config file not found at '/path/to/missing.yaml'

Exit code: 1

Testing

New Robot Framework test case covers the missing-file error path
Lint (ruff check): ✅ passes
Format (ruff format --check): ✅ passes
Typecheck (pyright): ✅ 0 errors, 0 warnings

Closes #2829

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

## Summary Fixes the unhandled `FileNotFoundError` in `robot/helper_actor_config.py` that caused the script to crash with a raw Python traceback when the provided config file path did not exist. ## Changes ### `robot/helper_actor_config.py` - Wrapped `ActorConfiguration.from_file(path=config_path)` in a `try...except FileNotFoundError` block - On `FileNotFoundError`: prints a user-friendly error message to `sys.stderr` and calls `sys.exit(1)` to ensure a non-zero exit code - The `main` function already had a `-> None` return type annotation ### `robot/actor_configuration.robot` - Added test case **"Missing Config File Exits With Non-Zero Code And Stderr Message"** that: - Runs `helper_actor_config.py` with a path that does not exist - Asserts the return code is non-zero - Asserts `stderr` contains the expected error message ## Before / After **Before** — script crashes with unhandled exception: ``` Traceback (most recent call last): File "robot/helper_actor_config.py", line 15, in main config = ActorConfiguration.from_file(path=config_path) FileNotFoundError: [Errno 2] No such file or directory: '/path/to/missing.yaml' ``` **After** — graceful error with non-zero exit: ``` Error: Config file not found at '/path/to/missing.yaml' ``` Exit code: `1` ## Testing - New Robot Framework test case covers the missing-file error path - Lint (`ruff check`): ✅ passes - Format (`ruff format --check`): ✅ passes - Typecheck (`pyright`): ✅ 0 errors, 0 warnings Closes #2829 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo added 1 commit

2026-04-05 06:57:33 +00:00

fix(error-handling): handle FileNotFoundError in robot.helper_actor_config

CI / lint (pull_request) Successful in 26s

Details

CI / typecheck (pull_request) Successful in 46s

Details

CI / quality (pull_request) Successful in 35s

Details

CI / security (pull_request) Successful in 1m1s

Details

CI / build (pull_request) Successful in 25s

Details

CI / helm (pull_request) Successful in 24s

Details

CI / unit_tests (pull_request) Successful in 6m51s

Details

CI / docker (pull_request) Successful in 11s

Details

CI / coverage (pull_request) Successful in 10m53s

Details

CI / e2e_tests (pull_request) Successful in 18m53s

Details

CI / integration_tests (pull_request) Failing after 22m54s

Details

CI / status-check (pull_request) Failing after 1s

Details

CI / benchmark-publish (pull_request) Has been skipped

Details

CI / benchmark-regression (pull_request) Successful in 58m21s

Details

7d5c7a1114

Wrap ActorConfiguration.from_file() in a try...except FileNotFoundError
block in robot/helper_actor_config.py. When the config file path does not
exist, print a user-friendly error message to sys.stderr and exit with
code 1 instead of crashing with an unhandled exception and raw traceback.

Also adds a Robot Framework test case 'Missing Config File Exits With
Non-Zero Code And Stderr Message' to robot/actor_configuration.robot to
cover the new error path.

ISSUES CLOSED: #2829

freemo referenced this pull request

2026-04-05 06:59:55 +00:00

BUG-HUNT: [error-handling] Unhandled FileNotFoundError in robot.helper_actor_config #2829

freemo referenced this pull request

2026-04-05 07:03:54 +00:00

[CA-AUTO] System Watchdog — Session Tracker — 2026-04-05 #3136

freemo referenced this pull request

2026-04-05 07:24:20 +00:00

Task: System Watchdog session state — 2026-04-05 #3120

freemo referenced this pull request

2026-04-05 07:46:51 +00:00

needs feedback: Agents creating PRs without required Type/ labels #3207

freemo commented

2026-04-05 07:56:20 +00:00

Author

Owner

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3151-1743897600]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3151-1743897600] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

freemo referenced this pull request

2026-04-05 08:07:06 +00:00

Proposal: improve ca-docs-writer — add mandatory Type/Documentation label when creating PRs #3232

freemo reviewed

2026-04-05 08:46:43 +00:00

freemo left a comment

Code Review — LGTM ✅

PR: fix(error-handling): handle FileNotFoundError in robot.helper_actor_config

Review Checklist

✅ Correctness: Wraps ActorConfiguration.from_file() in try...except FileNotFoundError, prints user-friendly error to sys.stderr, and calls sys.exit(1) for non-zero exit code.

✅ Error Handling: Follows project convention — immediate argument validation, user-friendly error message, proper exit code.

✅ Commit Format: fix(error-handling): follows Conventional Changelog format.

Issues Noted (Non-blocking)

⚠️ Missing milestone — Please assign to the appropriate milestone.
⚠️ Missing Type/ label — Please add Type/Bug.

Decision: LGTM — Proceeding to merge when CI passes.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

## Code Review — LGTM ✅ **PR:** fix(error-handling): handle FileNotFoundError in robot.helper_actor_config ### Review Checklist **✅ Correctness:** Wraps `ActorConfiguration.from_file()` in `try...except FileNotFoundError`, prints user-friendly error to `sys.stderr`, and calls `sys.exit(1)` for non-zero exit code. **✅ Error Handling:** Follows project convention — immediate argument validation, user-friendly error message, proper exit code. **✅ Commit Format:** `fix(error-handling):` follows Conventional Changelog format. ### Issues Noted (Non-blocking) - ⚠️ **Missing milestone** — Please assign to the appropriate milestone. - ⚠️ **Missing Type/ label** — Please add `Type/Bug`. ### Decision: **LGTM** — Proceeding to merge when CI passes. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

freemo scheduled this pull request to auto merge when all checks succeed

2026-04-05 08:48:20 +00:00

freemo added a new dependency

2026-04-05 18:06:17 +00:00

#2829 BUG-HUNT: [error-handling] Unhandled FileNotFoundError in robot.helper_actor_config

freemo referenced this pull request

2026-04-05 18:06:47 +00:00

[Automated] CleverAgents Build Session - 2026-04-05 #3377

freemo merged commit 47a8a6fb78 into master

2026-04-05 21:14:46 +00:00