cleveragents/cleveragents-core

Fork 3

BUG-HUNT: [error-handling] Silent error suppression in facade construction #3133

New issue

Open

opened 2026-04-05 06:43:32 +00:00 by freemo · 2 comments

freemo commented

2026-04-05 06:43:32 +00:00

Owner

Bug Report: [error-handling] — Silent error suppression in facade construction

Severity Assessment

Impact: Can hide critical configuration or dependency injection failures, leading to a partially-functional or non-functional application that is difficult to debug.
Likelihood: High, as any exception during service creation will be silently ignored.
Priority: High

Location

File: src/cleveragents/a2a/cli_bootstrap.py
Function/Class: _build_facade
Lines: 39-50

Description

The _build_facade function uses contextlib.suppress(Exception) to wrap the wiring of each service. This is a dangerous pattern as it swallows any and all exceptions that might occur during the instantiation of the services. This means that if a service fails to be created for any reason (e.g., a missing configuration, a database connection error, a programming error), the exception will be silently ignored. The facade will be created with the service missing, and the application will likely fail at a later point in time with a less obvious error message.

Evidence

    with contextlib.suppress(Exception):
        services["plan_lifecycle_service"] = container.plan_lifecycle_service()

    with contextlib.suppress(Exception):
        services["session_service"] = container.session_service()

    with contextlib.suppress(Exception):
        services["resource_registry_service"] = container.resource_registry_service()

    with contextlib.suppress(Exception):
        services["tool_registry"] = container.tool_registry()

Expected Behavior

Exceptions during service creation should be logged with a clear error message indicating which service failed to load and why. The application should either fail fast or have a clear and well-defined fallback behavior.

Actual Behavior

Exceptions are silently swallowed, and the facade is created in a partially-wired state.

Suggested Fix

Replace contextlib.suppress(Exception) with a try...except block that logs the exception and continues. This will make it clear when a service fails to load, while still allowing the facade to be created.

    try:
        services["plan_lifecycle_service"] = container.plan_lifecycle_service()
    except Exception as e:
        logger.error("Failed to wire plan_lifecycle_service", exc_info=e)

error-handling

Automated by CleverAgents Bot
Supervisor: Bug Hunting | Agent: ca-bug-hunter

## Bug Report: [error-handling] — Silent error suppression in facade construction ### Severity Assessment - **Impact**: Can hide critical configuration or dependency injection failures, leading to a partially-functional or non-functional application that is difficult to debug. - **Likelihood**: High, as any exception during service creation will be silently ignored. - **Priority**: High ### Location - **File**: `src/cleveragents/a2a/cli_bootstrap.py` - **Function/Class**: `_build_facade` - **Lines**: 39-50 ### Description The `_build_facade` function uses `contextlib.suppress(Exception)` to wrap the wiring of each service. This is a dangerous pattern as it swallows any and all exceptions that might occur during the instantiation of the services. This means that if a service fails to be created for any reason (e.g., a missing configuration, a database connection error, a programming error), the exception will be silently ignored. The facade will be created with the service missing, and the application will likely fail at a later point in time with a less obvious error message. ### Evidence ```python with contextlib.suppress(Exception): services["plan_lifecycle_service"] = container.plan_lifecycle_service() with contextlib.suppress(Exception): services["session_service"] = container.session_service() with contextlib.suppress(Exception): services["resource_registry_service"] = container.resource_registry_service() with contextlib.suppress(Exception): services["tool_registry"] = container.tool_registry() ``` ### Expected Behavior Exceptions during service creation should be logged with a clear error message indicating which service failed to load and why. The application should either fail fast or have a clear and well-defined fallback behavior. ### Actual Behavior Exceptions are silently swallowed, and the facade is created in a partially-wired state. ### Suggested Fix Replace `contextlib.suppress(Exception)` with a `try...except` block that logs the exception and continues. This will make it clear when a service fails to load, while still allowing the facade to be created. ```python try: services["plan_lifecycle_service"] = container.plan_lifecycle_service() except Exception as e: logger.error("Failed to wire plan_lifecycle_service", exc_info=e) ``` ### Category error-handling --- **Automated by CleverAgents Bot** Supervisor: Bug Hunting | Agent: ca-bug-hunter

freemo referenced this issue

2026-04-05 07:43:00 +00:00

[CA-AUTO] Backlog Groomer — groomer-1 — Session Tracker #2771

freemo commented

2026-04-05 07:57:37 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium (upgrading rationale: while the bug hunter marked this High, contextlib.suppress(Exception) in _build_facade is a deliberate design choice for graceful degradation during CLI bootstrap. The spec's "No Error Suppression" rule applies to production code paths, but facade construction is a bootstrap path where partial wiring is intentional. However, the silent suppression without logging IS a valid concern — the fix should add logging, not remove the suppression.)
Milestone: v3.7.0 (error handling improvements are hardening work, appropriate for M8)
MoSCoW: Could Have — this is a code quality improvement. The current behavior works (facade degrades gracefully), but the lack of logging makes debugging harder. Not blocking any milestone acceptance criteria.
Parent Epic: #362 (Security & Safety Hardening — error handling falls under safety hardening)

Note: The suggested fix in the issue (replace suppress with try/except + logging) is the correct approach. Do NOT remove the graceful degradation behavior — just add visibility.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium (upgrading rationale: while the bug hunter marked this High, `contextlib.suppress(Exception)` in `_build_facade` is a deliberate design choice for graceful degradation during CLI bootstrap. The spec's "No Error Suppression" rule applies to production code paths, but facade construction is a bootstrap path where partial wiring is intentional. However, the silent suppression without logging IS a valid concern — the fix should add logging, not remove the suppression.) - **Milestone**: v3.7.0 (error handling improvements are hardening work, appropriate for M8) - **MoSCoW**: Could Have — this is a code quality improvement. The current behavior works (facade degrades gracefully), but the lack of logging makes debugging harder. Not blocking any milestone acceptance criteria. - **Parent Epic**: #362 (Security & Safety Hardening — error handling falls under safety hardening) Note: The suggested fix in the issue (replace `suppress` with `try/except` + logging) is the correct approach. Do NOT remove the graceful degradation behavior — just add visibility. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo added the

MoSCoW

Could have

label

2026-04-05 07:59:15 +00:00

freemo referenced this issue

2026-04-05 08:01:25 +00:00

[CA-AUTO] Project Owner — project-owner-1 — Session Tracker #2793

freemo added this to the v3.7.0 milestone

2026-04-05 08:01:53 +00:00

freemo commented

2026-04-05 08:04:38 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified ✅
Priority: Medium (adjusted from Backlog — silent error suppression in facade construction is a significant concern)
Milestone: v3.7.0 (assigned)
MoSCoW: Could Have — Using contextlib.suppress(Exception) during facade construction silently swallows all errors, which violates CONTRIBUTING.md's error handling guidelines. However, this is a defensive pattern for graceful degradation. The suggested fix (log + continue) is a reasonable improvement that should be done when time permits.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified ✅ - **Priority**: Medium (adjusted from Backlog — silent error suppression in facade construction is a significant concern) - **Milestone**: v3.7.0 (assigned) - **MoSCoW**: Could Have — Using `contextlib.suppress(Exception)` during facade construction silently swallows all errors, which violates CONTRIBUTING.md's error handling guidelines. However, this is a defensive pattern for graceful degradation. The suggested fix (log + continue) is a reasonable improvement that should be done when time permits. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo added a new dependency

2026-04-05 08:05:08 +00:00

#362 Epic: Security & Safety Hardening

freemo referenced this issue

2026-04-05 08:07:05 +00:00

[CA-AUTO] Project Owner — project-owner-1 — Session Tracker #2793

freemo referenced this issue

2026-04-05 08:19:37 +00:00

[CA-AUTO] Backlog Groomer — Session Tracker — groomer-1 — 2026-04-05 #3182