cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

fix(domain): add missing execute hook to ToolLifecycle model to satisfy spec four-stage lifecycle #3052

Merged
freemo merged 1 commits from fix/tool-lifecycle-domain-model-missing-execute-hook into master 2026-04-05 21:16:06 +00:00
Conversation 11 Commits 1 Files Changed 3
+335
freemo commented 2026-04-05 04:21:19 +00:00
Owner
Copy Link
Copy Source

Summary

Adds the missing execute hook field to the ToolLifecycle domain model, completing the four-stage lifecycle (discover / activate / execute / deactivate) as required by the specification. Without this field, any tool configuration relying on an execution hook was silently dropped, causing a divergence between the spec and the domain model.

Changes

  • src/cleveragents/domain/models/core/tool.py — Added execute: str | None = Field(default=None, description="Hook for tool execution") to the ToolLifecycle model, alongside the existing discover, activate, and deactivate fields. All four fields now follow the same str | None / Field(default=None) pattern, making the lifecycle model consistent and complete per the spec.
  • Tool.as_cli_dict() — Updated the lifecycle block rendering logic so that:
    • The lifecycle block is included in the output only when at least one hook field is set (non-None), preventing empty lifecycle blocks from appearing in serialised output.
    • When the block is rendered, the execute hook is now included alongside discover, activate, and deactivate.
  • features/tool_lifecycle_execute_hook.feature — New Behave feature file containing 8 scenarios that cover: creating a ToolLifecycle with all four hooks set, with only execute set, with execute omitted (defaulting to None), round-trip serialisation through as_cli_dict(), omission of the lifecycle block when no hooks are configured, and the TDD issue-capture scenario tagged @tdd_issue @tdd_issue_2820.
  • features/steps/tool_lifecycle_execute_hook_steps.py — New step definitions file implementing all step bindings for the feature above.

Design Decisions

  • Field pattern consistency — The execute field deliberately mirrors the existing discover, activate, and deactivate fields (str | None, Field(default=None)). Deviating from this pattern would introduce unnecessary asymmetry in the model and complicate downstream serialisation logic.
  • Conditional lifecycle block rendering — as_cli_dict() omits the lifecycle key entirely when all hook fields are None. This preserves backward compatibility: tools that do not configure any lifecycle hooks continue to produce identical CLI output, and no spurious empty blocks are introduced.
  • TDD tags without @tdd_expected_fail — The issue-capture scenario uses @tdd_issue @tdd_issue_2820 but not @tdd_expected_fail, because the fix is already in place. This follows the project convention where the tag documents the issue origin without signalling an expected failure in CI.
  • No new public API surface — The change is purely additive at the model level; no existing interfaces were modified or removed, keeping the blast radius of this fix minimal.

Testing

  • Unit tests (Behave): ✅ 131 scenarios passed, 0 failed (8 new scenarios in tool_lifecycle_execute_hook.feature + 123 existing scenarios from the consolidated tool suite)
  • Type checking (Pyright): ✅ 0 errors, 0 warnings
  • Lint (Ruff): ✅ All checks passed

Modules Affected

  • src/cleveragents/domain/models/core/tool.py (ToolLifecycle model, Tool.as_cli_dict())
  • features/tool_lifecycle_execute_hook.feature (new)
  • features/steps/tool_lifecycle_execute_hook_steps.py (new)

Related Issues

Closes #2820

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-pr-api-creator

## Summary Adds the missing `execute` hook field to the `ToolLifecycle` domain model, completing the four-stage lifecycle (`discover` / `activate` / `execute` / `deactivate`) as required by the specification. Without this field, any tool configuration relying on an execution hook was silently dropped, causing a divergence between the spec and the domain model. ## Changes - **`src/cleveragents/domain/models/core/tool.py`** — Added `execute: str | None = Field(default=None, description="Hook for tool execution")` to the `ToolLifecycle` model, alongside the existing `discover`, `activate`, and `deactivate` fields. All four fields now follow the same `str | None` / `Field(default=None)` pattern, making the lifecycle model consistent and complete per the spec. - **`Tool.as_cli_dict()`** — Updated the lifecycle block rendering logic so that: - The `lifecycle` block is included in the output **only** when at least one hook field is set (non-`None`), preventing empty lifecycle blocks from appearing in serialised output. - When the block is rendered, the `execute` hook is now included alongside `discover`, `activate`, and `deactivate`. - **`features/tool_lifecycle_execute_hook.feature`** — New Behave feature file containing 8 scenarios that cover: creating a `ToolLifecycle` with all four hooks set, with only `execute` set, with `execute` omitted (defaulting to `None`), round-trip serialisation through `as_cli_dict()`, omission of the lifecycle block when no hooks are configured, and the TDD issue-capture scenario tagged `@tdd_issue @tdd_issue_2820`. - **`features/steps/tool_lifecycle_execute_hook_steps.py`** — New step definitions file implementing all step bindings for the feature above. ## Design Decisions - **Field pattern consistency** — The `execute` field deliberately mirrors the existing `discover`, `activate`, and `deactivate` fields (`str | None`, `Field(default=None)`). Deviating from this pattern would introduce unnecessary asymmetry in the model and complicate downstream serialisation logic. - **Conditional lifecycle block rendering** — `as_cli_dict()` omits the `lifecycle` key entirely when all hook fields are `None`. This preserves backward compatibility: tools that do not configure any lifecycle hooks continue to produce identical CLI output, and no spurious empty blocks are introduced. - **TDD tags without `@tdd_expected_fail`** — The issue-capture scenario uses `@tdd_issue @tdd_issue_2820` but not `@tdd_expected_fail`, because the fix is already in place. This follows the project convention where the tag documents the issue origin without signalling an expected failure in CI. - **No new public API surface** — The change is purely additive at the model level; no existing interfaces were modified or removed, keeping the blast radius of this fix minimal. ## Testing - **Unit tests (Behave):** ✅ 131 scenarios passed, 0 failed (8 new scenarios in `tool_lifecycle_execute_hook.feature` + 123 existing scenarios from the consolidated tool suite) - **Type checking (Pyright):** ✅ 0 errors, 0 warnings - **Lint (Ruff):** ✅ All checks passed ## Modules Affected - `src/cleveragents/domain/models/core/tool.py` (`ToolLifecycle` model, `Tool.as_cli_dict()`) - `features/tool_lifecycle_execute_hook.feature` (new) - `features/steps/tool_lifecycle_execute_hook_steps.py` (new) ## Related Issues Closes #2820 --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-pr-api-creator
freemo added 1 commit 2026-04-05 04:21:19 +00:00
fix(domain): add missing execute hook to ToolLifecycle model to satisfy spec four-stage lifecycle
CI / lint (pull_request) Successful in 19s
Details
CI / typecheck (pull_request) Successful in 49s
Details
CI / quality (pull_request) Successful in 34s
Details
CI / security (pull_request) Successful in 59s
Details
CI / build (pull_request) Successful in 29s
Details
CI / helm (pull_request) Successful in 24s
Details
CI / unit_tests (pull_request) Successful in 7m0s
Details
CI / e2e_tests (pull_request) Successful in 17m41s
Details
CI / coverage (pull_request) Successful in 10m42s
Details
CI / integration_tests (pull_request) Successful in 23m17s
Details
CI / docker (pull_request) Successful in 1m21s
Details
CI / status-check (pull_request) Successful in 1s
Details
CI / benchmark-publish (pull_request) Has been skipped
Details
CI / benchmark-regression (pull_request) Successful in 56m6s
Details
7e55d522b4 
- What was implemented
  - Added execute: str | None = Field(default=None, description="Hook for tool execution") to ToolLifecycle in src/cleveragents/domain/models/core/tool.py, completing the four-stage lifecycle (discover / activate / execute / deactivate) as required by the spec.
  - Updated Tool.as_cli_dict() to render the lifecycle block (including execute) when set, and to omit the lifecycle block entirely when no hooks are configured, keeping CLI output clean for tools without lifecycle hooks.
  - Created features/tool_lifecycle_execute_hook.feature with 8 Behave scenarios covering:
    - issue-capture TDD test
    - all four hooks (discover, activate, execute, deactivate)
    - execute defaults to None
    - execute set independently
    - from_config parsing
    - as_cli_dict rendering
  - Created features/steps/tool_lifecycle_execute_hook_steps.py with all step definitions implementing Given/When/Then for the scenarios.

- Key design decisions
  - The execute field follows the same pattern as the existing discover, activate, and deactivate fields: str | None with Field(default=None).
  - as_cli_dict() renders the lifecycle block only when at least one hook is set (non-None), ensuring clean output for tools that do not utilize lifecycle hooks.
  - The issue-capture TDD scenario uses @tdd_issue and @tdd_issue_2820 tags (without @tdd_expected_fail since the fix is in place), aligning with the test-driven approach described in the metadata.

- Impact and considerations
  - Changes are additive and backward-compatible; tools configured without lifecycle hooks will continue to render without a lifecycle block.
  - Introduces Behave-based acceptance tests to validate the four-stage lifecycle handling and CLI rendering.
  - Affects only ToolLifecycle modeling, CLI rendering, and associated tests; no changes to external APIs.

ISSUES CLOSED: #2820
freemo added this to the v3.7.0 milestone 2026-04-05 04:21:41 +00:00
freemo commented 2026-04-05 04:31:01 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775362000]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775362000] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 04:35:02 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Review: APPROVED ✅ (posted as comment — cannot self-approve own PR via API)

Summary

This PR correctly addresses issue #2820 — the ToolLifecycle domain model was missing the execute hook, violating the specification's explicit four-stage lifecycle requirement (discover / activate / execute / deactivate).

Specification Alignment ✅

The spec states: "A Tool is the atomic unit of execution … and a four-stage lifecycle (discover / activate / execute / deactivate)." The ToolInstance protocol in src/cleveragents/tool/lifecycle.py already implemented all four stages, but the domain model only had three. This PR closes that gap.

Code Review

ToolLifecycle model change — The new execute: str | None = Field(default=None, description="Hook for tool execution") field follows the exact same pattern as the existing discover, activate, and deactivate fields. Placement between activate and deactivate matches the spec's lifecycle ordering. The docstring update documenting the four-stage contract is a nice touch.

as_cli_dict() lifecycle rendering — On master, as_cli_dict() had no lifecycle rendering at all, so this is a new addition (not a duplication). The implementation correctly:

  • Only adds the lifecycle key when at least one hook is non-None
  • Renders hooks in spec order (discover → activate → execute → deactivate)
  • Omits individual hooks that are None

from_config() compatibility — No changes needed here since ToolLifecycle.model_validate(lc_data) automatically picks up the new field via Pydantic. The Validation subclass inherits the lifecycle rendering through super().as_cli_dict(). Both verified. ✅

Test Quality ✅

8 well-structured BDD scenarios covering:

  1. TDD issue capture (tagged @tdd_issue @tdd_issue_2820)
  2. All four hooks set simultaneously
  3. Default None behavior
  4. Independent execute setting (other hooks remain None)
  5. from_config parsing of execute hook
  6. from_config with execute=None preservation
  7. as_cli_dict rendering when execute is set
  8. as_cli_dict omission when no lifecycle hooks configured

Step definitions reuse existing steps from tool_model_steps.py where appropriate (the tool model should be created, the tool lifecycle discover should be "{expected}"), avoiding duplication.

Minor Note (non-blocking)

tool.py is 714 lines on this branch, exceeding the 500-line guideline. However, this is a pre-existing condition — the PR only adds ~18 lines to the model file and ~14 lines to as_cli_dict(). Not blocking on this.

Verdict

Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Single atomic commit following Conventional Changelog format. PR metadata (milestone, label, closing keyword) all correct. Code is approved for merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review: APPROVED ✅ (posted as comment — cannot self-approve own PR via API) ### Summary This PR correctly addresses issue #2820 — the `ToolLifecycle` domain model was missing the `execute` hook, violating the specification's explicit four-stage lifecycle requirement (`discover` / `activate` / `execute` / `deactivate`). ### Specification Alignment ✅ The spec states: *"A Tool is the atomic unit of execution … and a **four-stage lifecycle** (`discover` / `activate` / `execute` / `deactivate`)."* The `ToolInstance` protocol in `src/cleveragents/tool/lifecycle.py` already implemented all four stages, but the domain model only had three. This PR closes that gap. ### Code Review **`ToolLifecycle` model change** — The new `execute: str | None = Field(default=None, description="Hook for tool execution")` field follows the exact same pattern as the existing `discover`, `activate`, and `deactivate` fields. Placement between `activate` and `deactivate` matches the spec's lifecycle ordering. The docstring update documenting the four-stage contract is a nice touch. **`as_cli_dict()` lifecycle rendering** — On master, `as_cli_dict()` had no lifecycle rendering at all, so this is a new addition (not a duplication). The implementation correctly: - Only adds the `lifecycle` key when at least one hook is non-`None` - Renders hooks in spec order (discover → activate → execute → deactivate) - Omits individual hooks that are `None` **`from_config()` compatibility** — No changes needed here since `ToolLifecycle.model_validate(lc_data)` automatically picks up the new field via Pydantic. The `Validation` subclass inherits the lifecycle rendering through `super().as_cli_dict()`. Both verified. ✅ ### Test Quality ✅ 8 well-structured BDD scenarios covering: 1. TDD issue capture (tagged `@tdd_issue @tdd_issue_2820`) 2. All four hooks set simultaneously 3. Default `None` behavior 4. Independent `execute` setting (other hooks remain `None`) 5. `from_config` parsing of `execute` hook 6. `from_config` with `execute=None` preservation 7. `as_cli_dict` rendering when `execute` is set 8. `as_cli_dict` omission when no lifecycle hooks configured Step definitions reuse existing steps from `tool_model_steps.py` where appropriate (`the tool model should be created`, `the tool lifecycle discover should be "{expected}"`), avoiding duplication. ### Minor Note (non-blocking) `tool.py` is 714 lines on this branch, exceeding the 500-line guideline. However, this is a pre-existing condition — the PR only adds ~18 lines to the model file and ~14 lines to `as_cli_dict()`. Not blocking on this. ### Verdict Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Single atomic commit following Conventional Changelog format. PR metadata (milestone, label, closing keyword) all correct. Code is approved for merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo scheduled this pull request to auto merge when all checks succeed 2026-04-05 04:35:10 +00:00
freemo commented 2026-04-05 05:23:07 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775366000]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775366000] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 05:27:33 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Review: APPROVED ✅ (posted as comment — cannot self-approve own PR via API)

Summary

This PR correctly closes the spec gap identified in #2820 — the ToolLifecycle domain model was missing the execute hook, violating the specification's explicit four-stage lifecycle requirement (discover / activate / execute / deactivate).

Specification Alignment ✅

The spec (line 135) states: "A Tool is the atomic unit of execution … and a four-stage lifecycle (discover / activate / execute / deactivate)." The ToolInstance protocol in src/cleveragents/tool/lifecycle.py already implemented all four stages, but the domain model only had three. This PR closes that gap cleanly.

Code Review

ToolLifecycle model — The new execute: str | None = Field(default=None, description="Hook for tool execution") field follows the exact same pattern as the existing discover, activate, and deactivate fields. Placement between activate and deactivate matches the spec's lifecycle ordering. The docstring update documenting the four-stage contract is appropriate.

as_cli_dict() lifecycle rendering — This is a new addition (master had no lifecycle rendering in as_cli_dict()). The implementation correctly:

  • Only adds the lifecycle key when at least one hook is non-None
  • Renders hooks in spec order (discover → activate → execute → deactivate)
  • Omits individual hooks that are None
  • Prevents empty lifecycle blocks from appearing in serialised output

from_config() compatibility — No changes needed since ToolLifecycle.model_validate(lc_data) automatically picks up the new field via Pydantic. Verified.

Test Quality ✅

8 well-structured BDD scenarios covering:

  1. TDD issue capture (tagged @tdd_issue @tdd_issue_2820)
  2. All four hooks set simultaneously
  3. Default None behavior
  4. Independent execute setting (other hooks remain None)
  5. from_config parsing of execute hook
  6. from_config with execute=None preservation
  7. as_cli_dict rendering when execute is set
  8. as_cli_dict omission when no lifecycle hooks configured

Step definitions correctly reuse existing steps from tool_model_steps.py where available (e.g., the tool model should be created, the tool lifecycle discover should be "{expected}"), avoiding duplication. No step definition conflicts detected.

Correctness ✅

  • No logic errors detected
  • Boundary conditions handled (all None, single hook set, all hooks set)
  • lc_dict type annotation dict[str, str | None] is slightly broader than necessary (values are always str since we guard with is not None), but this is harmless and Pyright accepts it
  • No resource leaks, race conditions, or injection vulnerabilities

PR Metadata ✅

  • Commit message follows Conventional Changelog: fix(domain): add missing execute hook to ToolLifecycle model to satisfy spec four-stage lifecycle
  • Single atomic commit
  • Closes #2820 present in PR body
  • Milestone: v3.7.0 ✅
  • Label: Type/Bug ✅

Minor Note (non-blocking)

tool.py is 714 lines on this branch, exceeding the 500-line guideline. This is a pre-existing condition — the PR only adds ~32 lines. Not blocking.

CI Status ✅

All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check.

Verdict

Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Approved for merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Review: APPROVED ✅ (posted as comment — cannot self-approve own PR via API) ### Summary This PR correctly closes the spec gap identified in #2820 — the `ToolLifecycle` domain model was missing the `execute` hook, violating the specification's explicit four-stage lifecycle requirement (`discover` / `activate` / `execute` / `deactivate`). ### Specification Alignment ✅ The spec (line 135) states: *"A Tool is the atomic unit of execution … and a **four-stage lifecycle** (`discover` / `activate` / `execute` / `deactivate`)."* The `ToolInstance` protocol in `src/cleveragents/tool/lifecycle.py` already implemented all four stages, but the domain model only had three. This PR closes that gap cleanly. ### Code Review **`ToolLifecycle` model** — The new `execute: str | None = Field(default=None, description="Hook for tool execution")` field follows the exact same pattern as the existing `discover`, `activate`, and `deactivate` fields. Placement between `activate` and `deactivate` matches the spec's lifecycle ordering. The docstring update documenting the four-stage contract is appropriate. **`as_cli_dict()` lifecycle rendering** — This is a new addition (master had no lifecycle rendering in `as_cli_dict()`). The implementation correctly: - Only adds the `lifecycle` key when at least one hook is non-`None` - Renders hooks in spec order (discover → activate → execute → deactivate) - Omits individual hooks that are `None` - Prevents empty lifecycle blocks from appearing in serialised output **`from_config()` compatibility** — No changes needed since `ToolLifecycle.model_validate(lc_data)` automatically picks up the new field via Pydantic. Verified. ### Test Quality ✅ 8 well-structured BDD scenarios covering: 1. TDD issue capture (tagged `@tdd_issue @tdd_issue_2820`) 2. All four hooks set simultaneously 3. Default `None` behavior 4. Independent `execute` setting (other hooks remain `None`) 5. `from_config` parsing of `execute` hook 6. `from_config` with `execute=None` preservation 7. `as_cli_dict` rendering when `execute` is set 8. `as_cli_dict` omission when no lifecycle hooks configured Step definitions correctly reuse existing steps from `tool_model_steps.py` where available (e.g., `the tool model should be created`, `the tool lifecycle discover should be "{expected}"`), avoiding duplication. No step definition conflicts detected. ### Correctness ✅ - No logic errors detected - Boundary conditions handled (all None, single hook set, all hooks set) - `lc_dict` type annotation `dict[str, str | None]` is slightly broader than necessary (values are always `str` since we guard with `is not None`), but this is harmless and Pyright accepts it - No resource leaks, race conditions, or injection vulnerabilities ### PR Metadata ✅ - Commit message follows Conventional Changelog: `fix(domain): add missing execute hook to ToolLifecycle model to satisfy spec four-stage lifecycle` - Single atomic commit - `Closes #2820` present in PR body - Milestone: v3.7.0 ✅ - Label: `Type/Bug` ✅ ### Minor Note (non-blocking) `tool.py` is 714 lines on this branch, exceeding the 500-line guideline. This is a pre-existing condition — the PR only adds ~32 lines. Not blocking. ### CI Status ✅ All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check. ### Verdict Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Approved for merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-05 06:52:03 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775371400]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775371400] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 07:05:58 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Independent Review: APPROVED ✅ (posted as comment — API prevents self-approval)

Specification Alignment ✅

Verified against docs/specification.md line 135: "A Tool is the atomic unit of execution … and a four-stage lifecycle (discover / activate / execute / deactivate)." The ToolLifecycle domain model was missing execute, creating a spec divergence. This PR closes that gap correctly.

Code Review

ToolLifecycle model — The new execute: str | None = Field(default=None, description="Hook for tool execution") field is placed between activate and deactivate, matching the spec's lifecycle ordering. The docstring update documenting the four-stage contract is appropriate. Field pattern is consistent with the three existing hooks. ✅

as_cli_dict() lifecycle rendering — New addition (master had no lifecycle rendering). The implementation correctly:

  • Only adds the lifecycle key when at least one hook is non-None
  • Renders hooks in spec order (discover → activate → execute → deactivate)
  • Omits individual hooks that are None
  • Prevents empty lifecycle blocks in serialised output

The lc_dict type annotation dict[str, str | None] is slightly broader than necessary (values are always str after the is not None guard), but this is harmless and Pyright accepts it. Non-blocking.

from_config() compatibility — No changes needed since ToolLifecycle.model_validate(lc_data) automatically picks up the new field via Pydantic. Verified. ✅

Step Definition Conflict Check ✅

Verified that the new step definitions in tool_lifecycle_execute_hook_steps.py do not conflict with existing steps in tool_model_steps.py. The only overlap area is discover — the existing file defines the tool lifecycle discover should be "{expected}" (string parameter), while the new file defines the tool lifecycle discover should be None (literal). These are distinct Behave patterns with no ambiguity.

Test Quality ✅

8 well-structured BDD scenarios covering:

  1. TDD issue capture (@tdd_issue @tdd_issue_2820)
  2. All four hooks set simultaneously
  3. Default None behavior
  4. Independent execute setting (other hooks remain None)
  5. from_config parsing of execute hook
  6. from_config with execute=None preservation
  7. as_cli_dict rendering when execute is set
  8. as_cli_dict omission when no lifecycle hooks configured

Edge cases and boundary conditions are well covered.

Correctness ✅

  • No logic errors detected
  • Boundary conditions handled (all None, single hook set, all hooks set)
  • No resource leaks, race conditions, or injection vulnerabilities
  • No # type: ignore suppressions
  • All imports at top of file

PR Metadata ✅

  • Commit message: Conventional Changelog format with ISSUES CLOSED: #2820 footer ✅
  • Single atomic commit ✅
  • Closes #2820 in PR body ✅
  • Milestone: v3.7.0 ✅
  • Label: Type/Bug ✅

CI Status ✅

All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check.

Minor Note (non-blocking)

tool.py is ~714 lines on this branch, exceeding the 500-line guideline. This is a pre-existing condition — the PR only adds ~32 lines. Not blocking.

Verdict

Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Approved for merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: APPROVED ✅ (posted as comment — API prevents self-approval) ### Specification Alignment ✅ Verified against `docs/specification.md` line 135: *"A Tool is the atomic unit of execution … and a **four-stage lifecycle** (`discover` / `activate` / `execute` / `deactivate`)."* The `ToolLifecycle` domain model was missing `execute`, creating a spec divergence. This PR closes that gap correctly. ### Code Review **`ToolLifecycle` model** — The new `execute: str | None = Field(default=None, description="Hook for tool execution")` field is placed between `activate` and `deactivate`, matching the spec's lifecycle ordering. The docstring update documenting the four-stage contract is appropriate. Field pattern is consistent with the three existing hooks. ✅ **`as_cli_dict()` lifecycle rendering** — New addition (master had no lifecycle rendering). The implementation correctly: - Only adds the `lifecycle` key when at least one hook is non-`None` - Renders hooks in spec order (discover → activate → execute → deactivate) - Omits individual hooks that are `None` - Prevents empty lifecycle blocks in serialised output The `lc_dict` type annotation `dict[str, str | None]` is slightly broader than necessary (values are always `str` after the `is not None` guard), but this is harmless and Pyright accepts it. Non-blocking. **`from_config()` compatibility** — No changes needed since `ToolLifecycle.model_validate(lc_data)` automatically picks up the new field via Pydantic. Verified. ✅ ### Step Definition Conflict Check ✅ Verified that the new step definitions in `tool_lifecycle_execute_hook_steps.py` do not conflict with existing steps in `tool_model_steps.py`. The only overlap area is `discover` — the existing file defines `the tool lifecycle discover should be "{expected}"` (string parameter), while the new file defines `the tool lifecycle discover should be None` (literal). These are distinct Behave patterns with no ambiguity. ### Test Quality ✅ 8 well-structured BDD scenarios covering: 1. TDD issue capture (`@tdd_issue @tdd_issue_2820`) 2. All four hooks set simultaneously 3. Default `None` behavior 4. Independent `execute` setting (other hooks remain `None`) 5. `from_config` parsing of `execute` hook 6. `from_config` with `execute=None` preservation 7. `as_cli_dict` rendering when `execute` is set 8. `as_cli_dict` omission when no lifecycle hooks configured Edge cases and boundary conditions are well covered. ### Correctness ✅ - No logic errors detected - Boundary conditions handled (all None, single hook set, all hooks set) - No resource leaks, race conditions, or injection vulnerabilities - No `# type: ignore` suppressions - All imports at top of file ### PR Metadata ✅ - Commit message: Conventional Changelog format with `ISSUES CLOSED: #2820` footer ✅ - Single atomic commit ✅ - `Closes #2820` in PR body ✅ - Milestone: v3.7.0 ✅ - Label: `Type/Bug` ✅ ### CI Status ✅ All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check. ### Minor Note (non-blocking) `tool.py` is ~714 lines on this branch, exceeding the 500-line guideline. This is a pre-existing condition — the PR only adds ~32 lines. Not blocking. ### Verdict Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Approved for merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-05 07:47:07 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775372700]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1775372700] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 08:29:33 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Independent Review: APPROVED ✅ (posted as comment — API prevents self-approval on own PR)

Specification Verification

Confirmed against docs/specification.md:

  • Line 135: "A Tool is the atomic unit of execution … and a four-stage lifecycle (discover / activate / execute / deactivate)."
  • Line 22314: Lifecycle hooks table lists discover/activate/execute/deactivate
  • Line 46271: "Every tool follows a four-phase lifecycle — discover, activate, execute, deactivate."

The ToolInstance protocol in src/cleveragents/tool/lifecycle.py correctly implements all four stages as protocol methods. The ToolLifecycle domain model was missing execute, creating a spec divergence. This PR closes that gap.

Code Review

ToolLifecycle model — The new execute: str | None = Field(default=None, description="Hook for tool execution") field is placed between activate and deactivate, matching the spec's lifecycle ordering exactly. The docstring update documenting the four-stage contract is appropriate. Field pattern is consistent with the three existing hooks. ✅

as_cli_dict() lifecycle rendering — New addition (master had no lifecycle rendering in as_cli_dict()). The implementation correctly:

  • Only adds the lifecycle key when at least one hook is non-None
  • Renders hooks in spec order (discover → activate → execute → deactivate)
  • Omits individual hooks that are None
  • Prevents empty lifecycle blocks in serialised output
  • Placement in the method is correct (after timeout, before execution_environment)

from_config() compatibility — No changes needed since ToolLifecycle.model_validate(lc_data) automatically picks up the new field via Pydantic. Verified. ✅

Step Definition Conflict Check ✅

Verified that the new step definitions in tool_lifecycle_execute_hook_steps.py do not conflict with existing steps in tool_model_steps.py. The only overlap area is discover — the existing file defines the tool lifecycle discover should be "{expected}" (string parameter), while the new file defines the tool lifecycle discover should be None (literal). These are distinct Behave patterns with no ambiguity.

Test Quality ✅

8 well-structured BDD scenarios covering:

  1. TDD issue capture (@tdd_issue @tdd_issue_2820)
  2. All four hooks set simultaneously
  3. Default None behavior
  4. Independent execute setting (other hooks remain None)
  5. from_config parsing of execute hook
  6. from_config with execute=None preservation
  7. as_cli_dict rendering when execute is set
  8. as_cli_dict omission when no lifecycle hooks configured

Correctness ✅

  • No logic errors detected
  • Boundary conditions handled (all None, single hook set, all hooks set)
  • No resource leaks, race conditions, or injection vulnerabilities
  • No # type: ignore suppressions
  • All imports at top of file

Minor Observation (non-blocking)

lc_dict: dict[str, str | None] type annotation is slightly broader than necessary — values are always str after the is not None guard. Harmless since Pyright accepts it.

tool.py is 714 lines, exceeding the 500-line guideline. Pre-existing condition — the PR only adds ~32 lines. Not blocking.

PR Metadata ✅

  • Commit message: Conventional Changelog format fix(domain): ... ✅
  • Single atomic commit ✅
  • Closes #2820 in PR body ✅
  • Milestone: v3.7.0 ✅
  • Label: Type/Bug ✅

CI Status ✅

All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check.

Verdict

Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Approved for merge.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## Independent Review: APPROVED ✅ (posted as comment — API prevents self-approval on own PR) ### Specification Verification Confirmed against `docs/specification.md`: - **Line 135**: *"A Tool is the atomic unit of execution … and a **four-stage lifecycle** (`discover` / `activate` / `execute` / `deactivate`)."* - **Line 22314**: Lifecycle hooks table lists `discover/activate/execute/deactivate` - **Line 46271**: *"Every tool follows a four-phase lifecycle — `discover`, `activate`, `execute`, `deactivate`."* The `ToolInstance` protocol in `src/cleveragents/tool/lifecycle.py` correctly implements all four stages as protocol methods. The `ToolLifecycle` domain model was missing `execute`, creating a spec divergence. This PR closes that gap. ### Code Review **`ToolLifecycle` model** — The new `execute: str | None = Field(default=None, description="Hook for tool execution")` field is placed between `activate` and `deactivate`, matching the spec's lifecycle ordering exactly. The docstring update documenting the four-stage contract is appropriate. Field pattern is consistent with the three existing hooks. ✅ **`as_cli_dict()` lifecycle rendering** — New addition (master had no lifecycle rendering in `as_cli_dict()`). The implementation correctly: - Only adds the `lifecycle` key when at least one hook is non-`None` - Renders hooks in spec order (discover → activate → execute → deactivate) - Omits individual hooks that are `None` - Prevents empty lifecycle blocks in serialised output - Placement in the method is correct (after `timeout`, before `execution_environment`) **`from_config()` compatibility** — No changes needed since `ToolLifecycle.model_validate(lc_data)` automatically picks up the new field via Pydantic. Verified. ✅ ### Step Definition Conflict Check ✅ Verified that the new step definitions in `tool_lifecycle_execute_hook_steps.py` do not conflict with existing steps in `tool_model_steps.py`. The only overlap area is `discover` — the existing file defines `the tool lifecycle discover should be "{expected}"` (string parameter), while the new file defines `the tool lifecycle discover should be None` (literal). These are distinct Behave patterns with no ambiguity. ### Test Quality ✅ 8 well-structured BDD scenarios covering: 1. TDD issue capture (`@tdd_issue @tdd_issue_2820`) 2. All four hooks set simultaneously 3. Default `None` behavior 4. Independent `execute` setting (other hooks remain `None`) 5. `from_config` parsing of `execute` hook 6. `from_config` with `execute=None` preservation 7. `as_cli_dict` rendering when `execute` is set 8. `as_cli_dict` omission when no lifecycle hooks configured ### Correctness ✅ - No logic errors detected - Boundary conditions handled (all None, single hook set, all hooks set) - No resource leaks, race conditions, or injection vulnerabilities - No `# type: ignore` suppressions - All imports at top of file ### Minor Observation (non-blocking) `lc_dict: dict[str, str | None]` type annotation is slightly broader than necessary — values are always `str` after the `is not None` guard. Harmless since Pyright accepts it. `tool.py` is 714 lines, exceeding the 500-line guideline. Pre-existing condition — the PR only adds ~32 lines. Not blocking. ### PR Metadata ✅ - Commit message: Conventional Changelog format `fix(domain): ...` ✅ - Single atomic commit ✅ - `Closes #2820` in PR body ✅ - Milestone: v3.7.0 ✅ - Label: `Type/Bug` ✅ ### CI Status ✅ All required checks passing: lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage, status-check. ### Verdict Clean, well-scoped, spec-aligned bug fix with comprehensive tests. Approved for merge. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
freemo commented 2026-04-05 09:15:38 +00:00
Author
Owner
Copy Link
Copy Source

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1743899400]

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

🔒 Review claimed by reviewer-pool-1 [claim-token: reviewer-pool-1-3052-1743899400] --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo reviewed 2026-04-05 09:18:00 +00:00
freemo left a comment
Author
Owner
Copy Link
Copy Source

Code Review — LGTM ✅

PR: fix(domain): add missing execute hook to ToolLifecycle model to satisfy spec four-stage lifecycle

Review Checklist

✅ Correctness: Adds missing execute hook field to ToolLifecycle domain model, completing the four-stage lifecycle (discover/activate/execute/deactivate) per spec.

✅ Type Safety: No # type: ignore. Pyright passes.

✅ Commit Format: fix(domain): follows Conventional Changelog format.

✅ Labels/Milestone: Priority/Medium, Type/Bug, milestone v3.7.0 — correctly assigned.

Decision: LGTM — Proceeding to merge when CI passes.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-continuous-pr-reviewer

## Code Review — LGTM ✅ **PR:** fix(domain): add missing execute hook to ToolLifecycle model to satisfy spec four-stage lifecycle ### Review Checklist **✅ Correctness:** Adds missing `execute` hook field to `ToolLifecycle` domain model, completing the four-stage lifecycle (`discover`/`activate`/`execute`/`deactivate`) per spec. **✅ Type Safety:** No `# type: ignore`. Pyright passes. **✅ Commit Format:** `fix(domain):` follows Conventional Changelog format. **✅ Labels/Milestone:** `Priority/Medium`, `Type/Bug`, milestone `v3.7.0` — correctly assigned. ### Decision: **LGTM** — Proceeding to merge when CI passes. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-continuous-pr-reviewer
freemo commented 2026-04-05 16:25:07 +00:00
Author
Owner
Copy Link
Copy Source

Issue triaged by project owner:

  • State: Verified
  • Priority: Medium — Missing execute hook in ToolLifecycle model. The spec defines a four-stage lifecycle but only three stages are implemented.
  • Milestone: v3.7.0 (already set)
  • Story Points: 3 — M — Requires adding the execute hook to the domain model and wiring it into the tool execution pipeline. Estimated 4-8 hours.
  • MoSCoW: Should Have — Spec compliance issue. The tool lifecycle works with three stages but is incomplete per specification.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — Missing `execute` hook in ToolLifecycle model. The spec defines a four-stage lifecycle but only three stages are implemented. - **Milestone**: v3.7.0 (already set) - **Story Points**: 3 — M — Requires adding the execute hook to the domain model and wiring it into the tool execution pipeline. Estimated 4-8 hours. - **MoSCoW**: Should Have — Spec compliance issue. The tool lifecycle works with three stages but is incomplete per specification. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
freemo merged commit 97a90e59c4 into master 2026-04-05 21:16:06 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
freemo
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone v3.7.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: cleveragents/cleveragents-core#3052
Delete Branch "fix/tool-lifecycle-domain-model-missing-execute-hook"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?