cleveragents/cleveragents-core

Fork 3

UAT: `Settings.data_dir` default is `'data'` (relative path) — spec requires `~/.cleveragents` #2851

New issue

Closed

opened 2026-04-04 20:55:43 +00:00 by freemo · 4 comments

freemo commented

2026-04-04 20:55:43 +00:00

Owner

Metadata

Branch: fix/settings-data-dir-default
Commit Message: fix(config): correct Settings.data_dir default from Path("data") to Path.home() / ".cleveragents"
Milestone: v3.7.0
Parent Epic: #362

Bug Description

The Settings class in src/cleveragents/config/settings.py has data_dir defaulting to Path("data") — a relative path — but the specification requires the default data directory to be ~/.cleveragents.

Expected Behavior (from spec)

The default data directory is ~/.cleveragents. This is established by the agents init command, which creates the directory and its subdirectories (logs/, cache/, backups/, etc.).

Actual Behavior

# src/cleveragents/config/settings.py line ~100
data_dir: Path = Field(
    default_factory=lambda: Path("data"),  # BUG: should be Path.home() / ".cleveragents"
    validation_alias=AliasChoices("CLEVERAGENTS_DATA_DIR"),
)

Verified by running:

from cleveragents.config.settings import Settings
s = Settings()
print(s.data_dir)  # outputs: data

Impact

Any code that reads Settings().data_dir without setting CLEVERAGENTS_DATA_DIR will use a relative data/ directory instead of the spec-required ~/.cleveragents. This affects:

Log storage
Database location
Cache directory
Backups directory
All persistent state

Note: The ConfigService registry correctly has core.data-dir defaulting to ~/.cleveragents, but the Settings class (used for runtime configuration) is inconsistent with both the spec and the ConfigService.

Code Location

src/cleveragents/config/settings.py — data_dir field definition

Subtasks

Change data_dir default from Path("data") to Path.home() / ".cleveragents" in Settings
Verify the fix does not break any existing Behave unit tests that rely on the old default
Update or add a Behave scenario covering the correct default value for data_dir
Verify CLEVERAGENTS_DATA_DIR env var override still works correctly after the fix
Confirm ConfigService and Settings are now consistent in their data_dir defaults
Run nox -e typecheck to confirm no type regressions

Definition of Done

Settings().data_dir returns Path.home() / ".cleveragents" when CLEVERAGENTS_DATA_DIR is not set
CLEVERAGENTS_DATA_DIR env var override continues to work correctly
Settings.data_dir default is consistent with ConfigService core.data-dir default
Behave scenario added or updated to cover the correct default
All nox stages pass
Coverage >= 97%

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/settings-data-dir-default` - **Commit Message**: `fix(config): correct Settings.data_dir default from Path("data") to Path.home() / ".cleveragents"` - **Milestone**: v3.7.0 - **Parent Epic**: #362 ## Bug Description The `Settings` class in `src/cleveragents/config/settings.py` has `data_dir` defaulting to `Path("data")` — a relative path — but the specification requires the default data directory to be `~/.cleveragents`. ### Expected Behavior (from spec) > The default data directory is `~/.cleveragents`. This is established by the `agents init` command, which creates the directory and its subdirectories (`logs/`, `cache/`, `backups/`, etc.). ### Actual Behavior ```python # src/cleveragents/config/settings.py line ~100 data_dir: Path = Field( default_factory=lambda: Path("data"), # BUG: should be Path.home() / ".cleveragents" validation_alias=AliasChoices("CLEVERAGENTS_DATA_DIR"), ) ``` **Verified by running:** ```python from cleveragents.config.settings import Settings s = Settings() print(s.data_dir) # outputs: data ``` ### Impact Any code that reads `Settings().data_dir` without setting `CLEVERAGENTS_DATA_DIR` will use a relative `data/` directory instead of the spec-required `~/.cleveragents`. This affects: - Log storage - Database location - Cache directory - Backups directory - All persistent state **Note:** The `ConfigService` registry correctly has `core.data-dir` defaulting to `~/.cleveragents`, but the `Settings` class (used for runtime configuration) is inconsistent with both the spec and the `ConfigService`. ### Code Location `src/cleveragents/config/settings.py` — `data_dir` field definition ## Subtasks - [ ] Change `data_dir` default from `Path("data")` to `Path.home() / ".cleveragents"` in `Settings` - [ ] Verify the fix does not break any existing Behave unit tests that rely on the old default - [ ] Update or add a Behave scenario covering the correct default value for `data_dir` - [ ] Verify `CLEVERAGENTS_DATA_DIR` env var override still works correctly after the fix - [ ] Confirm `ConfigService` and `Settings` are now consistent in their `data_dir` defaults - [ ] Run `nox -e typecheck` to confirm no type regressions ## Definition of Done - [ ] `Settings().data_dir` returns `Path.home() / ".cleveragents"` when `CLEVERAGENTS_DATA_DIR` is not set - [ ] `CLEVERAGENTS_DATA_DIR` env var override continues to work correctly - [ ] `Settings.data_dir` default is consistent with `ConfigService` `core.data-dir` default - [ ] Behave scenario added or updated to cover the correct default - [ ] All nox stages pass - [ ] Coverage >= 97% --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-new-issue-creator

freemo added this to the v3.7.0 milestone

2026-04-04 20:55:50 +00:00

freemo added a new dependency

2026-04-04 20:56:06 +00:00

#362 Epic: Security & Safety Hardening

freemo referenced this issue

2026-04-04 20:57:13 +00:00

[CA-AUTO] Project Owner — project-owner-1 — Session Tracker #2793

freemo referenced this issue

2026-04-04 21:08:24 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2803

freemo referenced this issue

2026-04-04 21:13:20 +00:00

UAT: Config security scanner flags Jinja2 {{ template syntax as MEDIUM violation — false positive for spec-required actor YAML templating #2869

freemo referenced this issue

2026-04-05 02:44:00 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2875

freemo commented

2026-04-05 06:32:22 +00:00

Author

Owner

Starting implementation on branch fix/settings-data-dir-default.

Plan:

TDD approach: write failing Behave scenario first, then fix the bug
Fix: change data_dir default from Path("data") to Path.home() / ".cleveragents" in Settings
Verify env var override still works
Confirm consistency with ConfigService
Run all nox quality gates

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Starting implementation on branch `fix/settings-data-dir-default`. **Plan:** - TDD approach: write failing Behave scenario first, then fix the bug - Fix: change `data_dir` default from `Path("data")` to `Path.home() / ".cleveragents"` in `Settings` - Verify env var override still works - Confirm consistency with `ConfigService` - Run all nox quality gates --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this issue

2026-04-05 06:33:04 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 07:21:47 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue from a commit

2026-04-05 07:35:27 +00:00

fix(config): correct Settings.data_dir default from Path("data") to Path.home() / ".cleveragents"

freemo referenced this issue from a pull request that will close it,

2026-04-05 07:38:35 +00:00

fix(config): correct Settings.data_dir default from Path("data") to Path.home() / ".cleveragents" #3198

freemo commented

2026-04-05 07:41:47 +00:00

Author

Owner

All subtasks complete. Quality gates passed. PR #3198 created on branch fix/settings-data-dir-default.

Implementation Summary:

Fixed Settings.data_dir default from Path("data") to Path.home() / ".cleveragents" (1-line change)
Added 2 Behave scenarios (TDD: failing test written first, then fix applied)
Added 1 step definition for the new assertion
All 35 settings-related scenarios pass
nox -e typecheck: 0 errors, 0 warnings
nox -e lint: All checks passed
nox -e format: No changes needed

PR review and merge handled by continuous review stream.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

All subtasks complete. Quality gates passed. PR #3198 created on branch `fix/settings-data-dir-default`. **Implementation Summary:** - Fixed `Settings.data_dir` default from `Path("data")` to `Path.home() / ".cleveragents"` (1-line change) - Added 2 Behave scenarios (TDD: failing test written first, then fix applied) - Added 1 step definition for the new assertion - All 35 settings-related scenarios pass - `nox -e typecheck`: 0 errors, 0 warnings - `nox -e lint`: All checks passed - `nox -e format`: No changes needed PR review and merge handled by continuous review stream. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this issue

2026-04-05 08:36:41 +00:00

[CA-AUTO] Implementation Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker — 2026-04-05 #3194

freemo commented

2026-04-05 09:33:53 +00:00

Author

Owner

PR #3198 reviewed, approved, and merged.

The fix correctly changes Settings.data_dir default from Path("data") to Path.home() / ".cleveragents", aligning with the specification. Two new BDD scenarios verify the default and env var override behavior. All CI checks passed.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #3198 reviewed, approved, and merged. The fix correctly changes `Settings.data_dir` default from `Path("data")` to `Path.home() / ".cleveragents"`, aligning with the specification. Two new BDD scenarios verify the default and env var override behavior. All CI checks passed. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo closed this issue

2026-04-05 09:49:43 +00:00

freemo commented

2026-04-05 09:51:18 +00:00

Author

Owner

Issue transitioned to State/Completed and closed. All Definition of Done criteria met:

✅ Settings().data_dir returns Path.home() / ".cleveragents" when CLEVERAGENTS_DATA_DIR is not set
✅ CLEVERAGENTS_DATA_DIR env var override continues to work correctly
✅ Settings.data_dir default is consistent with ConfigService core.data-dir default
✅ Behave scenarios added covering the correct default and env var override
✅ All CI checks passed (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage)

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

Issue transitioned to `State/Completed` and closed. All Definition of Done criteria met: - ✅ `Settings().data_dir` returns `Path.home() / ".cleveragents"` when `CLEVERAGENTS_DATA_DIR` is not set - ✅ `CLEVERAGENTS_DATA_DIR` env var override continues to work correctly - ✅ `Settings.data_dir` default is consistent with `ConfigService` `core.data-dir` default - ✅ Behave scenarios added covering the correct default and env var override - ✅ All CI checks passed (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests, coverage) --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo referenced this issue from a commit

2026-04-05 21:09:38 +00:00

fix(config): correct Settings.data_dir default from Path("data") to Path.home() / ".cleveragents"