cleveragents/cleveragents-core

Fork 3

UAT: `ResourceDagMixin` missing `get_parents()` method — `resource_dag.feature` scenario "Get parents returns all direct parents" has no implementation #2844

New issue

Closed

opened 2026-04-04 20:48:59 +00:00 by freemo · 3 comments

freemo commented

2026-04-04 20:48:59 +00:00

Owner

Metadata

Branch: fix/v3.7.0-resource-dag-mixin-get-parents
Commit Message: fix(resource-registry): implement get_parents() on ResourceDagMixin
Milestone: v3.7.0
Parent Epic: #398

Background and context

The resource_dag.feature BDD test file contains a scenario "Get parents returns all direct parents" that exercises a get_parents() method on ResourceRegistryService (via ResourceDagMixin). Per the specification, resources are organized in a Directed Acyclic Graph (DAG) with parent/child links stored in the Resource Registry. A resource may have multiple parents, and querying those parents is a fundamental DAG traversal operation — symmetric to the already-implemented get_children().

The ResourceDagMixin in src/cleveragents/application/services/_resource_registry_dag.py implements get_children() and get_resource_tree() but has no get_parents() method. This is a spec-required capability that is entirely absent from the implementation.

Current behavior

ResourceDagMixin (and therefore ResourceRegistryService) has no get_parents() method. Running nox -e unit_tests against the resource_dag.feature scenario "Get parents returns all direct parents" fails with an AttributeError or NotImplementedError because the method does not exist.

Affected files:

src/cleveragents/application/services/_resource_registry_dag.py — get_children() exists (~line 200) but get_parents() is absent
features/resource_dag.feature — scenario "Get parents returns all direct parents" (tagged @dag_traversal) cannot pass

Failing BDD scenario:

@dag_traversal
Scenario: Get parents returns all direct parents
  Given a DAG parent type "dag/parent-type" allowing children '["dag/child-type"]'
  And a DAG child type "dag/child-type"
  And a DAG resource "P1" typed "dag/parent-type"
  And a DAG resource "P2" typed "dag/parent-type"
  And a DAG resource "C1" typed "dag/child-type"
  And DAG child "C1" is already linked to parent "P1"
  And DAG child "C1" is already linked to parent "P2"
  When DAG parents of "C1" are retrieved
  Then 2 DAG parents should be returned

Expected behavior

ResourceRegistryService (via ResourceDagMixin) exposes a get_parents(name_or_id: str) -> list[Resource] method that:

Accepts a resource name or ULID identifier
Returns all direct parent resources of the given resource
Mirrors the existing get_children() method in signature and behaviour
Raises an appropriate exception if the resource does not exist

The resource_dag.feature scenario "Get parents returns all direct parents" passes end-to-end.

Acceptance criteria

ResourceDagMixin.get_parents(name_or_id: str) -> list[Resource] is implemented in _resource_registry_dag.py
ResourceRegistryService exposes get_parents() via the mixin
The method returns all direct parent resources for a child that has multiple parents (e.g., C1 linked to P1 and P2 returns both)
The method returns an empty list for a resource with no parents (root node)
The method raises a descriptive exception when the given resource does not exist
The BDD scenario "Get parents returns all direct parents" in resource_dag.feature passes
All existing @dag_traversal scenarios continue to pass (no regression)
nox (all default sessions) passes with no errors
Coverage >= 97%

Supporting information

Parent Epic: #398 (Post-MVP Resources)
Symmetric method already implemented: get_children() in src/cleveragents/application/services/_resource_registry_dag.py
BDD feature file: features/resource_dag.feature
Severity: High — a spec-required DAG traversal operation is completely missing from the implementation

Subtasks

Implement get_parents(name_or_id: str) -> list[Resource] in ResourceDagMixin (_resource_registry_dag.py)
Expose get_parents() through ResourceRegistryService
Add/verify Behave step definitions for the "Get parents returns all direct parents" scenario in resource_dag.feature
Add unit tests covering: multiple parents returned, empty list for root node, exception for non-existent resource
Verify no regression in existing @dag_traversal BDD scenarios
Verify coverage >= 97% via nox -s coverage_report
Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly (fix(resource-registry): implement get_parents() on ResourceDagMixin), followed by a blank line, then additional lines providing relevant details about the implementation.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly (fix/v3.7.0-resource-dag-mixin-get-parents).
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
All nox stages pass.
Coverage >= 97%.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata - **Branch**: `fix/v3.7.0-resource-dag-mixin-get-parents` - **Commit Message**: `fix(resource-registry): implement get_parents() on ResourceDagMixin` - **Milestone**: v3.7.0 - **Parent Epic**: #398 ## Background and context The `resource_dag.feature` BDD test file contains a scenario "Get parents returns all direct parents" that exercises a `get_parents()` method on `ResourceRegistryService` (via `ResourceDagMixin`). Per the specification, resources are organized in a Directed Acyclic Graph (DAG) with parent/child links stored in the Resource Registry. A resource may have multiple parents, and querying those parents is a fundamental DAG traversal operation — symmetric to the already-implemented `get_children()`. The `ResourceDagMixin` in `src/cleveragents/application/services/_resource_registry_dag.py` implements `get_children()` and `get_resource_tree()` but has no `get_parents()` method. This is a spec-required capability that is entirely absent from the implementation. ## Current behavior `ResourceDagMixin` (and therefore `ResourceRegistryService`) has no `get_parents()` method. Running `nox -e unit_tests` against the `resource_dag.feature` scenario "Get parents returns all direct parents" fails with an `AttributeError` or `NotImplementedError` because the method does not exist. **Affected files:** - `src/cleveragents/application/services/_resource_registry_dag.py` — `get_children()` exists (~line 200) but `get_parents()` is absent - `features/resource_dag.feature` — scenario "Get parents returns all direct parents" (tagged `@dag_traversal`) cannot pass **Failing BDD scenario:** ```gherkin @dag_traversal Scenario: Get parents returns all direct parents Given a DAG parent type "dag/parent-type" allowing children '["dag/child-type"]' And a DAG child type "dag/child-type" And a DAG resource "P1" typed "dag/parent-type" And a DAG resource "P2" typed "dag/parent-type" And a DAG resource "C1" typed "dag/child-type" And DAG child "C1" is already linked to parent "P1" And DAG child "C1" is already linked to parent "P2" When DAG parents of "C1" are retrieved Then 2 DAG parents should be returned ``` ## Expected behavior `ResourceRegistryService` (via `ResourceDagMixin`) exposes a `get_parents(name_or_id: str) -> list[Resource]` method that: - Accepts a resource name or ULID identifier - Returns all direct parent resources of the given resource - Mirrors the existing `get_children()` method in signature and behaviour - Raises an appropriate exception if the resource does not exist The `resource_dag.feature` scenario "Get parents returns all direct parents" passes end-to-end. ## Acceptance criteria - [ ] `ResourceDagMixin.get_parents(name_or_id: str) -> list[Resource]` is implemented in `_resource_registry_dag.py` - [ ] `ResourceRegistryService` exposes `get_parents()` via the mixin - [ ] The method returns all direct parent resources for a child that has multiple parents (e.g., C1 linked to P1 and P2 returns both) - [ ] The method returns an empty list for a resource with no parents (root node) - [ ] The method raises a descriptive exception when the given resource does not exist - [ ] The BDD scenario "Get parents returns all direct parents" in `resource_dag.feature` passes - [ ] All existing `@dag_traversal` scenarios continue to pass (no regression) - [ ] `nox` (all default sessions) passes with no errors - [ ] Coverage >= 97% ## Supporting information - Parent Epic: #398 (Post-MVP Resources) - Symmetric method already implemented: `get_children()` in `src/cleveragents/application/services/_resource_registry_dag.py` - BDD feature file: `features/resource_dag.feature` - Severity: **High** — a spec-required DAG traversal operation is completely missing from the implementation ## Subtasks - [ ] Implement `get_parents(name_or_id: str) -> list[Resource]` in `ResourceDagMixin` (`_resource_registry_dag.py`) - [ ] Expose `get_parents()` through `ResourceRegistryService` - [ ] Add/verify Behave step definitions for the "Get parents returns all direct parents" scenario in `resource_dag.feature` - [ ] Add unit tests covering: multiple parents returned, empty list for root node, exception for non-existent resource - [ ] Verify no regression in existing `@dag_traversal` BDD scenarios - [ ] Verify coverage >= 97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly (`fix(resource-registry): implement get_parents() on ResourceDagMixin`), followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly (`fix/v3.7.0-resource-dag-mixin-get-parents`). - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done. - All nox stages pass. - Coverage >= 97%. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester

freemo added this to the v3.7.0 milestone

2026-04-04 20:49:26 +00:00

freemo added a new dependency

2026-04-04 20:49:51 +00:00

#398 Epic: Post-MVP Resources

freemo referenced this issue

2026-04-04 20:51:19 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2803

freemo referenced this issue

2026-04-04 20:51:37 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2803

freemo referenced this issue

2026-04-04 20:57:13 +00:00

[CA-AUTO] Project Owner — project-owner-1 — Session Tracker #2793

freemo referenced this issue

2026-04-04 21:08:24 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2803

freemo referenced this issue

2026-04-05 02:44:00 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.7.0 — Session Tracker #2875

freemo referenced this issue

2026-04-05 06:33:04 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo referenced this issue

2026-04-05 07:21:47 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.2.0–v3.7.0 — Session Tracker #3094

freemo commented

2026-04-05 07:57:50 +00:00

Author

Owner

Starting implementation on branch fix/v3.7.0-resource-dag-mixin-get-parents.

Analysis: ResourceDagMixin in _resource_registry_dag.py is missing get_parents() method. The symmetric get_children() method exists. The fix is straightforward: add get_parents() that queries ResourceLinkModel filtering by child_id instead of parent_id.

Implementation: Added get_parents(name_or_id: str) -> list[Resource] to ResourceDagMixin — mirrors get_children() exactly but queries parent links. Calls show_resource() first to raise NotFoundError for non-existent resources.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

Starting implementation on branch `fix/v3.7.0-resource-dag-mixin-get-parents`. **Analysis:** `ResourceDagMixin` in `_resource_registry_dag.py` is missing `get_parents()` method. The symmetric `get_children()` method exists. The fix is straightforward: add `get_parents()` that queries `ResourceLinkModel` filtering by `child_id` instead of `parent_id`. **Implementation:** Added `get_parents(name_or_id: str) -> list[Resource]` to `ResourceDagMixin` — mirrors `get_children()` exactly but queries parent links. Calls `show_resource()` first to raise `NotFoundError` for non-existent resources. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo referenced this issue from a commit

2026-04-05 08:29:38 +00:00

fix(resource-registry): implement get_parents() on ResourceDagMixin

freemo referenced this issue from a pull request that will close it,

2026-04-05 08:31:44 +00:00

fix(resource-registry): implement get_parents() on ResourceDagMixin #3252

freemo commented

2026-04-05 08:36:41 +00:00

Author

Owner

All subtasks complete. Quality gates passed. PR #3252 created on branch fix/v3.7.0-resource-dag-mixin-get-parents.

Results:

✅ get_parents() implemented in ResourceDagMixin (_resource_registry_dag.py)
✅ ResourceRegistryService exposes get_parents() via mixin inheritance
✅ BDD scenario "Get parents returns all direct parents" passes
✅ All 15 resource_dag.feature scenarios pass (no regression)
✅ nox -s typecheck — 0 errors
✅ nox -s lint — all checks passed

PR review and merge handled by continuous review stream.

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: ca-issue-worker

All subtasks complete. Quality gates passed. PR #3252 created on branch `fix/v3.7.0-resource-dag-mixin-get-parents`. **Results:** - ✅ `get_parents()` implemented in `ResourceDagMixin` (`_resource_registry_dag.py`) - ✅ `ResourceRegistryService` exposes `get_parents()` via mixin inheritance - ✅ BDD scenario "Get parents returns all direct parents" passes - ✅ All 15 `resource_dag.feature` scenarios pass (no regression) - ✅ `nox -s typecheck` — 0 errors - ✅ `nox -s lint` — all checks passed PR review and merge handled by continuous review stream. --- **Automated by CleverAgents Bot** Supervisor: Implementation | Agent: ca-issue-worker

freemo commented

2026-04-05 10:17:46 +00:00

Author

Owner

PR #3252 has been reviewed, approved, and scheduled to merge when all CI checks pass.

Review summary:

✅ Implementation correctly mirrors get_children() with symmetric child_id query
✅ All specification requirements met (signature, error handling, sorting)
✅ BDD scenario "Get parents returns all direct parents" passes
✅ All 15 existing DAG scenarios pass (no regression)
✅ Core CI checks passed (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests)
✅ Commit message follows Conventional Changelog format with ISSUES CLOSED: #2844

Merge is scheduled to complete automatically once remaining CI jobs (coverage, benchmark, docker, status-check) finish.

Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #3252 has been reviewed, approved, and scheduled to merge when all CI checks pass. **Review summary:** - ✅ Implementation correctly mirrors `get_children()` with symmetric `child_id` query - ✅ All specification requirements met (signature, error handling, sorting) - ✅ BDD scenario "Get parents returns all direct parents" passes - ✅ All 15 existing DAG scenarios pass (no regression) - ✅ Core CI checks passed (lint, typecheck, security, quality, unit_tests, integration_tests, e2e_tests) - ✅ Commit message follows Conventional Changelog format with `ISSUES CLOSED: #2844` Merge is scheduled to complete automatically once remaining CI jobs (coverage, benchmark, docker, status-check) finish. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer

freemo closed this issue

2026-04-05 21:11:49 +00:00

freemo referenced this issue from a commit

2026-04-05 21:11:50 +00:00

fix(resource-registry): implement get_parents() on ResourceDagMixin