Branch protection required_approvals is 0 — should be 2 per CONTRIBUTING.md #2792

New issue

Closed

opened 2026-04-04 19:42:37 +00:00 by freemo · 1 comment

freemo commented

2026-04-04 19:42:37 +00:00

Owner

Metadata

Branch: N/A (configuration change, not code)
Commit Message: N/A

Background and Context

The System Watchdog detected that the Forgejo branch protection rule for master has required_approvals: 0, but CONTRIBUTING.md § Pull Request Process requires:

A PR requires at least two approving reviews from contributors who are not the author.

This configuration gap means PRs can be merged with zero approvals, bypassing the peer review requirement.

Current Behavior

Branch protection for master:

✅ enable_status_check: true (with comprehensive CI contexts)
✅ apply_to_admins: true
✅ block_on_outdated_branch: true
✅ dismiss_stale_approvals: true
❌ required_approvals: 0 (should be 2)

Expected Behavior

required_approvals should be set to 2 to enforce the CONTRIBUTING.md requirement.

Acceptance Criteria

Branch protection rule for master has required_approvals: 2
Verify that PRs cannot be merged without 2 approving reviews

Supporting Information

Detected by: System Watchdog (ca-system-watchdog)
Persisted for: 6 monitoring cycles (~30 minutes)
Related: CONTRIBUTING.md § Pull Request Process

Automated by CleverAgents Bot
Supervisor: System Watchdog | Agent: ca-system-watchdog

## Metadata - **Branch**: N/A (configuration change, not code) - **Commit Message**: N/A ## Background and Context The System Watchdog detected that the Forgejo branch protection rule for `master` has `required_approvals: 0`, but CONTRIBUTING.md § Pull Request Process requires: > A PR requires at least **two** approving reviews from contributors who are not the author. This configuration gap means PRs can be merged with zero approvals, bypassing the peer review requirement. ## Current Behavior Branch protection for `master`: - ✅ `enable_status_check: true` (with comprehensive CI contexts) - ✅ `apply_to_admins: true` - ✅ `block_on_outdated_branch: true` - ✅ `dismiss_stale_approvals: true` - ❌ `required_approvals: 0` (should be 2) ## Expected Behavior `required_approvals` should be set to `2` to enforce the CONTRIBUTING.md requirement. ## Acceptance Criteria - [ ] Branch protection rule for `master` has `required_approvals: 2` - [ ] Verify that PRs cannot be merged without 2 approving reviews ## Supporting Information - Detected by: System Watchdog (ca-system-watchdog) - Persisted for: 6 monitoring cycles (~30 minutes) - Related: CONTRIBUTING.md § Pull Request Process --- **Automated by CleverAgents Bot** Supervisor: System Watchdog | Agent: ca-system-watchdog

freemo commented

2026-04-05 02:34:16 +00:00

Author

Owner

While normally we operate witha strict requirement of 2 reviews, this project is currently operating fully autonomously so we dont require reviews at all. it will stay that way for the near-term at least.

freemo closed this issue

2026-04-05 02:34:16 +00:00

freemo referenced this issue

2026-04-05 02:39:08 +00:00

[CA-AUTO] Backlog Groomer — groomer-1 — Session Tracker #2771

freemo referenced this issue

2026-04-05 02:47:49 +00:00

[CA-AUTO] Backlog Groomer — groomer-1 — Session Tracker #2771