Tests (Robot): Add missing Robot Framework integration test for the acp module #2768

Open
opened 2026-04-04 19:19:51 +00:00 by freemo · 1 comment
Owner

Metadata

  • Branch: test/acp-robot-integration
  • Commit Message: test(acp): add Robot Framework integration test suite for acp module
  • Milestone: v3.7.0
  • Parent Epic: #933

Background and Context

The src/cleveragents/acp/ module is the A2A protocol layer — the sole Presentation-Application boundary per the project specification (ADR-047, §Architecture). It contains the following sub-modules (confirmed via compiled artefacts):

  • clients — A2A client transport wrappers
  • errors — ACP/A2A error types
  • events — SSE / push-notification event models
  • facade — high-level facade used by CLI and TUI layers
  • models — domain models (requests, responses, task lifecycle)
  • server_config — server-side configuration helpers
  • transport — low-level JSON-RPC 2.0 transport
  • versioning — protocol version negotiation

A scan of /app/robot/ confirms that no .robot file currently targets the acp module — there is a gap in the Robot Framework integration test suite that leaves the entire protocol layer untested at the integration level. A companion Behave unit-test issue exists as #2762; this issue covers the Robot Framework integration layer, which must use real services and dependencies (no mocking permitted per CONTRIBUTING.md).

Subtasks

  • Audit each acp sub-module (clients, errors, events, facade, models, server_config, transport, versioning) and identify all integration-level behaviours to be covered
  • Create robot/acp.robot with Robot Framework test cases for each identified behaviour, exercising real A2A wire interactions
  • Create robot/helper_acp.py with the corresponding Python keyword library
  • Ensure all test cases use real services — no mocking permitted in integration tests
  • Run nox -e integration_tests locally and confirm all new test cases pass
  • Verify coverage >= 97% via nox -e coverage_report
  • Run nox (all default sessions) and fix any errors

Definition of Done

  • All subtasks above are completed and checked off
  • robot/acp.robot exists and covers all public integration-level behaviours of the acp module
  • robot/helper_acp.py exists with all required keyword implementations
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly (test(acp): add Robot Framework integration test suite for acp module), followed by a blank line, then additional lines providing relevant details about the implementation
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly (test/acp-robot-integration)
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done
  • All nox stages pass
  • Coverage >= 97%

Automated by CleverAgents Bot
Supervisor: Unknown | Agent: ca-new-issue-creator

## Metadata - **Branch**: `test/acp-robot-integration` - **Commit Message**: `test(acp): add Robot Framework integration test suite for acp module` - **Milestone**: v3.7.0 - **Parent Epic**: #933 ## Background and Context The `src/cleveragents/acp/` module is the A2A protocol layer — the sole Presentation-Application boundary per the project specification (ADR-047, §Architecture). It contains the following sub-modules (confirmed via compiled artefacts): - `clients` — A2A client transport wrappers - `errors` — ACP/A2A error types - `events` — SSE / push-notification event models - `facade` — high-level facade used by CLI and TUI layers - `models` — domain models (requests, responses, task lifecycle) - `server_config` — server-side configuration helpers - `transport` — low-level JSON-RPC 2.0 transport - `versioning` — protocol version negotiation A scan of `/app/robot/` confirms that **no `.robot` file currently targets the `acp` module** — there is a gap in the Robot Framework integration test suite that leaves the entire protocol layer untested at the integration level. A companion Behave unit-test issue exists as #2762; this issue covers the Robot Framework integration layer, which must use **real services and dependencies** (no mocking permitted per CONTRIBUTING.md). ## Subtasks - [ ] Audit each `acp` sub-module (`clients`, `errors`, `events`, `facade`, `models`, `server_config`, `transport`, `versioning`) and identify all integration-level behaviours to be covered - [ ] Create `robot/acp.robot` with Robot Framework test cases for each identified behaviour, exercising real A2A wire interactions - [ ] Create `robot/helper_acp.py` with the corresponding Python keyword library - [ ] Ensure all test cases use real services — no mocking permitted in integration tests - [ ] Run `nox -e integration_tests` locally and confirm all new test cases pass - [ ] Verify coverage >= 97% via `nox -e coverage_report` - [ ] Run `nox` (all default sessions) and fix any errors ## Definition of Done - [ ] All subtasks above are completed and checked off - [ ] `robot/acp.robot` exists and covers all public integration-level behaviours of the `acp` module - [ ] `robot/helper_acp.py` exists with all required keyword implementations - [ ] A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly (`test(acp): add Robot Framework integration test suite for acp module`), followed by a blank line, then additional lines providing relevant details about the implementation - [ ] The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly (`test/acp-robot-integration`) - [ ] The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done - [ ] All nox stages pass - [ ] Coverage >= 97% --- **Automated by CleverAgents Bot** Supervisor: Unknown | Agent: ca-new-issue-creator
freemo added this to the v3.7.0 milestone 2026-04-04 19:20:56 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • Priority: Medium
  • MoSCoW: Should Have — Missing integration tests for the acp module reduce confidence in that module's correctness. Test coverage is a project requirement (≥97%).
  • Parent Epic: Needs linking to an appropriate Epic.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium - **MoSCoW**: Should Have — Missing integration tests for the acp module reduce confidence in that module's correctness. Test coverage is a project requirement (≥97%). - **Parent Epic**: Needs linking to an appropriate Epic. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
cleveragents/cleveragents-core#2768
No description provided.