UAT: `InvariantService.get_effective_invariants()` silently drops ACTION-scope invariants — spec requires action invariants to participate in effective set #2526

New issue

Open

opened 2026-04-03 18:47:53 +00:00 by freemo · 1 comment

freemo commented

2026-04-03 18:47:53 +00:00

Owner

Metadata

Branch: fix/invariant-effective-action-scope
Commit Message: fix(invariant): include action-scope invariants in get_effective_invariants
Milestone: v3.4.0
Parent Epic: #394

Background and Context

The specification states that invariants can be scoped at four levels: global, project, action, and plan. The spec explicitly states:

"Action invariants are promoted to plan-level when the action is used, so the runtime precedence chain is three-tier: plan > project > global."

However, InvariantService.get_effective_invariants() only collects invariants from three scopes (PLAN, PROJECT, GLOBAL) and completely ignores ACTION-scope invariants. This means any invariant added with agents invariant add --action <ACTION> is silently excluded from the effective invariant set.

Steps to Reproduce

from cleveragents.application.services.invariant_service import InvariantService
from cleveragents.domain.models.core.invariant import InvariantScope

s = InvariantService()
s.add_invariant('Global rule', InvariantScope.GLOBAL, 'system')
s.add_invariant('Action rule', InvariantScope.ACTION, 'local/deploy')

effective = s.get_effective_invariants(plan_id=None, project_name=None)
print(len(effective))  # Prints 1 — action invariant is missing!

Expected Behavior (per spec)

get_effective_invariants() should accept an optional action_name parameter and include action-scope invariants in the merged result. The spec's precedence chain is plan > action > project > global (as implemented in InvariantReconciliationActor which correctly handles action scope via collect_invariants()).

Actual Behavior

get_effective_invariants() signature is:

def get_effective_invariants(
    self,
    plan_id: str | None = None,
    project_name: str | None = None,
) -> list[Invariant]:

There is no action_name parameter. The implementation only collects PLAN, PROJECT, and GLOBAL invariants — ACTION invariants are completely ignored.

Code Location

src/cleveragents/application/services/invariant_service.py — get_effective_invariants() method (lines ~100-130)

Impact

agents invariant list --effective with --action filter will not show action invariants in the effective set
Any code calling get_effective_invariants() directly (not via InvariantReconciliationActor) will silently miss action-scope invariants
The InvariantReconciliationActor correctly handles this via collect_invariants(), but InvariantService.get_effective_invariants() is inconsistent with it

Subtasks

Add action_name: str | None = None parameter to get_effective_invariants()
Collect ACTION-scope invariants filtered by action_name (or all action invariants if action_name is None)
Pass action invariants to merge_invariants() at the correct precedence level (between plan and project)
Update InvariantSet.merge() to accept action_invariants parameter
Update merge_invariants() function to handle action scope
Add unit tests for the corrected behavior

Definition of Done

get_effective_invariants(action_name='local/deploy') returns action-scope invariants in the effective set
InvariantSet.merge() accepts action_invariants parameter
merge_invariants() correctly places action invariants between plan and project in precedence
All existing tests pass
New unit tests cover action-scope invariant inclusion

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata - **Branch**: `fix/invariant-effective-action-scope` - **Commit Message**: `fix(invariant): include action-scope invariants in get_effective_invariants` - **Milestone**: v3.4.0 - **Parent Epic**: #394 ## Background and Context The specification states that invariants can be scoped at four levels: `global`, `project`, `action`, and `plan`. The spec explicitly states: > "Action invariants are promoted to plan-level when the action is used, so the runtime precedence chain is three-tier: plan > project > global." However, `InvariantService.get_effective_invariants()` only collects invariants from three scopes (`PLAN`, `PROJECT`, `GLOBAL`) and completely ignores `ACTION`-scope invariants. This means any invariant added with `agents invariant add --action <ACTION>` is silently excluded from the effective invariant set. ## Steps to Reproduce ```python from cleveragents.application.services.invariant_service import InvariantService from cleveragents.domain.models.core.invariant import InvariantScope s = InvariantService() s.add_invariant('Global rule', InvariantScope.GLOBAL, 'system') s.add_invariant('Action rule', InvariantScope.ACTION, 'local/deploy') effective = s.get_effective_invariants(plan_id=None, project_name=None) print(len(effective)) # Prints 1 — action invariant is missing! ``` ## Expected Behavior (per spec) `get_effective_invariants()` should accept an optional `action_name` parameter and include action-scope invariants in the merged result. The spec's precedence chain is `plan > action > project > global` (as implemented in `InvariantReconciliationActor` which correctly handles action scope via `collect_invariants()`). ## Actual Behavior `get_effective_invariants()` signature is: ```python def get_effective_invariants( self, plan_id: str | None = None, project_name: str | None = None, ) -> list[Invariant]: ``` There is no `action_name` parameter. The implementation only collects `PLAN`, `PROJECT`, and `GLOBAL` invariants — `ACTION` invariants are completely ignored. ## Code Location - `src/cleveragents/application/services/invariant_service.py` — `get_effective_invariants()` method (lines ~100-130) ## Impact - `agents invariant list --effective` with `--action` filter will not show action invariants in the effective set - Any code calling `get_effective_invariants()` directly (not via `InvariantReconciliationActor`) will silently miss action-scope invariants - The `InvariantReconciliationActor` correctly handles this via `collect_invariants()`, but `InvariantService.get_effective_invariants()` is inconsistent with it ## Subtasks - [ ] Add `action_name: str | None = None` parameter to `get_effective_invariants()` - [ ] Collect `ACTION`-scope invariants filtered by `action_name` (or all action invariants if `action_name` is None) - [ ] Pass action invariants to `merge_invariants()` at the correct precedence level (between plan and project) - [ ] Update `InvariantSet.merge()` to accept `action_invariants` parameter - [ ] Update `merge_invariants()` function to handle action scope - [ ] Add unit tests for the corrected behavior ## Definition of Done - `get_effective_invariants(action_name='local/deploy')` returns action-scope invariants in the effective set - `InvariantSet.merge()` accepts `action_invariants` parameter - `merge_invariants()` correctly places action invariants between plan and project in precedence - All existing tests pass - New unit tests cover action-scope invariant inclusion --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester

freemo commented

2026-04-03 18:53:44 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
MoSCoW: Should Have — Spec compliance or quality improvement.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **MoSCoW**: Should Have — Spec compliance or quality improvement. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo referenced this issue

2026-04-03 18:54:29 +00:00

[CA-AUTO] UAT Pool Supervisor — v3.x — Session Tracker #2435

freemo added a new dependency

2026-04-03 19:08:47 +00:00

#2597 fix(ci): restore all CI quality gates to passing on master — no suppression, no bypasses

freemo added this to the v3.3.0 milestone

2026-04-05 05:07:04 +00:00