refactor(automation): remove automation_level legacy fields #252

New issue

Closed

opened 2026-02-22 23:40:35 +00:00 by freemo · 0 comments

freemo commented

2026-02-22 23:40:35 +00:00

Owner

Metadata

Commit: refactor(automation): remove automation_level legacy fields
Branch: feature/m4-automation-legacy-cleanup

Subtasks

Remove automation_level from Plan domain model, config settings, and CLI flags; keep automation_profile as the only automation control.
Add migration to drop automation_level column + CHECK constraint from v3_plans (SQLite rebuild), with downgrade restoring legacy column.
Remove legacy mapping logic in PlanLifecycleService and config fallback (no automation_level alias).
Update config + CLI references to remove automation_level mentions and document profile-only flow.
Tests (Behave): Add scenarios ensuring legacy automation_level inputs are rejected with explicit errors.
Tests (Robot): Add Robot CLI test verifying plan use --automation-level is rejected post-removal.
Tests (ASV): Add benchmarks/automation_legacy_cleanup_bench.py for migration runtime baseline.
Verify coverage >=97% via nox -s coverage_report. If coverage is <97% then review the current unit test coverage report at build/coverage.xml and use it to write new Behave based unit tests to improve coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun nox -s coverage_report to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Section: #### Section 3 Notes
Status: Completed

## Metadata - **Commit**: `refactor(automation): remove automation_level legacy fields` - **Branch**: `feature/m4-automation-legacy-cleanup` ## Subtasks - [x] Remove `automation_level` from Plan domain model, config settings, and CLI flags; keep `automation_profile` as the only automation control. - [x] Add migration to drop `automation_level` column + CHECK constraint from `v3_plans` (SQLite rebuild), with downgrade restoring legacy column. - [x] Remove legacy mapping logic in `PlanLifecycleService` and config fallback (no `automation_level` alias). - [x] Update config + CLI references to remove automation_level mentions and document profile-only flow. - [x] Tests (Behave): Add scenarios ensuring legacy automation_level inputs are rejected with explicit errors. - [x] Tests (Robot): Add Robot CLI test verifying `plan use --automation-level` is rejected post-removal. - [x] Tests (ASV): Add `benchmarks/automation_legacy_cleanup_bench.py` for migration runtime baseline. - [x] Verify coverage >=97% via `nox -s coverage_report`. If coverage is <97% then review the current unit test coverage report at `build/coverage.xml` and use it to write new Behave based unit tests to improve coverage. Specifically, write Behave style unit tests that are descriptively named and specifically improves coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `nox -s coverage_report` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [x] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. **Section**: #### Section 3 Notes **Status**: Completed

Rows
Columns