UAT: agents action show and agents action list omit apply_actor and review_actor from output — optional actor fields not displayed #2514

Open
opened 2026-04-03 18:42:54 +00:00 by freemo · 1 comment
Owner

Metadata

  • Branch: fix/action-display-missing-actor-fields
  • Commit Message: fix(cli): include apply_actor and review_actor in action show and list output
  • Milestone: v3.7.0
  • Parent Epic: #372

Description

The _action_spec_dict() helper function in src/cleveragents/cli/commands/action.py (lines 103–132) and the _print_action() rich display function (lines 135–203) do not include apply_actor or review_actor in their output. This means:

  1. agents action show <name> — does not display apply_actor or review_actor even if they are set
  2. agents action list --format json — does not include apply_actor or review_actor in the JSON output
  3. agents action show <name> --format json — same omission

The Action domain model (src/cleveragents/domain/models/core/action.py) has both apply_actor: str | None (line 385) and review_actor: str | None (line 381) fields. The spec defines both as optional actors in the Action data model.

The _action_spec_dict function includes estimation_actor and invariant_actor conditionally, but completely omits apply_actor and review_actor.

Expected Behavior (per spec)

All actor fields defined in the Action data model should be visible in the action show/action list output when they are set.

Actual Behavior

apply_actor and review_actor are never shown in any action display command, regardless of whether they are set on the action.

Code Locations

  • src/cleveragents/cli/commands/action.py, lines 103–132 — _action_spec_dict() missing apply_actor and review_actor
  • src/cleveragents/cli/commands/action.py, lines 135–203 — _print_action() rich display missing apply_actor and review_actor

Proposed Fix

Add conditional inclusion of apply_actor and review_actor in _action_spec_dict() (mirroring how estimation_actor is handled), and add corresponding display lines for them in _print_action().

  • #2498 — CLI drops apply_actor and review_actor on action create
  • #2499 — Service layer missing apply_actor parameter

Note

: Even if #2498 and #2499 are resolved, this display bug would still need to be addressed independently.

Subtasks

  • Write TDD Behave scenario: agents action show <name> displays apply_actor when set (red test)
  • Write TDD Behave scenario: agents action show <name> displays review_actor when set (red test)
  • Write TDD Behave scenario: agents action list --format json includes apply_actor and review_actor in JSON output (red test)
  • Add conditional apply_actor inclusion to _action_spec_dict() in src/cleveragents/cli/commands/action.py (mirroring estimation_actor pattern)
  • Add conditional review_actor inclusion to _action_spec_dict() in src/cleveragents/cli/commands/action.py
  • Add apply_actor display row to _print_action() rich output
  • Add review_actor display row to _print_action() rich output
  • Verify all TDD scenarios pass (green tests)
  • Run nox -e typecheck — confirm no Pyright errors
  • Run nox -e unit_tests — confirm all Behave scenarios pass
  • Run nox -e coverage_report — confirm coverage ≥ 97%
  • Run nox (all default sessions) — fix any errors

Definition of Done

This issue is complete when:

  • agents action show <name> displays apply_actor and review_actor when they are set on the action
  • agents action list --format json includes apply_actor and review_actor keys in each action object (with null or omitted when not set, consistent with other optional actor fields)
  • agents action show <name> --format json includes apply_actor and review_actor in the JSON output
  • _action_spec_dict() conditionally includes apply_actor and review_actor (consistent with estimation_actor pattern)
  • _print_action() renders apply_actor and review_actor rows in the Rich display
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional details about the implementation
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done
  • All nox stages pass
  • Coverage ≥ 97%

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata - **Branch**: `fix/action-display-missing-actor-fields` - **Commit Message**: `fix(cli): include apply_actor and review_actor in action show and list output` - **Milestone**: v3.7.0 - **Parent Epic**: #372 ## Description The `_action_spec_dict()` helper function in `src/cleveragents/cli/commands/action.py` (lines 103–132) and the `_print_action()` rich display function (lines 135–203) do not include `apply_actor` or `review_actor` in their output. This means: 1. `agents action show <name>` — does not display `apply_actor` or `review_actor` even if they are set 2. `agents action list --format json` — does not include `apply_actor` or `review_actor` in the JSON output 3. `agents action show <name> --format json` — same omission The `Action` domain model (`src/cleveragents/domain/models/core/action.py`) has both `apply_actor: str | None` (line 385) and `review_actor: str | None` (line 381) fields. The spec defines both as optional actors in the Action data model. The `_action_spec_dict` function includes `estimation_actor` and `invariant_actor` conditionally, but completely omits `apply_actor` and `review_actor`. ### Expected Behavior (per spec) All actor fields defined in the `Action` data model should be visible in the `action show`/`action list` output when they are set. ### Actual Behavior `apply_actor` and `review_actor` are never shown in any action display command, regardless of whether they are set on the action. ### Code Locations - `src/cleveragents/cli/commands/action.py`, lines 103–132 — `_action_spec_dict()` missing `apply_actor` and `review_actor` - `src/cleveragents/cli/commands/action.py`, lines 135–203 — `_print_action()` rich display missing `apply_actor` and `review_actor` ### Proposed Fix Add conditional inclusion of `apply_actor` and `review_actor` in `_action_spec_dict()` (mirroring how `estimation_actor` is handled), and add corresponding display lines for them in `_print_action()`. ### Related Issues - #2498 — CLI drops `apply_actor` and `review_actor` on `action create` - #2499 — Service layer missing `apply_actor` parameter > **Note**: Even if #2498 and #2499 are resolved, this display bug would still need to be addressed independently. ## Subtasks - [ ] Write TDD Behave scenario: `agents action show <name>` displays `apply_actor` when set (red test) - [ ] Write TDD Behave scenario: `agents action show <name>` displays `review_actor` when set (red test) - [ ] Write TDD Behave scenario: `agents action list --format json` includes `apply_actor` and `review_actor` in JSON output (red test) - [ ] Add conditional `apply_actor` inclusion to `_action_spec_dict()` in `src/cleveragents/cli/commands/action.py` (mirroring `estimation_actor` pattern) - [ ] Add conditional `review_actor` inclusion to `_action_spec_dict()` in `src/cleveragents/cli/commands/action.py` - [ ] Add `apply_actor` display row to `_print_action()` rich output - [ ] Add `review_actor` display row to `_print_action()` rich output - [ ] Verify all TDD scenarios pass (green tests) - [ ] Run `nox -e typecheck` — confirm no Pyright errors - [ ] Run `nox -e unit_tests` — confirm all Behave scenarios pass - [ ] Run `nox -e coverage_report` — confirm coverage ≥ 97% - [ ] Run `nox` (all default sessions) — fix any errors ## Definition of Done This issue is complete when: - [ ] `agents action show <name>` displays `apply_actor` and `review_actor` when they are set on the action - [ ] `agents action list --format json` includes `apply_actor` and `review_actor` keys in each action object (with `null` or omitted when not set, consistent with other optional actor fields) - [ ] `agents action show <name> --format json` includes `apply_actor` and `review_actor` in the JSON output - [ ] `_action_spec_dict()` conditionally includes `apply_actor` and `review_actor` (consistent with `estimation_actor` pattern) - [ ] `_print_action()` renders `apply_actor` and `review_actor` rows in the Rich display - [ ] A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional details about the implementation - [ ] The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly - [ ] The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done - [ ] All nox stages pass - [ ] Coverage ≥ 97% --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester
freemo added this to the v3.7.0 milestone 2026-04-03 18:42:59 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • MoSCoW: Should Have — Spec compliance or quality improvement that should be included in the milestone.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **MoSCoW**: Should Have — Spec compliance or quality improvement that should be included in the milestone. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
Reference
cleveragents/cleveragents-core#2514
No description provided.