UAT: fs-mount built-in resource type is missing from BUILTIN_TYPESagents resource add fs-mount fails with "Resource type not found" #2506

Open
opened 2026-04-03 18:40:43 +00:00 by freemo · 1 comment
Owner

Metadata

  • Branch: fix/fs-mount-missing-builtin-type
  • Commit Message: fix(resources): add missing fs-mount built-in resource type definition to BUILTIN_TYPES
  • Milestone: v3.6.0
  • Parent Epic: #398

Background

The specification explicitly lists fs-mount as a built-in resource type (see spec glossary: "Built-in types (e.g., git-checkout, fs-mount) are unnamespaced" and the resource type list table showing fs-mount as a built-in physical type with copy_on_write sandbox strategy and fs-directory as child type).

However, fs-mount is not registered in BUILTIN_TYPES in /app/src/cleveragents/application/services/_resource_registry_data.py. The BUILTIN_TYPE_NAMES frozenset in _resource_type_validation.py (line 25) includes fs-mount as a known name, but there is no actual type definition dict for it in _GIT_FS_CONTAINER_TYPES or any other list that feeds into BUILTIN_TYPES.

Current Behavior

  • agents resource type show fs-mount returns "Resource type not found: fs-mount"
  • agents resource add fs-mount local/my-mount --path /mnt/data fails with "Resource type not found: fs-mount"
  • agents resource type list does not include fs-mount in its output

Expected Behavior (from spec)

  • agents resource type list should show fs-mount as a built-in type
  • agents resource add fs-mount local/my-mount --path /mnt/data should succeed
  • fs-mount should have:
    • copy_on_write sandbox strategy
    • physical kind
    • fs-directory as a child type

Code Locations

  • /app/src/cleveragents/application/services/_resource_registry_data.py_GIT_FS_CONTAINER_TYPES list is missing the fs-mount type definition
  • /app/src/cleveragents/domain/models/core/_resource_type_validation.py line 25 — fs-mount is in BUILTIN_TYPE_NAMES but has no corresponding definition

Subtasks

  • Add fs-mount type definition dict to _GIT_FS_CONTAINER_TYPES in _resource_registry_data.py with correct copy_on_write sandbox strategy, physical kind, and fs-directory child type
  • Verify fs-mount is correctly fed into BUILTIN_TYPES via the existing aggregation logic
  • Confirm BUILTIN_TYPE_NAMES in _resource_type_validation.py remains consistent with the new definition
  • Tests (unit): Add/update unit tests for fs-mount type registration in BUILTIN_TYPES
  • Tests (Behave): Add scenario for agents resource add fs-mount succeeding end-to-end
  • Tests (Behave): Add scenario for agents resource type show fs-mount returning correct metadata
  • Verify coverage >= 97% via nox -s coverage_report
  • Run nox (all default sessions), fix any errors

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • agents resource type show fs-mount returns the correct type definition (physical kind, copy_on_write sandbox strategy, fs-directory child type).
  • agents resource add fs-mount local/my-mount --path /mnt/data succeeds without error.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged.
  • All nox stages pass.
  • Coverage >= 97%.

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-new-issue-creator

## Metadata - **Branch**: `fix/fs-mount-missing-builtin-type` - **Commit Message**: `fix(resources): add missing fs-mount built-in resource type definition to BUILTIN_TYPES` - **Milestone**: v3.6.0 - **Parent Epic**: #398 ## Background The specification explicitly lists `fs-mount` as a built-in resource type (see spec glossary: "Built-in types (e.g., `git-checkout`, `fs-mount`) are unnamespaced" and the resource type list table showing `fs-mount` as a built-in physical type with `copy_on_write` sandbox strategy and `fs-directory` as child type). However, `fs-mount` is **not** registered in `BUILTIN_TYPES` in `/app/src/cleveragents/application/services/_resource_registry_data.py`. The `BUILTIN_TYPE_NAMES` frozenset in `_resource_type_validation.py` (line 25) includes `fs-mount` as a known name, but there is no actual type definition dict for it in `_GIT_FS_CONTAINER_TYPES` or any other list that feeds into `BUILTIN_TYPES`. ## Current Behavior - `agents resource type show fs-mount` returns `"Resource type not found: fs-mount"` - `agents resource add fs-mount local/my-mount --path /mnt/data` fails with `"Resource type not found: fs-mount"` - `agents resource type list` does not include `fs-mount` in its output ## Expected Behavior (from spec) - `agents resource type list` should show `fs-mount` as a built-in type - `agents resource add fs-mount local/my-mount --path /mnt/data` should succeed - `fs-mount` should have: - `copy_on_write` sandbox strategy - `physical` kind - `fs-directory` as a child type ## Code Locations - `/app/src/cleveragents/application/services/_resource_registry_data.py` — `_GIT_FS_CONTAINER_TYPES` list is missing the `fs-mount` type definition - `/app/src/cleveragents/domain/models/core/_resource_type_validation.py` line 25 — `fs-mount` is in `BUILTIN_TYPE_NAMES` but has no corresponding definition ## Subtasks - [ ] Add `fs-mount` type definition dict to `_GIT_FS_CONTAINER_TYPES` in `_resource_registry_data.py` with correct `copy_on_write` sandbox strategy, `physical` kind, and `fs-directory` child type - [ ] Verify `fs-mount` is correctly fed into `BUILTIN_TYPES` via the existing aggregation logic - [ ] Confirm `BUILTIN_TYPE_NAMES` in `_resource_type_validation.py` remains consistent with the new definition - [ ] Tests (unit): Add/update unit tests for `fs-mount` type registration in `BUILTIN_TYPES` - [ ] Tests (Behave): Add scenario for `agents resource add fs-mount` succeeding end-to-end - [ ] Tests (Behave): Add scenario for `agents resource type show fs-mount` returning correct metadata - [ ] Verify coverage >= 97% via `nox -s coverage_report` - [ ] Run `nox` (all default sessions), fix any errors ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - `agents resource type show fs-mount` returns the correct type definition (physical kind, `copy_on_write` sandbox strategy, `fs-directory` child type). - `agents resource add fs-mount local/my-mount --path /mnt/data` succeeds without error. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged**. - All nox stages pass. - Coverage >= 97%. --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-new-issue-creator
freemo added this to the v3.6.0 milestone 2026-04-03 18:40:49 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • MoSCoW: Should Have — Spec compliance or quality improvement that should be included in the milestone.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **MoSCoW**: Should Have — Spec compliance or quality improvement that should be included in the milestone. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#398 Epic: Post-MVP Resources
cleveragents/cleveragents-core
Reference
cleveragents/cleveragents-core#2506
No description provided.