cleveragents/cleveragents-core

Fork 3

UAT: `ACMSPipeline.BUILTIN_STRATEGIES` contains only internal strategies — spec-required built-in strategies (`simple-keyword`, `semantic-embedding`, `breadth-depth-navigator`, `arce`, `temporal-archaeology`, `plan-decision-context`) are absent #2492

New issue

Open

opened 2026-04-03 18:38:42 +00:00 by freemo · 2 comments

freemo commented

2026-04-03 18:38:42 +00:00

Owner

Summary

ACMSPipeline.BUILTIN_STRATEGIES in acms_service.py contains only three internal strategies (relevance, recency, tiered) that are not mentioned in the specification. The six spec-required built-in strategies are implemented in separate files but are never registered in BUILTIN_STRATEGIES, making them unavailable to the pipeline by default.

What Was Tested

Code-level analysis of src/cleveragents/application/services/acms_service.py (lines 633-637) against docs/specification.md §25546-25556.

Expected Behavior (from spec §25546-25556)

The spec defines exactly six built-in strategies that must be available by default:

Strategy	Quality	Backends Required
`simple-keyword`	0.3	Text only
`semantic-embedding`	0.6	Vector
`breadth-depth-navigator`	0.85	Graph
`arce`	0.95	All
`temporal-archaeology`	0.5	Graph + Cold tier
`plan-decision-context`	0.7	Warm/Cold tiers

The spec also states (§30602): context.strategies.enabled defaults to ["simple-keyword", "semantic-embedding", "breadth-depth-navigator"].

Actual Behavior

ACMSPipeline.BUILTIN_STRATEGIES (line 633-637 of acms_service.py):

BUILTIN_STRATEGIES: ClassVar[dict[str, type[ContextStrategy]]] = {
    "relevance": RelevanceStrategy,
    "recency": RecencyStrategy,
    "tiered": TieredStrategy,
}

The three strategies present (relevance, recency, tiered) are not mentioned anywhere in the specification as built-in strategies. They appear to be internal/legacy implementations.

The spec-required strategies ARE implemented in separate files:

SimpleKeywordStrategy → context_strategies.py
SemanticEmbeddingStrategy → context_strategies.py
BreadthDepthNavigatorStrategy → context_strategies.py
ArceStrategy → acms_advanced_strategies.py
TemporalArchaeologyStrategy → acms_advanced_strategies.py
PlanDecisionContextStrategy → acms_advanced_strategies.py

But none of them are registered in BUILTIN_STRATEGIES, so they are never instantiated or available to the pipeline unless explicitly registered via register_strategy().

Impact

agents project context set --strategy simple-keyword will fail with "Unknown strategy" because simple-keyword is not in BUILTIN_STRATEGIES
The default strategy list from config (simple-keyword, semantic-embedding, breadth-depth-navigator) cannot be resolved
The StrategyRegistry in strategy_registry.py has the correct strategies, but ACMSPipeline does not use StrategyRegistry — it uses its own BUILTIN_STRATEGIES dict

Code Locations

src/cleveragents/application/services/acms_service.py lines 633-637 (BUILTIN_STRATEGIES)
src/cleveragents/application/services/context_strategies.py (spec strategies implemented but not registered)
src/cleveragents/application/services/acms_advanced_strategies.py (spec strategies implemented but not registered)
src/cleveragents/application/services/strategy_registry.py (separate registry that does have correct strategies)

Steps to Reproduce

Read docs/specification.md §25546-25556 for the required built-in strategies
Read src/cleveragents/application/services/acms_service.py lines 633-637
Observe that simple-keyword, semantic-embedding, breadth-depth-navigator, arce, temporal-archaeology, plan-decision-context are absent

Severity

High — The six spec-required built-in strategies are not available to the pipeline by default. Any attempt to use the spec-documented strategy names will fail. The default configuration (simple-keyword, semantic-embedding, breadth-depth-navigator) cannot work.

Metadata

Branch: fix/acms-pipeline-builtin-strategies
Commit Message: fix(acms): register spec-required built-in strategies in ACMSPipeline.BUILTIN_STRATEGIES
Parent Epic: #396

Subtasks

Add SimpleKeywordStrategy, SemanticEmbeddingStrategy, BreadthDepthNavigatorStrategy to BUILTIN_STRATEGIES
Add ArceStrategy, TemporalArchaeologyStrategy, PlanDecisionContextStrategy to BUILTIN_STRATEGIES
Set default_strategy to "simple-keyword" or keep "relevance" as internal fallback (clarify with spec)
Remove or rename relevance, recency, tiered strategies if they are not spec-required (or keep as internal-only)
Add unit tests verifying all six spec strategies are available by default

Definition of Done

All six spec-required built-in strategies are in BUILTIN_STRATEGIES
ACMSPipeline can resolve simple-keyword, semantic-embedding, breadth-depth-navigator, arce, temporal-archaeology, plan-decision-context without explicit registration
All tests pass with ≥97% coverage

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Summary `ACMSPipeline.BUILTIN_STRATEGIES` in `acms_service.py` contains only three internal strategies (`relevance`, `recency`, `tiered`) that are not mentioned in the specification. The six spec-required built-in strategies are implemented in separate files but are never registered in `BUILTIN_STRATEGIES`, making them unavailable to the pipeline by default. ## What Was Tested Code-level analysis of `src/cleveragents/application/services/acms_service.py` (lines 633-637) against `docs/specification.md` §25546-25556. ## Expected Behavior (from spec §25546-25556) The spec defines exactly six built-in strategies that must be available by default: | Strategy | Quality | Backends Required | |----------|---------|------------------| | `simple-keyword` | 0.3 | Text only | | `semantic-embedding` | 0.6 | Vector | | `breadth-depth-navigator` | 0.85 | Graph | | `arce` | 0.95 | All | | `temporal-archaeology` | 0.5 | Graph + Cold tier | | `plan-decision-context` | 0.7 | Warm/Cold tiers | The spec also states (§30602): `context.strategies.enabled` defaults to `["simple-keyword", "semantic-embedding", "breadth-depth-navigator"]`. ## Actual Behavior `ACMSPipeline.BUILTIN_STRATEGIES` (line 633-637 of `acms_service.py`): ```python BUILTIN_STRATEGIES: ClassVar[dict[str, type[ContextStrategy]]] = { "relevance": RelevanceStrategy, "recency": RecencyStrategy, "tiered": TieredStrategy, } ``` The three strategies present (`relevance`, `recency`, `tiered`) are not mentioned anywhere in the specification as built-in strategies. They appear to be internal/legacy implementations. The spec-required strategies ARE implemented in separate files: - `SimpleKeywordStrategy` → `context_strategies.py` - `SemanticEmbeddingStrategy` → `context_strategies.py` - `BreadthDepthNavigatorStrategy` → `context_strategies.py` - `ArceStrategy` → `acms_advanced_strategies.py` - `TemporalArchaeologyStrategy` → `acms_advanced_strategies.py` - `PlanDecisionContextStrategy` → `acms_advanced_strategies.py` But none of them are registered in `BUILTIN_STRATEGIES`, so they are never instantiated or available to the pipeline unless explicitly registered via `register_strategy()`. ## Impact - `agents project context set --strategy simple-keyword` will fail with "Unknown strategy" because `simple-keyword` is not in `BUILTIN_STRATEGIES` - The default strategy list from config (`simple-keyword`, `semantic-embedding`, `breadth-depth-navigator`) cannot be resolved - The `StrategyRegistry` in `strategy_registry.py` has the correct strategies, but `ACMSPipeline` does not use `StrategyRegistry` — it uses its own `BUILTIN_STRATEGIES` dict ## Code Locations - `src/cleveragents/application/services/acms_service.py` lines 633-637 (`BUILTIN_STRATEGIES`) - `src/cleveragents/application/services/context_strategies.py` (spec strategies implemented but not registered) - `src/cleveragents/application/services/acms_advanced_strategies.py` (spec strategies implemented but not registered) - `src/cleveragents/application/services/strategy_registry.py` (separate registry that does have correct strategies) ## Steps to Reproduce 1. Read `docs/specification.md` §25546-25556 for the required built-in strategies 2. Read `src/cleveragents/application/services/acms_service.py` lines 633-637 3. Observe that `simple-keyword`, `semantic-embedding`, `breadth-depth-navigator`, `arce`, `temporal-archaeology`, `plan-decision-context` are absent ## Severity **High** — The six spec-required built-in strategies are not available to the pipeline by default. Any attempt to use the spec-documented strategy names will fail. The default configuration (`simple-keyword`, `semantic-embedding`, `breadth-depth-navigator`) cannot work. ## Metadata - **Branch**: `fix/acms-pipeline-builtin-strategies` - **Commit Message**: `fix(acms): register spec-required built-in strategies in ACMSPipeline.BUILTIN_STRATEGIES` - **Parent Epic**: #396 ## Subtasks - [ ] Add `SimpleKeywordStrategy`, `SemanticEmbeddingStrategy`, `BreadthDepthNavigatorStrategy` to `BUILTIN_STRATEGIES` - [ ] Add `ArceStrategy`, `TemporalArchaeologyStrategy`, `PlanDecisionContextStrategy` to `BUILTIN_STRATEGIES` - [ ] Set `default_strategy` to `"simple-keyword"` or keep `"relevance"` as internal fallback (clarify with spec) - [ ] Remove or rename `relevance`, `recency`, `tiered` strategies if they are not spec-required (or keep as internal-only) - [ ] Add unit tests verifying all six spec strategies are available by default ## Definition of Done - All six spec-required built-in strategies are in `BUILTIN_STRATEGIES` - `ACMSPipeline` can resolve `simple-keyword`, `semantic-embedding`, `breadth-depth-navigator`, `arce`, `temporal-archaeology`, `plan-decision-context` without explicit registration - All tests pass with ≥97% coverage --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester

freemo commented

2026-04-03 18:40:58 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
MoSCoW: Should Have — Spec compliance or quality improvement that should be included in the milestone.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **MoSCoW**: Should Have — Spec compliance or quality improvement that should be included in the milestone. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo commented

2026-04-05 03:15:05 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Confirmed
MoSCoW: Should Have (already set)

Valid finding verified during batch triage.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Confirmed - **MoSCoW**: Should Have (already set) Valid finding verified during batch triage. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo added this to the v3.7.0 milestone

2026-04-05 05:07:08 +00:00

freemo removed this from the v3.7.0 milestone

2026-04-07 00:49:32 +00:00