UAT: `agents plan diff --correction` is a stub — returns placeholder panel instead of correction attempt diff #2483

New issue

Open

opened 2026-04-03 18:37:37 +00:00 by freemo · 1 comment

freemo commented

2026-04-03 18:37:37 +00:00

Owner

Metadata

Commit message: feat(cli): implement agents plan diff --correction to show correction attempt diff
Branch: feat/plan-diff-correction
Parent Epic: #397 (Epic: Server & Autonomy Infrastructure)

Bug Description

The agents plan diff --correction <CORRECTION_ATTEMPT_ID> command is explicitly stubbed out with a placeholder message. The spec (§ agents plan diff, line 15324) defines this as a first-class operation that shows the diff for a specific correction attempt.

Expected Behavior (from spec)

The spec defines:

agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>)

When --correction is provided, the command should show the diff for a specific correction attempt — i.e., the changes introduced by that correction relative to the plan state before the correction was applied.

The spec also references this in the agents plan correct output (line 14964):

- agents plan diff --correction 01HXM9B7Z3Q1Q8K2..

Actual Behavior

The plan_diff command in src/cleveragents/cli/commands/plan.py (lines 2703–2715) contains an explicit stub:

if correction:
    # Show correction-specific diff (stub: shows info panel)
    console.print(
        Panel(
            f"[bold]Correction Attempt:[/bold] {correction}\n"
            f"[bold]Plan:[/bold] {plan_id}\n\n"
            "[dim]Correction diff will be available after M4.2.[/dim]",
            title="Correction Diff",
            expand=False,
        )
    )
    return

The message "Correction diff will be available after M4.2" indicates this was intentionally deferred but has not been implemented.

Code Location

src/cleveragents/cli/commands/plan.py, lines 2703–2715 (stub implementation)
src/cleveragents/application/services/correction_service.py (correction service — may have relevant data)

Subtasks

Implement correction attempt diff retrieval from CorrectionService or ChangeSetStore
Render correction diff using DiffBuilder/DiffSerializer (same as plan diff)
Add unit tests (Behave) for correction diff rendering

Definition of Done

agents plan diff --correction <CORRECTION_ATTEMPT_ID> returns the actual diff for the correction attempt
Output format matches the spec (same structure as plan diff but scoped to the correction)
Test coverage ≥ 97%

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata **Commit message**: `feat(cli): implement agents plan diff --correction to show correction attempt diff` **Branch**: `feat/plan-diff-correction` **Parent Epic**: #397 (Epic: Server & Autonomy Infrastructure) ## Bug Description The `agents plan diff --correction <CORRECTION_ATTEMPT_ID>` command is explicitly stubbed out with a placeholder message. The spec (§ `agents plan diff`, line 15324) defines this as a first-class operation that shows the diff for a specific correction attempt. ## Expected Behavior (from spec) The spec defines: ``` agents plan diff (--correction <CORRECTION_ATTEMPT_ID>|<PLAN_ID>) ``` When `--correction` is provided, the command should show the diff for a specific correction attempt — i.e., the changes introduced by that correction relative to the plan state before the correction was applied. The spec also references this in the `agents plan correct` output (line 14964): ``` - agents plan diff --correction 01HXM9B7Z3Q1Q8K2.. ``` ## Actual Behavior The `plan_diff` command in `src/cleveragents/cli/commands/plan.py` (lines 2703–2715) contains an explicit stub: ```python if correction: # Show correction-specific diff (stub: shows info panel) console.print( Panel( f"[bold]Correction Attempt:[/bold] {correction}\n" f"[bold]Plan:[/bold] {plan_id}\n\n" "[dim]Correction diff will be available after M4.2.[/dim]", title="Correction Diff", expand=False, ) ) return ``` The message "Correction diff will be available after M4.2" indicates this was intentionally deferred but has not been implemented. ## Code Location - `src/cleveragents/cli/commands/plan.py`, lines 2703–2715 (stub implementation) - `src/cleveragents/application/services/correction_service.py` (correction service — may have relevant data) ## Subtasks - [ ] Implement correction attempt diff retrieval from `CorrectionService` or `ChangeSetStore` - [ ] Render correction diff using `DiffBuilder`/`DiffSerializer` (same as plan diff) - [ ] Add unit tests (Behave) for correction diff rendering ## Definition of Done - `agents plan diff --correction <CORRECTION_ATTEMPT_ID>` returns the actual diff for the correction attempt - Output format matches the spec (same structure as plan diff but scoped to the correction) - Test coverage ≥ 97% --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester

freemo referenced this issue

2026-04-03 18:43:10 +00:00

[CA-GROOMER] Backlog Groomer — Session State (groomer-1) #2386

freemo commented

2026-04-05 02:35:30 +00:00

Author

Owner

Issue triaged by project owner:

State: Verified
Priority: Medium — agents plan diff --correction is explicitly stubbed with a placeholder message ("Correction diff will be available after M4.2"). The spec defines this as a first-class operation.
Milestone: v3.3.0 (setting — this belongs to the Corrections + Subplans + Checkpoints milestone)
MoSCoW: Should Have — The spec defines correction diff as a required operation. It's referenced in the agents plan correct output as a follow-up command. However, the core diff functionality works for non-correction cases.
Parent Epic: #397 (Epic: Server & Autonomy Infrastructure)

Valid UAT finding. The stub message confirms this was intentionally deferred.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: Medium — `agents plan diff --correction` is explicitly stubbed with a placeholder message ("Correction diff will be available after M4.2"). The spec defines this as a first-class operation. - **Milestone**: v3.3.0 (setting — this belongs to the Corrections + Subplans + Checkpoints milestone) - **MoSCoW**: Should Have — The spec defines correction diff as a required operation. It's referenced in the `agents plan correct` output as a follow-up command. However, the core diff functionality works for non-correction cases. - **Parent Epic**: #397 (Epic: Server & Autonomy Infrastructure) Valid UAT finding. The stub message confirms this was intentionally deferred. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner

freemo added this to the v3.3.0 milestone

2026-04-05 02:36:57 +00:00

freemo added a new dependency

2026-04-05 02:37:16 +00:00

#397 Epic: Server & Autonomy Infrastructure

freemo referenced this issue

2026-04-05 02:38:40 +00:00

[CA-AUTO] Project Owner — project-owner-1 — Session Tracker #2793

freemo removed this from the v3.3.0 milestone

2026-04-07 00:50:34 +00:00