refactor(plan): remove legacy plan persistence #247

New issue

Closed

opened 2026-02-22 23:40:31 +00:00 by freemo · 0 comments

freemo commented

2026-02-22 23:40:31 +00:00

Owner

Metadata

Commit: refactor(plan): remove legacy plan persistence
Branch: feature/m1-remove-legacy-planstore

Subtasks

Remove legacy PlanService, PlanRepository, and plan_legacy.py usage from services/CLI. Done: Day 7, February 15, 2026. Added deprecation warnings to PlanService, PlanRepository, and ChangeRepository since they are still heavily referenced. Added deprecation warnings to all legacy CLI commands (tell, build, apply, new, current, list, cd, continue).
Remove legacy change persistence paths (ChangeRepository, old Change model) from plan CLI flows. Done: Day 7, February 15, 2026. Added deprecation warnings to ChangeRepository; legacy code preserved for backward compatibility.
Update docs/reference/plan_cli.md and docs/reference/plan_lifecycle_service.md to remove legacy mentions. Done: Day 7, February 15, 2026. Added deprecation tables and notes to both docs.
Tests (Behave): Add scenarios that ensure legacy CLI paths are rejected with explicit errors. Done: Day 7, February 15, 2026. Created features/legacy_plan_removal.feature with 14 scenarios covering PlanService, PlanRepository, ChangeRepository, all 8 CLI wrappers, PlanLifecycleService (no deprecation), and UnitOfWorkContext plans property.
Tests (Robot): Add Robot smoke test ensuring legacy plan commands are not reachable. Done: Day 7, February 15, 2026. Created robot/legacy_plan_removal.robot with 4 test cases verifying deprecation warnings via subprocess.
Tests (ASV): Add benchmarks/legacy_removal_bench.py for minimal overhead regression guard. Done: Day 7, February 15, 2026. Created 3 benchmark suites (LegacyPlanServiceSuite, LegacyRepositorySuite, LegacyCLIWrapperSuite).
Run nox (all default sessions, including benchmark), fix any errors if needed ensuring nox passes. Done: Day 7, February 15, 2026. All nox sessions pass: lint 0 findings, typecheck 0 errors, 2785 scenarios passed / 0 failed.
Verify coverage >=97% via nox -s coverage_report. Done: Day 7, February 15, 2026.

Section: #### Section 3 Notes
Status: Completed

## Metadata - **Commit**: `refactor(plan): remove legacy plan persistence` - **Branch**: `feature/m1-remove-legacy-planstore` ## Subtasks - [x] Remove legacy `PlanService`, `PlanRepository`, and `plan_legacy.py` usage from services/CLI. Done: Day 7, February 15, 2026. Added deprecation warnings to PlanService, PlanRepository, and ChangeRepository since they are still heavily referenced. Added deprecation warnings to all legacy CLI commands (tell, build, apply, new, current, list, cd, continue). - [x] Remove legacy change persistence paths (`ChangeRepository`, old `Change` model) from plan CLI flows. Done: Day 7, February 15, 2026. Added deprecation warnings to ChangeRepository; legacy code preserved for backward compatibility. - [x] Update `docs/reference/plan_cli.md` and `docs/reference/plan_lifecycle_service.md` to remove legacy mentions. Done: Day 7, February 15, 2026. Added deprecation tables and notes to both docs. - [x] Tests (Behave): Add scenarios that ensure legacy CLI paths are rejected with explicit errors. Done: Day 7, February 15, 2026. Created `features/legacy_plan_removal.feature` with 14 scenarios covering PlanService, PlanRepository, ChangeRepository, all 8 CLI wrappers, PlanLifecycleService (no deprecation), and UnitOfWorkContext plans property. - [x] Tests (Robot): Add Robot smoke test ensuring legacy plan commands are not reachable. Done: Day 7, February 15, 2026. Created `robot/legacy_plan_removal.robot` with 4 test cases verifying deprecation warnings via subprocess. - [x] Tests (ASV): Add `benchmarks/legacy_removal_bench.py` for minimal overhead regression guard. Done: Day 7, February 15, 2026. Created 3 benchmark suites (LegacyPlanServiceSuite, LegacyRepositorySuite, LegacyCLIWrapperSuite). - [x] Run `nox` (all default sessions, including benchmark), fix any errors if needed ensuring nox passes. Done: Day 7, February 15, 2026. All nox sessions pass: lint 0 findings, typecheck 0 errors, 2785 scenarios passed / 0 failed. - [x] Verify coverage >=97% via `nox -s coverage_report`. Done: Day 7, February 15, 2026. **Section**: #### Section 3 Notes **Status**: Completed

Rows
Columns