cleveragents/cleveragents-core
4
0
Fork 3
Code Issues 6.0k Pull Requests 115 Actions Packages Projects Releases Wiki Activity

UAT: agents plan rollback output missing spec-required fields — label, child_plans_invalidated, decisions_after_cp, tool_calls_after_cp, phase, state, checkpoints_remaining #2455

New Issue
Open
opened 2026-04-03 18:27:12 +00:00 by freemo · 1 comment
freemo commented 2026-04-03 18:27:12 +00:00
Owner
Copy Link
Copy Source

Metadata

Summary

The agents plan rollback CLI command output is missing several fields required by the specification (spec lines 15970–15999). The root cause is that the RollbackResult domain model (src/cleveragents/domain/models/core/checkpoint.py, lines 161–186) does not carry the additional data needed to populate these fields, and the CLI output construction in src/cleveragents/cli/commands/plan.py (lines 3366–3384) therefore cannot emit them.

This is distinct from #1424, which addresses field-naming and envelope-structure mismatches. This issue specifically tracks the missing fields that require domain-model changes to supply the underlying data.

Expected Behavior (from spec — lines 15948–16119)

The rollback output must include:

Field Location Description
rollback_summary.label data.rollback_summary Human-readable checkpoint label (e.g., "before auth refactor")
impact.child_plans_invalidated data.impact Count of child plans invalidated by the rollback
impact.decisions_after_cp data.impact Count of decisions discarded (e.g., "2 discarded")
impact.tool_calls_after_cp data.impact Count of tool calls undone (e.g., "5 undone")
post_rollback_state.phase data.post_rollback_state Plan phase after rollback (e.g., "execute")
post_rollback_state.state data.post_rollback_state Plan state after rollback (e.g., "queued (awaiting input)")
post_rollback_state.checkpoints_remaining data.post_rollback_state Count of remaining checkpoints after rollback

Actual Behavior

The implementation in src/cleveragents/cli/commands/plan.py (lines 3366–3384) only outputs:

  • rollback_summary.plan_id, from_checkpoint_id, restored_files_count
  • impact.files_affected (not the spec-required fields)
  • post_rollback_state.active_checkpoint, plan_id (not phase, state, checkpoints_remaining)

The RollbackResult domain model (src/cleveragents/domain/models/core/checkpoint.py, lines 161–186) only carries restored_files_count, changed_paths, and from_checkpoint_id — it does not carry the additional fields needed to populate the spec-required output.

Code Locations

  • src/cleveragents/cli/commands/plan.py lines 3366–3384 — output dict construction in rollback_plan
  • src/cleveragents/domain/models/core/checkpoint.py lines 161–186 — RollbackResult domain model
  • src/cleveragents/application/services/checkpoint_service.py lines 259–368 — rollback_to_checkpoint service method (must be updated to populate new fields)

Steps to Reproduce

  1. Run agents plan rollback --yes <PLAN_ID> <CHECKPOINT_ID>
  2. Observe the output is missing label, child_plans_invalidated, decisions_after_cp, tool_calls_after_cp, phase, state, checkpoints_remaining

Spec Reference

docs/specification.md lines 15948–16119 (agents plan rollback command)

Subtasks

  • Audit RollbackResult model in src/cleveragents/domain/models/core/checkpoint.py (lines 161–186) against spec lines 15948–16119
  • Add label: str field to RollbackResult (checkpoint human-readable label)
  • Add child_plans_invalidated: int field to RollbackResult
  • Add decisions_after_cp: int field to RollbackResult (count of decisions discarded)
  • Add tool_calls_after_cp: int field to RollbackResult (count of tool calls undone)
  • Add phase: str field to RollbackResult (plan phase post-rollback)
  • Add state: str field to RollbackResult (plan state post-rollback)
  • Add checkpoints_remaining: int field to RollbackResult
  • Update rollback_to_checkpoint in checkpoint_service.py (lines 259–368) to query and populate all new fields when constructing RollbackResult
  • Update rollback_plan output dict in plan.py (lines 3366–3384) to emit all new fields in the spec-required locations
  • Write Behave BDD scenarios asserting each new field is present and correctly typed in the RollbackResult domain model
  • Write Behave BDD scenarios asserting the CLI output includes all 7 missing fields
  • Write Robot Framework integration test verifying agents plan rollback output contains all spec-required fields
  • Run nox (all default sessions) and fix any errors
  • Verify coverage >= 97% via nox -s coverage_report

Definition of Done

  • RollbackResult domain model carries all 7 spec-required fields with correct types and static type annotations
  • rollback_to_checkpoint service method populates all new fields from the database/plan state
  • agents plan rollback CLI output includes rollback_summary.label, impact.child_plans_invalidated, impact.decisions_after_cp, impact.tool_calls_after_cp, post_rollback_state.phase, post_rollback_state.state, and post_rollback_state.checkpoints_remaining
  • All new fields pass nox -e typecheck (Pyright) — no # type: ignore suppressions
  • Behave BDD unit tests cover all new model fields and CLI output paths
  • Robot Framework integration test verifies end-to-end output against spec
  • All nox stages pass
  • Coverage >= 97%

Automated by CleverAgents Bot
Supervisor: UAT Testing | Agent: ca-uat-tester

## Metadata - **Branch**: `bugfix/sandbox-checkpointing-rollback-result-missing-fields` - **Commit Message**: `fix(checkpoint): extend RollbackResult domain model with spec-required output fields` - **Milestone**: v3.7.0 - **Parent Epic**: #401 ## Summary The `agents plan rollback` CLI command output is missing several fields required by the specification (spec lines 15970–15999). The root cause is that the `RollbackResult` domain model (`src/cleveragents/domain/models/core/checkpoint.py`, lines 161–186) does not carry the additional data needed to populate these fields, and the CLI output construction in `src/cleveragents/cli/commands/plan.py` (lines 3366–3384) therefore cannot emit them. This is distinct from #1424, which addresses field-naming and envelope-structure mismatches. This issue specifically tracks the **missing fields** that require domain-model changes to supply the underlying data. ## Expected Behavior (from spec — lines 15948–16119) The rollback output must include: | Field | Location | Description | |---|---|---| | `rollback_summary.label` | `data.rollback_summary` | Human-readable checkpoint label (e.g., `"before auth refactor"`) | | `impact.child_plans_invalidated` | `data.impact` | Count of child plans invalidated by the rollback | | `impact.decisions_after_cp` | `data.impact` | Count of decisions discarded (e.g., `"2 discarded"`) | | `impact.tool_calls_after_cp` | `data.impact` | Count of tool calls undone (e.g., `"5 undone"`) | | `post_rollback_state.phase` | `data.post_rollback_state` | Plan phase after rollback (e.g., `"execute"`) | | `post_rollback_state.state` | `data.post_rollback_state` | Plan state after rollback (e.g., `"queued (awaiting input)"`) | | `post_rollback_state.checkpoints_remaining` | `data.post_rollback_state` | Count of remaining checkpoints after rollback | ## Actual Behavior The implementation in `src/cleveragents/cli/commands/plan.py` (lines 3366–3384) only outputs: - `rollback_summary.plan_id`, `from_checkpoint_id`, `restored_files_count` - `impact.files_affected` (not the spec-required fields) - `post_rollback_state.active_checkpoint`, `plan_id` (not `phase`, `state`, `checkpoints_remaining`) The `RollbackResult` domain model (`src/cleveragents/domain/models/core/checkpoint.py`, lines 161–186) only carries `restored_files_count`, `changed_paths`, and `from_checkpoint_id` — it does not carry the additional fields needed to populate the spec-required output. ## Code Locations - `src/cleveragents/cli/commands/plan.py` lines 3366–3384 — output dict construction in `rollback_plan` - `src/cleveragents/domain/models/core/checkpoint.py` lines 161–186 — `RollbackResult` domain model - `src/cleveragents/application/services/checkpoint_service.py` lines 259–368 — `rollback_to_checkpoint` service method (must be updated to populate new fields) ## Steps to Reproduce 1. Run `agents plan rollback --yes <PLAN_ID> <CHECKPOINT_ID>` 2. Observe the output is missing `label`, `child_plans_invalidated`, `decisions_after_cp`, `tool_calls_after_cp`, `phase`, `state`, `checkpoints_remaining` ## Spec Reference `docs/specification.md` lines 15948–16119 (`agents plan rollback` command) ## Subtasks - [ ] Audit `RollbackResult` model in `src/cleveragents/domain/models/core/checkpoint.py` (lines 161–186) against spec lines 15948–16119 - [ ] Add `label: str` field to `RollbackResult` (checkpoint human-readable label) - [ ] Add `child_plans_invalidated: int` field to `RollbackResult` - [ ] Add `decisions_after_cp: int` field to `RollbackResult` (count of decisions discarded) - [ ] Add `tool_calls_after_cp: int` field to `RollbackResult` (count of tool calls undone) - [ ] Add `phase: str` field to `RollbackResult` (plan phase post-rollback) - [ ] Add `state: str` field to `RollbackResult` (plan state post-rollback) - [ ] Add `checkpoints_remaining: int` field to `RollbackResult` - [ ] Update `rollback_to_checkpoint` in `checkpoint_service.py` (lines 259–368) to query and populate all new fields when constructing `RollbackResult` - [ ] Update `rollback_plan` output dict in `plan.py` (lines 3366–3384) to emit all new fields in the spec-required locations - [ ] Write Behave BDD scenarios asserting each new field is present and correctly typed in the `RollbackResult` domain model - [ ] Write Behave BDD scenarios asserting the CLI output includes all 7 missing fields - [ ] Write Robot Framework integration test verifying `agents plan rollback` output contains all spec-required fields - [ ] Run `nox` (all default sessions) and fix any errors - [ ] Verify coverage >= 97% via `nox -s coverage_report` ## Definition of Done - [ ] `RollbackResult` domain model carries all 7 spec-required fields with correct types and static type annotations - [ ] `rollback_to_checkpoint` service method populates all new fields from the database/plan state - [ ] `agents plan rollback` CLI output includes `rollback_summary.label`, `impact.child_plans_invalidated`, `impact.decisions_after_cp`, `impact.tool_calls_after_cp`, `post_rollback_state.phase`, `post_rollback_state.state`, and `post_rollback_state.checkpoints_remaining` - [ ] All new fields pass `nox -e typecheck` (Pyright) — no `# type: ignore` suppressions - [ ] Behave BDD unit tests cover all new model fields and CLI output paths - [ ] Robot Framework integration test verifies end-to-end output against spec - [ ] All nox stages pass - [ ] Coverage >= 97% --- **Automated by CleverAgents Bot** Supervisor: UAT Testing | Agent: ca-uat-tester
freemo added this to the v3.7.0 milestone 2026-04-03 18:27:17 +00:00
freemo commented 2026-04-03 18:35:10 +00:00
Author
Owner
Copy Link
Copy Source

Issue triaged by project owner:

  • State: Verified
  • MoSCoW: Should Have — Important spec requirement or quality improvement. Should be included in the milestone if possible.

Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **MoSCoW**: Should Have — Important spec requirement or quality improvement. Should be included in the milestone if possible. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
auto/needs-reevaluation
Controller deferred this PR; awaiting Phase 6+ scope-evaluator or operator re-enablement.
 controller-managed
Auto-agents controller manages this PR/issue (see tools/controller/deploy/RUNBOOK.md). Remove this label to abandon controller management.
 overdue
auto/blocked-by-deps
PR blocked by an open issue dependency. Operator must close the dep (or remove the dependency link) before the merge driver can act. Auto-cleared by merge_drive when no open deps remain.
 auto/ci-timeout
Most recent merge cycle hit CI timeout. Driver excludes this PR while last merge_cycle row is < 30 min old; label persists thereafter as visible history.
 auto/claimed-implementer
Currently being processed by an implementer worker.
 auto/claimed-merge
Currently being processed by the merge driver.
 auto/claimed-reviewer
Currently being processed by a reviewer worker.
 auto/driver-down
Merge driver heartbeat stale; pipeline halted. Closed automatically on next clean tick.
 auto/invariant-violation
Detected master commit violating the strict merge invariant. Tracked as an issue (not a PR label); kept here for label completeness.
 auto/last-attempt-tier-0
In-cycle escalation: most recent attempt ran at the Tier 0 slot (`tier-0`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-1
In-cycle escalation: most recent attempt ran at the Tier 1 slot (`tier-1`). Slot's model defined in .opencode/models/tiers.yaml.
 auto/last-attempt-tier-2
In-cycle escalation: most recent attempt ran at the Tier 2 slot (`tier-2`). Slot's model defined in .opencode/models/tiers.yaml. Gated behind IMPLEMENTER_ESCALATION_TIER2_ENABLED.
 auto/last-attempt-tier-min
In-cycle escalation: most recent attempt ran at the Tier -1 slot (`tier-min`). Slot's model defined in .opencode/models/tiers.yaml. Suffix is ``-min`` (not ``--1``) so the Forgejo UI reads naturally.
 Automation Tracking
Tracking issues used by the AI Automation system for agents to communicate and report.
 auto/needs-conflict-resolution
Rebase conflict needs LLM conflict-resolver.
 auto/needs-implementer
Failing CI needs implementer attention.
 auto/postmortem
Documenting a driver incident or rollback.
 auto/ready-to-merge
Reviewer has APPROVED this PR and no later REQUEST_CHANGES is outstanding. The merge driver requires this label to even consider a PR for merging. Set by the reviewer worker on APPROVE; cleared on REQUEST_CHANGES.
 auto/restart-throttled
Train repeatedly lost master-tempo races. Driver excludes via merge_cycle until cooldown elapses; label persists as visible history.
 auto/revert
Revert PR backing out an invariant violation. Fast-tracked through the merge driver.
 auto/sentinel
Sentinel PR duplicated from upstream into a personal fork by tools/duplicate_prs_to_fork.py for pipeline testing. Lives only in the fork; the canonical pipeline never sees it.
 auto/stale-inactivity
No implementer activity for N days. Flagged for human review. Auto-cleared on next push to head branch.
 auto/unstable
Repeatedly fails on current master (>= 3 ci-fail-on-rebased-sha releases in 12 h). Excluded from driver until human triage.
 Blocked
A ticket in a blocked state and unable to complete until some other task is completed first.
Bounty
$100
A bounty of $100 for any open-source contributor who provides a MR that solves this issue
Bounty
$1000
A bounty of $1000 for any open-source contributor who provides a MR that solves this issue
Bounty
$10000
A bounty of $10000 for any open-source contributor who provides a MR that solves this issue
Bounty
$20
A bounty of $20 for any open-source contributor who provides a MR that solves this issue
Bounty
$2000
A bounty of $2000 for any open-source contributor who provides a MR that solves this issue
Bounty
$250
A bounty of $250 for any open-source contributor who provides a MR that solves this issue
Bounty
$50
A bounty of $50 for any open-source contributor who provides a MR that solves this issue
Bounty
$500
A bounty of $500 for any open-source contributor who provides a MR that solves this issue
Bounty
$5000
A bounty of $5000 for any open-source contributor who provides a MR that solves this issue
Bounty
$750
A bounty of $750 for any open-source contributor who provides a MR that solves this issue
MoSCoW
Could have
Could have feature in order to satisfy the epic/legendary.
MoSCoW
Must have
Must have feature in order to satisfy the epic/legendary.
MoSCoW
Should have
Should have feature in order to satisfy the epic/legendary.
Needs Feedback
There are questions in the ticket that can not be completed until the project owner provides clarity.
Points
1
1 man-hours worth of work for an expert with no learning curve.
Points
13
13 man-hours worth of work for an expert with no learning curve.
Points
2
2 man-hours worth of work for an expert with no learning curve.
Points
21
21 man-hours worth of work for an expert with no learning curve.
Points
3
3 man-hours worth of work for an expert with no learning curve.
Points
34
34 man-hours worth of work for an expert with no learning curve.
Points
5
5 man-hours worth of work for an expert with no learning curve.
Points
55
55 man-hours worth of work for an expert with no learning curve.
Points
8
8 man-hours worth of work for an expert with no learning curve.
Points
88
88 man-hours worth of work for an expert with no learning curve.
Priority
Backlog
This ticket has backlogged priority and is not to be worked on yet
Priority
CI Blocker
Critical priority issue that blocks CI/CD pipeline and prevents PR merges
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Signed-off: Owner
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Scrum Master
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Signed-off: Tech Lead
When an epic or legendary is in review it must be signed off by owner, tech lead, and scrum master before being marked as completed.
 Spike
A ticket for learning a tool or technology that is needed to be able to do future planning and design.
State
Completed
The ticket has been fully implemented, completed, and merged with the source code. This label should only be applied once a ticket is closed.
State
Duplicate
A ticket that represents the same content as an existing ticket.
State
In Progress
A ticket that is actively being developed.
State
In Review
A ticket that has had some code completed to implement but is waiting to pass peer review and is not yet merged in.
State
Paused
This ticket's work started but wasn't finished. It's on hold (likely in a feature branch) and will be resumed later, either due to a blocker or a delay.
State
Unverified
All new tickets start in this state. A developer may set it to show the ticket is unverified. This means we haven't agreed to work on it. It will either move to a verified state or be closed as wontdo.
State
Verified
The issue has been verified by a developer as legitimate. It will be worked on and verified tickets are now considered part of the backlog.
State
Wont Do
This ticket has been decided it wont be done. This may mean the bug has been determined to not be real (cant verify) or the feature is one we have decided we dont want to adopt.
Type
Automation
Any edits or discussion about the AI automated coding system.
Type
Bug
Something that doesnt work as intended.
Type
Discussion
Anytime a ticket represents a discussion about a subject and doesnt fall into one of the other categories.
Type
Documentation
An error or improvement needed in the documentation.
Type
Epic
Any first tier epic. That is, an epic which contains only issues as children and will not have sub-epics.
Type
Feature
Some new functionality not present.
Type
Legendary
A type of Epic which will contain other Epics.
Type
Refactor
A code change that restructures existing code without changing its external behavior.
Type
Support
Someone needs help using the project.
Type
Task
A generic task that doesnt fit into the other type categories.
Type
Testing
Work exclusively focusing on fixing or expanding testing.
No Label
Milestone
No items
No Milestone v3.7.0
Projects
Clear projects
No project
Assignees
Clear assignees
aditya (Aditya Chhabra) aleenaumair (Aleena Umair) brent.edwards (Brent Edwards) CoreRasurae (Luis Mendes) drew (Drew Morris) eugen.thaci (Eugen Thaci) freemo (Jeffrey Phillips Freeman) HAL9000 (HAL 9000) HAL9001 (HAL9001) hamza.khyari (Hamza Khyari) hurui200320 (Rui Hu) justin.morris khird (Kyle Hird) org.cleveragents
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Blocks
#401 Epic: Milestone Acceptance and Workflow Example Integration Tests
cleveragents/cleveragents-core
Reference: cleveragents/cleveragents-core#2455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?