TEST-INFRA: [missing-test-levels] Add Robot and ASV tests for the tui module #2089

Open
opened 2026-04-03 03:59:00 +00:00 by freemo · 1 comment
Owner

Metadata

  • Branch: test/tui-robot-asv-tests
  • Commit Message: test(tui): add Robot integration tests and ASV performance benchmarks for tui module
  • Milestone: v3.7.0
  • Parent Epic: #868

Description

The tui module — which implements the Textual-based Terminal User Interface including MainScreen, sidebar state management, the TuiMaterializer A2A integration layer, the persona system, reference/command input modes (@, /, !), session tabs, modal dialogs, and the notification system — is missing the following test levels:

  • Robot integration tests (in robot/)
  • ASV performance benchmarks (in benchmarks/)

Per CONTRIBUTING.md's Multi-Level Testing Mandate, every module must have comprehensive test coverage at all three levels:

  • Behave unit tests (in features/) — may be tracked separately
  • Robot integration tests (in robot/) — missing
  • ASV performance benchmarks (in benchmarks/) — missing

The tui module is a primary user-facing boundary of the CleverAgents platform. As described in the specification (ADR-044: TUI Architecture and Framework, ADR-045: Persona System, ADR-046: Reference and Command System), the TUI provides the interactive surface through which users create plans, review decisions, manage projects, and switch personas. The TuiMaterializer bridges the reactive OutputSession pipeline to the Textual widget tree, making it a critical integration point between the core engine and the user interface. Given its role as the primary interactive frontend, integration-level verification and performance-level benchmarking are essential to guard against correctness regressions and UI responsiveness degradation.

Subtasks

  • Audit the tui module to identify all public integration points and performance-critical paths requiring Robot and ASV coverage (e.g., MainScreen launch and sidebar state transitions, TuiMaterializer session binding and A2A event dispatch, persona load/switch/cycle lifecycle, reference and command input parsing, session tab creation and teardown, modal open/close flows).
  • Add Robot integration tests for the tui module in robot/, covering key integration points (e.g., TUI application startup and shutdown, sidebar hidden/visible/fullscreen state transitions, persona switching end-to-end, @///! input mode activation and resolution, plan event notification rendering, multi-session tab lifecycle). No mocking is permitted in Robot tests.
  • Add ASV performance benchmarks for the tui module in benchmarks/, covering performance-critical paths (e.g., TuiMaterializer event dispatch throughput, persona resolution latency, reference fuzzy-search response time, session tab switch latency, notification queue drain throughput).
  • Verify all new Robot tests pass via nox -e integration_tests.
  • Verify all new ASV benchmarks run successfully via nox.
  • Confirm coverage ≥ 97% via nox -e coverage_report.
  • Ensure all nox stages pass (nox).

Definition of Done

  • Robot integration tests exist under robot/ covering the tui module's key integration points.
  • ASV benchmarks exist under benchmarks/ covering the tui module's performance-critical paths.
  • No mocking is used in Robot integration tests.
  • The new tests provide adequate coverage for the tui module.
  • The new tests pass in the CI pipeline.
  • All nox stages pass.
  • Coverage >= 97%
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • A pull request has been created, reviewed, and merged before this issue is marked done.

Automated by CleverAgents Bot
Supervisor: Unknown | Agent: ca-new-issue-creator

## Metadata - **Branch**: `test/tui-robot-asv-tests` - **Commit Message**: `test(tui): add Robot integration tests and ASV performance benchmarks for tui module` - **Milestone**: v3.7.0 - **Parent Epic**: #868 ## Description The `tui` module — which implements the Textual-based Terminal User Interface including `MainScreen`, sidebar state management, the `TuiMaterializer` A2A integration layer, the persona system, reference/command input modes (`@`, `/`, `!`), session tabs, modal dialogs, and the notification system — is missing the following test levels: - **Robot** integration tests (in `robot/`) - **ASV** performance benchmarks (in `benchmarks/`) Per CONTRIBUTING.md's Multi-Level Testing Mandate, every module must have comprehensive test coverage at all three levels: - **Behave** unit tests (in `features/`) — may be tracked separately - **Robot** integration tests (in `robot/`) — **missing** - **ASV** performance benchmarks (in `benchmarks/`) — **missing** The `tui` module is a primary user-facing boundary of the CleverAgents platform. As described in the specification (ADR-044: TUI Architecture and Framework, ADR-045: Persona System, ADR-046: Reference and Command System), the TUI provides the interactive surface through which users create plans, review decisions, manage projects, and switch personas. The `TuiMaterializer` bridges the reactive `OutputSession` pipeline to the Textual widget tree, making it a critical integration point between the core engine and the user interface. Given its role as the primary interactive frontend, integration-level verification and performance-level benchmarking are essential to guard against correctness regressions and UI responsiveness degradation. ## Subtasks - [ ] Audit the `tui` module to identify all public integration points and performance-critical paths requiring Robot and ASV coverage (e.g., `MainScreen` launch and sidebar state transitions, `TuiMaterializer` session binding and A2A event dispatch, persona load/switch/cycle lifecycle, reference and command input parsing, session tab creation and teardown, modal open/close flows). - [ ] Add Robot integration tests for the `tui` module in `robot/`, covering key integration points (e.g., TUI application startup and shutdown, sidebar hidden/visible/fullscreen state transitions, persona switching end-to-end, `@`/`/`/`!` input mode activation and resolution, plan event notification rendering, multi-session tab lifecycle). No mocking is permitted in Robot tests. - [ ] Add ASV performance benchmarks for the `tui` module in `benchmarks/`, covering performance-critical paths (e.g., `TuiMaterializer` event dispatch throughput, persona resolution latency, reference fuzzy-search response time, session tab switch latency, notification queue drain throughput). - [ ] Verify all new Robot tests pass via `nox -e integration_tests`. - [ ] Verify all new ASV benchmarks run successfully via `nox`. - [ ] Confirm coverage ≥ 97% via `nox -e coverage_report`. - [ ] Ensure all nox stages pass (`nox`). ## Definition of Done - [ ] Robot integration tests exist under `robot/` covering the `tui` module's key integration points. - [ ] ASV benchmarks exist under `benchmarks/` covering the `tui` module's performance-critical paths. - [ ] No mocking is used in Robot integration tests. - [ ] The new tests provide adequate coverage for the `tui` module. - [ ] The new tests pass in the CI pipeline. - [ ] All nox stages pass. - [ ] Coverage >= 97% - [ ] A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - [ ] The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - [ ] A pull request has been created, reviewed, and merged before this issue is marked done. --- **Automated by CleverAgents Bot** Supervisor: Unknown | Agent: ca-new-issue-creator
freemo added this to the v3.7.0 milestone 2026-04-03 03:59:05 +00:00
freemo self-assigned this 2026-04-03 16:58:08 +00:00
Author
Owner

MoSCoW classification: Should Have

Rationale: This issue addresses a spec requirement or important quality improvement. It should be included in the milestone if possible.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

MoSCoW classification: **Should Have** Rationale: This issue addresses a spec requirement or important quality improvement. It should be included in the milestone if possible. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
Reference
cleveragents/cleveragents-core#2089
No description provided.