UAT: ContextTierService and TierBudget use wrong default values — hot=8000 (spec: 16000), warm=500 (spec: 100), cold=5000 (spec: 500) #1443

Open
opened 2026-04-02 17:59:13 +00:00 by freemo · 11 comments
Owner

Metadata

  • Branch: fix/acms-tier-default-values
  • Commit Message: fix(acms): correct hot/warm/cold tier default values in ContextTierService, TierBudget, and Settings
  • Milestone: v3.5.0
  • Parent Epic: #935

What Was Tested

ACMS v1 tiered storage default values in ContextTierService, TierBudget (domain model), and Settings class.

Expected Behavior (from spec)

Per docs/specification.md line 30580-30582 and the ConfigService registration in config_service.py:

  • context.hot.max-tokens default = 16000 tokens
  • context.warm.max-decisions default = 100 fragments
  • context.cold.max-decisions default = 500 fragments

Actual Behavior

Three separate locations have wrong hardcoded defaults:

1. src/cleveragents/application/services/context_tiers.py (lines 45-47):

_DEFAULT_MAX_TOKENS_HOT = 8000      # spec says 16000
_DEFAULT_MAX_DECISIONS_WARM = 500   # spec says 100
_DEFAULT_MAX_DECISIONS_COLD = 5000  # spec says 500

2. src/cleveragents/domain/models/acms/tiers.py (TierBudget model defaults):

max_tokens_hot: int = Field(default=8000, ...)      # spec says 16000
max_decisions_warm: int = Field(default=500, ...)   # spec says 100
max_decisions_cold: int = Field(default=5000, ...)  # spec says 500

3. src/cleveragents/config/settings.py (lines 286-302):

context_max_tokens_hot: int = Field(default=8000, ...)       # spec says 16000
context_max_decisions_warm: int = Field(default=500, ...)    # spec says 100
context_max_decisions_cold: int = Field(default=5000, ...)   # spec says 500

Note: ConfigService in config_service.py correctly registers 16000/100/500, but ContextTierService reads from Settings (not ConfigService), so it gets the wrong values.

Steps to Reproduce

from cleveragents.application.services.context_tiers import ContextTierService, _DEFAULT_MAX_TOKENS_HOT, _DEFAULT_MAX_DECISIONS_WARM, _DEFAULT_MAX_DECISIONS_COLD
from cleveragents.domain.models.acms.tiers import TierBudget

print(_DEFAULT_MAX_TOKENS_HOT)      # prints 8000, should be 16000
print(_DEFAULT_MAX_DECISIONS_WARM)  # prints 500, should be 100
print(_DEFAULT_MAX_DECISIONS_COLD)  # prints 5000, should be 500

budget = TierBudget()
print(budget.max_tokens_hot)        # prints 8000, should be 16000
print(budget.max_decisions_warm)    # prints 500, should be 100
print(budget.max_decisions_cold)    # prints 5000, should be 500

svc = ContextTierService()
print(svc.budget.max_tokens_hot)    # prints 8000, should be 16000

Impact

  • Hot tier accepts only 8000 tokens by default instead of 16000, causing premature eviction of context fragments
  • Warm tier allows 500 fragments instead of 100, consuming more memory than specified
  • Cold tier allows 5000 fragments instead of 500, consuming more storage than specified
  • Inconsistency between ConfigService (correct) and Settings/TierBudget (wrong) creates confusion

Code Locations

  • src/cleveragents/application/services/context_tiers.py lines 45-47
  • src/cleveragents/domain/models/acms/tiers.py TierBudget field defaults
  • src/cleveragents/config/settings.py lines 286-302

This issue was found during UAT testing of ACMS v1 (v3.5.0) by instance uat-worker-acms-1.

Subtasks

  • Fix _DEFAULT_MAX_TOKENS_HOT, _DEFAULT_MAX_DECISIONS_WARM, _DEFAULT_MAX_DECISIONS_COLD constants in context_tiers.py (8000→16000, 500→100, 5000→500)
  • Fix TierBudget Pydantic field defaults in domain/models/acms/tiers.py (same three values)
  • Fix Settings field defaults in config/settings.py (same three values)
  • Verify ContextTierService reads from Settings (or ConfigService) and that the source of truth is consistent across all three locations
  • Write/update Behave unit tests in features/ to assert correct default values for TierBudget, ContextTierService, and Settings
  • Confirm nox -e typecheck passes (no type regressions)
  • Confirm nox -e unit_tests passes with ≥97% coverage

Definition of Done

  • All three hardcoded default locations corrected to spec values (hot=16000, warm=100, cold=500)
  • TierBudget() instantiated with no arguments yields max_tokens_hot=16000, max_decisions_warm=100, max_decisions_cold=500
  • ContextTierService() instantiated with no arguments yields a budget with the same correct defaults
  • Settings fields context_max_tokens_hot, context_max_decisions_warm, context_max_decisions_cold default to 16000, 100, 500 respectively
  • Behave unit tests covering the corrected defaults are present in features/
  • All nox stages pass
  • Coverage >= 97%
## Metadata - **Branch**: `fix/acms-tier-default-values` - **Commit Message**: `fix(acms): correct hot/warm/cold tier default values in ContextTierService, TierBudget, and Settings` - **Milestone**: v3.5.0 - **Parent Epic**: #935 ## What Was Tested ACMS v1 tiered storage default values in `ContextTierService`, `TierBudget` (domain model), and `Settings` class. ## Expected Behavior (from spec) Per `docs/specification.md` line 30580-30582 and the `ConfigService` registration in `config_service.py`: - `context.hot.max-tokens` default = **16000** tokens - `context.warm.max-decisions` default = **100** fragments - `context.cold.max-decisions` default = **500** fragments ## Actual Behavior Three separate locations have wrong hardcoded defaults: **1. `src/cleveragents/application/services/context_tiers.py`** (lines 45-47): ```python _DEFAULT_MAX_TOKENS_HOT = 8000 # spec says 16000 _DEFAULT_MAX_DECISIONS_WARM = 500 # spec says 100 _DEFAULT_MAX_DECISIONS_COLD = 5000 # spec says 500 ``` **2. `src/cleveragents/domain/models/acms/tiers.py`** (TierBudget model defaults): ```python max_tokens_hot: int = Field(default=8000, ...) # spec says 16000 max_decisions_warm: int = Field(default=500, ...) # spec says 100 max_decisions_cold: int = Field(default=5000, ...) # spec says 500 ``` **3. `src/cleveragents/config/settings.py`** (lines 286-302): ```python context_max_tokens_hot: int = Field(default=8000, ...) # spec says 16000 context_max_decisions_warm: int = Field(default=500, ...) # spec says 100 context_max_decisions_cold: int = Field(default=5000, ...) # spec says 500 ``` Note: `ConfigService` in `config_service.py` correctly registers 16000/100/500, but `ContextTierService` reads from `Settings` (not `ConfigService`), so it gets the wrong values. ## Steps to Reproduce ```python from cleveragents.application.services.context_tiers import ContextTierService, _DEFAULT_MAX_TOKENS_HOT, _DEFAULT_MAX_DECISIONS_WARM, _DEFAULT_MAX_DECISIONS_COLD from cleveragents.domain.models.acms.tiers import TierBudget print(_DEFAULT_MAX_TOKENS_HOT) # prints 8000, should be 16000 print(_DEFAULT_MAX_DECISIONS_WARM) # prints 500, should be 100 print(_DEFAULT_MAX_DECISIONS_COLD) # prints 5000, should be 500 budget = TierBudget() print(budget.max_tokens_hot) # prints 8000, should be 16000 print(budget.max_decisions_warm) # prints 500, should be 100 print(budget.max_decisions_cold) # prints 5000, should be 500 svc = ContextTierService() print(svc.budget.max_tokens_hot) # prints 8000, should be 16000 ``` ## Impact - Hot tier accepts only 8000 tokens by default instead of 16000, causing premature eviction of context fragments - Warm tier allows 500 fragments instead of 100, consuming more memory than specified - Cold tier allows 5000 fragments instead of 500, consuming more storage than specified - Inconsistency between `ConfigService` (correct) and `Settings`/`TierBudget` (wrong) creates confusion ## Code Locations - `src/cleveragents/application/services/context_tiers.py` lines 45-47 - `src/cleveragents/domain/models/acms/tiers.py` TierBudget field defaults - `src/cleveragents/config/settings.py` lines 286-302 This issue was found during UAT testing of ACMS v1 (v3.5.0) by instance uat-worker-acms-1. ## Subtasks - [ ] Fix `_DEFAULT_MAX_TOKENS_HOT`, `_DEFAULT_MAX_DECISIONS_WARM`, `_DEFAULT_MAX_DECISIONS_COLD` constants in `context_tiers.py` (8000→16000, 500→100, 5000→500) - [ ] Fix `TierBudget` Pydantic field defaults in `domain/models/acms/tiers.py` (same three values) - [ ] Fix `Settings` field defaults in `config/settings.py` (same three values) - [ ] Verify `ContextTierService` reads from `Settings` (or `ConfigService`) and that the source of truth is consistent across all three locations - [ ] Write/update Behave unit tests in `features/` to assert correct default values for `TierBudget`, `ContextTierService`, and `Settings` - [ ] Confirm `nox -e typecheck` passes (no type regressions) - [ ] Confirm `nox -e unit_tests` passes with ≥97% coverage ## Definition of Done - [ ] All three hardcoded default locations corrected to spec values (hot=16000, warm=100, cold=500) - [ ] `TierBudget()` instantiated with no arguments yields `max_tokens_hot=16000`, `max_decisions_warm=100`, `max_decisions_cold=500` - [ ] `ContextTierService()` instantiated with no arguments yields a budget with the same correct defaults - [ ] `Settings` fields `context_max_tokens_hot`, `context_max_decisions_warm`, `context_max_decisions_cold` default to 16000, 100, 500 respectively - [ ] Behave unit tests covering the corrected defaults are present in `features/` - [ ] All nox stages pass - [ ] Coverage >= 97%
freemo added this to the v3.5.0 milestone 2026-04-02 18:00:46 +00:00
freemo self-assigned this 2026-04-02 18:45:09 +00:00
Author
Owner

Issue triaged by project owner:

  • State: Verified
  • Priority: High (already assigned) — Wrong default values in three separate locations cause incorrect ACMS tier behaviour (premature hot eviction, excessive warm/cold storage).
  • Milestone: v3.5.0 (already assigned)
  • MoSCoW: Must Have (already assigned) — The spec explicitly defines default values for hot (16000), warm (100), and cold (500) tiers. The implementation uses 8000/500/5000 respectively. This causes the hot tier to evict context fragments prematurely (half the intended budget) and the warm/cold tiers to consume 5x/10x more resources than specified.
  • Parent Epic: #935

Valid, well-documented UAT bug. The fix is straightforward — update three hardcoded constants in three files. The inconsistency between ConfigService (correct) and Settings/TierBudget (wrong) is particularly concerning.


Automated by CleverAgents Bot
Supervisor: Project Owner | Agent: ca-project-owner

Issue triaged by project owner: - **State**: Verified - **Priority**: High (already assigned) — Wrong default values in three separate locations cause incorrect ACMS tier behaviour (premature hot eviction, excessive warm/cold storage). - **Milestone**: v3.5.0 (already assigned) - **MoSCoW**: Must Have (already assigned) — The spec explicitly defines default values for hot (16000), warm (100), and cold (500) tiers. The implementation uses 8000/500/5000 respectively. This causes the hot tier to evict context fragments prematurely (half the intended budget) and the warm/cold tiers to consume 5x/10x more resources than specified. - **Parent Epic**: #935 Valid, well-documented UAT bug. The fix is straightforward — update three hardcoded constants in three files. The inconsistency between `ConfigService` (correct) and `Settings`/`TierBudget` (wrong) is particularly concerning. --- **Automated by CleverAgents Bot** Supervisor: Project Owner | Agent: ca-project-owner
Author
Owner

PR #1485 Review: Changes Requested

PR #1485 was reviewed and changes were requested. The PR currently only updates test files to use the spec-correct warm/cold values but does not fix the actual production code defaults in the three source files identified in this issue:

  1. src/cleveragents/application/services/context_tiers.py — constants still 8000/500/5000
  2. src/cleveragents/domain/models/acms/tiers.pyTierBudget field defaults still 8000/500/5000
  3. src/cleveragents/config/settings.pySettings field defaults still 8000/500/5000

Additionally missing:

  • New Behave tests asserting correct default values
  • PR milestone assignment (v3.5.0)
  • Type/Bug label on PR
  • Correct commit message scope (acms instead of v3.7.0)

CI is also failing. Full review details are on the PR.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1485 Review: Changes Requested PR #1485 was reviewed and **changes were requested**. The PR currently only updates test files to use the spec-correct warm/cold values but does **not** fix the actual production code defaults in the three source files identified in this issue: 1. `src/cleveragents/application/services/context_tiers.py` — constants still 8000/500/5000 2. `src/cleveragents/domain/models/acms/tiers.py` — `TierBudget` field defaults still 8000/500/5000 3. `src/cleveragents/config/settings.py` — `Settings` field defaults still 8000/500/5000 Additionally missing: - New Behave tests asserting correct default values - PR milestone assignment (v3.5.0) - `Type/Bug` label on PR - Correct commit message scope (`acms` instead of `v3.7.0`) CI is also failing. Full review details are on the PR. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 — Follow-up Review: Changes Still Requested

PR #1485 has been reviewed again. None of the previously requested changes have been addressed. The PR still only contains test fixture updates — the 3 production files with wrong defaults (context_tiers.py, tiers.py, settings.py) remain unchanged.

Outstanding items:

  1. Production code defaults not fixed (8000→16000, 500→100, 5000→500) in all 3 files
  2. No Behave tests for default value assertions
  3. Commit message scope wrong (v3.7.0 → should be acms)
  4. PR milestone wrong (v3.7.0 → should be v3.5.0)

See full review comment on PR #1485 for details.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1485 — Follow-up Review: Changes Still Requested PR #1485 has been reviewed again. **None of the previously requested changes have been addressed.** The PR still only contains test fixture updates — the 3 production files with wrong defaults (`context_tiers.py`, `tiers.py`, `settings.py`) remain unchanged. ### Outstanding items: 1. Production code defaults not fixed (8000→16000, 500→100, 5000→500) in all 3 files 2. No Behave tests for default value assertions 3. Commit message scope wrong (`v3.7.0` → should be `acms`) 4. PR milestone wrong (v3.7.0 → should be v3.5.0) See [full review comment on PR #1485](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1485#issuecomment-91947) for details. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 — Third Review: Changes Still Requested

PR #1485 has been reviewed for the third time. No new commits have been pushed since the original submission. The PR still only contains test fixture changes (updating explicit TierBudget constructor args in 4 test files) but does not fix the actual production code defaults in:

  1. src/cleveragents/application/services/context_tiers.py
  2. src/cleveragents/domain/models/acms/tiers.py
  3. src/cleveragents/config/settings.py

Additionally missing: Behave tests for default values, correct commit message scope, and milestone assignment (should be v3.5.0, not v3.7.0).

The bug described in this issue remains unfixed. See the full review comment for details.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1485 — Third Review: Changes Still Requested PR #1485 has been reviewed for the third time. **No new commits have been pushed since the original submission.** The PR still only contains test fixture changes (updating explicit `TierBudget` constructor args in 4 test files) but does not fix the actual production code defaults in: 1. `src/cleveragents/application/services/context_tiers.py` 2. `src/cleveragents/domain/models/acms/tiers.py` 3. `src/cleveragents/config/settings.py` Additionally missing: Behave tests for default values, correct commit message scope, and milestone assignment (should be v3.5.0, not v3.7.0). The bug described in this issue remains **unfixed**. See the [full review comment](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1485#issuecomment-94107) for details. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 has been reviewed for the fourth time — changes still requested.

The PR only modifies test fixture values (explicit TierBudget constructor arguments in 4 test/robot files) but does not fix the actual production defaults in the 3 source files (context_tiers.py, tiers.py, settings.py). The bug remains unfixed. No new commits have been pushed since the PR was opened.

Key outstanding items:

  1. Fix production defaults in 3 files (9 values: 8000→16000, 500→100, 5000→500)
  2. Add Behave tests asserting correct default values
  3. Fix commit message scope (acms not v3.7.0)
  4. Reassign PR to milestone v3.5.0

See PR #1485 review comment for full details.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1485 has been reviewed for the **fourth time** — changes still requested. The PR only modifies test fixture values (explicit `TierBudget` constructor arguments in 4 test/robot files) but does **not** fix the actual production defaults in the 3 source files (`context_tiers.py`, `tiers.py`, `settings.py`). The bug remains unfixed. No new commits have been pushed since the PR was opened. Key outstanding items: 1. Fix production defaults in 3 files (9 values: 8000→16000, 500→100, 5000→500) 2. Add Behave tests asserting correct default values 3. Fix commit message scope (`acms` not `v3.7.0`) 4. Reassign PR to milestone v3.5.0 See [PR #1485 review comment](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1485#issuecomment-94460) for full details. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 has been reviewed for the fifth time. Changes still not addressed. The PR only modifies test fixture values in 4 files but does not fix the actual production defaults in context_tiers.py, tiers.py, or settings.py. The 9 hardcoded default values (hot=8000→16000, warm=500→100, cold=5000→500) remain unchanged. Additionally, Behave tests for default values are missing, the commit message scope is wrong (v3.7.0 instead of acms), and the PR milestone should be v3.5.0 not v3.7.0. Requesting changes again.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1485 has been reviewed for the fifth time. **Changes still not addressed.** The PR only modifies test fixture values in 4 files but does not fix the actual production defaults in `context_tiers.py`, `tiers.py`, or `settings.py`. The 9 hardcoded default values (hot=8000→16000, warm=500→100, cold=5000→500) remain unchanged. Additionally, Behave tests for default values are missing, the commit message scope is wrong (`v3.7.0` instead of `acms`), and the PR milestone should be v3.5.0 not v3.7.0. Requesting changes again. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 reviewed for the sixth time — changes still requested. The branch has not been updated since it was opened (HEAD is still 2603873). The PR only modifies test fixture values in 4 files but does not fix the actual production defaults in context_tiers.py, tiers.py, or settings.py. Missing: production code fixes (9 values across 3 files), Behave default-value tests, correct commit message scope, and milestone reassignment to v3.5.0.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1485 reviewed for the sixth time — **changes still requested**. The branch has not been updated since it was opened (HEAD is still `2603873`). The PR only modifies test fixture values in 4 files but does not fix the actual production defaults in `context_tiers.py`, `tiers.py`, or `settings.py`. Missing: production code fixes (9 values across 3 files), Behave default-value tests, correct commit message scope, and milestone reassignment to v3.5.0. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 Review Outcome: Changes Requested (7th review)

PR #1485 has been reviewed and changes were requested. This is the 7th review — the PR has not been updated since it was opened.

Key findings:

  1. The bug is NOT fixed — the three production files (context_tiers.py, tiers.py, settings.py) containing the wrong defaults are not modified in the PR at all. Only test fixture values were changed.

  2. Massive scope violation — the PR touches 160 files (1,728 insertions, 12,391 deletions) including CI workflows, 20+ agent definitions, documentation, source code across many modules, and build system changes. None of these are related to this issue.

  3. Dangerous safety regressions — the PR relaxes agent bash permissions from curated allowlists to unrestricted wildcards, enables force_merge (previously forbidden), and removes health signaling, finding validation, and state reconciliation guardrails.

  4. Missing Behave tests for default value assertions as required by the Definition of Done.

  5. Commit message and milestone mismatches — wrong scope (v3.7.0 instead of acms), wrong milestone (v3.7.0 instead of v3.5.0).

The PR needs to be stripped down to only the tier defaults fix, the actual production code needs to be changed, and the safety-critical agent definition changes need separate human-reviewed PRs.

See PR #1485 comment for full details.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1485 Review Outcome: Changes Requested (7th review) PR #1485 has been reviewed and **changes were requested**. This is the 7th review — the PR has not been updated since it was opened. ### Key findings: 1. **The bug is NOT fixed** — the three production files (`context_tiers.py`, `tiers.py`, `settings.py`) containing the wrong defaults are not modified in the PR at all. Only test fixture values were changed. 2. **Massive scope violation** — the PR touches 160 files (1,728 insertions, 12,391 deletions) including CI workflows, 20+ agent definitions, documentation, source code across many modules, and build system changes. None of these are related to this issue. 3. **Dangerous safety regressions** — the PR relaxes agent bash permissions from curated allowlists to unrestricted wildcards, enables `force_merge` (previously forbidden), and removes health signaling, finding validation, and state reconciliation guardrails. 4. **Missing Behave tests** for default value assertions as required by the Definition of Done. 5. **Commit message and milestone mismatches** — wrong scope (`v3.7.0` instead of `acms`), wrong milestone (v3.7.0 instead of v3.5.0). The PR needs to be stripped down to only the tier defaults fix, the actual production code needs to be changed, and the safety-critical agent definition changes need separate human-reviewed PRs. See [PR #1485 comment](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1485#issuecomment-99780) for full details. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 reviewed (eighth independent review) — REQUEST CHANGES.

The PR only modifies test fixture values in 4 files but does not change any of the 3 production files containing the wrong defaults. The bug remains unfixed. Additionally missing: Behave tests for default values, correct commit message scope (acms not v3.7.0), and milestone alignment (should be v3.5.0, not v3.7.0).

See review comment for full details.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1485 reviewed (eighth independent review) — **REQUEST CHANGES**. The PR only modifies test fixture values in 4 files but does not change any of the 3 production files containing the wrong defaults. The bug remains unfixed. Additionally missing: Behave tests for default values, correct commit message scope (`acms` not `v3.7.0`), and milestone alignment (should be v3.5.0, not v3.7.0). See [review comment](https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1485#issuecomment-107705) for full details. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 has been reviewed for the ninth time. Changes requested — the PR still only modifies test fixture values and does not fix the actual production defaults in context_tiers.py, tiers.py, or settings.py. The 9 hardcoded values remain wrong (8000/500/5000 instead of 16000/100/500). Additionally, Behave tests for default values are missing, the commit message scope is wrong (v3.7.0 instead of acms), and the PR milestone doesn't match this issue's milestone (v3.5.0).

See the full review at: #1485


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

PR #1485 has been reviewed for the ninth time. **Changes requested** — the PR still only modifies test fixture values and does not fix the actual production defaults in `context_tiers.py`, `tiers.py`, or `settings.py`. The 9 hardcoded values remain wrong (8000/500/5000 instead of 16000/100/500). Additionally, Behave tests for default values are missing, the commit message scope is wrong (`v3.7.0` instead of `acms`), and the PR milestone doesn't match this issue's milestone (v3.5.0). See the full review at: https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/1485 --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Author
Owner

PR #1485 Review: Changes Requested

PR #1485 (fix/1443-tier-defaults) was reviewed and changes were requested. The PR currently only updates hardcoded values in 4 test/robot helper files but does not fix the actual production code in the three source files identified in this issue:

  1. src/cleveragents/application/services/context_tiers.py — constants still 8000/500/5000
  2. src/cleveragents/domain/models/acms/tiers.py — TierBudget defaults still 8000/500/5000
  3. src/cleveragents/config/settings.py — Settings defaults still 8000/500/5000

Additionally missing:

  • Behave tests asserting correct default values
  • Proper commit message format (scope, ISSUES CLOSED footer)

The issue worker should pick up the review comments and implement the required fixes.


Automated by CleverAgents Bot
Supervisor: PR Review | Agent: ca-pr-self-reviewer

## PR #1485 Review: Changes Requested PR #1485 (`fix/1443-tier-defaults`) was reviewed and **changes were requested**. The PR currently only updates hardcoded values in 4 test/robot helper files but does **not fix the actual production code** in the three source files identified in this issue: 1. `src/cleveragents/application/services/context_tiers.py` — constants still 8000/500/5000 2. `src/cleveragents/domain/models/acms/tiers.py` — TierBudget defaults still 8000/500/5000 3. `src/cleveragents/config/settings.py` — Settings defaults still 8000/500/5000 Additionally missing: - Behave tests asserting correct default values - Proper commit message format (scope, ISSUES CLOSED footer) The issue worker should pick up the review comments and implement the required fixes. --- **Automated by CleverAgents Bot** Supervisor: PR Review | Agent: ca-pr-self-reviewer
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#1443
No description provided.