cleveragents/cleveragents-core

Fork 3

test(e2e): update m1_acceptance.robot #1249

New issue

Closed

opened 2026-04-01 20:55:44 +00:00 by brent.edwards · 4 comments

brent.edwards commented

2026-04-01 20:55:44 +00:00

Member

Metadata

Commit Message: test(e2e): update m1_acceptance.robot
Branch: test/e2e-update-m1-acceptance

Background

According to v3.0.0, the test m1_acceptance.robot has many steps that either do not check the output or only check that it is not blank.

This ticket is complete when all steps in m1_acceptance.robot contain checks for the return code and expected output, if an output exists.

Acceptance criteria

There are checks of output (if any output exists) and checks of the return code for the following function calls in m1_acceptance.robot:

[ ] action create
[ ] resource add git-checkout
[ ] project create
[ ] plan use local/test-action
[ ] plan execute (1)
[ ] plan execute (2)
[ ] plan diff
[ ] plan apply

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.

## Metadata - **Commit Message**: `test(e2e): update m1_acceptance.robot` - **Branch**: `test/e2e-update-m1-acceptance` ## Background According to [v3.0.0](https://wiki.cleverthis.com/en/CleverAgent/QA/v3point0), the test `m1_acceptance.robot` has many steps that either do not check the output or only check that it is not blank. This ticket is complete when all steps in `m1_acceptance.robot` contain checks for the return code and expected output, if an output exists. ## Acceptance criteria There are checks of output (if any output exists) and checks of the return code for the following function calls in `m1_acceptance.robot`: - [ ] `action create` - [ ] `resource add git-checkout` - [ ] `project create` - [ ] `plan use local/test-action` - [ ] `plan execute` (1) - [ ] `plan execute` (2) - [ ] `plan diff` - [ ] `plan apply` ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.

brent.edwards added this to the v3.0.0 milestone

2026-04-01 20:55:44 +00:00

brent.edwards added the

labels

2026-04-01 20:55:44 +00:00

brent.edwards referenced this issue from a commit

2026-04-02 04:20:05 +00:00

test(e2e): update m1_acceptance.robot

~~brent.edwards referenced this issue 2026-04-02 04:20:13 +00:00~~

test(e2e): update m1_acceptance.robot #1260

freemo commented

2026-04-02 04:45:46 +00:00

Owner

PR #1260 has been reviewed and changes requested. Two critical bugs were found that will cause the test to fail at runtime:

Step 10 (plan apply): ${git_log.rc} referenced before ${git_log} is defined — should be ${apply_result.rc}
Step 9 (plan diff): ${exec2_result.rc} checks the wrong command's return code — should be ${diff_result.rc}

Additionally, the "No changes in changeset" assertion in step 9 may be incorrect (the author's own ### IMPORTANT QUESTION comment suggests uncertainty), debug comments need to be removed, indentation inconsistencies need fixing, and the PR needs a milestone (v3.0.0) and Type/Testing label.

See the full review on PR #1260 for details.

PR #1260 has been reviewed and **changes requested**. Two critical bugs were found that will cause the test to fail at runtime: 1. **Step 10 (plan apply)**: `${git_log.rc}` referenced before `${git_log}` is defined — should be `${apply_result.rc}` 2. **Step 9 (plan diff)**: `${exec2_result.rc}` checks the wrong command's return code — should be `${diff_result.rc}` Additionally, the "No changes in changeset" assertion in step 9 may be incorrect (the author's own `### IMPORTANT QUESTION` comment suggests uncertainty), debug comments need to be removed, indentation inconsistencies need fixing, and the PR needs a milestone (v3.0.0) and `Type/Testing` label. See the full review on PR #1260 for details.

freemo referenced this issue

2026-04-02 08:06:41 +00:00

test(e2e): update m1_acceptance.robot #1260

freemo commented

2026-04-02 08:06:43 +00:00

Owner

PR #1260 review status: REQUEST_CHANGES (still unresolved)

PR #1260 has an outstanding REQUEST_CHANGES review with 2 critical variable-reference bugs, a questionable assertion, debug comments left in code, and missing PR metadata (milestone + Type/ label). No fixes have been pushed since the review was posted. The PR cannot be merged in its current state.

**PR #1260 review status:** REQUEST_CHANGES (still unresolved) PR #1260 has an outstanding REQUEST_CHANGES review with 2 critical variable-reference bugs, a questionable assertion, debug comments left in code, and missing PR metadata (milestone + Type/ label). No fixes have been pushed since the review was posted. The PR cannot be merged in its current state.

brent.edwards referenced this issue from a commit

2026-04-02 08:57:06 +00:00

test(e2e): update m1_acceptance.robot

brent.edwards referenced this issue from a pull request that will close it,

2026-04-02 08:57:25 +00:00

test(e2e): update m1_acceptance.robot #1260

brent.edwards referenced this issue

2026-04-02 11:45:03 +00:00

fix(plan): wire sandbox_root into plan execute pipeline #1313

brent.edwards referenced this issue from a commit

2026-04-02 11:46:58 +00:00

test(e2e): update m1_acceptance.robot

brent.edwards referenced this issue

2026-04-02 11:47:55 +00:00

test(e2e): update m1_acceptance.robot #1260

freemo referenced this issue

2026-04-02 16:48:48 +00:00

fix(plan): wire sandbox_root into plan execute pipeline #1313

freemo commented

2026-04-02 16:54:07 +00:00

Owner

[Backlog Groomer - groomer-1] 📋 Label state mismatch. This issue has State/Verified but PR #1260 (test(e2e): update m1_acceptance.robot) is open and references this issue. The state should be updated to State/In Review.

**[Backlog Groomer - groomer-1]** 📋 **Label state mismatch.** This issue has `State/Verified` but PR #1260 (`test(e2e): update m1_acceptance.robot`) is open and references this issue. The state should be updated to `State/In Review`.

freemo referenced this issue

2026-04-02 16:56:18 +00:00

[Automated] Product Build Session State #1314

freemo closed this issue

2026-04-02 16:58:39 +00:00

freemo commented

2026-04-02 16:58:47 +00:00

Owner

PR #1260 reviewed, approved, and merged.

All acceptance criteria have been met — every CLI step in m1_acceptance.robot now has return code checks and expected output validation. The test is tagged tdd_expected_fail for assertions that depend on the sandbox_root wiring bug (#1313).

PR #1260 reviewed, approved, and merged. All acceptance criteria have been met — every CLI step in `m1_acceptance.robot` now has return code checks and expected output validation. The test is tagged `tdd_expected_fail` for assertions that depend on the sandbox_root wiring bug (#1313).

freemo added

and removed

labels

2026-04-02 16:59:21 +00:00