Add `adr_compliance` nox session to CI pipeline to enforce Architecture Decision Record compliance #10730

New issue

Open

opened 2026-04-19 07:53:47 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-19 07:53:47 +00:00

Owner

Issue Description

The noxfile.py defines an adr_compliance session that checks code compliance with Architecture Decision Records (ADRs), but this session is not included in the CI pipeline (ci.yml). ADR compliance violations can therefore merge undetected.

Running nox -s adr_compliance locally reveals 56 existing violations (threading imports in async services, direct SQLAlchemy usage in service layer), confirming the check is meaningful and needed.

Current State

noxfile.py defines adr_compliance which runs scripts/check-adr-compliance.py, but ci.yml does NOT include this session in any job. The nox.options.sessions default list also does not include adr_compliance.

Impact

ADR compliance violations can be merged without detection
The scripts/check-adr-compliance.py script exists but is never run automatically
56 existing violations are currently undetected in CI
Developers may unknowingly violate architectural decisions documented in ADRs

Expected Behavior

Add nox -s adr_compliance to the quality job in ci.yml alongside the existing complexity check.

Note: The existing 56 violations must be resolved (or the ADR checker updated to reflect current architectural decisions) before this check can be enforced as a hard gate.

Subtasks

Resolve or document the 56 existing ADR violations found by nox -s adr_compliance
Add nox -s adr_compliance to the quality job in ci.yml
Add adr_compliance to nox.options.sessions default list in noxfile.py
Confirm CI passes with the added check

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged.

Metadata

Commit Message: feat(ci): add adr_compliance nox session to CI quality job
Branch Name: feat/ci-adr-compliance-check

Duplicate Check

Searched open and closed issues for: "adr compliance CI", "adr_compliance nox", "architecture decision record CI". No existing issues found.

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Issue Description The `noxfile.py` defines an `adr_compliance` session that checks code compliance with Architecture Decision Records (ADRs), but this session is **not included in the CI pipeline** (`ci.yml`). ADR compliance violations can therefore merge undetected. Running `nox -s adr_compliance` locally reveals **56 existing violations** (threading imports in async services, direct SQLAlchemy usage in service layer), confirming the check is meaningful and needed. ## Current State `noxfile.py` defines `adr_compliance` which runs `scripts/check-adr-compliance.py`, but `ci.yml` does NOT include this session in any job. The `nox.options.sessions` default list also does not include `adr_compliance`. ## Impact - ADR compliance violations can be merged without detection - The `scripts/check-adr-compliance.py` script exists but is never run automatically - 56 existing violations are currently undetected in CI - Developers may unknowingly violate architectural decisions documented in ADRs ## Expected Behavior Add `nox -s adr_compliance` to the `quality` job in `ci.yml` alongside the existing `complexity` check. **Note**: The existing 56 violations must be resolved (or the ADR checker updated to reflect current architectural decisions) before this check can be enforced as a hard gate. ## Subtasks - [ ] Resolve or document the 56 existing ADR violations found by `nox -s adr_compliance` - [ ] Add `nox -s adr_compliance` to the `quality` job in `ci.yml` - [ ] Add `adr_compliance` to `nox.options.sessions` default list in `noxfile.py` - [ ] Confirm CI passes with the added check ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged**. ## Metadata - **Commit Message**: `feat(ci): add adr_compliance nox session to CI quality job` - **Branch Name**: `feat/ci-adr-compliance-check` ## Duplicate Check Searched open and closed issues for: "adr compliance CI", "adr_compliance nox", "architecture decision record CI". No existing issues found. --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added this to the v3.2.0 milestone

2026-04-19 07:53:47 +00:00

HAL9000 self-assigned this

2026-04-19 07:53:47 +00:00

HAL9000 added the