CI `coverage` job should depend on `unit_tests` to prevent misleading parallel results #10724

New issue

Open

opened 2026-04-19 07:51:24 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-19 07:51:24 +00:00

Owner

Issue Description

The coverage job in .forgejo/workflows/ci.yml only depends on [lint, typecheck, security, quality] but does not depend on unit_tests. This means the coverage job runs in parallel with the test jobs, potentially wasting CI resources and producing misleading intermediate results.

Current State

coverage:
    needs: [lint, typecheck, security, quality]
    # Missing: unit_tests

The coverage job runs nox -s coverage_report, which internally re-runs the full Behave test suite under slipcover. This means:

Coverage runs its own copy of the tests regardless of whether unit_tests passed
If unit_tests fails, coverage may still pass (running the same tests again)
The two jobs run the same tests twice in parallel, wasting CI resources

Expected Behavior

coverage:
    needs: [lint, typecheck, security, quality, unit_tests]

Subtasks

Update coverage job's needs in ci.yml to include unit_tests
Verify CI pipeline still runs correctly with the updated dependency
Confirm no circular dependencies are introduced

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged.

Metadata

Commit Message: fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results
Branch Name: fix/ci-coverage-job-ordering

Duplicate Check

Searched open and closed issues for: "coverage needs unit_tests", "coverage job ordering", "coverage parallel tests". No existing issues found.

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Issue Description The `coverage` job in `.forgejo/workflows/ci.yml` only depends on `[lint, typecheck, security, quality]` but does **not** depend on `unit_tests`. This means the coverage job runs in parallel with the test jobs, potentially wasting CI resources and producing misleading intermediate results. ## Current State ```yaml coverage: needs: [lint, typecheck, security, quality] # Missing: unit_tests ``` The `coverage` job runs `nox -s coverage_report`, which internally re-runs the full Behave test suite under slipcover. This means: - Coverage runs its own copy of the tests regardless of whether `unit_tests` passed - If `unit_tests` fails, coverage may still pass (running the same tests again) - The two jobs run the same tests twice in parallel, wasting CI resources ## Expected Behavior ```yaml coverage: needs: [lint, typecheck, security, quality, unit_tests] ``` ## Subtasks - [ ] Update `coverage` job's `needs` in `ci.yml` to include `unit_tests` - [ ] Verify CI pipeline still runs correctly with the updated dependency - [ ] Confirm no circular dependencies are introduced ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged**. ## Metadata - **Commit Message**: `fix(ci): add unit_tests to coverage job needs to prevent misleading parallel results` - **Branch Name**: `fix/ci-coverage-job-ordering` ## Duplicate Check Searched open and closed issues for: "coverage needs unit_tests", "coverage job ordering", "coverage parallel tests". No existing issues found. --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added this to the v3.2.0 milestone

2026-04-19 07:51:24 +00:00

HAL9000 self-assigned this

2026-04-19 07:51:24 +00:00

HAL9000 added the