refactor(tests): implement missing step definitions for 25 consolidated feature files #10702

New issue

Open

opened 2026-04-19 06:50:31 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-19 06:50:31 +00:00

Owner

Summary

All 25 consolidated_*_steps.py files in features/steps/ are empty (0 bytes). The corresponding feature files have 850–1992 lines each with 116–250 scenarios. These features cannot run because their step implementations are missing, creating a silent test gap.

Problem

The following consolidated feature files exist with substantial content but their step files are empty:

Feature File	Lines	Scenarios
`features/consolidated_action.feature`	850	116
`features/consolidated_actor.feature`	1370	~150
`features/consolidated_misc.feature`	1992	250
`features/consolidated_domain_models.feature`	1614	223
`features/consolidated_plan_misc.feature`	1050	~120
`features/consolidated_plan_model_lifecycle.feature`	962	~110
`features/consolidated_routing.feature`	1384	~160
`features/consolidated_security.feature`	1139	~130
`features/consolidated_skill.feature`	1237	~140
`features/consolidated_tool.feature`	1015	~115
... and 15 more

All corresponding features/steps/consolidated_*_steps.py files are 0 bytes.

Root Cause

The consolidated feature files appear to have been created as a refactoring effort to group related scenarios, but the step implementations were never written (or the step files were accidentally emptied).

Impact

Behave may silently skip these scenarios or report them as undefined steps
Coverage data from these scenarios is not collected
The 97% coverage threshold may be artificially maintained by excluding these scenarios

Subtasks

Audit all 25 consolidated_*_steps.py files to confirm they are empty
Determine if consolidated feature files reuse steps from other step files (Behave loads all step files in features/steps/)
If steps are shared from other files, add a comment to each empty file explaining this (e.g., # Steps for this feature are defined in <module>_steps.py)
If steps are NOT shared, implement the missing step definitions
Run nox -s unit_tests and verify all consolidated features execute without undefined step errors
Update coverage report to confirm no regression

Definition of Done

All 25 consolidated_*_steps.py files either have implementations or documented explanations for why they are empty
nox -s unit_tests passes with all consolidated features running
No undefined step errors for consolidated feature files
nox -s coverage_report passes at ≥97% threshold

Metadata

Branch: refactor/consolidated-step-files
Commit Message: refactor(tests): implement missing step definitions for 25 consolidated feature files

Duplicate Check

Searched open and closed issues for: "consolidated", "step definitions", "empty step", "missing step". No duplicates found.

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Summary All 25 `consolidated_*_steps.py` files in `features/steps/` are empty (0 bytes). The corresponding feature files have 850–1992 lines each with 116–250 scenarios. These features cannot run because their step implementations are missing, creating a silent test gap. ## Problem The following consolidated feature files exist with substantial content but their step files are empty: | Feature File | Lines | Scenarios | |---|---|---| | `features/consolidated_action.feature` | 850 | 116 | | `features/consolidated_actor.feature` | 1370 | ~150 | | `features/consolidated_misc.feature` | 1992 | 250 | | `features/consolidated_domain_models.feature` | 1614 | 223 | | `features/consolidated_plan_misc.feature` | 1050 | ~120 | | `features/consolidated_plan_model_lifecycle.feature` | 962 | ~110 | | `features/consolidated_routing.feature` | 1384 | ~160 | | `features/consolidated_security.feature` | 1139 | ~130 | | `features/consolidated_skill.feature` | 1237 | ~140 | | `features/consolidated_tool.feature` | 1015 | ~115 | | ... and 15 more | | | All corresponding `features/steps/consolidated_*_steps.py` files are 0 bytes. ## Root Cause The consolidated feature files appear to have been created as a refactoring effort to group related scenarios, but the step implementations were never written (or the step files were accidentally emptied). ## Impact - Behave may silently skip these scenarios or report them as undefined steps - Coverage data from these scenarios is not collected - The 97% coverage threshold may be artificially maintained by excluding these scenarios ## Subtasks - [ ] Audit all 25 `consolidated_*_steps.py` files to confirm they are empty - [ ] Determine if consolidated feature files reuse steps from other step files (Behave loads all step files in `features/steps/`) - [ ] If steps are shared from other files, add a comment to each empty file explaining this (e.g., `# Steps for this feature are defined in <module>_steps.py`) - [ ] If steps are NOT shared, implement the missing step definitions - [ ] Run `nox -s unit_tests` and verify all consolidated features execute without undefined step errors - [ ] Update coverage report to confirm no regression ## Definition of Done - All 25 `consolidated_*_steps.py` files either have implementations or documented explanations for why they are empty - `nox -s unit_tests` passes with all consolidated features running - No undefined step errors for consolidated feature files - `nox -s coverage_report` passes at ≥97% threshold ## Metadata - **Branch:** `refactor/consolidated-step-files` - **Commit Message:** `refactor(tests): implement missing step definitions for 25 consolidated feature files` ## Duplicate Check Searched open and closed issues for: "consolidated", "step definitions", "empty step", "missing step". No duplicates found. --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added this to the v3.9.0 milestone

2026-04-19 06:50:31 +00:00

HAL9000 added the

labels

2026-04-19 07:17:29 +00:00