`benchmark-regression` job in `master.yml` has unreachable trigger condition #10697

New issue

Open

opened 2026-04-19 06:41:49 +00:00 by HAL9000 · 0 comments

HAL9000 commented

2026-04-19 06:41:49 +00:00

Owner

Issue Description

The benchmark-regression job in .forgejo/workflows/master.yml contains an if condition that can never be true, making the job permanently dead code. Benchmark regression testing on pull requests is silently broken.

Root Cause

master.yml is triggered only on push events to master and develop branches. But the benchmark-regression job has:

benchmark-regression:
    if: forgejo.event_name == 'pull_request'

Since master.yml never triggers on pull_request events, forgejo.event_name will always be push — the condition is permanently false and the job never runs.

Impact

Benchmark regression testing on PRs is completely broken and silently skipped
Performance regressions can merge undetected
The benchmark-publish job (push-triggered) works correctly, but the PR regression check does not

Expected Behavior

Fix options:

Option A (Recommended): Move benchmark-regression to ci.yml (which triggers on pull_request)
Option B: Add pull_request to master.yml's on: trigger

Subtasks

Move or restructure benchmark-regression so it triggers on pull_request events
Verify benchmark-publish continues to run on push to master/develop
Confirm CI passes with corrected workflow

Definition of Done

This issue is complete when:

All subtasks above are completed and checked off.
A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly.
The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
The commit is submitted as a pull request to master, reviewed, and merged.

Metadata

Commit Message: fix(ci): restore benchmark-regression trigger to pull_request events in master.yml
Branch Name: fix/ci-benchmark-regression-trigger

Duplicate Check

Searched open and closed issues for: "benchmark regression master.yml", "benchmark workflow trigger", "pull_request event_name". No existing issues found.

Automated by CleverAgents Bot
Supervisor: Implementation Pool | Agent: implementation-worker

## Issue Description The `benchmark-regression` job in `.forgejo/workflows/master.yml` contains an `if` condition that can **never be true**, making the job permanently dead code. Benchmark regression testing on pull requests is silently broken. ## Root Cause `master.yml` is triggered only on `push` events to `master` and `develop` branches. But the `benchmark-regression` job has: ```yaml benchmark-regression: if: forgejo.event_name == 'pull_request' ``` Since `master.yml` never triggers on `pull_request` events, `forgejo.event_name` will always be `push` — the condition is permanently `false` and the job **never runs**. ## Impact - Benchmark regression testing on PRs is completely broken and silently skipped - Performance regressions can merge undetected - The `benchmark-publish` job (push-triggered) works correctly, but the PR regression check does not ## Expected Behavior Fix options: 1. **Option A (Recommended)**: Move `benchmark-regression` to `ci.yml` (which triggers on `pull_request`) 2. **Option B**: Add `pull_request` to `master.yml`'s `on:` trigger ## Subtasks - [ ] Move or restructure `benchmark-regression` so it triggers on `pull_request` events - [ ] Verify `benchmark-publish` continues to run on push to `master`/`develop` - [ ] Confirm CI passes with corrected workflow ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged**. ## Metadata - **Commit Message**: `fix(ci): restore benchmark-regression trigger to pull_request events in master.yml` - **Branch Name**: `fix/ci-benchmark-regression-trigger` ## Duplicate Check Searched open and closed issues for: "benchmark regression master.yml", "benchmark workflow trigger", "pull_request event_name". No existing issues found. --- **Automated by CleverAgents Bot** Supervisor: Implementation Pool | Agent: implementation-worker

HAL9000 added this to the v3.2.0 milestone

2026-04-19 06:41:49 +00:00

HAL9000 self-assigned this

2026-04-19 06:41:49 +00:00

HAL9000 added the