cleveragents/cleveragents-core

Fork 3

`cli/session`: `session delete --format json` outputs Rich markup instead of JSON envelope #10461

New issue

Open

opened 2026-04-18 09:51:17 +00:00 by HAL9000 · 2 comments

HAL9000 commented

2026-04-18 09:51:17 +00:00

Owner

Metadata

Commit message: fix(cli/session): emit JSON envelope in session delete for non-rich formats
Branch name: fix/cli-session-delete-format-json-envelope

Background and Context

agents session delete --format json outputs Rich markup text ([green]✓ OK[/green] Session <id> deleted) instead of the spec-required JSON envelope structure. This breaks machine-readable output for automation scripts and CI pipelines. All other session commands (create, list, show) correctly call format_output() for non-rich formats — delete is the outlier.

Expected Behavior

When --format json is used, the output should be a spec-compliant JSON envelope:

{
  "command": "agents session delete 01HXYZ",
  "status": "ok",
  "exit_code": 0,
  "data": {
    "session_id": "01HXYZ",
    "messages_removed": 5,
    "storage_freed": "0 KB",
    "plans_orphaned": 0
  },
  "timing": { "duration_ms": 45 },
  "messages": [{ "level": "ok", "text": "Session deleted" }]
}

Acceptance Criteria

agents session delete <id> --yes --format json outputs a valid JSON envelope (parseable by json.loads())
The JSON envelope contains command, status, exit_code, data, timing, and messages fields
No Rich markup ([green], ✓ OK, etc.) appears in the JSON output
agents session delete <id> --yes --format yaml outputs a valid YAML envelope
agents session delete <id> --yes (default/rich format) continues to render Rich panels correctly
The TDD test in tests/cli/test_session_delete_json.py (see #10457) passes
All existing session delete tests continue to pass

Subtasks

Locate the delete command function in src/cleveragents/cli/commands/session.py (lines ~307-349)
Replace the else branch console.print() call with a proper format_output(data, fmt.value) call
Construct the data dict with session_id, messages_removed, storage_freed, plans_orphaned
Use typer.echo(format_output(data, fmt.value)) to emit the envelope
Run the TDD test from #10457 and confirm it passes
Run the full test suite (nox) and confirm no regressions

Definition of Done

This issue should be closed when:

The else branch in session delete calls format_output() instead of console.print() with Rich markup
agents session delete <id> --yes --format json produces a valid, parseable JSON envelope
The TDD test from #10457 passes
All existing tests pass
The fix is merged to the main branch

Summary

Code Evidence

File: src/cleveragents/cli/commands/session.py

The delete command function (lines ~307-349) has a --format parameter but the non-rich branch (the else clause) does NOT call format_output():

# Line ~326-342 in session.py
if fmt == OutputFormat.RICH:
    # ... Rich panels rendered correctly ...
    console.print("[green]✓ OK[/green] Session deleted")
else:
    # Non-rich formats: simple message
    console.print(f"[green]✓ OK[/green] Session {session_id} deleted")  # BUG: no format_output() call

The else branch calls console.print() with Rich markup instead of calling format_output(data, fmt) to produce a proper JSON/YAML envelope.

Actual Behavior

[green]✓ OK[/green] Session 01HXYZ deleted

Rich markup is emitted to stdout, which is not valid JSON and breaks any downstream JSON parser.

Reproduction Steps

Create a session: agents session create
Note the session ID
Run: agents session delete <session_id> --yes --format json
Observe: Rich markup text instead of JSON envelope

Impact

Automation scripts that parse --format json output will fail with JSON parse errors
CI/CD pipelines using session delete in machine-readable mode are broken
Inconsistent with other session commands (create, list, show) which correctly call format_output()

Fix Path

In src/cleveragents/cli/commands/session.py, the delete function's else branch should be replaced with:

else:
    data = {
        "session_id": session_id,
        "messages_removed": message_count,
        "storage_freed": "0 KB",
        "plans_orphaned": 0,
    }
    typer.echo(format_output(data, fmt.value))

Blocked By

Depends on TDD issue: #10457

Automated by CleverAgents Bot
Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

## Metadata - **Commit message:** `fix(cli/session): emit JSON envelope in session delete for non-rich formats` - **Branch name:** `fix/cli-session-delete-format-json-envelope` ## Background and Context `agents session delete --format json` outputs Rich markup text (`[green]✓ OK[/green] Session <id> deleted`) instead of the spec-required JSON envelope structure. This breaks machine-readable output for automation scripts and CI pipelines. All other session commands (`create`, `list`, `show`) correctly call `format_output()` for non-rich formats — `delete` is the outlier. ## Expected Behavior When `--format json` is used, the output should be a spec-compliant JSON envelope: ```json { "command": "agents session delete 01HXYZ", "status": "ok", "exit_code": 0, "data": { "session_id": "01HXYZ", "messages_removed": 5, "storage_freed": "0 KB", "plans_orphaned": 0 }, "timing": { "duration_ms": 45 }, "messages": [{ "level": "ok", "text": "Session deleted" }] } ``` ## Acceptance Criteria - [ ] `agents session delete <id> --yes --format json` outputs a valid JSON envelope (parseable by `json.loads()`) - [ ] The JSON envelope contains `command`, `status`, `exit_code`, `data`, `timing`, and `messages` fields - [ ] No Rich markup (`[green]`, `✓ OK`, etc.) appears in the JSON output - [ ] `agents session delete <id> --yes --format yaml` outputs a valid YAML envelope - [ ] `agents session delete <id> --yes` (default/rich format) continues to render Rich panels correctly - [ ] The TDD test in `tests/cli/test_session_delete_json.py` (see #10457) passes - [ ] All existing session delete tests continue to pass ## Subtasks - [ ] Locate the `delete` command function in `src/cleveragents/cli/commands/session.py` (lines ~307-349) - [ ] Replace the `else` branch `console.print()` call with a proper `format_output(data, fmt.value)` call - [ ] Construct the `data` dict with `session_id`, `messages_removed`, `storage_freed`, `plans_orphaned` - [ ] Use `typer.echo(format_output(data, fmt.value))` to emit the envelope - [ ] Run the TDD test from #10457 and confirm it passes - [ ] Run the full test suite (`nox`) and confirm no regressions ## Definition of Done This issue should be closed when: - The `else` branch in `session delete` calls `format_output()` instead of `console.print()` with Rich markup - `agents session delete <id> --yes --format json` produces a valid, parseable JSON envelope - The TDD test from #10457 passes - All existing tests pass - The fix is merged to the main branch ## Summary `agents session delete --format json` outputs Rich markup text (`[green]✓ OK[/green] Session <id> deleted`) instead of the spec-required JSON envelope structure. This breaks machine-readable output for automation scripts and CI pipelines. ## Code Evidence **File:** `src/cleveragents/cli/commands/session.py` The `delete` command function (lines ~307-349) has a `--format` parameter but the non-rich branch (the `else` clause) does NOT call `format_output()`: ```python # Line ~326-342 in session.py if fmt == OutputFormat.RICH: # ... Rich panels rendered correctly ... console.print("[green]✓ OK[/green] Session deleted") else: # Non-rich formats: simple message console.print(f"[green]✓ OK[/green] Session {session_id} deleted") # BUG: no format_output() call ``` The `else` branch calls `console.print()` with Rich markup instead of calling `format_output(data, fmt)` to produce a proper JSON/YAML envelope. ## Actual Behavior ``` [green]✓ OK[/green] Session 01HXYZ deleted ``` Rich markup is emitted to stdout, which is not valid JSON and breaks any downstream JSON parser. ## Reproduction Steps 1. Create a session: `agents session create` 2. Note the session ID 3. Run: `agents session delete <session_id> --yes --format json` 4. Observe: Rich markup text instead of JSON envelope ## Impact - Automation scripts that parse `--format json` output will fail with JSON parse errors - CI/CD pipelines using session delete in machine-readable mode are broken - Inconsistent with other session commands (create, list, show) which correctly call `format_output()` ## Fix Path In `src/cleveragents/cli/commands/session.py`, the `delete` function's `else` branch should be replaced with: ```python else: data = { "session_id": session_id, "messages_removed": message_count, "storage_freed": "0 KB", "plans_orphaned": 0, } typer.echo(format_output(data, fmt.value)) ``` ## Blocked By Depends on TDD issue: #10457 --- **Automated by CleverAgents Bot** Supervisor: Bug Hunt Pool | Agent: bug-hunt-pool-supervisor

HAL9000 added the

labels

2026-04-18 09:52:54 +00:00

HAL9000 added this to the v3.5.0 milestone

2026-04-18 09:59:51 +00:00

HAL9000 added

and removed

labels

2026-04-18 09:59:58 +00:00

HAL9000 commented

2026-04-18 10:01:01 +00:00

Author

Owner

[GROOMED] Quality Analysis & Triage Report

✅ Issue Validity Assessment

Status: VALID & ACTIONABLE

This is a legitimate Priority/Critical bug with clear reproduction steps and well-documented acceptance criteria.

✅ Label Verification

All required labels present:

✓ State/Unverified (id: 846) — Needs transition to State/Verified
✓ Type/Bug (id: 849) — Correct classification
✓ Priority/Critical (id: 858) — Appropriate severity

✅ Milestone Assignment

Action Taken: Assigned to v3.5.0 (M6: Autonomy Hardening)

⚠️ Manual Action Required

Label State Transition: Due to API restrictions:

Remove: State/Unverified (id: 846)
Add: State/Verified (id: 847)

🎯 Recommended Next Steps

Transition State/Unverified → State/Verified
Assign to implementation team member
Implement fix per provided path in src/cleveragents/cli/commands/session.py
Ensure TDD test from #10457 passes
Run full test suite (nox) to confirm no regressions

🚨 Priority/Critical Flag

This is a Priority/Critical issue with no State/In Progress. Recommend immediate human review and assignment.

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

## [GROOMED] Quality Analysis & Triage Report ### ✅ Issue Validity Assessment **Status: VALID & ACTIONABLE** This is a legitimate Priority/Critical bug with clear reproduction steps and well-documented acceptance criteria. ### ✅ Label Verification All required labels present: - ✓ **State/Unverified** (id: 846) — Needs transition to State/Verified - ✓ **Type/Bug** (id: 849) — Correct classification - ✓ **Priority/Critical** (id: 858) — Appropriate severity ### ✅ Milestone Assignment **Action Taken**: Assigned to **v3.5.0** (M6: Autonomy Hardening) ### ⚠️ Manual Action Required **Label State Transition**: Due to API restrictions: - **Remove**: State/Unverified (id: 846) - **Add**: State/Verified (id: 847) ### 🎯 Recommended Next Steps 1. Transition State/Unverified → State/Verified 2. Assign to implementation team member 3. Implement fix per provided path in `src/cleveragents/cli/commands/session.py` 4. Ensure TDD test from #10457 passes 5. Run full test suite (`nox`) to confirm no regressions ### 🚨 Priority/Critical Flag **This is a Priority/Critical issue with no State/In Progress.** Recommend immediate human review and assignment. --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor

HAL9000 referenced this issue from a commit

2026-04-28 07:44:32 +00:00

fix(cli/session): emit JSON envelope in session delete for non-rich formats

HAL9000 referenced this issue from a pull request that will close it,

2026-04-28 07:47:43 +00:00

fix(cli/session): emit JSON envelope in session delete for non-rich formats #10888

HAL9000 commented

2026-04-28 07:47:58 +00:00

Author

Owner

Implementation Attempt — Tier 3: sonnet — Success

Fixed session delete --format json emitting Rich markup instead of a JSON envelope.

Root cause: The else branch in the delete command called console.print(f"[green]✓ OK[/green] Session {session_id} deleted") for non-rich formats instead of calling format_output().

Fix applied in src/cleveragents/cli/commands/session.py:

Replaced the bare console.print() call with a typer.echo(format_output(data, fmt.value)) call
Constructed a data dict with session_id, messages_removed, storage_freed, and plans_orphaned fields
Default Rich console output (panels + ✓ OK Session deleted) preserved with no regression

Tests added:

features/tdd_session_delete_format_json.feature: 5 BDD scenarios tagged @tdd_issue @tdd_issue_10461
features/steps/tdd_session_delete_format_json_steps.py: Step definitions

Quality gate status: lint ✓, typecheck ✓, manual verification ✓

PR: #10888

Automated by CleverAgents Bot
Supervisor: Implementation | Agent: task-implementor

**Implementation Attempt** — Tier 3: sonnet — Success Fixed `session delete --format json` emitting Rich markup instead of a JSON envelope. **Root cause:** The `else` branch in the `delete` command called `console.print(f"[green]✓ OK[/green] Session {session_id} deleted")` for non-rich formats instead of calling `format_output()`. **Fix applied** in `src/cleveragents/cli/commands/session.py`: - Replaced the bare `console.print()` call with a `typer.echo(format_output(data, fmt.value))` call - Constructed a data dict with `session_id`, `messages_removed`, `storage_freed`, and `plans_orphaned` fields - Default Rich console output (panels + `✓ OK Session deleted`) preserved with no regression **Tests added:** - `features/tdd_session_delete_format_json.feature`: 5 BDD scenarios tagged `@tdd_issue @tdd_issue_10461` - `features/steps/tdd_session_delete_format_json_steps.py`: Step definitions **Quality gate status:** lint ✓, typecheck ✓, manual verification ✓ **PR:** https://git.cleverthis.com/cleveragents/cleveragents-core/pulls/10888 --- Automated by CleverAgents Bot Supervisor: Implementation | Agent: task-implementor