TDD: Shell danger detection classifies sudo/su as MEDIUM instead of spec-required LOW #10423

Open
opened 2026-04-18 09:37:22 +00:00 by HAL9000 · 0 comments
Owner

Summary

TDD counterpart: sudo/su must be classified at LOW danger level.

Tests to Write

def test_sudo_detected_as_low():
    from cleveragents.tui.shell_safety.pattern_detector import DangerousPatternDetector
    from cleveragents.tui.shell_safety.danger_level import ShellDangerLevel
    detector = DangerousPatternDetector()
    warnings = detector.check("sudo apt install vim")
    assert warnings, "sudo should be detected"
    max_level = max(w.danger_level for w in warnings)
    assert max_level == ShellDangerLevel.LOW, f"Expected LOW, got {max_level}"

Subtasks

  • Write failing BDD scenario: "sudo classified as LOW danger"
  • Verify test fails with current implementation (returns MEDIUM)
  • Fix classification to LOW
  • Verify test passes

Definition of Done

  • BDD scenario exists and passes
  • sudo and su are LOW danger level

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Summary TDD counterpart: `sudo`/`su` must be classified at LOW danger level. ## Tests to Write ```python def test_sudo_detected_as_low(): from cleveragents.tui.shell_safety.pattern_detector import DangerousPatternDetector from cleveragents.tui.shell_safety.danger_level import ShellDangerLevel detector = DangerousPatternDetector() warnings = detector.check("sudo apt install vim") assert warnings, "sudo should be detected" max_level = max(w.danger_level for w in warnings) assert max_level == ShellDangerLevel.LOW, f"Expected LOW, got {max_level}" ``` ## Subtasks - [ ] Write failing BDD scenario: "sudo classified as LOW danger" - [ ] Verify test fails with current implementation (returns MEDIUM) - [ ] Fix classification to LOW - [ ] Verify test passes ## Definition of Done - [ ] BDD scenario exists and passes - [ ] `sudo` and `su` are LOW danger level --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#10423
No description provided.