TDD: Shell danger detection missing kill -9/killall (medium) and fdisk/parted (high) patterns #10420

Open
opened 2026-04-18 09:36:58 +00:00 by HAL9000 · 0 comments
Owner

Summary

TDD counterpart: kill -9/killall and fdisk/parted patterns must be added to the default danger pattern registry.

Tests to Write

def test_kill_9_detected_as_medium():
    from cleveragents.tui.shell_safety.pattern_detector import DangerousPatternDetector
    from cleveragents.tui.shell_safety.danger_level import ShellDangerLevel
    detector = DangerousPatternDetector()
    warnings = detector.check("kill -9 1234")
    assert warnings, "kill -9 should be detected"
    assert max(w.danger_level for w in warnings) == ShellDangerLevel.MEDIUM

def test_fdisk_detected_as_high():
    from cleveragents.tui.shell_safety.pattern_detector import DangerousPatternDetector
    from cleveragents.tui.shell_safety.danger_level import ShellDangerLevel
    detector = DangerousPatternDetector()
    warnings = detector.check("fdisk /dev/sda")
    assert warnings, "fdisk should be detected"
    assert max(w.danger_level for w in warnings) == ShellDangerLevel.HIGH

Subtasks

  • Write failing BDD scenarios for kill -9/killall and fdisk/parted
  • Verify tests fail with current implementation
  • Add patterns to registry
  • Verify tests pass

Definition of Done

  • BDD scenarios exist and pass for all 4 patterns

Automated by CleverAgents Bot
Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor

## Summary TDD counterpart: `kill -9`/`killall` and `fdisk`/`parted` patterns must be added to the default danger pattern registry. ## Tests to Write ```python def test_kill_9_detected_as_medium(): from cleveragents.tui.shell_safety.pattern_detector import DangerousPatternDetector from cleveragents.tui.shell_safety.danger_level import ShellDangerLevel detector = DangerousPatternDetector() warnings = detector.check("kill -9 1234") assert warnings, "kill -9 should be detected" assert max(w.danger_level for w in warnings) == ShellDangerLevel.MEDIUM def test_fdisk_detected_as_high(): from cleveragents.tui.shell_safety.pattern_detector import DangerousPatternDetector from cleveragents.tui.shell_safety.danger_level import ShellDangerLevel detector = DangerousPatternDetector() warnings = detector.check("fdisk /dev/sda") assert warnings, "fdisk should be detected" assert max(w.danger_level for w in warnings) == ShellDangerLevel.HIGH ``` ## Subtasks - [ ] Write failing BDD scenarios for kill -9/killall and fdisk/parted - [ ] Verify tests fail with current implementation - [ ] Add patterns to registry - [ ] Verify tests pass ## Definition of Done - [ ] BDD scenarios exist and pass for all 4 patterns --- **Automated by CleverAgents Bot** Supervisor: UAT Test Pool | Agent: uat-test-pool-supervisor
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
cleveragents/cleveragents-core#10420
No description provided.