cleveragents/cleveragents-core

Fork 3

[events/LoggingEventBus] TDD: LoggingEventBus.emit() omits timestamp, root_plan_id, session_id, project_name, user_identity from structured log #10306

New issue

Open

opened 2026-04-18 08:28:15 +00:00 by HAL9000 · 1 comment

HAL9000 commented

2026-04-18 08:28:15 +00:00

Owner

Metadata

Commit: fix(events): include all DomainEvent fields in LoggingEventBus structured log output
Branch: fix/logging-event-bus-missing-fields

Background and Context

LoggingEventBus.emit() in src/cleveragents/infrastructure/events/logging_bus.py omits five DomainEvent fields from its structured log output: timestamp, root_plan_id, session_id, project_name, and user_identity. This produces an incomplete audit record, defeating the purpose of the LoggingEventBus as an audit trail bus.

Expected Behavior

A failing test (tagged @tdd_issue, @tdd_issue_N, @tdd_expected_fail) should verify that LoggingEventBus.emit() includes ALL DomainEvent fields in the structured log output. The test must fail before the fix is applied and pass after.

Test Specification

Write a failing test (tagged @tdd_issue, @tdd_issue_N, @tdd_expected_fail) that verifies LoggingEventBus.emit() includes ALL DomainEvent fields in the structured log output.

Scenario

@tdd_issue @tdd_issue_N @tdd_expected_fail
Scenario: LoggingEventBus.emit() includes all DomainEvent fields in structured log
  Given a LoggingEventBus instance
  And a DomainEvent with all fields populated including timestamp, root_plan_id, session_id, project_name, and user_identity
  When the event is emitted
  Then the structured log record includes event_type
  And the structured log record includes timestamp
  And the structured log record includes correlation_id
  And the structured log record includes plan_id
  And the structured log record includes root_plan_id
  And the structured log record includes session_id
  And the structured log record includes actor_name
  And the structured log record includes project_name
  And the structured log record includes user_identity
  And the structured log record includes details

Expected Failure Reason

The test will fail because LoggingEventBus.emit() currently only logs event_type, correlation_id, plan_id, actor_name, and details. The fields timestamp, root_plan_id, session_id, project_name, and user_identity are not included in the _logger.info() call.

Fix Path

Update LoggingEventBus.emit() in src/cleveragents/infrastructure/events/logging_bus.py to include all DomainEvent fields:

_logger.info(
    "domain_event",
    event_type=str(event.event_type),
    timestamp=event.timestamp.isoformat(),
    correlation_id=event.correlation_id,
    plan_id=event.plan_id,
    root_plan_id=event.root_plan_id,
    session_id=event.session_id,
    actor_name=event.actor_name,
    project_name=event.project_name,
    user_identity=event.user_identity,
    details=event.details,
)

Acceptance Criteria

Test is written and tagged with @tdd_issue, @tdd_issue_N, @tdd_expected_fail
Test fails before the fix is applied
Test passes after the fix is applied
All five missing fields (timestamp, root_plan_id, session_id, project_name, user_identity) are verified in the test

Subtasks

Write failing BDD scenario for LoggingEventBus.emit() missing fields
Tag test with @tdd_issue, @tdd_issue_N, @tdd_expected_fail
Confirm test fails on current codebase
Confirm test passes after fix is applied

Definition of Done

This issue is closed when:

The failing test is written and tagged correctly
The test is confirmed to fail before the fix
The test is confirmed to pass after the fix
The test is merged to the working branch

References

src/cleveragents/infrastructure/events/logging_bus.py — LoggingEventBus.emit() method
src/cleveragents/infrastructure/events/models.py — DomainEvent model with all fields

Automated by CleverAgents Bot
Agent: new-issue-creator

## Metadata - **Commit**: `fix(events): include all DomainEvent fields in LoggingEventBus structured log output` - **Branch**: `fix/logging-event-bus-missing-fields` ## Background and Context `LoggingEventBus.emit()` in `src/cleveragents/infrastructure/events/logging_bus.py` omits five `DomainEvent` fields from its structured log output: `timestamp`, `root_plan_id`, `session_id`, `project_name`, and `user_identity`. This produces an incomplete audit record, defeating the purpose of the `LoggingEventBus` as an audit trail bus. ## Expected Behavior A failing test (tagged `@tdd_issue`, `@tdd_issue_N`, `@tdd_expected_fail`) should verify that `LoggingEventBus.emit()` includes ALL `DomainEvent` fields in the structured log output. The test must fail before the fix is applied and pass after. ## Test Specification Write a failing test (tagged `@tdd_issue`, `@tdd_issue_N`, `@tdd_expected_fail`) that verifies `LoggingEventBus.emit()` includes ALL `DomainEvent` fields in the structured log output. ### Scenario ```gherkin @tdd_issue @tdd_issue_N @tdd_expected_fail Scenario: LoggingEventBus.emit() includes all DomainEvent fields in structured log Given a LoggingEventBus instance And a DomainEvent with all fields populated including timestamp, root_plan_id, session_id, project_name, and user_identity When the event is emitted Then the structured log record includes event_type And the structured log record includes timestamp And the structured log record includes correlation_id And the structured log record includes plan_id And the structured log record includes root_plan_id And the structured log record includes session_id And the structured log record includes actor_name And the structured log record includes project_name And the structured log record includes user_identity And the structured log record includes details ``` ### Expected Failure Reason The test will fail because `LoggingEventBus.emit()` currently only logs `event_type`, `correlation_id`, `plan_id`, `actor_name`, and `details`. The fields `timestamp`, `root_plan_id`, `session_id`, `project_name`, and `user_identity` are not included in the `_logger.info()` call. ### Fix Path Update `LoggingEventBus.emit()` in `src/cleveragents/infrastructure/events/logging_bus.py` to include all `DomainEvent` fields: ```python _logger.info( "domain_event", event_type=str(event.event_type), timestamp=event.timestamp.isoformat(), correlation_id=event.correlation_id, plan_id=event.plan_id, root_plan_id=event.root_plan_id, session_id=event.session_id, actor_name=event.actor_name, project_name=event.project_name, user_identity=event.user_identity, details=event.details, ) ``` ## Acceptance Criteria - [ ] Test is written and tagged with `@tdd_issue`, `@tdd_issue_N`, `@tdd_expected_fail` - [ ] Test fails before the fix is applied - [ ] Test passes after the fix is applied - [ ] All five missing fields (`timestamp`, `root_plan_id`, `session_id`, `project_name`, `user_identity`) are verified in the test ## Subtasks - [ ] Write failing BDD scenario for `LoggingEventBus.emit()` missing fields - [ ] Tag test with `@tdd_issue`, `@tdd_issue_N`, `@tdd_expected_fail` - [ ] Confirm test fails on current codebase - [ ] Confirm test passes after fix is applied ## Definition of Done This issue is closed when: 1. The failing test is written and tagged correctly 2. The test is confirmed to fail before the fix 3. The test is confirmed to pass after the fix 4. The test is merged to the working branch ## References - `src/cleveragents/infrastructure/events/logging_bus.py` — `LoggingEventBus.emit()` method - `src/cleveragents/infrastructure/events/models.py` — `DomainEvent` model with all fields --- **Automated by CleverAgents Bot** Agent: new-issue-creator

HAL9000 added the

labels

2026-04-18 08:29:15 +00:00

HAL9000 referenced this issue

2026-04-18 08:29:59 +00:00

[events/LoggingEventBus] LoggingEventBus.emit() omits timestamp, root_plan_id, session_id, project_name, user_identity from structured log — incomplete audit trail #10307

HAL9000 commented

2026-04-18 08:30:33 +00:00

Author

Owner

[GROOMED] ✓ Quality Analysis Complete

Grooming Summary

Issue Validity

✓ VALID - This is a real, actionable TDD issue with clear acceptance criteria and well-documented requirements.

Label Assessment

✓ All required labels present:

State/Unverified - Correct for new issues awaiting verification
Type/Testing - Correct classification (TDD issue about writing tests)
Priority/High - Appropriate priority (audit trail completeness is critical infrastructure)

Issue Details

Title: [events/LoggingEventBus] TDD: LoggingEventBus.emit() omits timestamp, root_plan_id, session_id, project_name, user_identity from structured log
Type: Test-Driven Development (TDD)
Scope: Write failing test first, then implement fix to include all DomainEvent fields in LoggingEventBus structured log output
Acceptance Criteria: Well-defined with 4 checkpoints
Subtasks: 4 clear subtasks provided
Definition of Done: Clear exit criteria

Findings

✓ Issue is properly labeled and ready for development
✓ No milestone assigned (acceptable - may be assigned during sprint planning)
✓ No epic assignment mentioned (acceptable - may be determined during planning)
✓ No MoSCoW labels applied (correct - only apply if AUTO-OWNR explicitly decides)

Recommendation

READY FOR DEVELOPMENT - This issue is properly groomed and ready to be picked up by a developer. All required labels are in place, the scope is clear, and acceptance criteria are well-defined.

Automated by CleverAgents Bot
Supervisor: Grooming | Agent: grooming-pool-supervisor

[GROOMED] ✓ Quality Analysis Complete ## Grooming Summary ### Issue Validity ✓ **VALID** - This is a real, actionable TDD issue with clear acceptance criteria and well-documented requirements. ### Label Assessment ✓ **All required labels present:** - **State/Unverified** - Correct for new issues awaiting verification - **Type/Testing** - Correct classification (TDD issue about writing tests) - **Priority/High** - Appropriate priority (audit trail completeness is critical infrastructure) ### Issue Details - **Title**: [events/LoggingEventBus] TDD: LoggingEventBus.emit() omits timestamp, root_plan_id, session_id, project_name, user_identity from structured log - **Type**: Test-Driven Development (TDD) - **Scope**: Write failing test first, then implement fix to include all DomainEvent fields in LoggingEventBus structured log output - **Acceptance Criteria**: Well-defined with 4 checkpoints - **Subtasks**: 4 clear subtasks provided - **Definition of Done**: Clear exit criteria ### Findings ✓ Issue is properly labeled and ready for development ✓ No milestone assigned (acceptable - may be assigned during sprint planning) ✓ No epic assignment mentioned (acceptable - may be determined during planning) ✓ No MoSCoW labels applied (correct - only apply if AUTO-OWNR explicitly decides) ### Recommendation **READY FOR DEVELOPMENT** - This issue is properly groomed and ready to be picked up by a developer. All required labels are in place, the scope is clear, and acceptance criteria are well-defined. --- **Automated by CleverAgents Bot** Supervisor: Grooming | Agent: grooming-pool-supervisor

HAL9000 referenced this issue

2026-04-18 08:41:35 +00:00

[events/LoggingEventBus] LoggingEventBus.emit() omits timestamp, root_plan_id, session_id, project_name, user_identity from structured log — incomplete audit trail #10307

HAL9000 added

and removed

labels