fix: Failing E2E tests on master after plan execute cache-sharing fix #1026

New issue

Closed

opened 2026-03-17 11:26:45 +00:00 by CoreRasurae · 0 comments

CoreRasurae commented

2026-03-17 11:26:45 +00:00

Member

Summary

E2E tests are failing on the master branch at commit f0bdc3c6 (fix(cli): load persisted actions in start_strategize and run execute phase inline).

The HEAD of master includes changes that fix the stale-cache bug in plan execute CLI (where _get_plan_executor() created a second PlanLifecycleService Factory instance with its own in-memory _plans cache), but the E2E test suites are not passing against this state.

Affected Commit

Branch: master
Commit: f0bdc3c651 — fix(cli): load persisted actions in start_strategize and run execute phase inline

Changes on master

The commit modifies the following files:

File	Change
`src/cleveragents/cli/commands/plan.py`	`_get_plan_executor()` now accepts an optional `lifecycle_service` parameter; `execute_plan` handler passes its own service instance so both share the same cache
`docs/reference/plan_execute.md`	Documents CLI executor wiring and shared lifecycle service instance pattern
`docs/reference/plan_cli.md`	Updates `plan execute` docs to reflect inline phase detection and processing
`docs/reference/di.md`	Documents cache-sharing caveat for Factory-scoped `PlanLifecycleService`
`CHANGELOG.md`	Adds entry describing the stale-cache fix

Key code change (`plan.py`)

_get_plan_executor(lifecycle_service=None) — accepts optional pre-existing PlanLifecycleService to share the same in-memory cache
execute_plan handler now calls _get_plan_executor(lifecycle_service=service) instead of _get_plan_executor() to prevent stale state reads after phase transitions

E2E Test Suites to Investigate

robot/e2e/m6_acceptance.robot
robot/m6_e2e_verification.robot
robot/m5_e2e_verification.robot
robot/m4_e2e_verification.robot
robot/m3_e2e_verification.robot
robot/cli_lifecycle_e2e.robot
robot/plan_persistence_e2e.robot

Expected Outcome

All E2E test suites pass on master with the plan execute cache-sharing fix in place.

Refs

Related to #746

## Summary E2E tests are failing on the `master` branch at commit `f0bdc3c6` (`fix(cli): load persisted actions in start_strategize and run execute phase inline`). The HEAD of master includes changes that fix the stale-cache bug in `plan execute` CLI (where `_get_plan_executor()` created a second `PlanLifecycleService` Factory instance with its own in-memory `_plans` cache), but the E2E test suites are not passing against this state. ## Affected Commit - **Branch:** `master` - **Commit:** `f0bdc3c651` — _fix(cli): load persisted actions in start_strategize and run execute phase inline_ ## Changes on master The commit modifies the following files: | File | Change | |------|--------| | `src/cleveragents/cli/commands/plan.py` | `_get_plan_executor()` now accepts an optional `lifecycle_service` parameter; `execute_plan` handler passes its own service instance so both share the same cache | | `docs/reference/plan_execute.md` | Documents CLI executor wiring and shared lifecycle service instance pattern | | `docs/reference/plan_cli.md` | Updates `plan execute` docs to reflect inline phase detection and processing | | `docs/reference/di.md` | Documents cache-sharing caveat for Factory-scoped `PlanLifecycleService` | | `CHANGELOG.md` | Adds entry describing the stale-cache fix | ### Key code change (`plan.py`) - `_get_plan_executor(lifecycle_service=None)` — accepts optional pre-existing `PlanLifecycleService` to share the same in-memory cache - `execute_plan` handler now calls `_get_plan_executor(lifecycle_service=service)` instead of `_get_plan_executor()` to prevent stale state reads after phase transitions ## E2E Test Suites to Investigate - `robot/e2e/m6_acceptance.robot` - `robot/m6_e2e_verification.robot` - `robot/m5_e2e_verification.robot` - `robot/m4_e2e_verification.robot` - `robot/m3_e2e_verification.robot` - `robot/cli_lifecycle_e2e.robot` - `robot/plan_persistence_e2e.robot` ## Expected Outcome All E2E test suites pass on master with the plan execute cache-sharing fix in place. ## Refs - Related to #746

Rows
Columns