3 Commits

Author	SHA1	Message	Date
HAL9000	883ec872e2	fix(CI): resolve remaining lint/format violations in PR #8722 ... - Apply ruff format to features/steps/strategize_decision_recording_steps.py: expanded single-line set literal to multi-line canonical form (PEP 87) This was the sole remaining CI lint blocker per review cycle 14. - Remove unused imports from tests/actor/test_registry_builtin_yaml.py: removed 'Settings' and 'ProviderRegistry' to fix F401 errors. These were pre-existing violations caught by ruff check. ISSUES CLOSED: #8522 Closes: #8722	2026-05-08 06:24:23 +00:00
hurui200320	8dc55655e9	feat(actor): make built-in actors virtual, resolved on-demand from provider registry ... Replace the DB-persistence approach for built-in actors with in-memory virtual resolution. Built-in actors (e.g. openai/gpt-4o, anthropic/claude-sonnet) are now resolved on-demand from ProviderRegistry at query time and merged with persisted custom actors — no database writes occur for built-in actors. Key changes: - Add ActorRegistry._resolve_virtual_builtin_actors(): generates virtual Actor objects in-memory from configured providers (is_built_in=True, id=None) - ActorRegistry.list()/list_actors(): merges virtual built-ins with custom DB actors; custom actors win on name collision; result sorted alphabetically - ActorRegistry.get()/get_actor(): DB-first, virtual built-in fallback, NotFoundError if neither - ActorRegistry.remove()/remove_actor(): rejects virtual built-in names with ValidationError - ActorRegistry.set_default_actor(): stores only the actor name string via new actor_preferences singleton table; no actor row created for virtual built-ins - ActorRegistry.get_default_actor(): reads preference name, resolves via DB→virtual chain, returns actor with is_default=True - Remove ensure_built_in_actors() entirely — 20+ call sites cleaned up including plan.py - Remove ActorRepository.upsert_built_in() — no longer needed - Remove is_built_in from ActorModel DB column (kept on Actor domain model for virtual actors) - New Alembic migration m10_001_virtual_builtin_actors: drops is_built_in column, adds actor_preferences singleton table - Add ActorService.set_default_actor_name() and get_default_actor_name() for preference storage without requiring a DB actor row - Update 15+ Behave step files and 5 feature files; add new features/virtual_builtin_actors.feature with 8 scenarios covering list, show, remove, set-default, get-default, no-DB-writes guarantees - Rewrite tests/actor/test_registry_builtin_yaml.py: TestEnsureBuiltInActorsWithYaml → TestResolveVirtualBuiltinActors plus new TestListActors, TestGetActor, TestRemoveActor, TestDefaultActor test classes Quality gates: lint ✓, typecheck ✓, unit_tests ✓ (15674 scenarios), coverage ✓ (97.10%), integration_tests ✓ (1997 tests) ISSUES CLOSED: #10923	2026-04-30 10:56:21 +00:00
hurui200320	bb6765d85e	fix(actor): add v3 YAML text generation for built-in actors ... Built-in actors (e.g., openai/gpt-4, anthropic/claude-3-opus) were failing silently with agents actor run because they lacked the required v3 type field in their stored configuration. The ReactiveConfigParser._is_v3_format() check failed, resulting in empty agents/routes dictionaries and no output. This fix adds _generate_builtin_actor_yaml() helper to ActorRegistry that generates spec-compliant v3 YAML text including: - type: llm (required for v3 format recognition) - description (required by v3 schema) - name, model, provider, capabilities, unsafe, source fields The ensure_built_in_actors() method now calls this helper and persists yaml_text via upsert_actor(), ensuring built-in actors work identically to custom actors with the agents actor run command. Existing built-in actors will be automatically refreshed on next startup since they are regenerated from the provider registry - no database migration needed. Added: - _generate_builtin_actor_yaml() helper method - BDD feature file with scenarios for v3 YAML format - Step definitions for new BDD scenarios - Unit tests covering YAML generation and schema validation - CHANGELOG entry ISSUES CLOSED: #10883	2026-04-28 12:38:04 +00:00