Commit Graph

2 Commits

Author SHA1 Message Date
HAL9000 552dcb15b0 fix(plugins): remove duplicate step definitions and fix keyword context in feature
CI / lint (pull_request) Successful in 43s
CI / helm (pull_request) Successful in 45s
CI / build (pull_request) Successful in 53s
CI / quality (pull_request) Successful in 56s
CI / push-validation (pull_request) Successful in 55s
CI / typecheck (pull_request) Successful in 1m18s
CI / security (pull_request) Successful in 1m21s
CI / unit_tests (pull_request) Successful in 6m29s
CI / integration_tests (pull_request) Successful in 9m16s
CI / docker (pull_request) Successful in 1m41s
CI / coverage (pull_request) Successful in 12m27s
CI / status-check (pull_request) Successful in 3s
AmbiguousStep error caused all 8 features to error: plugin_executing_state_steps.py
re-defined 6 steps already present in plugin_architecture_steps.py:
- @then("a PluginError should be raised")
- @then("a PluginNotFoundError should be raised")
- @then('the plugin error message should contain "{text}"')
- @when('I attempt to deactivate the plugin "{name}"')
- @given("the PluginState enum is available")
- @then('it should have values ...')

Remove all duplicates, keeping only the 6 new steps unique to this feature.

Also fix the last scenario where `And I attempt to execute method on unknown plugin`
followed a `Given` step (so behave treated it as `given` context, not matching
the `@when` definition). Changed `And` to `When`.

ISSUES CLOSED: #5691
2026-06-04 20:36:52 -04:00
HAL9000 b0edcb53a4 fix(plugins): implement EXECUTING state in PluginManager lifecycle
- Added execute_plugin() method to PluginManager that properly sets PluginState.EXECUTING before calling a plugin method

- Transitions state back to ACTIVATED on success, or ERRORED on failure

- Completes the lifecycle state machine defined in PluginState enum

- Added BDD feature file features/plugin_executing_state.feature with scenarios covering state transitions

- Added step definitions in features/steps/plugin_executing_state_steps.py

ISSUES CLOSED: #5691
2026-06-04 20:36:52 -04:00