5 Commits

Author	SHA1	Message	Date
drew	132a5a2269	feat(auto-agents): centralise model registry under .opencode/models with session-create model stamp ... Every agent's model assignment now lives in a single-line text file at .opencode/models/<name>.txt; default.txt is the 27-agent catch-all. opencode.json's agent.<name>.model uses {file:./.opencode/models/<name>.txt} interpolation, and tools/_opencode_worker.py reads the same files at session-create to stamp the resolved model on the session record (observability + drift sentinel; OpenCode does NOT propagate session-level model to prompt_async — schema for that is undocumented and deferred to Stage 2). 39 .md frontmatter `model:` lines stripped; the two intentional inheritors (task-implementor, agent-evolution-pool-supervisor) keep their model-less frontmatter. Operator workflow for swapping a model is now: edit .opencode/models/<role>.txt, restart OpenCode so opencode.json's {file:...} re-resolves, run the dispatcher. Live-swap without restart was attempted (override on prompt_async); OpenCode 0.x silently dropped those requests (200 OK, no assistant message) and the prompt_async override was reverted. The session-create override remains for observability + drift detection. End-to-end validation (2026-05-10): dispatch_review.py on PR #25 with default.txt=openai/gpt-5-mini produced a clean REQUEST_CHANGES review in 26 s for ~$0.016; dispatch_implementer.py on PR #30 with tier-qwen-* files remapped to openai/{gpt-5-nano, gpt-5-mini, gpt-5-codex} ran the full implementation-worker → tier-dispatcher → estimator-implementation → tier-qwen-med → task-implementor → git-isolator-util chain in 16 min with model=gpt-5-mini end-to-end. Also documents the printenv VAR form as the only allowed env-read in implementation-worker.md and task-implementor.md (live testing showed the worker burning 2–4 turns on permission-denied trial-and-error trying printf and echo variants). Tests: 21 in tests/auto_agents/test_opencode_worker_models.py (resolver semantics with caplog assertions on every malformed-input path; session-create body shape; prompt_async body never carries model; three repo-level invariants — every {file:...} reference resolves, every .md is wired or in the inheritor allowlist, no .md has a model: frontmatter). 1027 auto_agents tests pass / 3 skipped. Note: .opencode/models/default.txt and the three tier-qwen-*.txt files are committed with their OpenAI swaps in place (gpt-5-mini, gpt-5-nano, gpt-5-mini, gpt-5-codex respectively) because the CleverThis HuggingFace endpoints are paused. Revert with `git diff HEAD~1 -- .opencode/models/*.txt | git apply -R` if/when they come back. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-05-10 17:23:06 -04:00
drew	2cbe62a70c	fix(auto-agents): F1+F2+F3 telemetry liveness, reviewer perf (A+C), bash rules ... Bundles a long-overdue set of fixes that surfaced while watching the single-PR pipeline test against PR #30 the morning of 2026-05-07. # F1 — long-worker liveness contract The dispatcher heartbeat was only refreshed *between* worker sessions. On a 30-minute review the heartbeat file went stale, and any heartbeat-watchdog (dispatchers-launcher.sh / cleveragents-dispatchers.service) would SIGTERM a perfectly-healthy worker mid-cycle, orphaning the OpenCode session and the auto/claimed-* lock. ``_opencode_worker.run_session_blocking`` now accepts an ``on_poll`` callback fired once per status-poll iteration; ``_dispatch_runtime.dispatch_one`` and ``conflict_drive.py`` wire it to ``write_heartbeat(cfg.heartbeat_path)``. Callback exceptions are logged and swallowed so a transient EROFS on the heartbeat path can never mask a successful worker completion. # F2 — in-flight cycle visibility (schema v5) The ``dispatch_*_cycles`` tables previously only recorded a row at cycle *end*. While a worker was running, the operator's only signal was the heartbeat file — and even that became stale (see F1). Schema bumped to v5: ``ended_at`` is now nullable and ``cycle_id`` carries a UNIQUE index. ``begin_cycle`` writes the in-flight row at start; ``finish_cycle`` updates it at end. ``run_one_cycle``'s try/finally guarantees ``finish_cycle`` runs even when ``collect_candidates`` / ``dispatch_one`` raises, so an orphan ``ended_at IS NULL`` can no longer be stuck forever after a crash. The v4→v5 migration is now defined in ONE place — a set of helpers in ``_forgejo_cache.py`` (``DISPATCH_CYCLE_TABLES``, ``_dispatch_cycle_create_sql``, ``_dispatch_cycle_index_sqls``, ``migrate_dispatch_cycle_table_to_v5``, ``ensure_dispatch_cycle_schema``). Both ``ForgejoCache._migrate_to_v5_in_flight_rows`` and ``_dispatch_runtime.ensure_cycle_table`` import from there, eliminating the drift risk of the previous duplicated DDL. Pre-existing rows are preserved verbatim across the migration. # F3 — telemetry surface for the new state ``/api/health`` now returns ``in_flight_cycle: {cycle_id, started_at, session_id, candidates_count, elapsed_s}`` per dispatcher daemon and a ``running_long_worker: bool`` flag (heartbeat older than 600s AND a matching pid alive — should never fire under healthy F1 operation, so when it does it points at a real bug). The Drivers and Overview tabs in ``.opencode/telemetry/{index.html,app.js,style.css}`` render in-flight rows with a tinted background + "in flight" pill, daemon tiles get a dashed border for the long-worker state, and each tile shows the running cycle's id + elapsed time inline. # Fix A — reasoningEffort high → medium for pr-review-worker On its own that change alone would not have been enough, but combined with Fix C below it dropped a representative cycle from "timed out at 30:00" to a target ~2-3min. Pure config change in ``.opencode/agents/pr-review-worker.md``; no code path touched. # Fix C — pre-fetch PR diff in dispatch_review and embed in prompt The reviewer used to spawn a ``git-isolator-util`` subagent, which shelled out to ``git clone``, ``git fetch``, and ``git diff master...HEAD``. That subagent burned 90+ seconds and several token budgets per cycle. ``dispatch_review.py`` now fetches the unified diff via the Forgejo ``/pulls/{n}.diff`` endpoint and embeds it into the worker prompt under an ``UNTRUSTED CONTENT`` fence with explicit BEGIN_PR_DIFF / END_PR_DIFF markers, head_sha pinning, character-count metadata, and END marker redaction to defeat patch-text injection. The worker is instructed to use the embedded diff and skip the isolator subagent entirely when it is present. Falls back to the old path on fetch failure or via the ``REVIEW_DISPATCHER_EMBED_DIFF=0`` env switch. # Cross-cutting bash rules The ``pr-review-worker``'s shell tool calls kept hitting ``permission denied`` because OpenCode's permission engine matches the *raw, unexpanded* command string against allow-globs. Chained commands (``&&``, ``||``, ``;``, ``|``), command substitution (``$(...)``), bare variable assignments, multi-line continuations (``\\\n``), heredocs, and inline ``python3 -c "..."`` strings all contain characters the permission glob cannot span, and were silently denied. Added ``.opencode/instructions/bash-commands.md`` (wired into ``opencode.json`` via the ``instructions`` array so it appends to EVERY agent's system prompt globally), with hard rules + recovery recipes (``printf > /tmp/file`` instead of heredocs; ``printf > /tmp/script.py`` + ``python3 /tmp/script.py`` instead of ``python3 -c``; ``curl -d @/tmp/body.json`` instead of multi-line ``-d '{...}'``). # Pre-commit polish (architect/dev/test review) Surfaced during a chief-architect / principal-developer / senior-test-engineer code review of the uncommitted change: - Schema DDL deduplication (described above under F2). - ``finish_cycle`` INSERT-fallback now preserves ``started_at`` / ``driver_name`` when caller provides them; otherwise stamps a ``synthetic_started_at: true`` flag in the raw blob so cycle-time analytics can exclude rows whose duration was synthesised. - ``bytes=`` → ``chars=`` in the embedded-diff header. The value is ``len(diff_text)`` after ``decode("utf-8")`` — a UTF-8 character count, not a byte count. Off-by-multibyte for non-ASCII patches. - ``scripts/opencode-builder.sh`` mode 644 → 755. - ``.gitignore`` entries for ``.parked-prs.json`` (runtime state for ``tools/park_other_prs.py --restore``) and ``.dispatcher-logs/`` (append-only local pipeline log directory). # Tests (381 passed, 1 skipped) - ``test_opencode_worker.py``: 3 new tests for ``on_poll`` cadence, error swallowing, and backwards-compatible default. - ``test_dispatch_runtime.py``: 7 new tests for ``begin_cycle`` / ``finish_cycle`` semantics, the v4→v5 migration with row preservation, the crash-safe try/finally path, the ``dispatch_one`` → ``run_session_blocking`` ``on_poll`` wiring, and the new ``started_at`` / ``driver_name`` plumbing through the INSERT-fallback branch. - ``test_telemetry_server.py``: 4 new tests for ``in_flight_cycle`` in ``/api/health``, the elapsed-seconds computation, and the ``running_long_worker`` flag. - ``test_telemetry_schema.py``: assertion bumped from v4 → v5 and a new test confirming the cycle tables now allow ``ended_at IS NULL``. - ``test_dispatch_review.py`` (new file): 14 tests for diff fetch (happy path, truncation, HTTP/URL errors, END_PR_DIFF redaction, Forgejo auth scheme), ``_build_diff_section`` (dry-run, env toggle, embedding, fallback), and end-to-end prompt embedding. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-05-07 07:12:45 -04:00
drew	e247c10219	chore(opencode): reconcile providers and agents with agents/final-working ... Imports the source-of-truth tier selector shape (tier-qwen-small/med/ large, tier-kimi) and the explicit-only variable-propagation contract from agents/final-working, while preserving this branch's deterministic merge_drive.py / conflict_drive.py ownership model and the implementer/reviewer claim-release behavior so LLM workers do not race the host drivers. Rebuilds root opencode.json so host-launched OpenCode sees the same live HF endpoints as the devcontainer, and corrects pipeline-agent model pins to the live default CleverThis-15/Qwen3-6-35B-A3B-GGUF-UD-Q3-K-XL after CleverThis-8 was decommissioned. Drops the stale single tier-qwen selector. Telemetry pricing keys are updated to match the new model pin. Scope is intentionally limited to provider/model routing and agent- definition reconciliation; the Tier 2 deterministic dispatchers and their telemetry land in a separate commit. Co-authored-by: Cursor <cursoragent@cursor.com>	2026-05-06 22:41:41 -04:00
brent.edwards	50458d1c9f	ci(opencode.json): change based on Luis's comments	2026-03-05 23:39:16 +00:00
brent.edwards	d4acd05dbf	ci(opencode.json): add file from Luis's suggestions ... https://matrix.to/#/!ZuWYQzDEGWoZeNbfFB:qoto.org/$sLRMR8jNmeXw6FGpwqwG_Kp9PVus4SwlApmCtboYetk?via=qoto.org&via=matrix.org	2026-03-05 23:18:08 +00:00