Applies `ruff format` to the accumulated formatting debt on this branch.
Formatting-only — no behavioral changes. Required for CI/lint's format
gate (`nox -s format -- --check`), which the branch was failing on 288
tracked files that drifted from ruff's canonical style.
In-progress WIP files are intentionally excluded so this commit stays a
clean formatting-only diff.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Five rounds of fresh-eyes review against the b154d480 deterministic
worker-side improvements landed four substantive corrections:
- Sentinel handoff for compliance + preflight (workers read off
disk via implementer_pr_context.py --field; survives tier-agent
prompt summarisation)
- _GATE_STATUS_RE fixed to match real `## [unit_tests] PASS (12s)`
output from local_ci_gate.sh (previously zero gates parsed)
- Preflight timeout returns explicit sentinel (-9999) and the
orchestrator zeros counts so renderer can't show "Persistent
failures: N" alongside the timeout warning
- outcome_synthesised plumbed per-attempt through phase 4 telemetry
Plus a fresh-eyes catch: check_worktree_clean / check_commit_has_issues_closed
return True on git rc != 0 (deliberate "don't conflate masking with
real gap"), but a fully-masked worktree coincidentally with valid
CHANGELOG + CONTRIBUTORS would have produced a confident "PR resolved"
verdict. New check_compliance_gaps_with_masking + masked_checks plumb
through the sentinel; both renderers (module-level + dispatcher's
pointer) hedge the verdict; worker docs instruct inspection of
masked_checks before exiting resolved.
Two new env flags, both default-ON kill-switches:
- IMPLEMENTER_OUTCOME_SYNTHESIS (=0 reverts to UNKNOWN-bucket)
- IMPLEMENTER_COMPLIANCE_GAPS_ENABLED (=0 disables compliance scan;
AND-coupled with escalation since compliance is meaningless
outside the gap-filling flow)
Byte-equivalence holds when all new flags are unset. Test suite
1432 passed, 3 skipped (+~70 new tests across compliance, masking,
synthesis-across-loop, sentinel round-trip, regex fixes, fixtures).
ISSUES CLOSED: #30
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Four changes that move judgment off the LLM and into the dispatcher,
motivated by the live PR #30 escalation pilot (2026-05-12): Tier 0
spent 16 min and gave up on flaky-looking unrelated tests; Tier 2
spent 88 min discovering the PR was already correct and only needed
two compliance entries. Together these collapse the typical
"PR is correct, only needs compliance fixups" case from 88 min on
Kimi to ~5 min on gpt-5-mini at Tier 0.
- Outcome-JSON synthesis in dispatch_implementer
(_synthesize_outcome_if_missing): synthesises a concrete outcome
from terminal_state when the worker emits no contract JSON,
routing the escalation predicate to ESCALATE instead of UNKNOWN.
- Diff-aware gate parser (_diff_aware_gate.py): pure-Python
classifier that splits failing BDD scenarios into related vs.
unrelated to the PR's changed files via a feature-stem heuristic.
- Flaky-test pre-flight (_implementer_gate_preflight.py): runs
local_ci_gate.sh --fast twice and surfaces only the persistent
failures. Off-by-default behind IMPLEMENTER_DISPATCHER_GATE_PREFLIGHT.
- Compliance gap detector (_implementer_compliance.py): deterministic
check of CHANGELOG / CONTRIBUTORS / commit-footer / worktree-clean
state. Result is embedded as a "Compliance gap report" stanza so
the agent fills in known gaps instead of discovering them.
Both prompt stanzas are appended via _append_deterministic_stanzas,
flag-gated, skipped in dry-run, and skipped when no preclone exists.
Flag-off path is byte-equivalent to the pre-feature build.
Suite: 1382 passed, 3 skipped (+59 new tests over 4 modules).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
drew