Commit Graph

2 Commits

Author SHA1 Message Date
hamza.khyari 135481f9a6 fix(resource): address PR #618 review findings (round 1)
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 14s
CI / quality (pull_request) Successful in 18s
CI / build (pull_request) Successful in 16s
CI / unit_tests (pull_request) Failing after 25s
CI / security (pull_request) Successful in 34s
CI / typecheck (pull_request) Successful in 36s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Failing after 25s
CI / integration_tests (pull_request) Failing after 2m19s
CI / benchmark-regression (pull_request) Has been cancelled
- P2-1: Add field_validator('inherits') on ResourceTypeSpec
- P2-2: Remove 'properties' from _COLLECTION_FIELDS (scalar override)
- P2-3: Add behave scenarios for exception rollback paths
- P2-4: Add ordering comment to BUILTIN_TYPES
- P2-5: Define RegistryHost Protocol, remove type:ignore on mixins
- P2-6: Add if_not_exists=True on migration index creation
- P3-1: Use deque.popleft() in get_ancestors for O(1) BFS
- P3-2: Filter private attrs in _to_dict vars() fallback
- P3-3: Replace _handler_cache import with clear_handler_cache()
- P3-4: Add migration downgrade test for m6_004
- P3-5: Extract ResourceDagMixin to _resource_registry_dag.py

All files remain under 500-line CONTRIBUTING limit.
Lint, typecheck, and 85 behave scenarios pass.
2026-03-10 04:06:02 +00:00
hamza.khyari ab4da7804d test(resource): add diff-coverage BDD scenarios for inheritance service and resolver
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 15s
CI / build (pull_request) Successful in 16s
CI / quality (pull_request) Successful in 22s
CI / unit_tests (pull_request) Failing after 26s
CI / security (pull_request) Successful in 35s
CI / typecheck (pull_request) Successful in 37s
CI / docker (pull_request) Has been skipped
CI / coverage (pull_request) Failing after 23s
CI / integration_tests (pull_request) Failing after 2m19s
CI / benchmark-regression (pull_request) Has been cancelled
Add 21 scenarios covering uncovered paths in:
- resource_registry_service.py: register_type inherits validation,
  remove_type guards, resolve_chain, is_subtype_of (76% -> 95%)
- resolver.py: import error, instantiation, protocol check,
  polymorphic chain walk (77% -> 98%)
- _resource_registry_ops.py: exact filter, child type mismatch,
  tree type_filter (95% -> 98%)
- inheritance.py: _merge_dict, resolve_fields gap (96% -> 99%)

Overall project coverage holds at 97%.
2026-03-10 03:39:32 +00:00