1 Commits

Author	SHA1	Message	Date
Luis Mendes	1ffb0fddbe	feat(plan): decision correction recomputes only affected subtree ... Enhanced the CorrectionService to properly isolate correction scope: 1. analyze_impact() now populates excluded_decisions by computing the set difference between all plan decisions and the affected subtree, ensuring root and sibling decisions are tracked. 2. Added rollback_tier computation that counts parent hops from the target decision to the root, enabling depth-aware rollback strategies (tier 0 = root targeted, tier N = N levels deep). 3. Enhanced dry-run report with excluded decisions list, rollback tier, and tier-0 warning when entire tree is affected. 4. Added subtree isolation validation confirming root exclusion and sibling non-contamination for non-root corrections. 5. Fixed status state-machine regression in execute_revert() where analyze_impact() overwrote status back to ANALYZING from EXECUTING. Guard now only transitions to ANALYZING when status is PENDING. execute_revert() now transitions through ANALYZING before EXECUTING for correct lifecycle ordering. 6. Fixed validate_subtree_isolation() to use structural-only BFS for the sibling invariant check, so that influence-DAG-caused sibling reachability is not misreported as an isolation violation (per spec § Affected Subtree Computation). 7. Fixed false-positive cycle-detection warnings from convergent (diamond) topologies by replacing per-node seen_this_round with a global enqueued set in BFS, preventing duplicate queue insertions from different parents. 8. Added dry_run enforcement guard in _assert_executable() to prevent execution of dry-run-only corrections per spec (§ plan correct --dry-run: "Show impact without executing"). 9. Fixed generate_dry_run_report() to preserve request status so that generating a preview does not advance the correction lifecycle (dry-run is non-mutating per spec). Status restoration now uses try/finally to guarantee recovery even when analyze_impact() raises after transitioning the status. 10. Improved cycle-detection log message accuracy to cover both structural tree and influence DAG sources. 11. Extracted cost/time estimation constants (_COST_PER_DECISION, _RECOMPUTE_SECONDS_PER_DECISION) from magic numbers. 12. Added terminal-state guard in analyze_impact() to reject re-analysis after execution (APPLIED/FAILED/CANCELLED/REJECTED), preventing audit-data corruption. Promoted terminal-status set to a module-level _TERMINAL_STATUSES frozenset constant. 13. Added mode validation in execute_revert()/execute_append() to prevent mode-mismatched execution (e.g. calling execute_revert on an APPEND correction). 14. Fixed _collect_all_decisions() to always include the target decision in the universe, preventing broken partition invariant for isolated single-node plans. 15. Fixed tier-0 dry-run warning to only trigger when the target is genuinely in the structural tree (avoiding false warnings for nodes not present in the tree). 16. Removed duplicate as_cli_dict regression scenarios in resource_type_deferred_physical.feature. ISSUES CLOSED: #845	2026-03-23 18:41:53 +00:00