2746 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
HAL9000	4099872acd	fix(events): restore exc_info=True in handler error logging ... The exc_info=True parameter was accidentally removed from the event_handler_failed logging block during a previous formatting cleanup. This restores it to include full exception tracebacks in warning logs, which is required by existing integration tests. Refs: #10378	2026-05-13 12:24:33 +00:00
HAL9000	3459f821c5	fix(events): add close() method to ReactiveEventBus to complete RxPY subject ... Add _closed flag and close() method to ReactiveEventBus to complete the RxPY Subject, preventing subscriber resource leaks. close() is idempotent and raises RuntimeError when called on a closed bus. Also adds: - emit() guard against post-close calls (RuntimeError) - __enter__/__exit__ context manager protocol for automatic cleanup - BDD scenarios in event_bus.feature and TDD tests in tdd_reactive_event_bus_close.feature ISSUES CLOSED: #10378	2026-05-13 12:24:33 +00:00
CoreRasurae	3fcfaee02d	feat(mcp): implement StdioMCPTransport for JSON-RPC 2.0 stdio communication ... Implements concrete StdioMCPTransport class that: - Spawns MCP server as subprocess and communicates via JSON-RPC 2.0 over stdio - Performs MCP handshake (initialize + notifications/initialized) - Supports tools/list and tools/call methods - Uses RLock for thread-safe concurrent access - Auto-selected when transport='stdio' in MCPServerConfig Adds BDD tests for stdio transport covering: - Connection lifecycle and error handling - Tool discovery and invocation - MCPToolAdapter integration ISSUES CLOSED: #4918	2026-05-13 07:13:34 +00:00
HAL9000	3368cba38f	refactor(a2a): execute ACP to A2A module rename and symbol standardization (#10583) ... Executes the systematic ACP -> A2A module rename per ADR-047. - Renamed all legacy ACP references to A2A throughout cleveragents.a2a module - Standardized all 22 exported symbols to A2A naming conventions - Added BDD test suite validating export completeness, zero ACP remnants, and documentation accuracy Closes #10583 Parent Epic: #8569 (A2A Standard Adoption)	2026-05-13 06:49:40 +00:00
HAL9000	09c79eab73	chore(deps): upgrade PyYAML to address known security vulnerability (#9244) ... - Add explicit `pyyaml>=6.0.3` constraint to pyproject.toml dependencies with a security comment - Add a `\#\#\# Security` section to CHANGELOG.md documenting this dependency constraint update - Verify no unsafe yaml.load() calls exist in the codebase Co-authored-by: HAL 9000 <hal9000@cleverthis.com> ISSUES CLOSED: #9055	2026-05-13 06:01:19 +00:00
brent.edwards	8ae754961a	test(noxfile.py): turn off bold and colors (#11172) ... ISSUES CLOSED: #11134 ## Description This turns off bold and colors in the terminal, making the output much easier to find substrings. ## Type of Change - [ X ] Bug fix (non-breaking change which fixes an issue) - [ X ] Test improvements ## Quality Checklist - [ ] Code follows the project's coding standards (see CONTRIBUTING.md) - [ ] All public/protected methods have argument validation - [ ] Static typing is complete (no `Any` unless justified) - [ ] `nox -s typecheck` passes with no errors - [ ] `nox -s lint` passes with no errors - [ ] Unit tests written/updated (Behave scenarios in `features/`) - [ ] Integration tests written/updated (Robot suites in `robot/`) if applicable - [ ] Coverage remains above 85% (`nox -s coverage_report`) - [ ] No security issues introduced (`nox -s security_scan`) - [ ] No dead code introduced (`nox -s dead_code`) - [ ] Documentation updated if behavior changed ## Testing I ran `nox -e unit_tests` locally, and I verified that the seven errors that had existed no longer exist. ### Test Commands Run ```bash nox -s unit_tests # Behave tests nox -s typecheck # Type checking nox -s lint # Linting nox -s coverage_report # Coverage ``` ## Related Issues ISSUES CLOSED: #11134 ## Implementation Notes This change to the terminal had been done outside the program in git.cleverthis.com, so the problems never showed up there. Reviewed-on: #11172 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com>	2026-05-12 21:06:23 +00:00
freemo	9cfa1dd1d7	fix(subplan): propagate invariant_enforced decisions to child plans on spawn ... SubplanService.spawn() now re-records all invariant_enforced decisions from the parent plan decision tree onto each child plan decision tree. This satisfies the spec requirement: 'recorded as invariant_enforced decisions that propagate to child plans.' (Glossary → Invariant) Previously, child plans started Strategize with a completely empty invariant set, violating the spec's propagation requirement. non_overridable global invariants enforced on the parent were not guaranteed to be enforced on child plans. The fix adds _propagate_invariant_decisions() to SubplanService which queries the parent plan's invariant_enforced decisions and re-records each one on the child plan using DecisionService.record_decision(). The DecisionService is already injected into SubplanService, so no new dependencies are required. BDD regression coverage added in features/tdd_invariant_propagation_subplan.feature with 4 scenarios covering: single invariant propagation, multiple invariant propagation, non_overridable invariant propagation, and clean spawn with no parent invariants. ISSUES CLOSED: #9131	2026-05-12 16:45:59 +00:00
CoreRasurae	3b83438e7d	test(actor): add regression test for issue 4321 nested config extraction ... Add BDD regression test for Forgejo issue 4321: ActorRegistry.add() fails to extract provider and model from nested actor config. The test verifies that when type is only at the nested actors map level (not at top level), provider and model are correctly extracted from the nested config block. This scenario is already handled correctly by the _extract_nested_v3_config() function added in commit 78be0887 (issue #4300). The test confirms the fix works as expected and prevents future regressions. Tags: @tdd_issue @tdd_issue_4321 ISSUES CLOSED: #4321	2026-05-12 13:02:59 +00:00
hamza.khyari	1e385b8f61	Merge pull request 'feat(agents): add review-started notification to pr-review-worker' (#11029) from feature/review-started-notification into master ... Reviewed-on: #11029 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com>	2026-05-12 12:29:39 +00:00
hamza.khyari	f37bfa01fe	feat(agents): add review-started notification to pr-review-worker ... Add Step 0 to both first_review and re_review modes — posts a comment on the PR immediately after parameter validation, before any reading or cloning. Gives the PR author instant visibility that a review is in progress. CI flag mode is unchanged (too lightweight to warrant a notification). ISSUES CLOSED: #11028	2026-05-12 12:11:12 +00:00
hamza.khyari	d82f5de2eb	Merge pull request 'feat(agents): add work-started notification to task-implementor' (#11032) from feature/impl-started-notification into master ... Reviewed-on: #11032 Reviewed-by: Rui Hu <rui.hu@cleverthis.com>	2026-05-12 12:06:44 +00:00
CoreRasurae	39bbff0849	feat(agents): add work-started notification to task-implementor ... Add Step 2 (notification) to issue_impl and pr_fix procedures — posts a comment on the issue/PR after reading it but before cloning, giving authors instant visibility that implementation work has started. Also update CHANGELOG.md with entry for #11031. ISSUES CLOSED: #11031	2026-05-12 11:47:15 +00:00
hurui200320	52830971f2	fix(plan): guard cleanup_stale against execute/complete plans awaiting apply ... Bug #11121: _create_sandbox_for_plan() called GitWorktreeSandbox.cleanup_stale() unconditionally, destroying the cleveragents/plan-<id> git branch when agents plan execute was re-invoked on a plan already in execute/complete state (awaiting apply). This caused plan apply to find zero artifacts. Fix: Add a phase/state guard inside _create_sandbox_for_plan() that returns the flat fallback early when the plan is execute/complete, preserving the worktree branch intact for plan apply to merge. - TDD regression test from issue #11120 (without @tdd_expected_fail) - Verified sandbox lifecycle tests still pass ISSUES CLOSED: #11121	2026-05-12 10:17:39 +00:00
hurui200320	9fe69c468c	test(plan): add tdd issue-capture test for cleanup_stale destroying execute output before apply ... Add two Behave scenarios tagged @tdd_issue, @tdd_issue_11121, and @tdd_expected_fail that capture bug #11121: _create_sandbox_for_plan() calls GitWorktreeSandbox.cleanup_stale() unconditionally on every execute invocation, including when the plan is already in execute/complete state awaiting apply. Scenario 1 asserts that the cleveragents/plan-<id> branch survives a second call to _create_sandbox_for_plan() on an execute/complete plan. This assertion fails because cleanup_stale deletes the branch regardless of plan state. Scenario 2 asserts that plan apply would find at least one artifact after a re-invoked execute on an execute/complete plan. This assertion fails because the branch (holding execute output) was destroyed by cleanup_stale. Both scenarios use @tdd_expected_fail so CI passes while the bug is unfixed. The @mock_only tag ensures no database is created for these git-only tests. The companion fix is tracked in issue #11121. Additional CI fixes bundled in this commit: - Fixed PlanGenerationGraph recursion bug: _should_retry() was mutating state in-place but LangGraph conditional edge functions cannot persist state mutations. Replaced with a proper _handle_retry() node that increments retry_count via state returns, resolving the GraphRecursionError that was crashing the integration tests. Updated the graph to include handle_retry as the 5th node, routing validate→should_retry→handle_retry→analyze. - Fixed TDD quality gate (scripts/tdd_quality_gate.py): Renamed @tdd_bug_N tags to @tdd_issue_N to match the CONTRIBUTING.md specification. Added _diff_is_tdd_issue_capture() detection so that TDD issue-capture PRs (which add @tdd_expected_fail rather than remove it) pass the quality gate correctly. Updated all related tests (Behave unit tests, Robot integration tests, and test helpers) to use the new tag naming. ISSUES CLOSED: #11120	2026-05-12 16:57:50 +08:00
hurui200320	d25a060c58	Revert "feat(ci): implement TDD bug tag quality gate for bug fix PRs" ... This reverts commit e8d2f76466.	2026-05-12 08:30:24 +00:00
freemo	d1328e562f	Fix validation bypass for code longer than 10 characters — the length fallback was overriding LLM-based FAIL verdicts and rendering validation ineffective	2026-05-12 02:16:48 +00:00
hurui200320	b4a514e0f4	fix(cli): add spec-required --data-dir, --config-path, and -v global options to main_callback ... Implements ADR-021 §Global CLI Flags and ADR-024 §Resolution Chain. All three global options were missing from main_callback(), causing any invocation with these flags to crash with 'No such option'. Changes: - src/cleveragents/cli/main.py * Add _VERBOSITY_LOG_LEVELS tuple mapping verbose count to log levels (0=CRITICAL/silent, 1=ERROR, 2=WARNING, 3=INFO, 4=DEBUG, 5+=DEBUG) * Add --data-dir PATH option: validates path is a directory if it exists, sets CLEVERAGENTS_DATA_DIR env var, resets Settings singleton * Add --config-path PATH option: validates file exists and is a file, sets CLEVERAGENTS_CONFIG_PATH env var for ConfigService to pick up * Add -v (count=True) option: wires verbose count to configure_structlog * Store all three values in ctx.obj for subcommand access * Update _print_basic_help() to include the three new global options so 'cleveragents --help' (fast path) also lists them * In the catch-all Exception handler, print the original exception type+message directly to err_console so actionable details remain visible even when log level is CRITICAL (e.g. 'No such option') - src/cleveragents/application/services/config_service.py * ConfigService.__init__ now checks CLEVERAGENTS_CONFIG_PATH env var when no explicit config_path is passed, completing the resolution chain for --config-path CLI override Tests (all passing): - features/cli_global_options.feature (21 Behave scenarios) - features/steps/cli_global_options_steps.py - robot/cli_global_options.robot (8 Robot Framework integration tests) - robot/helper_cli_global_options.py Quality gates: lint ✓ typecheck ✓ unit_tests ✓ integration_tests ✓ Coverage: 96.52% (threshold 96.5% ✓) ISSUES CLOSED: #6785	2026-05-12 01:05:10 +00:00
CoreRasurae	e8d2f76466	feat(ci): implement TDD bug tag quality gate for bug fix PRs ... Add an automated quality gate that enforces TDD bug fix workflow rules on pull requests. The gate parses PR descriptions for bug-closing keywords (Closes/Fixes/Resolves #N, ISSUES CLOSED: #N), searches the codebase for corresponding TDD tests tagged @tdd_bug_N, and verifies that @tdd_expected_fail tags have been removed. Key components: - scripts/tdd_quality_gate.py: Main quality gate script with PR description parsing, TDD test discovery, and tag removal verification. All public functions validate arguments fail-fast and are statically typed. - noxfile.py: New tdd_quality_gate session that reads PR_DESCRIPTION from the environment and runs the quality gate script. - .forgejo/workflows/ci.yml: New tdd_quality_gate CI job that runs only on pull_request events, passing the PR body as PR_DESCRIPTION. - features/tdd_quality_gate.feature: 46 Behave scenarios covering PR parsing, TDD test search, tag removal verification, full gate logic, robot diff handling, edge cases, argument validation, bool guards, co-located bug false-positive guard, and main() CLI entry point. - features/steps/tdd_quality_gate_steps.py: Step definitions for all Behave scenarios using temporary directories for isolation. - robot/tdd_quality_gate.robot: 15 Robot Framework integration tests exercising the gate end-to-end via a helper subprocess. - robot/helper_tdd_quality_gate.py: Helper script for Robot tests with sentinel-based sub-commands. Review-round fixes applied: - check_expected_fail_removed now uses _contains_tag_token for word-boundary matching (avoids false positives on partial tag names) - Diff expected-fail removal detection tracks flags at file level instead of per-hunk (fixes false negatives when tags span hunks) - parse_bug_refs filters out issue number zero - Redundant double error reporting eliminated (file-level check short-circuits the diff-level check) - run_quality_gate returns (errors, bug_refs) tuple to avoid redundant re-parsing in main() - Regex compilation cached via functools.lru_cache - Nox session no longer installs the full project (stdlib only) - CI checkout uses fetch-depth: 0 for reliable merge-base resolution Review-round 2 fixes applied: - _diff_has_expected_fail_removal_for_bug now requires the removed line to contain both the expected-fail tag and the specific bug tag (fixes false positives when two bugs share the same test file) - check_expected_fail_removed error messages use the correct tag prefix per file type (@tdd_bug_N for .feature, tdd_bug_N for .robot) - bool values rejected by bug-number validation guards in find_tdd_tests, check_expected_fail_removed, and _diff_has_expected_fail_removal_for_bug - File-read error handling catches UnicodeDecodeError alongside OSError (root-safe unreadable-file handling via invalid-UTF-8 test fixture) - Temp directory cleanup added to after_scenario hook in environment.py - 8 new Behave scenarios: bool type guards (2), co-located bug false-positive regression (1), run_quality_gate argument validation (3), and main() CLI entry point exit codes (2) Review-round 3 fixes applied: - Synthetic PR diff helper (_default_pr_diff_for_bug_refs) now auto-detects .robot vs .feature file type from the temp search tree and generates the matching diff format (fixes under-tested robot-format diff code path in multi-bug integration scenarios) - check_expected_fail_removed test step now filters files by bug tag via find_tdd_tests before checking (matches production path in run_quality_gate) - after_scenario temp directory cleanup no longer sets context.temp_dir = None (fixes cleanup conflict with cli_init_yes_flag_steps.py cleanup functions that run after hooks) - 2 new Behave scenarios: multi-line PR description parsing, and non-string pr_diff type guard for run_quality_gate ISSUES CLOSED: #629	2026-05-12 00:22:49 +01:00
clever-agent	dd763f50d9	build: moved e2e tests to master only yaml	2026-05-11 17:35:41 -04:00
clever-agent	81229422f2	Revert "ci(docker): Ensure CI uses CT docker proxy to workaround Docker ratelimit issues" ... This reverts commit 9c5f19854d.	2026-05-11 17:22:45 -04:00
HAL9000	b692894c88	fix(tests): remove AmbiguousStep conflict in security_pyyaml_dependency_steps ... Duplicate step definitions for 'the pyproject.toml file exists at', 'I read the project dependencies from pyproject.toml', 'I attempt to import the module', and 'the import should succeed without errors' were present in both security_pyyaml_dependency_steps.py and tdd_a2a_sdk_dependency_steps.py, causing a behave.AmbiguousStep error that failed the unit_tests CI gate. Removed the 4 duplicate step definitions from security_pyyaml_dependency_steps.py, keeping only the 3 PyYAML-specific step definitions. The shared steps are now exclusively provided by tdd_a2a_sdk_dependency_steps.py. Also resolved merge conflicts from master in CONTRIBUTORS.md: preserved all master additions (database resource types entry) alongside the existing PyYAML upgrade entry. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	2f01e7d625	fix(tests): resolve lint format failure and harden pyyaml BDD step path resolution ... - Move _flatten_toml_dict to module level: eliminates nested function definition that ruff format reformats unexpectedly; makes the helper independently testable and clearly documented. - Rename helper to _flatten_toml_dict (was _flatten) for unambiguous module-level identity and improved readability. - Add _PROJECT_ROOT constant computed from __file__ so pyproject.toml is always resolved via an absolute path regardless of the process working directory — fixes brittle relative-path lookup that fails when behave-parallel forks workers whose cwd differs from the repo root. - Fix ruff format violations: wrap long assert message, normalise decorator quote style, ensure trailing newline, fix import ordering (behave imports before packaging). - All quality gates pass: lint, format --check, security_scan, dead_code. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	63746b4d30	fix(pyyaml): address CI review feedback from PR #11012 ... - Fix ruff lint F541 error: remove unnecessary f-string prefix - Remove dead step_uv_lock_specifier step (never called by BDD scenarios) - Update CONTRIBUTORS.md to reference correct PR number (#11012 not #9244) ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	05acc26c40	chore(deps): upgrade PyYAML to address known security vulnerability ... - Added `pyyaml>=6.0.3` dependency constraint to pyproject.toml after aiohttp to prevent installation of vulnerable older versions with known YAML parsing security issues. - Updated uv.lock package dependencies and requires-dist to include pyyaml entry with specifier '>=6.0.3'. - Added changelog Security section entry under [Unreleased] documenting the upgrade for issue #9055. - Updated CONTRIBUTORS.md with contribution note (PR #9244). - Added BDD test scenario verifying PyYAML security dependency constraint. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	a1ea40d2e7	feat(plans): implement agents plan rollback command for checkpoint-based rollback ... Documents the agents plan rollback command (CLI entry at src/cleveragents/cli/commands/plan.py) that was integrated into master under Epic #8493. The command provides checkpoint-based plan state restoration, allowing plans to be restored to a previous checkpoint and resuming execution from that point. CHANGELOG.md entry added under [Unreleased] > ### Added section; CONTRIBUTORS.md updated with HAL 9000's contribution for this checkpoint-based rollback feature. ISSUES CLOSED: #8557 Epic: #8493	2026-05-11 06:54:32 +00:00
hurui200320	87a7ce35d7	feat(session): implement real LLM actor invocation in session tell ... Replace the M3 stub in `agents session tell` with real orchestrator actor invocation via `SessionWorkflow.tell()`. The stub echoed a canned `Acknowledged: ...` response without calling any LLM or actor; this commit wires up the full pipeline: Architecture: - New `SessionWorkflow` (Application layer) orchestrates LLM invocation for session tell. Accepts a `ProviderRegistry` and `ToolRegistry`; falls back to `FakeListLLM` when no provider is configured. - `LangChainSessionCaller` implements the `LLMCaller` protocol, building history-aware LangChain message lists from the session conversation and invoking the LLM via `ToolCallingRuntime.run_tool_loop()`. - `TellResult` (Pydantic BaseModel) carries the assistant response plus token usage (input_tokens, output_tokens, cost_usd, duration_ms). Domain / service layer: - `SessionActorNotConfiguredError` added to the session domain model; raised when tell is invoked with no actor on the session and no `--actor` override. Clear message; CLI exits with code 1. - `SessionService.get_messages()` abstract method added (+ implementation in `PersistentSessionService`) to load ordered message history. A2A facade: - `A2aLocalFacade` gains `message/send` and `message/stream` standard A2A operation handlers that route to `SessionWorkflow.tell()`. Total supported operations count: 42 → 44. CLI: - `session tell` command delegates to `_build_session_workflow()` (patchable factory) instead of directly calling `SessionService`. - Non-streaming: `SessionWorkflow.tell()` returns `TellResult`; output includes a Usage panel (Rich/Plain) or a `usage` object (JSON/YAML). - Streaming: `SessionWorkflow.tell_stream()` yields tokens; CLI prints them via `console.print` (not raw `sys.stdout.write`). - Token usage recorded via `SessionService.update_token_usage()` in both paths. Tests: - New Behave feature `session_tell_llm.feature` (4 scenarios): real LLM response persisted; streaming yields tokens; no-actor exits code 1; `--actor` override resolves correctly. - New Robot suite `session_tell_llm.robot` (4 tests): end-to-end with stub LLM injected via monkey-patching `_resolve_llm`. - Updated all existing `session tell` test steps to patch `_build_session_workflow` returning a mock `TellResult` so tests remain isolated from the LLM layer. - Updated operation-count assertions (42 → 44) in `a2a_cli_facade_integration`, `consolidated_misc`, `m6_autonomy_acceptance` feature files and steps. Cycle 7 (Review ID 8088) fixes: - Blocker 4: Split `session_workflow.py` (was 801 lines) into two files: `session_workflow.py` (467 lines) and `session_caller.py` (318 lines). Extracted: `LangChainSessionCaller`, `extract_content`, `extract_token_usage`, `estimate_cost`, `estimate_tokens`, `history_to_langchain_messages`, and stub classes. - Blocker 5: Route CLI streaming path through `_facade_dispatch("message/stream", ...)` instead of directly calling `workflow.tell_stream()`. The facade's `_handle_message_stream` falls back to non-streaming with `streamed: false` (acceptable for this milestone per the spec). - Updated streaming test assertion to validate full response presence (no longer checks token-by-token word positions, since the facade fallback returns a complete message). ISSUES CLOSED: #5784	2026-05-11 04:39:29 +00:00
CoreRasurae	78be08870c	fix(cli): validate actor provider field at correct config nesting level ... - Actor configuration in V3 is now obtained from the nested configuration parameter, according to the specification. - Removed the legacy V2 fallback support and the tests affected by that removal. Mocked existing steps to allow remaining V2 features to be covered/tested. - Fix add() to pass unsafe flag to add_v3() for proper unsafe actor handling - Add _extract_nested_v3_config() to extract provider/model from nested actors.<name>.config block before v3 schema validation - Remove v2 extraction test scenarios from consolidated_actor.feature that call removed _extract_v2_actor() and _extract_v2_options() methods - Update test YAML in actor_registry_spec_yaml_steps.py to exercise nested type detection (no top-level type field) - Add @tdd_issue_4300 regression test tag to existing spec-compliant actors map scenario ISSUES CLOSED: #4300	2026-05-09 23:13:33 +01:00
HAL9000	5ee08ea946	fix(plan): remove TDD expected fail tag and fix format violations ... - Remove @tdd_expected_fail from Tree with json format scenario in plan_explain.feature (bug is now fixed by the envelope implementation) - Update scenario assertions to verify new spec-required envelope format instead of old bare-array format - Add step_tree_json_valid_envelope step definition in plan_explain_steps.py - Fix ruff format violation in plan_explain_cli_coverage_steps.py ISSUES CLOSED: #9163	2026-05-09 12:23:24 +00:00
HAL9000	6e1646d565	fix(plan): wrap plan tree JSON/YAML output in spec-required command envelope.\n\nISSUES CLOSED: #9163 ... # Conflicts: # CONTRIBUTORS.md	2026-05-09 12:23:24 +00:00
HAL9000	815f546bd2	fix(plan): wrap plan tree JSON/YAML output in spec-required command envelope.	2026-05-09 12:23:24 +00:00
HAL9000	f78c1c2c98	docs(resources): correct CHANGELOG entry to accurately describe DatabaseResourceHandler ... Replace the factual inaccuracy claiming a PostgreSQL resource subclass with accurate description of the unified DatabaseResourceHandler design. The PR description and all code use a unified handler pattern with type-specific routing via PostgreSQL, MySQL, SQLite, and DuckDB type definitions - there is no PostgreSQLResource subclass anywhere in the codebase. This fix was requested in review #8172.	2026-05-09 10:01:20 +00:00
HAL9000	3f0ce3d20a	feat(resources): add CHANGELOG and CONTRIBUTORS entries for PR #10591 ... - Add CHANGELOG.md entry under [Unreleased] / Database resource types (PostgreSQL, SQLite) with transaction-based sandbox strategy (issues #8608, Epic #8568) - Update CONTRIBUTORS.md with HAL 9000 contribution note for database resource types implementation ISSUES CLOSED: #8608	2026-05-09 10:01:20 +00:00
HAL9000	2cba7d41bc	chore(agents): fix bug-hunt-pool-supervisor tracking prefix AUTO-BUG-POOL to AUTO-BUG-SUP (complete fix) ... Replace all remaining AUTO-BUG-POOL references with correct AUTO-BUG-SUP in agent-system-specification.md, automation-tracking.md documentation and agent-system-specification.md spec document, replaced with correct `AUTO-BUG-SUP` prefix used by the bug-hunt-pool-supervisor agent (#7875). ISSUES CLOSED: #7875	2026-05-09 00:05:17 +00:00
HAL9000	57881a075b	docs(spec): update specification — validation gate blocks on empty validation summary	2026-05-08 19:14:24 +00:00
HAL9000	af6e54f0b2	fix(tests): reformat pr_compliance_pool_supervisor_steps.py and fix pre-existing lint errors ... - ruff format: multiline AGENT_DEF_PATH assignment, compress all() comprehension, add blank line before decorator block — fixes CI / unit_tests lint failure - ruff --fix: remove unused imports from tests/actor/test_registry_builtin_yaml.py (pre-existing F401 errors on master) ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	addbc51dc4	fix(tests): fix lint violation UP035 and match feature file step text to Pool: prefixes ... - B5 (lint): changed 'from typing import Any, Callable' to 'from collections.abc import Callable' per ruff UP035 rule - B7 (step mismatch): added 'Pool: ' prefix to all Then/And steps in pr_compliance_pool_supervisor.feature to match step definition decorators ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	96670720f0	fix(tests): resolve Behave AmbiguousStep conflict in pool-supervisor steps ... The pr_compliance_pool_supervisor_steps.py file defined @then step texts identical to those in the pre-existing pr_compliance_checklist_steps.py, causing Behave's ambiguous-step detection to reject the test run. Fix: prefix all pool-supervisor @then decorators with 'Pool:' so they're uniquely identifiable by Behave while reusing the same validator logic. Also fix PROJECT_ROOT from parents[3] -> parents[2] for correct repo root resolution in step files located at features/steps/. ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	fbe6308200	feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor ... Add a new implementation-pool-supervisor agent definition with an embedded 8-item PR Compliance Checklist. Workers dispatched by the pool supervisor must complete all 8 items before creating any PR: CHANGELOG.md update, CONTRIBUTORS.md update, commit footer (ISSUES CLOSED: #N), CI verification, BDD tests, Epic reference, label application via forgejo-label-manager, and milestone assignment. Includes concrete markdown examples for each subsection and compliance verification pseudocode. Also adds BDD test coverage (pr_compliance_pool_supervisor.feature + steps) to verify the pool supervisor agent definition contains all 8 checklist items. Parent Epic: #9779 ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	e8996d66d7	test(core): fix ASV benchmark timing methodology and remove unused imports ... - Remove unused `from typing import Any` import from core_retry_patterns_bench.py - Refactor CircuitBreakerStateTransitionBench into three separate benchmark classes (CircuitBreakerClosedToOpenTransitionBench, CircuitBreakerOpenToHalfOpenTransitionBench, CircuitBreakerHalfOpenToClosedTransitionBench), each with a proper setup() method that pre-creates the CircuitBreaker in the correct initial state so only the transition itself is measured - Move open-state CircuitBreaker creation for async fast-fail benchmark into setup() in CircuitBreakerAsyncBench, eliminating instance creation overhead from the timed method Addresses reviewer feedback on PR #10961.	2026-05-08 14:21:41 +00:00
HAL9000	9aa966cdaa	fix(bench): correct API usage and formatting in core ASV benchmark files ... - Fix get_retry_decorator() calls to use category string instead of keyword arguments (max_attempts, base_delay, etc.) - Fix retry_on_result() calls to pass required predicate argument - Fix retry_service_operation() to use circuit_breaker= (CircuitBreaker instance) instead of use_circuit_breaker= (bool), and backoff_strategy= instead of wait_strategy= - Fix is_read_only_plan_operation() calls to pass dict instead of string - Fix RetryContext() to use operation_name= instead of service_name=, remove non-existent use_circuit_breaker and attempt_count constructor params - Fix retry_auto_debug() to use max_debug_attempts= instead of service_name=/operation_name= (which are not valid parameters) - Remove unused Any import from core_circuit_breaker_bench.py - Apply ruff format to all three benchmark files to fix CI format check	2026-05-08 14:21:41 +00:00
HAL9000	ffd83e8712	test(core): add ASV performance benchmarks for core module ... Added three new ASV benchmark suites for the core module: 1. core_circuit_breaker_bench.py - Benchmarks for CircuitBreaker class: - Closed state call overhead - Open state fast-fail latency - State transition overhead (closed→open, open→half-open, half-open→closed) - Async operations - Initialization overhead 2. core_retry_patterns_bench.py - Benchmarks for retry decorators: - Decorator construction overhead for exponential backoff, jitter, timeout, and result-based retry - Happy-path invocation overhead - Async decorator operations - Decorator usage with function arguments - Factory function performance - Various configuration scenarios 3. core_retry_service_patterns_bench.py - Benchmarks for service-level retry: - retry_service_operation decorator construction and invocation - retry_auto_debug decorator performance - RetryContext operations - is_read_only_plan_operation utility - Different wait strategies (exponential, linear, fixed, jitter) These benchmarks ensure latency regressions in core resilience primitives are caught early. ISSUES CLOSED: #1921	2026-05-08 14:21:41 +00:00
HAL9000	3f8f8eb0bf	docs(agents): add State/In Review and Priority labels to pr-creator ... ISSUES CLOSED: #8520	2026-05-08 13:22:11 +00:00
hamza.khyari	a79d22642a	docs(tui): document MULTILINE limitation and spec reference in _PromptSymbolMixin ... The spec (§29257) refers to 'PromptTextArea' implying a multi-line TextArea widget, but TextArea.__init__() dropped the placeholder kwarg in textual >=1.0. This implementation uses Input (single-line) as a workaround. MULTILINE mode detection works via content inspection but the widget cannot display multiple lines. Document this gap and reference the spec sections for future migration.	2026-05-08 11:15:36 +00:00
HAL9000	b588de18d6	fix(tui): rebase onto master and add CHANGELOG entry for prompt symbol fix (#6431) ... Rebases the TUI prompt symbol fix onto the latest master, resolving conflicts with the TextArea→Input refactor and the dollar-prefix shell mode addition. Adds the missing CHANGELOG.md entry for #6431 and removes the now-obsolete tui_prompt_textarea feature/steps that tested the old TextArea-based implementation. ISSUES CLOSED: #6431	2026-05-08 11:15:36 +00:00
HAL9000	a130d63357	docs(timeline): update schedule adherence Day 101 (2026-04-12) (#7858)	2026-05-08 10:21:23 +00:00
HAL9000	a15b77f6a6	fix(acms): normalize context path matching for absolute paths in _path_matches ... Fixes issue #10972 where _path_matches() used PurePath.full_match()/match() which requires the entire path to match. Since fragment metadata stores absolute paths (e.g. /app/.opencode/skills/SKILL.md) while project context --exclude-path/--include-path settings produce relative globs (.opencode/*, docs/*), include/exclude filters were silently ineffective. Added _matches_any() static helper in execute_phase_context_assembler.py that: - Tries full_match(pattern) as-is for relative paths and anchored patterns - Auto-prefixes relative patterns with **/ so they match absolute paths Updated _matches_pattern() in context_phase_analysis.py with same logic plus zero-depth compatibility shim. Added 7 new BDD regression scenarios with @tdd_issue tags: - 5 in execute_phase_context_assembler_coverage.feature (absolute path matching) - 1 extra trailing ** glob exclusion test - 1 in project_context_phase_analysis.feature (phase analysis exclusion) ISSUES CLOSED: #10972	2026-05-08 09:57:18 +00:00
HAL9000	5b6224daa8	fix(plugins): prevent arbitrary code execution in PluginLoader.validate_protocol() ... - Add guard in TypeError fallback path: raise ProtocolMismatchError when issubclass raises TypeError and protocol has no inspectable members, preventing silent True return for unverifiable protocols - Update test scenario descriptions to accurately reflect the new implementation (no instantiation occurs at any point) - Update step definition comments to remove references to old instantiation-based code paths ISSUES CLOSED: #7418	2026-05-08 09:32:29 +00:00
HAL9000	c58ceb7918	fix(plugins): strengthen validate_protocol structural check and satisfy linter	2026-05-08 09:32:29 +00:00
freemo	c84ae3bb96	fix(plugins): prevent arbitrary code execution in PluginLoader.validate_protocol() ... Fixes #7418 - Security vulnerability where PluginLoader.validate_protocol() instantiated arbitrary plugin classes with no-arg constructor, allowing arbitrary code execution during validation. Changes: - Reversed validation order: use issubclass() first (safe, no instantiation) - Only instantiate if structural check is insufficient - Prevents constructor code execution from untrusted plugins - Maintains protocol validation functionality This prevents RCE attacks via malicious plugin constructors during the validation phase.	2026-05-08 09:32:29 +00:00
HAL9000	883ec872e2	fix(CI): resolve remaining lint/format violations in PR #8722 ... - Apply ruff format to features/steps/strategize_decision_recording_steps.py: expanded single-line set literal to multi-line canonical form (PEP 87) This was the sole remaining CI lint blocker per review cycle 14. - Remove unused imports from tests/actor/test_registry_builtin_yaml.py: removed 'Settings' and 'ProviderRegistry' to fix F401 errors. These were pre-existing violations caught by ruff check. ISSUES CLOSED: #8522 Closes: #8722	2026-05-08 06:24:23 +00:00