7 Commits

Author	SHA1	Message	Date
freemo	8ea00f5185	fix: restore CI quality tests to passing state (#4175) ... Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-08 11:02:14 +00:00
brent.edwards	01b6eb1804	feat(autonomy): parallel execution scales to 10+ concurrent subplans (#1201) ... ## Summary Add M6 parallel-scaling coverage for 10+ concurrent subplans: - **15-subplan parallel scenario** with explicit peak-concurrency bound checks (`max_parallel=10`) and thread-safe concurrency tracking via `_build_executor()`. - **Deep hierarchical decomposition** coverage (4+ levels) with adjusted leaf condition that only stops early when hitting `max_depth` or when the workset is trivially small (`min_files_per_subplan`). - **Non-progress guard** in `_build_hierarchy` to prevent pathological recursion when clustering cannot meaningfully split the file set. - **Small-project regression test** (< 50 files) verifying decomposition depth does not increase unexpectedly with the relaxed leaf condition. - **ASV benchmark** for 15-subplan parallel execution with `max_parallel=10` to track scaling behavior. ### Removed from this PR The `_build_hierarchy` child-linkage correctness fix (returning `node_id` from recursive calls instead of using `nodes[-1].node_id`) has been **removed** per review feedback — it is a separate bug fix and will be submitted as an independent issue/PR per CONTRIBUTING.md §Atomic Commits. ## Approach - **Concurrency tracking:** The `_build_executor()` closure in step definitions detects `context.concurrency_counter` / `context.concurrency_lock` and performs thread-safe peak tracking in a try/finally block. - **Leaf condition:** Replaced the `max_files_per_subplan` / `max_tokens_per_subplan` leaf check with a `min_files_per_subplan` check to allow deeper decomposition for large projects. Added a non-progress guard so clustering that cannot split the file set terminates immediately rather than recursing to `max_depth`. - **Deterministic IDs:** `_ids_for_count()` preserves legacy fixed IDs for the first 5 subplans and generates additional deterministic IDs for scale scenarios. ## Validation ### Passing - `nox -s lint` — all checks passed - `nox -s typecheck` — 0 errors, 0 warnings - `nox -s unit_tests` — 12,988 scenarios passed, 0 failed - `nox -s coverage_report` — 97% (passes `--fail-under=97`) Closes #855 Reviewed-on: #1201 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-31 23:57:39 +00:00
brent.edwards	3eecb79003	test(plan): TDD failing tests for checkpoint real rollback (bug #822) ... TDD expected-fail tests proving bug #822 exists: CheckpointService.rollback_to_checkpoint() returns a successful RollbackResult but does not execute git reset --hard. Files modified after the checkpoint remain unchanged after rollback. Also fixes Robot Framework timeout robustness across the entire test suite: all Run Process calls now use on_timeout=kill (prevents SIGTERM-induced -15 exit codes under CI load) and timeouts increased to 120s (prevents premature kills during heavy parallel execution). ISSUES CLOSED: #839	2026-03-16 01:45:50 +00:00
freemo	5f07316641	fix: wire DI persistence and plan execute/apply for M1 lifecycle ... Fixed 5 bugs preventing the M1 E2E acceptance test from passing: 1. _get_lifecycle_service() in action.py and plan.py bypassed the DI container, creating PlanLifecycleService without UnitOfWork. All plan/action data was in-memory only and lost between subprocess calls. Now uses container.plan_lifecycle_service() for DB persistence. 2. `plan execute` CLI only called service.execute_plan() (a pure state transition) without running PlanExecutor phase processing. Rewrote to detect the plan's current phase/state and dispatch synchronously: Strategize/queued → run_strategize(), Strategize/complete → transition + run_execute(), Execute/queued → run_execute(). 3. `plan apply` CLI had no plan_id argument. Added optional positional plan_id with _lifecycle_apply_with_id() that drives the plan through Apply/queued → Apply/processing → Apply/applied. 4. Preflight guardrail in start_strategize() built action_registry from the in-memory _actions dict only. Added get_action(plan.action_name) call to load the action from DB into cache before the guardrail check. 5. Robot Framework Create File syntax used continuation lines producing 9 arguments instead of 1. Fixed to use Catenate SEPARATOR=\n then pass single variable to Create File. Also fixed --branch main to --branch master (git init default). update mocks for execute_plan CLI changes across unit and integration tests The new execute_plan() command calls _get_plan_executor() and service.get_plan(plan_id) for phase/state detection. Existing tests only mocked _get_lifecycle_service, so MagicMock defaults caused phase/state comparisons to fail. Changes across 14 files: - Patch _get_plan_executor in all test setups that invoke the CLI execute command (Behave step files + Robot helper scripts) - Set service.get_plan.return_value to real Plan objects with correct phase/state so the execute_plan dispatch logic works - Fix error-path tests to use STRATEGIZE/COMPLETE plans so the error side_effects are actually reached - Fix "Multiple plans eligible" → "Multiple plans ready" message text to match existing test expectations increase Robot Framework subprocess timeouts for CI resource contention Three integration tests were timing out in CI due to resource contention when pabot runs multiple test suites in parallel. All three pass locally and the timeouts were simply too tight for constrained CI environments. - tdd_session_create_di.robot: 30s → 90s (DI container init + DB setup) - database_integration.robot: 60s → 120s (Run Python Script keyword) - m3_e2e_verification.robot: 60s → 120s (correction-live-revert spawns 3 sequential CLI subprocesses with full container initialization) ISSUES CLOSED: #789	2026-03-15 20:50:02 +00:00
hurui200320	cb1403c24d	test(e2e): validate M3 acceptance criteria for v3.2.0 milestone closure (#559) ... ## Summary Validates all 10 M3 (v3.2.0) acceptance criteria via the E2E verification suite. This is the final gate before closing milestone v3.2.0. ### Single Commit (Squashed per CONTRIBUTING.md) Branch history was squashed from 2 commits into 1 (`e1665c6e`) to comply with the one-commit-per-issue rule. The single commit includes: 1. **Original work**: Suite-level Force Tags, per-test acceptance criteria tags, enhanced documentation with milestone cross-references, CHANGELOG and CONTRIBUTORS entries. 2. **Review feedback fixes** (addressing Luis's CRITICAL/HIGH findings): Replaced fixture-self-assertion patterns with real CLI-path validation for all 10 acceptance criteria, added persistence-backed decision tree checks, robust JSON output parsing, explicit Robot process timeouts, and clearer correction tags. 3. **Rebase onto current master** (`fff6bb38`): Clean rebase resolving CHANGELOG conflict, as requested by PM (freemo). 4. **Bug fix — `async_enabled` attribute**: `PlanLifecycleService.execute_plan()` accesses `self.settings.async_enabled` (`plan_lifecycle_service.py:283`). The test helper's `_make_settings()` used `create_autospec(Settings)` but didn't set this attribute, causing `plan execute` CLI tests to fail with `AttributeError`. Fixed by adding `settings.async_enabled = False`. 5. **Timeout fixes for parallel execution**: When `pabot` runs 16 parallel Robot processes, cold-start import times + Alembic migrations cause 30s timeouts to be insufficient. Increased timeouts from 30s to 120s in 3 robot files: `actor_context_management.robot`, `decision_di_wiring_smoke.robot`, `changeset_persistence.robot`. ### Files Changed (7) | File | Change | |------|--------| | `robot/helper_m3_e2e_verification.py` | Rewritten for real CLI-path validation; `_make_settings()` fixed with `async_enabled = False` | | `robot/m3_e2e_verification.robot` | Force Tags, per-test tags, timeouts, enhanced docs | | `robot/actor_context_management.robot` | Timeout 30s → 120s (line 92) | | `robot/decision_di_wiring_smoke.robot` | Timeout 30s → 120s (lines 14, 21) | | `robot/changeset_persistence.robot` | `${TIMEOUT}` 30s → 120s (line 12) | | `CHANGELOG.md` | Entry for #494 | | `CONTRIBUTORS.md` | Added Rui Hu | ### Acceptance Criteria Verified (10/10) **Success Criteria:** - `plan use` + `plan execute` generates decisions during Strategize - `plan tree` displays decision tree correctly (via CLI invocation) - `plan explain` shows full decision context (via CLI invocation) - `invariant add --project` / `invariant list --project` work with project scope - `plan correct --dry-run` performs impact analysis (via CLI invocation) - `plan correct --mode=revert` executes live correction (via CLI invocation) **Technical Criteria:** - Decisions recorded with full context snapshot - Decision tree persists to database and renders correctly - Correction in revert mode re-executes from decision point - Invariants enforced during strategize ### Quality Gates (Full Nox Suite) | Session | Result | Details | |---------|--------|---------| | `lint` | PASS | ruff clean | | `format` | PASS | ruff format clean | | `typecheck` | PASS | pyright 0 errors, 0 warnings | | `security_scan` | PASS | bandit clean | | `dead_code` | PASS | vulture clean | | `unit_tests` | PASS | 8500 BDD scenarios, 0 failures | | `integration_tests` | PASS | 1194/1194 tests, 0 failures | | `docs` | PASS | mkdocs build clean | | `build` | PASS | wheel built | | `benchmark` | PASS | performance benchmarks pass | | `coverage_report` | PASS | 96.96% → rounds to 97% (meets `--fail-under=97`) | Closes #494 Reviewed-on: #559 Reviewed-by: Luis Mendes <luis.mendes@cleverthis.com> Co-authored-by: Rui Hu <rui.hu@cleverthis.com> Co-committed-by: Rui Hu <rui.hu@cleverthis.com>	2026-03-05 15:09:19 +00:00
brent.edwards	4f079c20ea	fix(test): route M3 E2E subcommands through CLI rendering path ... - decision-tree-view, decision-explain, and decision-tree-persistence now invoke 'plan status --format plain' via mocked lifecycle service so regressions in CLI rendering/serialization are caught - plan-generates-decisions now asserts use_action was called by the CLI and verifies plan status renders the strategize phase after creation - Updated robot test case documentation to reflect CLI integration	2026-02-26 01:26:02 +00:00
brent.edwards	aeb5cc5110	test(e2e): verify M3 success criteria — decision tree and correction ... Robot Framework E2E test suite for M3 milestone verification covering: - Plan execution generating decisions during Strategize phase - Decision tree viewing with parent-child relationships and BFS traversal - Decision explanation with full context snapshot verification - Invariant add/list via CLI and InvariantService with scope filtering - Dry-run correction via CorrectionService with impact analysis - Live revert correction execution with decision re-creation - Context snapshot round-trip serialisation assertions - Decision tree persistence via model_dump/model_validate - Correction revert re-execution from decision point - Invariant enforcement during strategize with merge precedence ISSUES CLOSED: #404	2026-02-25 21:15:29 +00:00