test/cli-docstring-example-validation
2 Commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
|
|
9f62f9c9c8 |
fix(skills): replace get_tool() calls with get() in SkillRegistry validation methods
CI / lint (pull_request) Failing after 20s
CI / quality (pull_request) Successful in 34s
CI / typecheck (pull_request) Successful in 46s
CI / security (pull_request) Successful in 55s
CI / coverage (pull_request) Has been skipped
CI / build (pull_request) Successful in 17s
CI / helm (pull_request) Successful in 24s
CI / unit_tests (pull_request) Failing after 6m45s
CI / docker (pull_request) Has been skipped
CI / e2e_tests (pull_request) Successful in 17m43s
CI / integration_tests (pull_request) Successful in 22m51s
CI / status-check (pull_request) Failing after 1s
CI / benchmark-publish (pull_request) Has been skipped
CI / benchmark-regression (pull_request) Has been skipped
SkillRegistry.validate_plan() and validate_skill() called the non-existent ToolRegistry.get_tool() method, causing AttributeError at runtime. The correct method is ToolRegistry.get(), which is already used by SkillRegistry.refresh(). Changes: - Replace self._tool_registry.get_tool(entry.name) with self._tool_registry.get(entry.name) in validate_plan() - Replace self._tool_registry.get_tool(ref) with self._tool_registry.get(ref) in validate_skill() - Update Behave BDD tests to use mock.get instead of mock.get_tool - Add new BDD scenarios covering validate_skill() happy path, not-found path, unregistered include path, and no-tool-registry path - Remove stale get_tool mock setup from test helpers ISSUES CLOSED: #2914 |
||
|
|
a808c395f9 |
test(coverage): add Behave BDD tests to improve unit test coverage across 53 source modules
CI / benchmark-publish (pull_request) Has been skipped
CI / lint (pull_request) Successful in 15s
CI / build (pull_request) Successful in 15s
CI / quality (pull_request) Successful in 17s
CI / typecheck (pull_request) Successful in 35s
CI / security (pull_request) Successful in 50s
CI / unit_tests (pull_request) Successful in 2m46s
CI / integration_tests (pull_request) Successful in 3m16s
CI / docker (pull_request) Successful in 40s
CI / coverage (pull_request) Successful in 5m6s
CI / lint (push) Successful in 13s
CI / quality (push) Successful in 16s
CI / build (push) Successful in 18s
CI / security (push) Successful in 32s
CI / typecheck (push) Successful in 35s
CI / benchmark-regression (push) Has been skipped
CI / unit_tests (push) Successful in 2m52s
CI / integration_tests (push) Successful in 3m8s
CI / docker (push) Successful in 39s
CI / coverage (push) Successful in 5m53s
CI / benchmark-publish (push) Successful in 16m55s
CI / benchmark-regression (pull_request) Successful in 33m0s
Add 53 new .feature files and corresponding step definition files targeting uncovered lines identified in build/coverage.xml. Fix AmbiguousStep conflicts in 7 pre-existing step files by disambiguating step text. New tests cover: ACP clients/facade, actor CLI/config, application container, ACMS service/strategies, async worker, automation profile CLI, autonomy guardrail, bridge, change model, config CLI/service, context service, cross-plan correction, database models, decision service, decomposition clustering/service, discovery handler, langchain chat provider, langgraph nodes, materializers, multi-project service, plan apply/CLI/lifecycle/model/ preflight/resume/service, PostgreSQL analyzer, project CLI/context CLI, provider registry, reactive application/route, repositories, resolver handler, resource registry service, resume model, retry patterns, sandbox protocol, server CLI, skill CLI/service, skills registry, subplan execution/service, system CLI, UKO loader, UoW, and YAML template engine. Closes #645 |