5 Commits

Author	SHA1	Message	Date
freemo	e201aa07c9	fix(resource): add overlay to ResourceTypeConfigSchema._VALID_STRATEGIES ... Implemented test coverage and documentation updates to ensure overlay is properly recognized and communicated across the sandbox strategy validation surface. - Verification: Confirmed that overlay already exists in the _VALID_STRATEGIES frozenset within src/cleveragents/resource/schema.py (introduced in a prior commit that closed issue #2827). - Comprehensive audit: Audited strategy validation points to ensure consistency: - _VALID_STRATEGIES in schema.py - _IMPLEMENTED_STRATEGIES and _SUPPORTED_STRATEGIES in factory.py - SandboxStrategy enum definitions in both resource.py and resource_type.py All include overlay as an allowed strategy. - Tests: Added a new BDD scenario titled: "Invalid sandbox_strategy error message lists overlay as allowed" to features/consolidated_resource.feature. This asserts that validation errors explicitly list overlay among the allowed values when an invalid strategy is used. - Documentation: Updated docstring in src/cleveragents/infrastructure/sandbox/strategy_registry.py to reflect that the built-in SandboxFactory handles six strategies, including snapshot and overlay. - Design considerations: The fix itself was already applied in a previous commit (dbf3b8d7) addressing #2827. Issue #3614, raised by the UAT bot, required additional test coverage and accurate documentation of the available strategies. - Impact: No behavioral changes beyond ensuring test coverage and documentation are aligned with the existing implementation. The added test guarantees that error messages remain accurate and comprehensive as strategies evolve. - Affected areas: resource/schema.py, factory.py, resource.py, resource_type.py, features/consolidated_resource.feature, strategy_registry.py. ISSUES CLOSED: #3614	2026-05-30 16:14:46 -04:00
hamza.khyari	bdd1ea4f3a	fix(checkpoint): wire CheckpointManager into PlanExecutor execution path ... CheckpointManager was never wired into PlanExecutor — the CLI factory constructed PlanExecutor without a checkpoint_manager (defaulted to None), silently skipping all checkpoint hooks. Fix: - Register CheckpointManager as Singleton in DI container - Resolve container singleton in _get_plan_executor() and pass to PlanExecutor constructor - Bridge infra→domain: _try_create_checkpoint() now persists last_checkpoint_id on the plan via _commit_plan(), raises PlanError if persistence fails - Default checkpointable=True for writable+sandboxable resources and write-capable tools (model_validators on ResourceCapabilities and ToolCapability) - Validate that non-writable/non-sandboxable resources cannot be checkpointable (ValueError guard) - Add post-execute A2A facade notification using plan.status to avoid duplicate execute→execute transition errors Tests: - 10 Behave scenarios covering DI wiring, singleton identity, checkpoint creation, plan metadata update, rollback, graceful fallback, no-arg constructor, capability defaults (positive + 2 negative) - Updated consolidated_resource, consolidated_skill, and Robot helper_skill_flatten for new checkpointable defaults ISSUES CLOSED: #1253	2026-04-17 11:46:38 +00:00
freemo	dbf3b8d7f7	fix(resources): remove overlay from SandboxStrategy enum - not in spec ... Add 'overlay' to _VALID_STRATEGIES frozenset in ResourceTypeConfigSchema validator so that resource type YAML configs specifying sandbox_strategy: overlay are accepted without raising ValueError. The overlay strategy is defined in the specification for fs-mount resources using OverlayFS. The domain model SandboxStrategy enum correctly includes OVERLAY = 'overlay', but the YAML schema validator in src/cleveragents/resource/schema.py was missing it from _VALID_STRATEGIES, causing a validation error on valid configurations. Changes: - Add 'overlay' to _VALID_STRATEGIES in src/cleveragents/resource/schema.py - Add BDD scenario: 'Schema accepts overlay sandbox strategy' - Add step definitions for the new scenario ISSUES CLOSED: #2827	2026-04-05 08:04:27 +00:00
brent.edwards	8a87262f86	feat(sandbox): implement overlay filesystem sandbox strategy (#994) ... ## Summary Implement the overlay filesystem sandbox strategy with OverlayFS support and userspace fallback. ### Implementation **`OverlaySandbox`** (`infrastructure/sandbox/overlay.py`, 497 lines): - Detects OverlayFS availability at runtime via `/proc/filesystems` + `os.geteuid() == 0` check - **Real OverlayFS mode** (requires root): creates upper/work/merged dirs, mounts overlay filesystem, captures writes in upper layer - **Userspace fallback** (default in CI/containers): `shutil.copytree` the original into merged dir, tracks changes via `filecmp` diff on commit - `create()`: sets up directory structure, mounts if available - `commit()`: copies changed/added files from overlay to original, removes deleted files - `rollback()`: unmounts (or removes) merged, recreates from scratch - `cleanup()`: unmounts, removes all temp dirs, idempotent ### Domain Model Updates - Added `OVERLAY = "overlay"` to `SandboxStrategy` enum in both `resource_type.py` and `resource.py` - Added `STRATEGY_OVERLAY` to `SandboxFactory`, registered for `fs-mount`, `fs-directory`, `fs-file` resources ### Tests - **22 Behave scenarios**: full lifecycle (create/commit/rollback/cleanup), status transitions, path traversal guard, fallback detection, error handling - **6 Robot integration tests**: end-to-end overlay sandbox operations ### Quality Gates | Session | Result | |---|---| | `nox -s lint` | PASS | | `nox -s typecheck` | PASS (0 errors) | | `nox -s unit_tests` | PASS (10,917 scenarios) | | `nox -s coverage_report` | 97% (>= 97%) | Closes #880 Reviewed-on: #994 Co-authored-by: Brent Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent Edwards <brent.edwards@cleverthis.com>	2026-03-21 03:14:40 +00:00
freemo	b2e923173f	perf(tests): consolidate 141 trivially small feature files into 34 domain groups ... Consolidate 141 BDD feature files that each complete in under 0.1 seconds into 25 domain-grouped feature files, reducing subprocess count from 339 to ~223. Each consolidated file groups scenarios from the same domain/module that share step definitions and fixtures. All scenarios are preserved with clear comment headers indicating their original source file. This reduces subprocess overhead by ~116 invocations (141 original files replaced by 25 consolidated files), targeting the 42% of subprocess count that contributed only 0.2% of actual test runtime. ISSUES CLOSED: #485	2026-03-02 14:56:13 +00:00