69 Commits

Author	SHA1	Message	Date
HAL9000	6a4a49158c	fix(cli): address review feedback on docstring example validator ... - Fix error suppression in validate_all_commands: log at DEBUG level instead of silently swallowing exceptions - Fix multi-word command name parsing bug: use command_token_count to skip the full command prefix when extracting positional values - Add @cli tag to features/cli_docstring_example_validation.feature - Update CONTRIBUTING.md with CLI docstring example style guide - Update CHANGELOG.md with entry for automated docstring validation - Update CONTRIBUTORS.md with contribution entry - Fix test design flaws: separate Given/When/Then steps per scenario - Add validate_all_commands test coverage via new Behave scenario - Fix _extract_positional_args to only count required positional args	2026-06-02 14:01:59 -04:00
HAL9000	bf6326b715	test(plan-correct): remove @tdd_expected_fail now bug #8584 is fixed ... The plan correct --format json output already nests correction fields under data.correction and sets command to "plan correct" via format_output, so the three BDD scenarios now pass against the current implementation. Remove the @tdd_expected_fail inversion tag so CI reports them as passing, not as unexpected-pass failures. Updated CHANGELOG.md and CONTRIBUTORS.md. ISSUES CLOSED: #8584	2026-06-02 07:19:20 -04:00
HAL9000	d54ed1440c	fix(engine_cache): guard MEMORY_ENGINES with lock to prevent TOCTOU race ... Add MEMORY_ENGINES_LOCK to engine_cache.py and wrap the check-and-set in UnitOfWork.engine with it to prevent concurrent threads from creating duplicate in-memory SQLite engines. Also fix cache-hit bug where self._engine was never assigned on a cache hit. Closes #7566	2026-06-02 05:51:55 -04:00
HAL9000	0dcf7bf152	fix(plan-lifecycle): gate Apply phase on Definition-of-Done evaluation ... Before transitioning to the Apply phase, PlanLifecycleService.apply_plan now evaluates the plan's definition_of_done criteria using DoDEvaluator (TextMatchEvaluator). If any required criteria fail, a DoDGatingError is raised and the plan remains in Execute/COMPLETE state. The evaluation result is stored in plan.validation_summary with dod_evaluated=True and dod_all_passed reflecting the outcome. Plans with no DoD text skip evaluation and proceed normally. Adds DoDGatingError exception class and _evaluate_dod() helper method. Adds BDD feature file and step definitions for DoD gating scenarios. ISSUES CLOSED: #7927	2026-06-02 05:14:43 -04:00
HAL9000	f7901c404f	fix(actor): move namespace filter inside lock in ActorLoader.list_actors ... Fixes a race condition (TOCTOU) in ActorLoader.list_actors() where the namespace filter was applied outside the threading lock, creating a window for concurrent dictionary modifications. Moving the filter inside the with self._lock: block ensures atomic reads and filtering. - Move namespace filtering inside the RLock in list_actors() - Add concurrency BDD test (threading.Barrier) for list_actors + clear race condition - Update CHANGELOG.md with fix entry (closes #8588) - Update CONTRIBUTORS.md with contribution details ISSUES CLOSED: #8588	2026-06-02 04:52:51 -04:00
HAL9000	2609787d35	fix(concurrency): fix ValidationPipeline.run() sys.stdout replacement #7623 ... Introduce a reference-counted shared stream wrapper manager so concurrent ValidationPipeline.run() calls correctly restore the true sys.stdout/stderr after all pipelines finish. - Add _install_thread_local_streams() / _release_thread_local_streams() protected by threading.Lock; first caller saves originals and installs wrappers, last caller restores them - Remove io.TextIOBase inheritance from _ThreadLocalStream to avoid Python 3.13 read-only slot conflict; use cast(TextIO, ...) at assignment sites - encoding property returns str | None matching io.TextIOBase signature - Replace assert guards with explicit RuntimeError fail-fast checks - Add Behave scenario: Concurrent pipelines restore global streams after execution - Split validation_pipeline_steps.py (547→428 lines) by extracting MockValidationExecutor to _validation_pipeline_mock.py and edge-case steps to validation_pipeline_edge_steps.py - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #7623	2026-06-02 04:29:20 -04:00
HAL9000	7859a6c05b	fix(alembic): handle fileConfig parsing errors with user-friendly diagnostic (#7874) ... Wrapped the `fileConfig()` call in `src/cleveragents/infrastructure/database/migrations/env.py` with a `try/except` block that catches malformed INI logging configuration and emits a clear, user-actionable error message to stderr before exiting with code 1. Includes: - Error handling guard around fileConfig() in env.py (fileConfig can raise configparser.Error, KeyError, ValueError on malformed logging config) - BDD/Behave feature file with 4 scenarios under `features/` - Step definitions in `features/steps/` for isolated test coverage - CHANGELOG.md entry under [Unreleased] Fixed section - CONTRIBUTORS.md update for HAL 9000 ISSUES CLOSED: #7874 Signed-off-by: CleverThis <hal9000@cleverthis.com>	2026-06-02 03:39:50 -04:00
HAL9000	9854b2c7cc	chore: add CHANGELOG.md and CONTRIBUTORS.md entries for tracking prefix fix (#7891) ... Added missing CHANGELOG.md entry under [Unreleased] > Fixed section documenting the AUTO-REV-POOL to AUTO-REV-SUP tracking prefix alignment for the pr-review-pool-supervisor agent. Added CONTRIBUTORS.md entry crediting HAL 9000 for the tracking prefix documentation fix (#7891). ISSUES CLOSED: #7891	2026-06-02 00:58:16 -04:00
HAL9000	565263ab24	fix(cli): fix project context show test mock for tier service ... Add ContextTierService mock to step_m5_invoke_project_context_show so the CLI command can call _get_context_tier_service() without failing. Also patch _load_policy_json to prevent JSON decode errors from MagicMock session objects. Update CHANGELOG.md and CONTRIBUTORS.md. ISSUES CLOSED: #6323	2026-05-31 20:45:10 -04:00
HAL9000	b8eab7c032	fix(resources): delete executable.yaml, fix resource list columns, update docs ... - Delete examples/resource-types/executable.yaml (orphaned artifact referencing non-existent ExecutableHandler; flagged in 4 prior reviews as blocking) - Update agents resource list CLI columns from [ID, Name, Type, Status, Kind, Location, Description] to spec-required [Name, ID, Type, Phys/Virt, Children, Projects] per specification line 11051 - Lifecycle state for container resources now shown as a note below the table - Update resource_list_lifecycle_state.feature to remove Status column header assertions; add spec-column header scenario - Add BDD scenario in resource_cli.feature verifying new column headers - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #3077	2026-05-30 15:43:56 -04:00
HAL9000	30f8c81a33	fix(actor): add changelog, contributors and benchmark fix for issue #1429 ... ISSUES CLOSED: #1429	2026-05-30 02:07:41 -04:00
HAL9000	02e51b9298	fix(actor): fix lint errors and add regression tests for lsp_binding field (#1432) ... - Remove trailing whitespace from blank lines in _extract_lsp_bindings() (W293 at lines 160, 164, 167, 172, 183, 188, 203) - Simplify over-long line 180 (E501): auto_detect=node.lsp_binding.auto - Add Behave scenario verifying NodeLspBinding typed field populates CompilationMetadata.lsp_bindings (features/actor_lsp_binding_field.feature) - Add corresponding @given step using NodeLspBinding in actor_compiler_steps.py - Add Robot Framework regression test case and lsp-binding-field helper command confirming node.lsp_binding is read by compile_actor() - Update CHANGELOG.md and CONTRIBUTORS.md ISSUES CLOSED: #1432	2026-05-30 00:36:20 -04:00
freemo	7b91b66b28	Fix actor add --config crash with combined-format config.actor (#11189) ... When users register actors via `agents actor add --config` using the spec-compliant combined config.actor YAML format — either as a compact string (config:\n actor: "<provider>/<model>") or as a nested dict (config:\n actor:\n type: llm\n provider: aws) — the CLI crashed with click.BadParameter: "Invalid value: 'provider' is required" because the parser did not detect or flatten the nested structure. Added: - _detect_nested_config_actor() in schema.py to recognise both compact-string and nested-dict forms of config-actor format. - _flatten_config_actor() in schema.py to merge config["actor"] fields into the dict top-level (removing the wrapper). - Flattening logic in ActorConfiguration.from_blob() to handle both string ("<provider>/<model>") and nested-dict forms of config.actor. - CLI flattening step at the start of `agents actor add` command. - New BDD scenarios for combined-format registration. - Unit tests for detection, flattening, schema-v3 detection, and full from_blob() flow. ISSUES CLOSED: #11189	2026-05-28 20:25:17 -04:00
freemo	bf52a9c648	fix(invariant): restore ACTION scope in merge_invariants and InvariantSet.merge precedence chain ... The 4-tier invariant precedence chain (plan > action > project > global) was broken at the domain layer — merge_invariants() and InvariantSet.merge() only accepted 3 parameters (plan, project, global), silently dropping all action- scoped invariants. Added action_invariants as a fourth parameter with proper backward compatibility (default to empty list). Updated module docstrings, InvariantScope docstring, and InvariantService.get_effective_invariants() to reflect the correct precedence chain. Added comprehensive BDD test scenarios covering four-tier merge precedence, action-before-project ordering, and effective invariant computation with all four scopes. ISSUES CLOSED: #9126	2026-05-16 04:14:17 +00:00
HAL9000	655cd7ebc2	fix: persist strategy decisions via DecisionService during strategize (#10813) ... The plan tree command reported zero decision nodes after strategize because PlanExecutor.run_strategize() never persisted strategy decisions as domain Decision objects. Added _persist_strategy_decisions() to the PlanExecutor, wired decision_service from the DI container in _get_plan_executor(), and ensure each strategy decision is recorded with correct DecisionType mapping. ISSUES CLOSED: #10813	2026-05-15 03:41:13 +00:00
HAL9000	fa95c518d5	fix(tui): rename ActorSelectionOverlay._render to avoid shadowing Textual Widget._render ... Rename ActorSelectionOverlay._render() to _refresh_display() to avoid shadowing Textual's Widget._render(), fixing a crash in textual >=1.0 where get_content_height() would receive None and raise AttributeError. ISSUES CLOSED: #11039	2026-05-15 00:56:08 +00:00
HAL9000	2f29f8352f	chore: resolve merge conflicts and apply cosmetic fixes ... - Resolve CHANGELOG.md conflict to include both entries, referencing issue #8164 instead of PR #11161 - Resolve CONTRIBUTORS.md conflict, fix leading space in new entry - Remove duplicate create_sequence_node function (dead code) Merges master into feat/structural-output-validation branch	2026-05-14 18:14:48 +00:00
HAL9000	8c5dbf3f33	chore(contributors): add ACMS hot_max_tokens fix detail entry ... Adds contributor detail line for Hamza Khyari's ACMS execute-phase context assembler project-level budget override fix. ISSUES CLOSED: #11035	2026-05-14 07:13:24 +00:00
freemo	80d27df9cc	fix(changelog): correct PR #11161 references in CHANGELOG.md and CONTRIBUTORS.md ... ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
HAL9000	f8e4f4a579	feat: implement structural component output validation ... Replace exact character matching with structural component checking for output validation. Implements three validators covering plan tree output, decision CLI dicts, and structured session snapshots. - validate_plan_tree: validates node dicts for required keys (decision_id, type, sequence, question, children), ULID format, correct types, and sibling ordering - validate_decision_dict: validates decision CLI output against Decision.as_cli_dict() schema with field presence, type, ULID, confidence range [0..1], bool fields - validate_structured_output: validates StructuredOutput envelope for command, session_id (ULID), status membership, exit_code, elements integrity - validate_structured_component_output: unified dispatcher by target_type BDD tests in features/structural_validation.feature. ISSUES CLOSED: #11147	2026-05-14 06:46:27 +00:00
HAL9000	3368cba38f	refactor(a2a): execute ACP to A2A module rename and symbol standardization (#10583) ... Executes the systematic ACP -> A2A module rename per ADR-047. - Renamed all legacy ACP references to A2A throughout cleveragents.a2a module - Standardized all 22 exported symbols to A2A naming conventions - Added BDD test suite validating export completeness, zero ACP remnants, and documentation accuracy Closes #10583 Parent Epic: #8569 (A2A Standard Adoption)	2026-05-13 06:49:40 +00:00
HAL9000	09c79eab73	chore(deps): upgrade PyYAML to address known security vulnerability (#9244) ... - Add explicit `pyyaml>=6.0.3` constraint to pyproject.toml dependencies with a security comment - Add a `\#\#\# Security` section to CHANGELOG.md documenting this dependency constraint update - Verify no unsafe yaml.load() calls exist in the codebase Co-authored-by: HAL 9000 <hal9000@cleverthis.com> ISSUES CLOSED: #9055	2026-05-13 06:01:19 +00:00
freemo	9cfa1dd1d7	fix(subplan): propagate invariant_enforced decisions to child plans on spawn ... SubplanService.spawn() now re-records all invariant_enforced decisions from the parent plan decision tree onto each child plan decision tree. This satisfies the spec requirement: 'recorded as invariant_enforced decisions that propagate to child plans.' (Glossary → Invariant) Previously, child plans started Strategize with a completely empty invariant set, violating the spec's propagation requirement. non_overridable global invariants enforced on the parent were not guaranteed to be enforced on child plans. The fix adds _propagate_invariant_decisions() to SubplanService which queries the parent plan's invariant_enforced decisions and re-records each one on the child plan using DecisionService.record_decision(). The DecisionService is already injected into SubplanService, so no new dependencies are required. BDD regression coverage added in features/tdd_invariant_propagation_subplan.feature with 4 scenarios covering: single invariant propagation, multiple invariant propagation, non_overridable invariant propagation, and clean spawn with no parent invariants. ISSUES CLOSED: #9131	2026-05-12 16:45:59 +00:00
hurui200320	d25a060c58	Revert "feat(ci): implement TDD bug tag quality gate for bug fix PRs" ... This reverts commit e8d2f76466.	2026-05-12 08:30:24 +00:00
CoreRasurae	e8d2f76466	feat(ci): implement TDD bug tag quality gate for bug fix PRs ... Add an automated quality gate that enforces TDD bug fix workflow rules on pull requests. The gate parses PR descriptions for bug-closing keywords (Closes/Fixes/Resolves #N, ISSUES CLOSED: #N), searches the codebase for corresponding TDD tests tagged @tdd_bug_N, and verifies that @tdd_expected_fail tags have been removed. Key components: - scripts/tdd_quality_gate.py: Main quality gate script with PR description parsing, TDD test discovery, and tag removal verification. All public functions validate arguments fail-fast and are statically typed. - noxfile.py: New tdd_quality_gate session that reads PR_DESCRIPTION from the environment and runs the quality gate script. - .forgejo/workflows/ci.yml: New tdd_quality_gate CI job that runs only on pull_request events, passing the PR body as PR_DESCRIPTION. - features/tdd_quality_gate.feature: 46 Behave scenarios covering PR parsing, TDD test search, tag removal verification, full gate logic, robot diff handling, edge cases, argument validation, bool guards, co-located bug false-positive guard, and main() CLI entry point. - features/steps/tdd_quality_gate_steps.py: Step definitions for all Behave scenarios using temporary directories for isolation. - robot/tdd_quality_gate.robot: 15 Robot Framework integration tests exercising the gate end-to-end via a helper subprocess. - robot/helper_tdd_quality_gate.py: Helper script for Robot tests with sentinel-based sub-commands. Review-round fixes applied: - check_expected_fail_removed now uses _contains_tag_token for word-boundary matching (avoids false positives on partial tag names) - Diff expected-fail removal detection tracks flags at file level instead of per-hunk (fixes false negatives when tags span hunks) - parse_bug_refs filters out issue number zero - Redundant double error reporting eliminated (file-level check short-circuits the diff-level check) - run_quality_gate returns (errors, bug_refs) tuple to avoid redundant re-parsing in main() - Regex compilation cached via functools.lru_cache - Nox session no longer installs the full project (stdlib only) - CI checkout uses fetch-depth: 0 for reliable merge-base resolution Review-round 2 fixes applied: - _diff_has_expected_fail_removal_for_bug now requires the removed line to contain both the expected-fail tag and the specific bug tag (fixes false positives when two bugs share the same test file) - check_expected_fail_removed error messages use the correct tag prefix per file type (@tdd_bug_N for .feature, tdd_bug_N for .robot) - bool values rejected by bug-number validation guards in find_tdd_tests, check_expected_fail_removed, and _diff_has_expected_fail_removal_for_bug - File-read error handling catches UnicodeDecodeError alongside OSError (root-safe unreadable-file handling via invalid-UTF-8 test fixture) - Temp directory cleanup added to after_scenario hook in environment.py - 8 new Behave scenarios: bool type guards (2), co-located bug false-positive regression (1), run_quality_gate argument validation (3), and main() CLI entry point exit codes (2) Review-round 3 fixes applied: - Synthetic PR diff helper (_default_pr_diff_for_bug_refs) now auto-detects .robot vs .feature file type from the temp search tree and generates the matching diff format (fixes under-tested robot-format diff code path in multi-bug integration scenarios) - check_expected_fail_removed test step now filters files by bug tag via find_tdd_tests before checking (matches production path in run_quality_gate) - after_scenario temp directory cleanup no longer sets context.temp_dir = None (fixes cleanup conflict with cli_init_yes_flag_steps.py cleanup functions that run after hooks) - 2 new Behave scenarios: multi-line PR description parsing, and non-string pr_diff type guard for run_quality_gate ISSUES CLOSED: #629	2026-05-12 00:22:49 +01:00
HAL9000	05acc26c40	chore(deps): upgrade PyYAML to address known security vulnerability ... - Added `pyyaml>=6.0.3` dependency constraint to pyproject.toml after aiohttp to prevent installation of vulnerable older versions with known YAML parsing security issues. - Updated uv.lock package dependencies and requires-dist to include pyyaml entry with specifier '>=6.0.3'. - Added changelog Security section entry under [Unreleased] documenting the upgrade for issue #9055. - Updated CONTRIBUTORS.md with contribution note (PR #9244). - Added BDD test scenario verifying PyYAML security dependency constraint. ISSUES CLOSED: #9055	2026-05-11 08:59:08 +00:00
HAL9000	a1ea40d2e7	feat(plans): implement agents plan rollback command for checkpoint-based rollback ... Documents the agents plan rollback command (CLI entry at src/cleveragents/cli/commands/plan.py) that was integrated into master under Epic #8493. The command provides checkpoint-based plan state restoration, allowing plans to be restored to a previous checkpoint and resuming execution from that point. CHANGELOG.md entry added under [Unreleased] > ### Added section; CONTRIBUTORS.md updated with HAL 9000's contribution for this checkpoint-based rollback feature. ISSUES CLOSED: #8557 Epic: #8493	2026-05-11 06:54:32 +00:00
HAL9000	6e1646d565	fix(plan): wrap plan tree JSON/YAML output in spec-required command envelope.\n\nISSUES CLOSED: #9163 ... # Conflicts: # CONTRIBUTORS.md	2026-05-09 12:23:24 +00:00
HAL9000	3f0ce3d20a	feat(resources): add CHANGELOG and CONTRIBUTORS entries for PR #10591 ... - Add CHANGELOG.md entry under [Unreleased] / Database resource types (PostgreSQL, SQLite) with transaction-based sandbox strategy (issues #8608, Epic #8568) - Update CONTRIBUTORS.md with HAL 9000 contribution note for database resource types implementation ISSUES CLOSED: #8608	2026-05-09 10:01:20 +00:00
HAL9000	2cba7d41bc	chore(agents): fix bug-hunt-pool-supervisor tracking prefix AUTO-BUG-POOL to AUTO-BUG-SUP (complete fix) ... Replace all remaining AUTO-BUG-POOL references with correct AUTO-BUG-SUP in agent-system-specification.md, automation-tracking.md documentation and agent-system-specification.md spec document, replaced with correct `AUTO-BUG-SUP` prefix used by the bug-hunt-pool-supervisor agent (#7875). ISSUES CLOSED: #7875	2026-05-09 00:05:17 +00:00
HAL9000	57881a075b	docs(spec): update specification — validation gate blocks on empty validation summary	2026-05-08 19:14:24 +00:00
HAL9000	fbe6308200	feat(agents): add mandatory PR compliance checklist to implementation-pool-supervisor ... Add a new implementation-pool-supervisor agent definition with an embedded 8-item PR Compliance Checklist. Workers dispatched by the pool supervisor must complete all 8 items before creating any PR: CHANGELOG.md update, CONTRIBUTORS.md update, commit footer (ISSUES CLOSED: #N), CI verification, BDD tests, Epic reference, label application via forgejo-label-manager, and milestone assignment. Includes concrete markdown examples for each subsection and compliance verification pseudocode. Also adds BDD test coverage (pr_compliance_pool_supervisor.feature + steps) to verify the pool supervisor agent definition contains all 8 checklist items. Parent Epic: #9779 ISSUES CLOSED: #9824	2026-05-08 18:50:33 +00:00
HAL9000	a15b77f6a6	fix(acms): normalize context path matching for absolute paths in _path_matches ... Fixes issue #10972 where _path_matches() used PurePath.full_match()/match() which requires the entire path to match. Since fragment metadata stores absolute paths (e.g. /app/.opencode/skills/SKILL.md) while project context --exclude-path/--include-path settings produce relative globs (.opencode/*, docs/*), include/exclude filters were silently ineffective. Added _matches_any() static helper in execute_phase_context_assembler.py that: - Tries full_match(pattern) as-is for relative paths and anchored patterns - Auto-prefixes relative patterns with **/ so they match absolute paths Updated _matches_pattern() in context_phase_analysis.py with same logic plus zero-depth compatibility shim. Added 7 new BDD regression scenarios with @tdd_issue tags: - 5 in execute_phase_context_assembler_coverage.feature (absolute path matching) - 1 extra trailing ** glob exclusion test - 1 in project_context_phase_analysis.feature (phase analysis exclusion) ISSUES CLOSED: #10972	2026-05-08 09:57:18 +00:00
HAL9000	e7fb7168b4	feat(decisions): implement decision recording hook in Strategize phase ... Implement the StrategizeDecisionHook class for recording decisions during the Strategize phase. The hook captures every decision point with question, chosen_option, alternatives_considered, confidence_score, rationale, and full context_snapshot (hot_context_hash, actor_state_ref, relevant_resources). Supports four decision types: strategy_choice, resource_selection, subplan_spawn, and invariant_enforced. Includes a DecisionRecorder protocol port for decoupled persistence and capture_context_snapshot utility function. Comprehensive BDD test suite with 40+ scenarios covering all decision types, context snapshot validation, error handling, and tree structure tracking. ISSUES CLOSED: #8522	2026-05-08 06:24:23 +00:00
HAL9000	8ed8c25652	fix(plan-lifecycle): record full context snapshots in Strategize phase ... The Strategize phase was recording decisions with minimal context snapshots (only a hash of question+chosen_option), violating the v3.2.0 acceptance criterion that decisions must include full context snapshots sufficient to replay the decision. Changes: - Add _build_strategize_context_snapshot() helper that builds a full ContextSnapshot from plan metadata (description, action_name, strategy_actor, project_links) - Update _try_record_decision() to accept an optional context_snapshot parameter and forward it to DecisionService - Update start_strategize() to build and pass a full context snapshot - Add 3 BDD scenarios in decision_recording.feature verifying that hot_context_hash, hot_context_ref, actor_state_ref, and relevant_resources are all populated for Strategize-phase decisions ISSUES CLOSED: #9056	2026-05-08 05:11:47 +00:00
HAL9000	94dd77fbcd	fix(application): Complete PR #9247 compliance — add CHANGELOG and CONTRIBUTORS entries ... - Add CHANGELOG.md entry under [Unreleased] Fixed section for error suppression removal (issue #9060) - Update CONTRIBUTORS.md with HAL 9000 contribution note for this fix - Branch: bugfix/m-error-suppression-reactive-registry-adapter-v2 ISSUES CLOSED: #9060	2026-05-07 14:51:35 +00:00
HAL9000	2778bde95a	fix(repositories): derive PlanResult.success from result_success column instead of error_message ... ISSUES CLOSED: #7501	2026-05-07 14:22:57 +00:00
HAL9000	741186cbfb	docs: add ACMS Index Data Model contribution to CONTRIBUTORS.md	2026-05-05 17:48:37 +00:00
HAL9000	63241f1859	fix(agents): add mandatory PR compliance checklist to implementation-supervisor ... Workers were systematically omitting CHANGELOG.md, CONTRIBUTORS.md, and commit footer (ISSUES CLOSED: #N), causing all PRs to be blocked from merge. Added a mandatory 8-item PR Compliance Checklist to the worker prompt body in implementation-supervisor.md that supervisors must pass to every worker. The checklist covers: 1. CHANGELOG.md update under [Unreleased] 2. CONTRIBUTORS.md update 3. Commit footer with ISSUES CLOSED: #N 4. CI verification (all quality gates green) 5. BDD/Behave test coverage 6. Epic reference in PR description 7. Labels applied via forgejo-label-manager 8. Milestone assignment Also removed @tdd_expected_fail tag from PlanContextInheritance test in depth_breadth_projection.feature (bug #4198 is fixed). Added BDD tests in features/pr_compliance_checklist.feature with 10 scenarios covering all 8 checklist items. ISSUES CLOSED: #9824	2026-05-05 17:18:16 +00:00
HAL9000	876a2c6916	fix(data-integrity): Replace unconditional commit with flush in LLMTraceRepository.save() ... Implement dual-path session management in LLMTraceRepository.save(): - UoW mode (explicit session provided): flush only, caller controls commit - Standalone mode (no session): flush + commit + close for durable persistence This resolves three data-integrity violations: 1. Premature commit of outer UoW transactions 2. Loss of rollback capability for subsequent failures 3. Mismatch between class docstring and implementation Also adds: - Input validation: trace must not be None - Updated BDD step definitions to pass session explicitly in UoW scenarios - close() method to _BrokenSession mock for proper cleanup path coverage - CHANGELOG.md entry for issue #7505 - CONTRIBUTORS.md credit for HAL 9000 ISSUES CLOSED: #7505	2026-05-05 09:57:46 +00:00
HAL9000	39175dd284	fix(git_tools): eliminate TOCTOU race in _get_base_env() with double-checked locking ... Add module-level _BASE_ENV_LOCK: threading.Lock and replace the bare if _BASE_ENV is None assignment with double-checked locking. The outer check keeps the warm-cache path lock-free; the inner check inside with _BASE_ENV_LOCK prevents duplicate initialisation when two threads race on the very first call. Add three BDD scenarios in features/git_tools.feature (step definitions in features/steps/git_tools_thread_safety_steps.py) verifying caching identity, content correctness, and thread safety under 20 concurrent threads using threading.Barrier. Update CHANGELOG.md and CONTRIBUTORS.md per contribution guidelines. ISSUES CLOSED: #7619	2026-05-05 05:25:28 +00:00
HAL9000	dde71cf8e2	docs(milestone): split advanced-concepts and tui docs into sub-documents ... Split docs/advanced-concepts.md (554 lines) into four sub-documents under docs/advanced-concepts/ and docs/tui.md (634 lines) into four sub-documents under docs/tui/, each under the 500-line limit per CONTRIBUTING.md. Advanced Concepts sub-documents: - docs/advanced-concepts/index.md: Overview, context strategies, LLM backends - docs/advanced-concepts/resource-types.md: Resource types, A2A rename - docs/advanced-concepts/container-tools.md: Container tools, scope chain, budgets, safety - docs/advanced-concepts/e2e-tests-and-plugins.md: E2E tests, code review, plugins TUI sub-documents: - docs/tui/index.md: Overview, getting started, main screen layout - docs/tui/sidebar-and-personas.md: Sidebar states, persona system - docs/tui/input-and-sessions.md: Reference/command input, session management - docs/tui/configuration-and-integration.md: Config, key bindings, theme, integration Updated mkdocs.yml navigation to reflect new sub-document structure. Updated CONTRIBUTORS.md with contribution entry for PR #9903. ISSUES CLOSED: #10533	2026-05-03 01:11:03 +00:00
HAL9000	60edcba1f2	docs(contributors): restore missing entries and add #7888 contribution detail	2026-05-03 00:17:15 +00:00
HAL9000	ecf9710369	docs(changelog): add TOCTOU race condition fix entry and contributor credit ... Updated CHANGELOG.md with comprehensive entry for the git worktree TOCTOU race condition fix (issue #7507). Added contributor credit to CONTRIBUTORS.md for HAL 9000's work on this fix. ISSUES CLOSED: #8178	2026-04-28 04:06:57 +00:00
HAL9000	5a45db3e41	docs(contributors): remove duplicate entry and sync with master	2026-04-28 04:06:57 +00:00
HAL9000	6bab6c3055	fix(sandbox): TOCTOU race condition in git_worktree.py	2026-04-28 04:06:57 +00:00
HAL9000	2db01fbc17	fix(cli): resolve merge conflict and address all reviewer blockers for #993 ... - Resolve merge conflict in config_service.py: integrate PR's emit_config_changed() helper with master's scoped config infrastructure (write_scoped_config, scoped set_value) - Remove # type: ignore[assignment] by introducing typed _AutoDiscover sentinel class for project_root parameter - Add exc_info=True to emit_config_changed warning log - Fix server.py: remove invalid scope='global' from emit_config_changed rollback calls; use svc._config_path instead of hardcoded path - Add ReactiveEventBus.close() method for proper resource cleanup - Fix BDD test steps: call event_bus.close() in cleanup handler - Update CHANGELOG.md and CONTRIBUTORS.md Closes #993	2026-04-26 17:36:29 +00:00
HAL9000	7c21ca0d6f	docs(agents): sync pr-merge-pool-supervisor merge criteria with runtime behaviour ... Add Ten Merge Criteria section to pr-merge-pool-supervisor.md documenting all 10 criteria the supervisor checks at runtime. Previously only 6 criteria were documented, creating inconsistency with actual runtime behaviour. Also update CHANGELOG.md and CONTRIBUTORS.md. Closes #8107 # Conflicts: # CONTRIBUTORS.md	2026-04-26 13:01:44 +00:00
HAL9000	8320f9f4cb	fix: correct trusted automation profile description to match spec ... ISSUES CLOSED: #9156	2026-04-26 09:12:01 +00:00
HAL9000	c4122f877a	chore(agents): add CONTRIBUTING.md compliance steps to agent-evolution-worker ... ISSUES CLOSED: #8370	2026-04-25 03:14:00 +00:00