11 Commits

Author	SHA1	Message	Date
CleverAgents Bot	556de5f6f9	fix(events): restore event bus close and bridge semantics	2026-06-18 10:38:44 +00:00
cleveragents-auto	17c6e5f4ea	chore: worker ruff auto-fix (pre-push lint gate)	2026-06-14 15:26:27 -04:00
HAL9000	c69e960696	fix(actor): repair list_actors lock-filter test fixtures (#8588) ... Address CI lint + unit_tests failures on the namespace-lock test suite: - Step file: drop unused imports (yaml, ExitStack, ValidationError) and unused noqa directives flagged by ruff F401/RUF100; rewrite the collected-errors list to use iterable unpacking (RUF005); register the "I create an ActorLoader with initial actors from multiple namespaces" step under both @given and @when so scenario 3 is no longer reported as undefined; remove the dead _error_collector inner function the reviewer flagged. - Step regex fix: the concurrent-modifications step pattern ended with '' (two single quotes) instead of `` (two backticks), so it never matched the feature file's `(triggering ``discover()``)` literal. - Test fixtures: add the required `description` field to _make_actor_yaml in both the BDD step file and tests/actor/test_loader_list_actors_thread_safety.py so ActorConfigSchema validation passes (previously every scenario errored at discover() with "description: Field required"). - Concurrent worker names: collapse three-slash actor names like "conc/ns{i % 2}/concurrent_{i}" to the single-slash form "conc/concurrent_{i}" required by the schema's namespaced-name rule. - Test file: drop unused `yaml` import and three unused F841 assignments in _list_worker; apply ruff format. - Feature file: switch the @issue_8660 TDD tag to @tdd_issue_8588 to match the CONTRIBUTING.md tag convention for the bug issue this PR closes. ISSUES CLOSED: #8588	2026-06-14 15:26:27 -04:00
HAL9000	1c4f763685	fix(actor): move namespace filter inside lock in ActorLoader.list_actors (#8660) ... Fixes a race condition where the namespace filter was applied outside the threading.RLock, allowing concurrent mutations (discover(), clear()) to corrupt the iteration state. The filter now runs inside the locked section, matching the locking discipline of all other public methods. - Moved namespace filtering inside lock in list_actors() - Added BDD concurrency regression test - Added unit test for thread-safety under concurrent discover/clear - Updated CHANGELOG.md with fix description - Updated CONTRIBUTORS.md ISSUES CLOSED: #8588	2026-06-14 15:26:27 -04:00
HAL9000	aecbaa00f6	fix(actor): resolve CI failures for config-actor format PR ... Lint (ruff): - schema.py: import `cast`, replace non-breaking hyphens, inline SIM103 return, wrap long is_nested_v3 line - config.py: replace `if k in d: del d[k]` with `pop`, collapse nested ifs (SIM102) - format both reformatted-only files (ruff format) Typecheck (pyright): - config.py: guard `actor_type.lower()` calls with isinstance checks so the None branch is type-safe Unit tests (behave): - Remove duplicate `@then('v3actor the command ...')` and `@then('the actor should be registered with type ...')` registrations that crashed step-registry with AmbiguousStep — shared versions live in actor_add_v3_schema_validation_steps.py - Add missing Actor import; drop unused ActorConfiguration / is_v3_yaml imports and unused provider/model locals - Populate `context.registered_actor_type` from the upsert call args so the shared assertion step works for combined-format scenarios - Add a `@when("I run the actor add command without a name argument")` step that exercises the CLI's "Actor name is required" validation path (the previously-active step always supplied a name, masking the scenario's intent) ISSUES CLOSED: #11189	2026-05-28 20:47:07 -04:00
freemo	7b91b66b28	Fix actor add --config crash with combined-format config.actor (#11189) ... When users register actors via `agents actor add --config` using the spec-compliant combined config.actor YAML format — either as a compact string (config:\n actor: "<provider>/<model>") or as a nested dict (config:\n actor:\n type: llm\n provider: aws) — the CLI crashed with click.BadParameter: "Invalid value: 'provider' is required" because the parser did not detect or flatten the nested structure. Added: - _detect_nested_config_actor() in schema.py to recognise both compact-string and nested-dict forms of config-actor format. - _flatten_config_actor() in schema.py to merge config["actor"] fields into the dict top-level (removing the wrapper). - Flattening logic in ActorConfiguration.from_blob() to handle both string ("<provider>/<model>") and nested-dict forms of config.actor. - CLI flattening step at the start of `agents actor add` command. - New BDD scenarios for combined-format registration. - Unit tests for detection, flattening, schema-v3 detection, and full from_blob() flow. ISSUES CLOSED: #11189	2026-05-28 20:25:17 -04:00
HAL9000	883ec872e2	fix(CI): resolve remaining lint/format violations in PR #8722 ... - Apply ruff format to features/steps/strategize_decision_recording_steps.py: expanded single-line set literal to multi-line canonical form (PEP 87) This was the sole remaining CI lint blocker per review cycle 14. - Remove unused imports from tests/actor/test_registry_builtin_yaml.py: removed 'Settings' and 'ProviderRegistry' to fix F401 errors. These were pre-existing violations caught by ruff check. ISSUES CLOSED: #8522 Closes: #8722	2026-05-08 06:24:23 +00:00
hurui200320	8dc55655e9	feat(actor): make built-in actors virtual, resolved on-demand from provider registry ... Replace the DB-persistence approach for built-in actors with in-memory virtual resolution. Built-in actors (e.g. openai/gpt-4o, anthropic/claude-sonnet) are now resolved on-demand from ProviderRegistry at query time and merged with persisted custom actors — no database writes occur for built-in actors. Key changes: - Add ActorRegistry._resolve_virtual_builtin_actors(): generates virtual Actor objects in-memory from configured providers (is_built_in=True, id=None) - ActorRegistry.list()/list_actors(): merges virtual built-ins with custom DB actors; custom actors win on name collision; result sorted alphabetically - ActorRegistry.get()/get_actor(): DB-first, virtual built-in fallback, NotFoundError if neither - ActorRegistry.remove()/remove_actor(): rejects virtual built-in names with ValidationError - ActorRegistry.set_default_actor(): stores only the actor name string via new actor_preferences singleton table; no actor row created for virtual built-ins - ActorRegistry.get_default_actor(): reads preference name, resolves via DB→virtual chain, returns actor with is_default=True - Remove ensure_built_in_actors() entirely — 20+ call sites cleaned up including plan.py - Remove ActorRepository.upsert_built_in() — no longer needed - Remove is_built_in from ActorModel DB column (kept on Actor domain model for virtual actors) - New Alembic migration m10_001_virtual_builtin_actors: drops is_built_in column, adds actor_preferences singleton table - Add ActorService.set_default_actor_name() and get_default_actor_name() for preference storage without requiring a DB actor row - Update 15+ Behave step files and 5 feature files; add new features/virtual_builtin_actors.feature with 8 scenarios covering list, show, remove, set-default, get-default, no-DB-writes guarantees - Rewrite tests/actor/test_registry_builtin_yaml.py: TestEnsureBuiltInActorsWithYaml → TestResolveVirtualBuiltinActors plus new TestListActors, TestGetActor, TestRemoveActor, TestDefaultActor test classes Quality gates: lint ✓, typecheck ✓, unit_tests ✓ (15674 scenarios), coverage ✓ (97.10%), integration_tests ✓ (1997 tests) ISSUES CLOSED: #10923	2026-04-30 10:56:21 +00:00
hurui200320	bb6765d85e	fix(actor): add v3 YAML text generation for built-in actors ... Built-in actors (e.g., openai/gpt-4, anthropic/claude-3-opus) were failing silently with agents actor run because they lacked the required v3 type field in their stored configuration. The ReactiveConfigParser._is_v3_format() check failed, resulting in empty agents/routes dictionaries and no output. This fix adds _generate_builtin_actor_yaml() helper to ActorRegistry that generates spec-compliant v3 YAML text including: - type: llm (required for v3 format recognition) - description (required by v3 schema) - name, model, provider, capabilities, unsafe, source fields The ensure_built_in_actors() method now calls this helper and persists yaml_text via upsert_actor(), ensuring built-in actors work identically to custom actors with the agents actor run command. Existing built-in actors will be automatically refreshed on next startup since they are regenerated from the provider registry - no database migration needed. Added: - _generate_builtin_actor_yaml() helper method - BDD feature file with scenarios for v3 YAML format - Step definitions for new BDD scenarios - Unit tests covering YAML generation and schema validation - CHANGELOG entry ISSUES CLOSED: #10883	2026-04-28 12:38:04 +00:00
freemo	f7a5d26c41	Modernized build tooling	2025-08-01 18:38:09 -04:00
freemo	bda31cf4ce	Added boilerplate code for python	2024-03-06 23:57:14 -05:00