2 Commits

Author	SHA1	Message	Date
hurui200320	8953449dc2	fix(actor): validate v3 YAML via ActorConfigSchema in agents actor add CLI ... - schema.py: provider field changed to Optional[str] with model validator validate_provider_required_for_llm_graph() that requires it only for LLM and GRAPH actor types; TOOL actors do not require provider - schema.py: is_v3_yaml() uses version_str == "3" or version_str.startswith("3.") to avoid false positives from "30" or "300" version strings - schema.py: tool namespace validation uses strict 2-part split to reject empty namespace or empty name (e.g. "/tool", "ns/", "a/b/c") - cli/commands/actor.py: schema_version extraction uses raw_version pattern (no # type: ignore[assignment]) for clean static typing - actor/__init__.py: is_v3_yaml removed from __all__ and _LAZY_IMPORTS since it is a module-private helper, not a public API - robot/actor_add_v3_schema_validation.robot: YAML fixtures for 'Reject v3 LLM Actor Without Model Field' and 'Reject v3 TOOL Actor Without Tools Field' now include required provider field (and model for TOOL fixture) - robot/helper_actor_add_v3_schema_validation.py: except clauses unified to catch (subprocess.TimeoutExpired, FileNotFoundError) in both add_actor() and update_actor() functions - features/actor_add_v3_schema_validation.feature: 'Update a v3 actor with valid YAML succeeds' scenario now includes 'And the actor should be validated via ActorConfigSchema'; error assertions tightened to exact messages (e.g. "Input should be 'llm', 'tool' or 'graph'", "Node ID must be alphanumeric", "must be namespaced") - features/steps/actor_add_v3_schema_validation_steps.py: step_run_actor_update now spies on ActorConfigSchema.model_validate; failure paths assert isinstance(result.exception, SystemExit) ISSUES CLOSED: #5869	2026-04-17 16:28:45 +08:00
aditya	e476d2de0e	feat(actor): extend hierarchical actor YAML schema and loader ... Extend actor YAML schema to support hierarchical graphs with explicit node types (agent, tool, conditional, subgraph), per-node LSP bindings (lsp_binding with server, languages, auto, capabilities), and tool-source references (skills, mcp_servers, agent_skills). Add schema validation for namespaced actor references, duplicate node IDs, edge target existence, and graph reachability — all nodes must be reachable from entry_node via explicit edges or conditional node routing targets. Update loader to report YAML parse errors with precise line/column positions and schema validation errors with dotted field paths and remediation hints pointing to docs/reference/actor_config.md. Add docs/reference/actor_config.md as the practical configuration reference covering hierarchical graph examples, node type table, topology rules, and common error cases with fix guidance. Refresh examples/actors/graph_workflow.yaml to replace deprecated actor_path with actor_ref. Add benchmarks/actor_yaml_bench.py for schema load overhead. Tests: 95 Behave scenarios, 10 Robot smoke tests (including hierarchical loader smoke test), security scan clean, coverage 99% (threshold 97%). ISSUES CLOSED: #157	2026-02-25 10:30:42 +00:00