3 Commits

Author	SHA1	Message	Date
freemo	b122ec7ed5	fix(test-infra): remove redundant ${PYTHON} variable definitions from robot files ... Remove the local ${PYTHON} python (and python3) variable definitions from the *** Variables *** sections of all affected robot files. These local definitions were overriding the pabot-injected venv Python path passed via --variable PYTHON:/path/to/venv/python, causing tests to use the system Python (which lacks required packages like structlog, sqlalchemy, etc.) instead of the nox venv Python. The correct ${PYTHON} value is already set by Setup Test Environment in common.resource via sys.executable, and pabot passes it via --variable. The local fallback definitions are redundant and harmful in parallel runs. Audit found 56 robot files with the pattern (more than the 9 originally identified in the issue). All occurrences have been removed. ISSUES CLOSED: #1309	2026-04-14 14:50:55 +00:00
freemo	4d31f0ed02	fix(cli): promote --format to global CLI callback option per spec ... Add `fmt: OutputFormat` parameter to `main_callback()` in `src/cleveragents/cli/main.py` and store the selected format in `ctx.obj["format"]` so all subcommands can read it without needing their own per-command `--format` flag. Remove per-command `--format` / `fmt` parameters from `version()`, `info()`, and `diagnostics()` commands. These commands now read the format from `ctx.obj.get("format", OutputFormat.RICH.value)`. The specification states: "The framework supports six distinct output formats, selectable via the global `--format` flag." This change aligns the implementation with the spec by making `--format` a global option on the root `agents` command (via the Typer callback). All six formats (json, yaml, plain, rich, table, color) are supported via the global flag and the `-f` shorthand. Add Behave BDD scenarios covering global `--format` flag propagation to subcommands for all six formats. Update Robot Framework integration tests to exercise the global `--format` flag. Update existing tests that used per-command `--format` for version/info/diagnostics to use the global flag instead. ISSUES CLOSED: #2908	2026-04-05 08:39:14 +00:00
brent.edwards	95d3e09925	feat(cli): final CLI polish and UX consistency pass (#1018) ... ## Summary Final CLI polish and UX consistency pass: shared constants, centralized error formatting, shell completion, and standardized help text. ### New Modules - **`cli/constants.py`** (70 lines): Exit codes (`EXIT_SUCCESS`=0 through `EXIT_CONFLICT`=4), format defaults (`FORMAT_TEXT`, `FORMAT_JSON`, `FORMAT_TABLE`) - **`cli/errors.py`** (105 lines): `cli_error()` with hint support, `cli_warning()`, `cli_not_found()` with resource-type-aware hint ### CLI Changes - Shell `completion` command generating scripts for bash/zsh/fish/powershell - Standardized help text across command modules - Error functions exported from `cli/__init__.py` ### Tests - **17 Behave scenarios**: Exit codes, error formatting, cli_not_found, format constants, help text, completion - **15 Robot integration tests**: All subcommands respond to --help, invalid commands return non-zero, completion generation works ### Quality Gates | Session | Result | |---|---| | `nox -s lint` | PASS | | `nox -s typecheck` | PASS (0 errors) | | `nox -s unit_tests` | PASS (10,912 scenarios) | | `nox -s coverage_report` | 97% (>= 97%) | Closes #861 Reviewed-on: #1018 Co-authored-by: Brent E. Edwards <brent.edwards@cleverthis.com> Co-committed-by: Brent E. Edwards <brent.edwards@cleverthis.com>	2026-03-21 01:14:18 +00:00