9 Commits

Author	SHA1	Message	Date
HAL9000	afe89964df	chore(tests): remove stale tdd_expected_fail tags from tests now passing on master ... The tdd_expected_fail listener (robot/tdd_expected_fail_listener.py and features/environment.py) inverts test results: a test tagged @tdd_expected_fail that PASSES is forced to FAIL with the message "Bug appears to be fixed. Remove the tdd_expected_fail tag…". After rebasing onto master, 22 scenarios across 11 files were triggering that forced-failure path because the underlying bugs (#4199, #4201, #4202, #4203, #4205, #4206, #4243, #4252, #4301, #4303, #4304) have been fixed on master but the @tdd_expected_fail tags were never removed. This commit removes the stale tag (keeping @tdd_issue and @tdd_issue_<N> for traceability, per the master-side pattern in robot/tdd_skill_add_regression.robot:9 "tag removed after bug fix"). Files touched (lines: where the stale tag was): features/plan_cli_spec_alignment.feature (121, 128, 136) robot/a2a_facade.robot (40) robot/actor_cli_show.robot (13, 30) robot/actor_configuration.robot (8) robot/actor_context_export_import.robot (20, 71, 92) robot/cli_extensions.robot (61) robot/cli_formats.robot (14, 23, 30, 48, 57, 85) robot/cli_lifecycle_e2e.robot (77, 87) robot/config_project_scope.robot (37) robot/config_resolution.robot (13) robot/container_tool_exec.robot (137) Verified locally: targeted unit_tests run on features/plan_cli_spec_alignment.feature now passes 20/20 (was 17/20 with 3 scenarios forced-failed by the inversion). ISSUES CLOSED: #3677	2026-06-03 03:22:59 -04:00
CoreRasurae	78be08870c	fix(cli): validate actor provider field at correct config nesting level ... - Actor configuration in V3 is now obtained from the nested configuration parameter, according to the specification. - Removed the legacy V2 fallback support and the tests affected by that removal. Mocked existing steps to allow remaining V2 features to be covered/tested. - Fix add() to pass unsafe flag to add_v3() for proper unsafe actor handling - Add _extract_nested_v3_config() to extract provider/model from nested actors.<name>.config block before v3 schema validation - Remove v2 extraction test scenarios from consolidated_actor.feature that call removed _extract_v2_actor() and _extract_v2_options() methods - Update test YAML in actor_registry_spec_yaml_steps.py to exercise nested type detection (no top-level type field) - Add @tdd_issue_4300 regression test tag to existing spec-compliant actors map scenario ISSUES CLOSED: #4300	2026-05-09 23:13:33 +01:00
freemo	b122ec7ed5	fix(test-infra): remove redundant ${PYTHON} variable definitions from robot files ... Remove the local ${PYTHON} python (and python3) variable definitions from the *** Variables *** sections of all affected robot files. These local definitions were overriding the pabot-injected venv Python path passed via --variable PYTHON:/path/to/venv/python, causing tests to use the system Python (which lacks required packages like structlog, sqlalchemy, etc.) instead of the nox venv Python. The correct ${PYTHON} value is already set by Setup Test Environment in common.resource via sys.executable, and pabot passes it via --variable. The local fallback definitions are redundant and harmful in parallel runs. Audit found 56 robot files with the pattern (more than the 9 originally identified in the issue). All occurrences have been removed. ISSUES CLOSED: #1309	2026-04-14 14:50:55 +00:00
freemo	8ea00f5185	fix: restore CI quality tests to passing state (#4175) ... Co-authored-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me> Co-committed-by: Jeffrey Phillips Freeman <the@jeffreyfreeman.me>	2026-04-08 11:02:14 +00:00
freemo	7d5c7a1114	fix(error-handling): handle FileNotFoundError in robot.helper_actor_config ... Wrap ActorConfiguration.from_file() in a try...except FileNotFoundError block in robot/helper_actor_config.py. When the config file path does not exist, print a user-friendly error message to sys.stderr and exit with code 1 instead of crashing with an unhandled exception and raw traceback. Also adds a Robot Framework test case 'Missing Config File Exits With Non-Zero Code And Stderr Message' to robot/actor_configuration.robot to cover the new error path. ISSUES CLOSED: #2829	2026-04-05 06:55:19 +00:00
CoreRasurae	bbd06d2fdd	test(robot): Fix failing integration tests due to multiple STDOUT file overwrites	2026-02-18 09:57:37 +00:00
brent.edwards	51a6e76e9e	fix(ci): merge duplicate Settings blocks, inject venv Python, add CI debug ... Three fixes targeting CI integration_tests failures (18 failures on e8aa5ac): 1. Merge duplicate *** Settings *** blocks in 14 robot files into single blocks. Multiple Settings sections are non-standard RF practice and may cause resource import failures in certain Robot Framework versions or CI environments. 2. Replace bare 'python' with ${PYTHON} variable in all Run Process calls (14 files). Noxfile now passes --variable PYTHON:<venv-path> to robot so tests use the venv interpreter regardless of PATH. This fixes '/usr/local/bin/python: No module named cleveragents' on CI. 3. Add comprehensive CI debug output in noxfile.py: file existence checks for .resource files, PATH/Python resolution, fixture dir checks, and RF version. This will diagnose any remaining resource import issues. Also: remove hardcoded '/app/src' sys.path.insert in system_prompt_template_rendering.robot (not portable to CI), and add trailing newline to common.resource. All 204 tests pass locally (4 excluded: 2 slow, 2 discovery).	2026-02-13 03:43:44 +00:00
brent.edwards	e5b1b04ec6	test(integration_tests-3.13): fix nox tests ... `integration_tests-3.13` was failing; it is now passing.	2026-02-12 22:48:19 +00:00
freemo	6dfd41cafe	Feat: Pulled in core engine from v2 for running configs	2025-12-29 21:25:14 -05:00