2 Commits

Author	SHA1	Message	Date
HAL9000	8b066b6721	fix(lsp): preserve injected registry/lifecycle + deconflict persona test steps ... LspRuntime.__init__ and LspActorService.__init__ used ``x or Y()`` to default the registry/runtime kwargs. LspRegistry defines __len__, so an empty instance is falsy, and the OR silently discarded a caller-supplied empty registry — making the constructor parameter unusable. Replace with explicit ``is None`` checks so callers can inject collaborators at construction time. The previous workaround in lsp_actor_service_steps.py reached into ``service._runtime._registry`` to compensate; the steps now inject via the public LspRuntime + LspActorService constructors, no private-attribute access. Also deconflict three behave AmbiguousStep collisions in the bundled TUI persona work that prevented behave-parallel from registering any step definitions (the unit_tests gate was aborting at load time): * tui_persona_cycle_steps.py duplicated the registry-setup and active- persona steps already defined in tui_persona_system_steps.py — drop the duplicates and let the system file own them. * tui_persona_state_coverage_steps.py / .feature shared ``the registry last persona should be set to "X"`` with tui_persona_cycle_steps.py while asserting on a different mock — rename the coverage step to ``the mock registry set_last_persona should have been called with "X"``. * lsp_actor_service_steps.py registered the "actor bindings are activated" step under @when only; the deactivate scenario uses it after a ``Given/And`` chain, so behave inherited Given and the step was undefined. Register the same handler under both @given and @when. Reformat three files that ``ruff format --check`` flagged (tui_persona_cycle_steps.py, tui_persona_state_coverage_steps.py via the rename, tui/persona/state.py) so the lint gate goes green. ISSUES CLOSED: #5663	2026-06-04 13:06:20 -04:00
freemo	051ee7c290	test(coverage): add Behave BDD tests to improve coverage across 52 source files ... Added 52 new .feature files and corresponding _steps.py files targeting previously uncovered code paths in the following areas: - TUI layer: app, commands, persona (state/schema/registry), widgets, input (shell_exec, reference_parser) - Application services: plan lifecycle/service/executor, session, project, repo indexing, correction, checkpoint, actor, llm_actors, strategy coordinator, resource file watcher, service retry wiring - CLI commands: session, resource, repl, plan, db, automation_profile - Domain models: retry_policy, resource_type, cost_budget, docker_compose_analyzer, detail_level, _sql_string_aware, _postgresql_helpers - Core: circuit_breaker, retry_service_patterns - Infrastructure: repositories, transaction_sandbox, strategy_registry, plugins/loader, container - Config: settings - Agents: plan_generation, context_analysis, auto_debug - A2A: facade All new tests follow the Behave/Gherkin BDD standard. Resolved step definition collisions with unique prefixes. Fixed Alembic fileConfig logger disabling issue (disable_existing_loggers=False). ISSUES CLOSED: #1068	2026-03-20 21:22:10 +00:00