13 Commits

Author	SHA1	Message	Date
HAL9000	8d62a51561	fix(cli/session): emit ASCII box chars in --format table + ruff format ... The `_format_table` helper documented itself as rendering an "ASCII table" but built a Rich `Table` with the default `HEAVY_HEAD` box, emitting Unicode box-drawing chars (│ ─ ┌). The new @format_flag scenario "Tell table format outputs ASCII table" asserts the output contains `|` or `+`, so the rendered table did not match either the docstring contract or the BDD expectation. Pass `box=box.ASCII` so the table actually uses `|` and `+` borders. Also apply `ruff format` to the new step definitions (four split-string concatenations the formatter wants collapsed onto one line each).	2026-06-14 13:50:01 -04:00
freemo	946ebdec66	fix(cli/session): add --format flag and JSON envelope output to session tell ... Add BDD/Behave test scenarios for the existing --format/-f flag on `agents session tell`, and update CHANGELOG.md and CONTRIBUTORS.md. The implementation of --format on session tell exists in the codebase (commit 87a7ce35d), but lacks dedicated BDD test coverage. This PR adds: - 6 new Behave scenarios in features/session_cli.feature testing JSON, YAML, plain, table, short flag (-f), and Rich output regression paths - 6 corresponding step definitions in features/steps/session_cli_steps.py verifying spec-compliant JSON envelopes, valid YAML/JSON output, ASCII table output, and Rich console content preservation - CHANGELOG.md entry under [Unreleased] documenting the --format flag feature - CONTRIBUTORS.md entry crediting Jeffrey Phillips Freeman Quality gates: lint ✓, typecheck ✓ (only pre-existing warnings about optional provider imports) ISSUES CLOSED: #10466	2026-06-14 13:23:57 -04:00
HAL9000	c0606ce0ce	fix(cli): handle --format color in session delete as Rich output ... The delete command's output branch used `fmt == OutputFormat.RICH` which caused --format color to emit a JSON envelope instead of Rich panels. Align with all other session commands by checking `fmt not in (OutputFormat.RICH, OutputFormat.COLOR)` for machine-readable paths. Add BDD scenario and step for --format color to close the coverage gap. ISSUES CLOSED: #6457	2026-05-31 19:27:43 -04:00
HAL9000	b1bfaf032e	fix(cli): fix JSON/YAML envelope messages[].text for delete/export/import ... Extend the JSON/YAML envelope messages[].text fix to cover the remaining three session subcommands that were still producing plain Rich output instead of structured envelopes for non-rich format paths: - session delete: route non-rich formats through format_output() with messages=[{"level": "ok", "text": "Session deleted"}] - session export: add --output-format/-f option; emit structured envelope with session_export/contents/integrity data and "Export completed" message - session import: add --format/-f option; emit structured envelope with session_import/validation/merge data and "Import completed" message Also add BDD scenarios to features/session_cli.feature for each new envelope path, add corresponding step definitions, add CHANGELOG entry under [Unreleased] Fixed, and assign milestone v3.2.0 to the PR. ISSUES CLOSED: #6457	2026-05-31 19:27:43 -04:00
HAL9000	d785397da4	fix(cli): fix JSON/YAML envelope messages[].text to show actual content (#6457)	2026-05-31 19:27:43 -04:00
hurui200320	87a7ce35d7	feat(session): implement real LLM actor invocation in session tell ... Replace the M3 stub in `agents session tell` with real orchestrator actor invocation via `SessionWorkflow.tell()`. The stub echoed a canned `Acknowledged: ...` response without calling any LLM or actor; this commit wires up the full pipeline: Architecture: - New `SessionWorkflow` (Application layer) orchestrates LLM invocation for session tell. Accepts a `ProviderRegistry` and `ToolRegistry`; falls back to `FakeListLLM` when no provider is configured. - `LangChainSessionCaller` implements the `LLMCaller` protocol, building history-aware LangChain message lists from the session conversation and invoking the LLM via `ToolCallingRuntime.run_tool_loop()`. - `TellResult` (Pydantic BaseModel) carries the assistant response plus token usage (input_tokens, output_tokens, cost_usd, duration_ms). Domain / service layer: - `SessionActorNotConfiguredError` added to the session domain model; raised when tell is invoked with no actor on the session and no `--actor` override. Clear message; CLI exits with code 1. - `SessionService.get_messages()` abstract method added (+ implementation in `PersistentSessionService`) to load ordered message history. A2A facade: - `A2aLocalFacade` gains `message/send` and `message/stream` standard A2A operation handlers that route to `SessionWorkflow.tell()`. Total supported operations count: 42 → 44. CLI: - `session tell` command delegates to `_build_session_workflow()` (patchable factory) instead of directly calling `SessionService`. - Non-streaming: `SessionWorkflow.tell()` returns `TellResult`; output includes a Usage panel (Rich/Plain) or a `usage` object (JSON/YAML). - Streaming: `SessionWorkflow.tell_stream()` yields tokens; CLI prints them via `console.print` (not raw `sys.stdout.write`). - Token usage recorded via `SessionService.update_token_usage()` in both paths. Tests: - New Behave feature `session_tell_llm.feature` (4 scenarios): real LLM response persisted; streaming yields tokens; no-actor exits code 1; `--actor` override resolves correctly. - New Robot suite `session_tell_llm.robot` (4 tests): end-to-end with stub LLM injected via monkey-patching `_resolve_llm`. - Updated all existing `session tell` test steps to patch `_build_session_workflow` returning a mock `TellResult` so tests remain isolated from the LLM layer. - Updated operation-count assertions (42 → 44) in `a2a_cli_facade_integration`, `consolidated_misc`, `m6_autonomy_acceptance` feature files and steps. Cycle 7 (Review ID 8088) fixes: - Blocker 4: Split `session_workflow.py` (was 801 lines) into two files: `session_workflow.py` (467 lines) and `session_caller.py` (318 lines). Extracted: `LangChainSessionCaller`, `extract_content`, `extract_token_usage`, `estimate_cost`, `estimate_tokens`, `history_to_langchain_messages`, and stub classes. - Blocker 5: Route CLI streaming path through `_facade_dispatch("message/stream", ...)` instead of directly calling `workflow.tell_stream()`. The facade's `_handle_message_stream` falls back to non-streaming with `streamed: false` (acceptable for this milestone per the spec). - Updated streaming test assertion to validate full response presence (no longer checks token-by-token word positions, since the facade fallback returns a complete message). ISSUES CLOSED: #5784	2026-05-11 04:39:29 +00:00
hurui200320	85c579b51f	fix(cli): display full session IDs in session list output ... Remove the [:8] truncation from session IDs in the Rich table row, Most Recent summary, and Oldest summary fields of list_sessions() and _session_list_dict(). Session IDs are 26-character ULIDs and must be usable directly for copy-paste into session tell, session show, and other session commands. The structured output (JSON/YAML) already used full IDs in the sessions[*].id field, but the summary panel leaked the truncation into those formats as well. Added Behave scenarios: - Rich table displays full 26-character ULIDs (scoped to table region) - Summary panel shows full ULIDs for unnamed sessions (scoped to panel) - Summary panel shows session names for named sessions - Full ULID from list output works with session tell (round-trip, uses parsed ULID, not hardcoded constant) Review Cycle 2 fixes: - docs/specification.md: Updated YAML output example to full ULIDs - docs/showcase/*.md: Updated all example output blocks to full ULIDs - docs/reference/session_cli.md: Replaced placeholder with full ULID - features/session_cli.feature: Consecutive When steps -> And - features/steps/session_cli_steps.py: Summary panel asserts both IDs, 8-char negative guard in table output, ULID capture scoped to table region with fixture verification, named-session absence check for second session - CHANGELOG.md: Added [Unreleased] entry for the behavioral change ISSUES CLOSED: #10970	2026-05-05 10:56:18 +00:00
HAL9000	f2b60cc3d6	fix(cli): restore session list json contract ... Ensure the session list helper only emits the documented fields so downstream consumers stay compliant, and tighten the Behave coverage to enforce the contract.\n\nISSUES CLOSED: #6436	2026-04-26 19:40:00 +00:00
HAL9000	b92f0270c2	fix(cli): fix session show/list JSON output to not redact input messages (#6436) ... ISSUES CLOSED: #6436	2026-04-26 19:40:00 +00:00
freemo	54285e0f33	fix(cli): correct session show rich output Session Summary panel field labels and fields ... Reviewed and APPROVED. Closes #3040.	2026-04-05 21:12:13 +00:00
freemo	a0df5a4cd0	fix(cli): wrap format_output() in spec-required JSON/YAML envelope across all CLI commands ... Implements the spec-required JSON/YAML output envelope for all CLI commands that use format_output(). The envelope structure is: { "command": "<command that was run>", "status": "ok" | "warn" | "error", "exit_code": 0, "data": { ... command-specific payload ... }, "timing": { "duration_ms": 123 }, "messages": [{ "level": "ok", "text": "..." }] } Changes: - Add _build_envelope() helper to construct the spec-required envelope - Add optional command, status, exit_code, messages parameters to format_output() - Wrap json/yaml output in the envelope; plain/table/rich/color unchanged - Add timing measurement (duration_ms) to all json/yaml outputs - Add new BDD feature file (cli_json_envelope.feature) with 14 scenarios testing envelope field presence, values, and data payload - Update 14 existing step files to unwrap the envelope when checking specific data keys (backward-compatible via _unwrap_envelope() helper) Closes #3431	2026-04-05 19:48:40 +00:00
freemo	e4493e8978	fix(cli): correct session show rich output Session Summary panel field labels and fields ... Fixes three deviations from docs/specification.md in the agents session show rich output Session Summary panel: 1. Renamed 'Session ID:' label to 'ID:' to match spec exactly. 2. Removed 'Namespace:' field which is not part of the spec. 3. Added 'Automation:' field sourced from session.metadata['automation_profile'], defaulting to '(none)' when not set. 4. Field order now matches spec: ID → Actor → Messages → Created → Updated → Automation. Updated features/session_cli.feature to assert the corrected field labels are present ('ID:', 'Actor:', 'Messages:', 'Created:', 'Updated:', 'Automation:') and that the removed fields ('Session ID:', 'Namespace:') are absent. Added 'the session CLI output should not contain' step definition to features/steps/session_cli_steps.py to support the new negative assertions. ISSUES CLOSED: #3040	2026-04-05 19:44:08 +00:00
brent.edwards	04c8a886db	feat(cli): add session commands	2026-02-20 01:10:19 +00:00