3 Commits

Author	SHA1	Message	Date
HAL9000	66850665b7	fix(sandbox): split oversized step file and update CONTRIBUTORS.md ... Split checkpoint_manager_coverage_steps.py (692 lines) into three focused modules to comply with the 500-line file limit: - checkpoint_manager_coverage_steps.py: model, protocol, manager init, create_checkpoint, _snapshot_directory, and _cleanup_snapshot steps (408 lines) - checkpoint_manager_rollback_steps.py: rollback_to, list_checkpoints, and delete_checkpoint branch steps (283 lines) - checkpoint_manager_bug7488_steps.py: Bug #7488 sandbox_path auto-stored-in-metadata steps (59 lines) Also updated CONTRIBUTORS.md to document HAL 9000's contribution for bug fix #7488 as required by CONTRIBUTING.md guidelines. ISSUES CLOSED: #7488	2026-04-17 18:34:16 +00:00
HAL9000	beceb183d0	fix(sandbox): store sandbox_path in checkpoint metadata to enable rollback ... CheckpointManager.create_checkpoint() computed sandbox_path from sandbox.context.sandbox_path but never stored it in the metadata dict. This caused rollback_to() to always find metadata.get('sandbox_path') returning None, silently skip the rollback, and return False. The fix adds sandbox_path to the metadata dict immediately after it is resolved from the sandbox context, before the SandboxCheckpoint is constructed. rollback_to() can now retrieve the path and correctly restore the sandbox filesystem state. Added two new BDD scenarios to checkpoint_manager_coverage.feature: - Verifies sandbox_path is automatically stored in metadata on create - Verifies rollback succeeds without manually supplying sandbox_path ISSUES CLOSED: #7488	2026-04-17 18:33:39 +00:00
freemo	2eb31a598c	test(coverage): add Behave BDD tests for 8 under-covered modules ... Added targeted Behave BDD feature files and step definitions to improve unit test coverage for: - decision_service.py: Full coverage of all 7 service methods (18 scenarios) - plan_apply_service.py: Branch coverage for handle_merge_failure (2 scenarios) - plan_executor.py: Edge cases for rollback, checkpoint, and parse_steps (15 scenarios) - cli/commands/plan.py: Uncovered region lines 1950-2273 (23 scenarios) - repositories.py: Remaining missed branches and lines (14 scenarios) - sandbox/checkpoint.py: Full coverage of CheckpointManager (26 scenarios) - langgraph/bridge.py: Remaining uncovered lines and branches (10 scenarios) - cli/commands/config.py: Safety net to maintain 100% coverage (42 scenarios) Total: 150 new scenarios, 596 steps, all passing. Also fixed a step definition collision in plan_lifecycle_coverage by renaming "the delete result should be false" to "the plan delete result should be false". ISSUES CLOSED: #475	2026-03-01 03:09:51 +00:00