8 Commits

Author	SHA1	Message	Date
HAL9000	6390ce1171	fix(a2a): address reviewer feedback on HTTP transport ... - Remove misplaced pytest test files: tests/unit/a2a_test_http_transport.py, tests/unit/__init__.py, and features/steps/test_a2a_http_transport_pytest.py. Project layout uses Behave in features/ exclusively per CONTRIBUTING.md. - Resolve AmbiguousStep crash in features/steps/a2a_facade_steps.py by deduplicating step_transport_connect / step_transport_disconnect / "the transport should not be connected" definitions left over from the pre-implementation stub. - Remove all `# type: ignore[arg-type]` comments (zero-tolerance policy). - Fix ruff lint failures in src/cleveragents/a2a/transport.py: drop unused imports (Any, map_domain_error, BaseHandler, OpenerDirector), wrap long log lines (E501), and switch ssl.VerifyMode literal 0 to CERT_NONE for pyright compliance. - Update Robot helpers (robot/helper_a2a_facade.py, robot/helper_m6_autonomy_acceptance.py) and the m6 / consolidated Behave scenarios to verify the new server-mode lifecycle (connect succeeds with valid URL, send-before-connect raises RuntimeError, invalid scheme raises ValueError) instead of the obsolete "stub raises A2aNotAvailableError" contract. - Broaden the "I try to connect via the transport to ..." regex so the invalid-URL scenario outline matches the empty-string / quoted / None example cells; alias "I disconnect the transport" with @then so it is reachable from `And` after a `Then` keyword.	2026-06-14 16:11:26 -04:00
CleverThis	d71653a056	feat(a2a): implement server-mode HTTP transport ... Replace the A2aHttpTransport stub with a working HTTP(S) transport that: - Connects to remote A2A servers via HTTPS (with configurable TLS verification) - Sends JSON-RPC 2.0 requests over HTTP POST - Parses JSON-RPC responses into A2aResponse objects - Handles HTTP errors (4xx/5xx) with structured error mapping - Supports JWT Bearer token authentication - Validates connection state before send operations Added comprehensive test coverage: - Behave BDD scenarios for validation and lifecycle testing - Pytest unit tests with mocked HTTP responses covering success, errors, network failures, auth tokens, and roundtrip serialization	2026-06-14 16:11:26 -04:00
freemo	f5d244cd37	fix(a2a): change A2aErrorDetail.code to int and map error constants to JSON-RPC 2.0 integer codes ... Per JSON-RPC 2.0 specification (Section 5.1), error codes must be integers. This commit fixes the protocol compliance defect where A2aErrorDetail.code was typed as str and error constants were string literals. Changes: - src/cleveragents/a2a/models.py: Change A2aErrorDetail.code from str to int; update field_validator to only validate 'message' (code no longer needs non-empty string check; Pydantic enforces int type) - src/cleveragents/a2a/errors.py: Change all error code constants from string literals to JSON-RPC 2.0 integer codes per docs/reference/a2a.md taxonomy: NOT_FOUND = -32001, AUTH_ERROR = -32002, FORBIDDEN = -32003, INVALID_STATE = -32004, PLAN_ERROR = -32008, CONFIGURATION_ERROR = -32009, VALIDATION_ERROR = -32602, INTERNAL_ERROR = -32603 Update map_domain_error() return type from tuple[str, str] to tuple[int, str] - features/steps/a2a_facade_steps.py: Update A2aErrorDetail construction to map symbolic string names to integer codes via _CODE_MAP - features/steps/a2a_facade_wiring_steps.py: Update error code assertion to map symbolic names to integers for comparison - features/steps/a2a_facade_coverage_boost_steps.py: Same as above - features/steps/a2a_jsonrpc_wire_format_steps.py: Update all A2aErrorDetail constructions and JSON-RPC dict payloads to use integer codes - robot/helper_a2a_facade_wiring.py: Update wired_error_mapping() to compare against integer codes - robot/helper_a2a_jsonrpc_wire_format.py: Update response_error_wire_format() to use integer code -32001 instead of string 'NOT_FOUND' Wire format now produces {"code": -32001, ...} instead of {"code": "NOT_FOUND", ...}, making it compliant with JSON-RPC 2.0 and interoperable with standards-conformant clients. ISSUES CLOSED: #2746	2026-04-05 17:53:56 +00:00
freemo	02250473ad	fix(ci): restore all CI quality gates to passing on master ... Fix all failing CI quality gates (lint, unit_tests, format) without suppressing any quality enforcement. Root causes and fixes: 1. Format: features/steps/plan_namespaced_name_tdd_steps.py had trailing whitespace; fixed by running ruff format. 2. Unit tests - A2A JSON-RPC 2.0 migration (commit 9c6d6915) renamed A2aRequest fields (operation→method, request_id→id, a2a_version→jsonrpc) and A2aResponse fields (status+data→result, request_id→id) but did not update all step files and feature files: - a2a_jsonrpc_wire_format_steps.py: added use_step_matcher('re') and reset to 'parse' at end to prevent parallel test interference - a2a_facade_wiring_steps.py: updated operation= to method=, .status/.data to .result - a2a_facade_steps.py: updated request_id→id, a2a_version→jsonrpc, A2aResponse(request_id=..., status=...) to new API - m6_facade_steps.py: updated all old API usage - devcontainer_cleanup_steps.py: updated A2aRequest(operation=...) - plan_prompt_command_steps.py: updated A2aRequest(operation=...) - wf03_plan_prompt_confidence_steps.py: updated A2aRequest(operation=...) - consolidated_misc.feature: updated old A2aRequest/A2aResponse scenarios 3. Unit tests - Session CLI output changed (commit 0d5d9cf0 and others): - 'Session Created' → 'Session created' (lowercase) - 'Session Details' → 'Session Summary' - 'Sessions (N total)' → 'Sessions' - session list JSON: top-level 'total' → nested 'summary.total' - Fixed in: session_cli.feature, session_cli_coverage_boost.feature, session_cli_uncovered_branches.feature, session_list_error.feature, tdd_session_create_persist_steps.py 4. Unit tests - Plan list output changed (commit 1a07a891): - 'V3 Lifecycle Plans' → 'Plans' - 'Lifecycle Plans' → 'Plans' - Name column removed (restored in source) - Invariants column removed (restored in source) - Project truncation removed (restored in source) - Fixed in: plan_cli_cancel_revert_coverage.feature, plan_lifecycle_cli_coverage.feature, plan_cli_coverage_boost_steps.py, plan.py (source code restored) 5. Unit tests - Plan apply command now requires ULID (commit 300a5d6d): - plan_cli_coverage_r3.feature: updated 'PLAN-001' to valid ULID - plan_cli_coverage_r3_steps.py: added --yes flag, added new step for no-eligible-plans path 6. Unit tests - Various source code bugs: - ThoughtBlock: converted from @dataclass to Pydantic BaseModel (architecture test requires all dataclasses to use Pydantic) - session.py: added DatabaseError handling to export, import, tell commands - database.py: fixed rollback_to() to reuse checkpoint connection for writes - database.py: added _get_checkpoint_conn() helper - check-tls-cert.py: fixed SSLCertVerificationError.reason AttributeError 7. Unit tests - Test step bugs: - error_recovery_coverage_boost_steps.py: fixed invalid ULID _PLAN_ID - session_service_coverage_steps.py: fixed 'sha256:' prefix bug in checksum - database_models_new_coverage_steps.py: added 'name' field to session mock - async_audit_recording_steps.py: fixed Settings(audit_async=False) via env var - coverage_threshold_config_steps.py: added --coverage-min pattern support - m5_acms_smoke_steps.py: updated usage hint text - actor_cli_yaml_steps.py: updated 'Removed actor' → 'Actor removed' - aimodelscredentials_steps.py: set context.imported_class in import step - domain_base_model.feature: added missing 'When I examine model_config' step - tui_first_run_steps.py: fixed module reload to restore cleveragents.tui.* modules after test (prevented patch interference in subsequent tests) - tui_first_run_steps.py: added set_search('') step for empty string - resource_handler_base_coverage_r3_steps.py: use _MinimalHandler instead of DatabaseResourceHandler for NotImplementedError tests - resource_handler_crud.feature: updated to test new DatabaseHandler behavior - resource_handler_sandbox.feature: updated to test new DatabaseHandler behavior - tdd_json_decode_crash_persistence.feature: fixed @tdd_bug → @tdd_issue tags 8. Parallel test interference: - All step files using use_step_matcher('re') now reset to 'parse' at end to prevent global matcher state leaking to subsequent step files	2026-04-04 20:38:16 +00:00
freemo	0be3f85c56	feat(tui): implement Permission Question Widget ... Implement inline permission question widget for quick allow/reject decisions within the conversation stream with file diff context. ISSUES CLOSED: #997	2026-04-03 05:56:27 +00:00
freemo	9c6d69153e	fix(a2a): rename A2aRequest/A2aResponse fields to comply with JSON-RPC 2.0 wire format ... Rewrites the A2aRequest and A2aResponse Pydantic models to use the field names mandated by the JSON-RPC 2.0 specification, fixing a fundamental protocol compliance issue that prevented external A2A-compliant clients from communicating with the server. Changes: - A2aRequest: a2a_version→jsonrpc (fixed '2.0'), request_id→id, operation→method; auth field removed (not in JSON-RPC 2.0) - A2aResponse: a2a_version→jsonrpc, request_id→id, status+data→result (success path), timing_ms removed; added _result_xor_error validator enforcing mutual exclusion of result and error fields - A2aLocalFacade.dispatch(): updated to use request.method, request.id, result=data, error=A2aErrorDetail(...) - A2aHttpTransport.send(): updated to use request.method - CLI call sites (session.py, plan.py): updated A2aRequest(method=...) and response.result / response.error field access - All existing A2A Behave step files updated to new field names - New 35-scenario Behave feature (a2a_jsonrpc_wire_format.feature) covering serialisation, deserialisation, validation, and facade dispatch - New 7-test Robot Framework suite (a2a_jsonrpc_wire_format.robot) for end-to-end wire format verification ISSUES CLOSED: #1501	2026-04-03 00:29:46 +00:00
hamza.khyari	5e96b4bf80	feat(resource): implement 6-level execution environment precedence chain ... Implement the spec's 6-level execution environment precedence chain (spec lines 19324-19386): 1. Plan override (priority=override) — always wins 2. Project override (priority=override) — wins over devcontainer 3. Nearest-ancestor devcontainer — auto-discovered 4. Plan fallback (priority=fallback) — defers to devcontainer 5. Project fallback (priority=fallback) — defers to closer scopes 6. Host default — final fallback - New resolve_with_precedence() API on ExecutionEnvironmentResolver - Added execution_env_priority field to ContextConfig (project model) - has_devcontainer() helper for devcontainer-instance detection - Legacy 4-level resolve() preserved for backward compatibility - _parse_priority() defaults missing priority to FALLBACK - 13 new Behave scenarios testing all 6 levels + edge cases - Updated CHANGELOG ISSUES CLOSED: #877	2026-03-31 16:01:58 +00:00
freemo	ec0b7631d0	refactor(a2a): rename ACP module and symbols to A2A standard ... Renamed src/cleveragents/acp/ to src/cleveragents/a2a/ and all 13 Acp* classes to A2a* per ADR-047 (A2A Standard Adoption). Updated all imports, structlog event names (acp.* → a2a.*), field names (acp_version → a2a_version), and test references across the entire codebase. This is a cosmetic rename only — no behavioral changes. ISSUES CLOSED: #688	2026-03-12 14:38:57 +00:00