4 Commits

Author	SHA1	Message	Date
HAL9000	22c3cddf08	test(lsp): cover the select-based read-body timeout branch via os.pipe() ... The DoS mitigation added in db389a730 wraps each message-body read in ``select()`` so a stalled client cannot pin the server forever. The existing transport tests route through MockLspTransport, whose ``BytesIO`` raises ``UnsupportedOperation`` on ``fileno()`` -- so ``_read_body_with_timeout`` always falls through the BytesIO fast path and the actual ``select()``-based mitigation code (the part that runs in production) is never executed. That left ~19 new lines uncovered, dragging total coverage below the 96.5% floor and failing the coverage gate. Two new scenarios drive the helper through an ``os.pipe()`` whose read fd satisfies ``fileno()``, so ``use_select`` is True and the real DoS-protection path runs: * ``timeout=0.0`` makes the deadline already past on the first iteration, exercising the ``if timeout <= 0:`` early-exit warning. * ``timeout=0.05`` lets ``select.select()`` run and time out with no ready descriptors, exercising the ``if not ready:`` warning. Both paths log ``lsp.transport.read_timeout`` and return ``None``, matching the production behaviour the helper was added to provide. ISSUES CLOSED: #5566	2026-06-05 17:25:35 -04:00
HAL9000	db389a7304	fix(lsp): add per-message read timeout to prevent DoS in _read_message() ... Resolves the DoS vulnerability in LspServer._read_message() where a malicious client could send a valid Content-Length header but stall without delivering the body, blocking the server indefinitely. Changes: - Add MESSAGE_READ_TIMEOUT constant (default: 30 seconds) - Add _read_body_with_timeout() method using select() for timeout enforcement - Add read_timeout constructor parameter for configurability - Replace blocking self._input.read(content_length) with timeout-based read - Remove the SEC: comment that documented the vulnerability - Add BDD tests covering timeout behavior and constant export The fix uses select() for streams with a real file descriptor (e.g. sys.stdin) and falls back to direct blocking read for in-memory streams (e.g. io.BytesIO used in tests), preserving full test compatibility. Closes #7083	2026-06-04 21:00:09 -04:00
freemo	ec0b7631d0	refactor(a2a): rename ACP module and symbols to A2A standard ... Renamed src/cleveragents/acp/ to src/cleveragents/a2a/ and all 13 Acp* classes to A2a* per ADR-047 (A2A Standard Adoption). Updated all imports, structlog event names (acp.* → a2a.*), field names (acp_version → a2a_version), and test references across the entire codebase. This is a cosmetic rename only — no behavioral changes. ISSUES CLOSED: #688	2026-03-12 14:38:57 +00:00
CoreRasurae	23803f14ec	feat(lsp): add LSP server stub ... Added minimal LSP server entrypoint supporting initialize/shutdown/exit handshake over JSON-RPC stdin/stdout transport with Content-Length framing. Unsupported methods return MethodNotFound error with descriptive message. Wired LSP requests through ACP facade in local mode. Added agents lsp serve CLI command with --log-level flag, PID output, and startup banner. Created reference documentation for the stub server. Includes Behave BDD tests for protocol handshake, Robot smoke test, and ASV startup latency benchmark. ISSUES CLOSED: #203	2026-03-06 18:16:47 +00:00